Commit Graph

7 Commits

Author SHA1 Message Date
Lars Hvam
1dbd4d1912
Refactoring types (#2785)
* align use less different types

* refactor

* updates
2019-07-15 09:33:37 -07:00
larshp
4169d1045a generic serializer: order by primary key #2682 2019-05-29 23:53:50 -07:00
larshp
4a4f556e21 Generic: only unique tables 2019-04-24 07:58:07 -07:00
Martin Fuchs
6e860f53da Avoid DYNPRO_SEND_IN_BACKGROUND while ADT Pull (#2634)
* Avoid DYNPRO_SEND_IN_BACKGROUND while ADT Pull

When ADT (aka ABAP in Eclipse) is used to trigger a pull request, there is no SAPGUI available in the backend system. Whenever a dynpro is called, a DYNPRO_SEND_IN_BACKGROUND short dump occurs.
This commit fixes issue #2632.
Additional remark: In case of a private repository, username and password are passed to the backend system. The ADT backend coding handles this via class ZCL_ABAPGIT_DEFAULT_AUTH_INFO. To avoid sending a password dialog in the backend system (class CL_ABAPGIT_PASSWORD_DIALOG), ZABAPGIT coding needs to be adjusted to take over user/pw from ZCL_ABAPGIT_DEFAULT_AUTH_INFO. I know this is not nice and it would be better to have ZCL_ABAPGIT_DEFAULT_AUTH_INFO in ZABAPGIT. Even the best solution would be to re-use ZCL_ABAPGIT_LOGIN_MANAGER, but I would recommend to refactor this in a new pull request later on...

* Fix abaplint identiation failure 

Fix abaplint identiation failure

* Rest ZCL_ABAPGIT_PASSWORD_DIALOG

Rest ZCL_ABAPGIT_PASSWORD_DIALOG to prelimiary version. 
To be changed in a different pull request....
2019-04-16 22:21:46 -07:00
Jakub Filak
6a01862cd6 Avoid use of the RS package in BASIS systems (#1874)
* objects: use a different constant for 'R3TR'

The constant rs_c_pgmid_r3tr comes from the package RS which is not
available in pure BASIS systems.

The constant seok_pgmid_r3tr comes from the package SEOK and abapGit is
already using another constants from this package - seok_access_*.

Related to #1826

* objects: replace rs_c_true with abap_true

The constant rs_c_true comes from the package RS which is no available
in pure BASIS systems.

I believe that the constant rs_c_true was used by mistake.
The constant was assigned to a variable which is of the type abap_bool
and the variable is initialized with abap_false.

Related to #1826
2018-08-29 12:36:16 +02:00
ThomasPloski
6ea0c465f4 fixes issue #1621 (#1640) 2018-07-14 06:51:20 +02:00
Lars Hvam
7d7def95a5
Generic object handler + ASFC support #1578 (#1590)
* scaffolding #1578

* generic object handler #1578

* fix linter errors
2018-07-10 16:39:49 +02:00