Commit Graph

266 Commits

Author SHA1 Message Date
Christian Guenter
1f52d8b2c7 TR request jump: fallback to SAPGUI 2019-07-01 20:50:06 -07:00
Frederik Hudák
f5d421e399 ADT jump for package link and transports (#2758)
* ADT jump for package links

* Also handle transport requests/tasks

* fix abaplint
2019-06-28 23:02:37 -07:00
Lars Hvam
f6e8332754
Cleanup (#2753)
* refactor IF

* fix some indentation

* indentation fixes

* indentation fixes

* indentation

* indentation
2019-06-25 03:02:51 -07:00
Fabian Lupa
7f04d59bf9 Belize theme (#2733)
* Add Belize theme

* Implement polyfill for CSS variables

* Fix CSS variables with spaces in values

* Always load default theme and add others on top

* Adjust theme CSS for use with variables

* Support variables referencing variables in CSS

* Adjust themes

* Add font size to theme

* Skip asset registration for unused themes

* Unify theme greyscale

* Refactor CSS preprocessor

* Refactor CSS preprocessor, add basic tests

* Fix linter issues

* Always load theme asset

Otherwise switching does not work
2019-06-25 03:02:40 -07:00
Martin Fuchs
4aab0166ac Pass log to deserialization API and show log (#2729)
* Pass log interface for de-serialization

Interface ZIF_ABAPGIT_LOG is now passed for deseriaization API.
This includes:
- Log messages for FUGR: Imported function modules and includes
- Improved error messages for TABL compare
- Log objects w/o changes
- Log is shown in the UI if available ("Log" entry appears if a log exists, no persistence!)
This PR enhances #2534 and #2694

Another important change: In case an object fails (or a single function module in a group fails), the import continues with the next object!

* small pretty printer changes

small pretty printer changes

* fix abaplint issues

reduce line sizes and ensure 7.02 compatibility

* show errors and warnings from pull

Errors and warnings after a pull are now part of the "message list" above the object list in the main screen and will be shown immediately. The new"Log" button shows errors, warnings and success messages on demand.
The log title is now part of the ZIF_ABAPGIT_LOG interface.

* fix abaplint issue

fix abaplint issue
2019-06-21 23:05:10 -07:00
Frederik Hudák
c679d11d7b Change behavior of second back button to go home (#2679)
* Change behavior of second back button to go home

* Change logic as proposed

* Don't go to tutorial page on exit

* Final changes

* Fix abaplint
2019-06-13 22:59:18 -07:00
Thomas B
84042f1370 Enhance 'Transport to ZIP' to process multiple transport requests (#2683)
* New Program : Mass Transport to local zip file

Create new program ZMASSGIT in order to convert multiple tranport request to local zip files ( by giving output folder ).
Timestamped subfolder will be created in the input folder.

* Add files via upload

* Update zmassgit.prog.abap

* Add files via upload

* Add files via upload

* Delete zmassgit.prog.xml

* Delete zmassgit.prog.abap

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Delete zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipf01.abap

* Delete zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipf01.xml

* Delete zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipplc.abap

* Delete zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipplc.xml

* Delete zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipscr.abap

* Rename zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipscr.xml to src/zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipscr.xml

* Rename zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2ziptop.abap to src/zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2ziptop.abap

* Rename zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2ziptop.xml to src/zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2ziptop.xml

* Rename zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.abap to src/zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.abap

* Rename zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.xml to src/zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.xml

* Rename zabapgit_masstransp2zip.fugr.xml to src/zabapgit_masstransp2zip.fugr.xml

* Rename zabapgit_masstransp2zip.fugr.z_abapgit_transports_2_zip.abap to src/zabapgit_masstransp2zip.fugr.z_abapgit_transports_2_zip.abap

* Rename zcl_abapgit_transport_mass.clas.abap to src/zcl_abapgit_transport_mass.clas.abap

* Rename zcl_abapgit_transport_mass.clas.xml to src/zcl_abapgit_transport_mass.clas.xml

* Delete zcl_abapgit_zip.clas.abap

* Delete zcl_abapgit_zip.clas.xml

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Update zcl_abapgit_zip.clas.abap

* Update zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipf01.abap

* Update zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipf01.abap

* Update zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipf01.abap

* Update zcl_abapgit_transport_mass.clas.xml

* Update zcl_abapgit_transport_mass.clas.abap

* Update zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.abap

* Update zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipplc.abap

* Update zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.xml

* Update zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipplc.abap

* Update zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipplc.abap

* Update zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.abap

* New version without function group

* Cleanup

* Abaplint

* AbapLint Fixes

* Remove plugins objects from master

* Skip log flag in ZIP export

* Popup to ask the Export logic ( FULL / PREFIX ..)

* line length for abaplint

* Refactoring of code

Avoid redundancy of code and remove unused constant.

* Reduce line 50 length for abaplint ( < 120 )

* Change by the review of code

Refactoring of code

* AbapLint Fix
2019-06-11 08:57:08 -07:00
Alexander Tsybulsky
6845fe3ea4 Ui themes support (#2700)
* settings ui_theme

* theme css rendering

* theme split

* linetr fix
2019-06-07 03:36:44 -07:00
Martin Fuchs
2e781b316a ZIF_ABAPGIT_LOG: extend and move UI methods to new class (#2694)
* log: move show functions to new class

Enhance ZIF_ABAPGIT_LOG
- add IS_ITEM structure (object) to message adding functions
- add method "add_exception"
- add method "add_info"
- relocate methods "show", "to_html" and "write" to new class ZCL_ABAPGIT_LOG_VIEWER
Introduction of new log viewer class ZCL_ABAPGIT_LOG_VIEWER
Replacement of relocated methods where used
-> This is the next step providing a log for serialzation/de-serialization (see #2534)

* fix abaplint issues

fix abaplint issues

* fix abaplint issues (2)

fix abaplint issues
2019-05-26 03:16:03 -07:00
Domi Bigl
b6b3551238 downport assert_true()/false() #2698
702 don't know cl_abap_unit_assert%3D>assert_true() and assert_false()
2019-05-25 22:44:28 -07:00
Srinivasu Reddy
2f43ee4591 Changes to compare operators to align code 2019-05-24 06:50:15 -07:00
Christian Guenter
d10d922c06 Patch refactoring: remove duplication + meth order 2019-05-24 03:03:36 -07:00
Christian Günter
9429a3e13b Patch: make cell around checkbox clickable (#2687)
* Patch: make cell around checkbox clickable

* Fixed minor cursor issue
2019-05-21 07:19:27 -07:00
Christian Günter
53dd60c07b Patch: replace links with checkboxes #2673 (#2684)
* Patch: replace links with checkboxes

With this commit we replace the links on the patch page
with checkboxes.
This has several advantages:
- better performance
- simplified and less cluttered UI
- less and easier to understand code

* refactor

* refactoring: introduce new method add_checkbox

* fix linter

* enable link hint navigation

* Refactoring: remove duplication

* refactor: remove duplication

* fix: link hint activate section/lines
2019-05-20 08:44:49 -07:00
Christian Guenter
c61b3f9138 some UI cleanup 2019-05-20 08:43:52 -07:00
Srinivasu Reddy
d1c5e332d4 Added client check to add the ability to run abapGit in production/QA environments (#2668)
* Added client check 

Check if repository objects are modifiable in client. If not make write_protected setting active for all repos and make this setting disabled in repo setting page.

* fix abaplint errors

fix for abaplint errors

* code changes as suggested in review

1) Remove zcl_abapgit_client_check class
2) Add is_repo_object_changes_allowed method to zcl_abapgit_environment class

* Delete zcl_abapgit_client_check class

Delete zcl_abapgit_client_check class
2019-05-15 11:32:56 -07:00
Hector Martinez
a41382352c Activation on ABAP 7.02 ( #2665) (#2666)
* fixed error when activating on ABAP 7.02

* implemented suggestion, direct assignment instead of casting

* implemented suggestion (now using the interface)

* changed lr_popups to li_popups
2019-05-13 23:49:11 -07:00
Frederik Hudák
02a1a27178 Fix diff filter
@sbcgua  Fixes #2613
2019-05-07 08:02:00 -07:00
Alexander Tsybulsky
2fdff035be unify convert utils, part1 2019-04-24 07:59:06 -07:00
Christian Guenter
7050093986 Downport xstring_to_string conversion 2019-04-23 00:35:58 -07:00
Srinivasu Reddy
94604a7db5 syntax page "no errors" more neat
Display no errors message in syntax check with green check and no syntax errors message
2019-04-22 22:45:59 -07:00
Christian Günter
02647d77c6 Hotkeys no longer depend on abapGit installation #2629 (#2633)
* Hotkeys no longer depend on abapGit installation

When this commit is applied hotkeys also work with
the single abapGit report. Limitation is still that users
only can override hotkeys with the installed abapGit repo.

* Fix hotkey display when no user def. hotkeys

* New: Override hotkeys within one file abapGit report

When this commit is applied it's possible to override the default
shortcut also in the one file abapGit report. It's no longer necessary
to installe the full abapGit repo to use this feature

* Extract is_merged + check in hotkey logic
2019-04-19 00:21:36 -07:00
Christian Guenter
e246ae7ac1 Code Inspector: Downport 2019-04-19 00:21:10 -07:00
Martin Fuchs
1d58d5a0ed Allow access to private repos when using ADT (#2635)
* Allow access to private repos when using ADT

In case of using a private repository in ADT (aka ABAP in Eclipse), username and password are passed to the backend system. The ADT backend coding currently handles this via class ZCL_ABAPGIT_DEFAULT_AUTH_INFO. To avoid sending a password dialog in the backend system, class CL_ABAPGIT_PASSWORD_DIALOG needs to be adjusted to take over user/pw from ZCL_ABAPGIT_DEFAULT_AUTH_INFO in a generic way. I know this is not nice and it would be better to have ZCL_ABAPGIT_DEFAULT_AUTH_INFO in ZABAPGIT. Even the best solution would be to re-use ZCL_ABAPGIT_LOGIN_MANAGER instead, but I would recommend to refactor this in a new pull request later on...

* Add comment

Add comment for temporary solution and link to PR#2635
2019-04-19 00:20:54 -07:00
Alexander Tsybulsky
272925fff7 Floating save buttons (#2608)
* floating save buttons

* hover hand cursor
2019-04-09 11:44:52 -07:00
Alexander Tsybulsky
f39aab3244 fix display name in attache/change remote 2019-04-08 07:21:09 -07:00
Alexander Tsybulsky
3c80012b37 HDPI icon scaling (#2609)
* setting for icon scaling

* enforce icon scaling

* linter fixes
2019-04-05 03:47:09 -07:00
Lars Hvam
7bbaf069e2
File format update collection (#2605)
* File format update - changed object handler

I removed the following fields:

CLAS
VSEOCLASS-VERSION

INTF
VSEOINTERF-VERSION

PROG
PROGDIR-STATE

DCLS
AS4LOCAL
ABAP_LANGUAGE_VERSION (if exists)

DDLS
ABAP_LANGUAGE_VERSION (if exists)

DDLX
VERSION
RESPONSIBLE
MASTER_SYSTEM

MSAG
DOKIL-DOKSTATE

ENQU
DD25V-AS4LOCAL
DD25V-AS4VERS

* fix syntax error

* also clear PROG VARCL

* update XML files
2019-03-31 01:17:46 -07:00
sandra rossi
8f681e88dd 2 unit tests in ZCL_ABAPGIT_GUI_PAGE_DIFF failing
#2498 Two unit tests in ZCL_ABAPGIT_GUI_PAGE_DIFF failing

It concerns two test methods which test zcl_abapgit_gui_page_diff%3D>get_patch_data. The parameter IV_PATCH is passed with an incorrect value.

This issue is due to commit 389512f690 on Feb 26, 2019

Correction of method get_patch_data_add: 
- Before: |add_patch_zcl_test_git_add_p.clas.abap_19| 
- After: |patch_line_add_zcl_test_git_add_p.clas.abap_0_19| 

Correction of method get_patch_data_remove:
- Before: |remove_patch_ztest_patch.prog.abap_39| 
- After: |patch_line_remove_ztest_patch.prog.abap_0_39|
2019-03-30 03:20:31 -07:00
Jakub Filak
01b855467a clas: use exception instead of assert for not found file
For easier debugging.
2019-03-28 23:11:41 -07:00
Alexander Tsybulsky
f8347636a0 GUI remove zif_abapgit_gui_page (#2582)
* remove usage of zif_abapgit_gui_page

* reorderings

* delete zif_abapgit_gui_page
2019-03-28 23:08:04 -07:00
Alexander Tsybulsky
d22f5af1ab rewrite gui error handler 2019-03-28 22:57:39 -07:00
Kjetil Kilhavn
c7f21c2a5b Unknown action url -- fix for issue #2566 (#2567)
* Handle calls to repository URL on all pages

Call super class' for unhandled events in all classes displaying repository (identified from where-used list for zcl_abapgit_gui_chunk_lib%3D>render_repo_top).

I suppose it should be safe to add the 'super' call everywhere, but for now this will solve the bug.

* Revert "Merge branch 'unknown-action-url' into 'master'"

This reverts merge request !1

* Handle calls to repository URL on all pages

Call super class' for unhandled events in all classes displaying repository to handle URL click.
Relevant classes were identified by the where-used list for method render_repo_top in class zcl_abapgit_gui_chunk_lib.

I suppose it should be safe to add the 'super' call everywhere, but for now this will solve the bug.
2019-03-27 00:03:29 -07:00
Alexander Tsybulsky
ecc1c85ee7 GUI subclass zcx_abapgit_cancel from zcx_abapgit_exception (#2576)
* subclass zcx_abapgit_cancel from zcx_abapgit_excep

* upper case
2019-03-26 23:51:38 -07:00
Jakub Filak
77cea9c92a New repo with Folder Logic and Ignore Sub-packages params (#2561)
* repo: do not validate sub-packages when ignored

In our landscape, we often need to version a package which has
sub-packages and those sub-packages have own repositories - the super
package provides framework and the sub-packages provides production
functionality.

When adding a new repository for these "framework" super-packages,
we need want to configure "Ignore sub-packages" because they are
already versioned in standalone repositories.

We also need to turn of the sub-package repo package check which is done
by this patch.

Dependency of #2395

* repo: allow creating with folder logic and ignore package

I need to enable users to add a new online repo with ignored
sub-packages and PREFIX folder logic because we often deal with
framework + implementations packages hierarchies.

Dependency of #2395

* repo: add folder logic and ign. sub.pkg to the new repo popup

This patch adds the parameters Folder logic and Ignore subpackages to
the new online repo popup to help us deal with old package which do not
follow the prefix approach for subpackages and to allow us to version
superpackages (which are shared by many developers) in separate
repositories.

I am not sure how to add a check-box to the popup window. I think I need
to find the right table with the righ column of the type char(1).

Closes #2395
2019-03-22 05:50:46 -07:00
Alexander Tsybulsky
80f86bd005 free, go_page, ext error handler 2019-03-22 05:49:33 -07:00
Frederik Hudák
79905ccd82 Escape slashes in branch overview commit messages 2019-03-20 11:46:45 -07:00
Christian Guenter
a3c69433fb Fix: repo sett. display_name ony for online repos 2019-03-18 08:11:15 -07:00
Alexander Tsybulsky
1248319d82 UI move to core package (#2543)
* move to core package

* zcx_cancel to ui_core
2019-03-18 07:58:48 -07:00
Alexander Tsybulsky
1ad16a03fe SCI page deisgn (#2542)
* codeinsp design, phase 1

* fix alpha_output

* final design
2019-03-18 07:58:34 -07:00
Alexander Tsybulsky
85085b6434 improve list css 2019-03-17 01:42:55 -07:00
Alexander Tsybulsky
2ab4ae9f26 Refactor GUI interfaces (#2540)
* refactor gui interfaces

* delete zif_abapgit_gui_router

* move zif_abapgit_gui_page_hotkey to ui

* linter fixes
2019-03-17 01:42:41 -07:00
larshp
ff6725e759 replace uses of log with interface 2019-03-17 01:39:52 -07:00
Alexander Tsybulsky
17dc2501eb GUI, asset manager refactoring (#2536)
* refactor asset manager

* assets man tests

* linter fixes

* linter fix
2019-03-16 03:44:55 -07:00
Lars Hvam
f9318305e9
Minor fixes (#2532)
* minor fixes regarding unused variables

* minor code inspector fixes
2019-03-15 05:54:39 -07:00
Alexander Tsybulsky
9b38d79cce GUI CORE, move constants (#2526)
* zcl_abapgit_gui constants

* renames in all classes

* zif_abapgit_html

* zif_abapgit_html related renames

* remove gui->free for now
2019-03-15 02:22:08 -07:00
larshp
dcaf585d47 move file_download to ui package
move file_download to ui package, part of #2510

the zip class should ideally work without frontend interaction, and just provide/parse the raw xstrings, this way it can be reused across different frontend technologies
2019-03-15 01:52:42 -07:00
Sdfraga
7c8b2228fb Branch Overview Page gitGraph Horizontal Top scrollbar (#2492)
* Adding HTML new elements to BOverview Page

* Adding gitGraph CSS propertires

* Adding gitGraph scroller function

* Set gitGraph Scroller css width dynamically

* Initialize Top Horizontal Scroller on GitGraph

* Adding setGitGraphScroller() to BOverview HTML

* Fixed HTML wrong TAG

* Adding some comments

* Fixing abaplint messages

* Refactoring Indentation for Travis

* Refactoring for Travis

* Removing trailing spaces for Travis
2019-03-14 02:52:40 -07:00
Lars Hvam
48f6cb1bb1
move ZCL_ABAPGIT_FRONTEND_SERVICES to UI (#2516)
* move ZCL_ABAPGIT_FRONTEND_SERVICES to UI

move ZCL_ABAPGIT_FRONTEND_SERVICES to UI package

* move factory and interface

* fix errors found by linter
2019-03-14 01:34:19 -07:00
Lars Hvam
13213e2f2f
decode object name #2504 (#2507)
* decode object name #2504

* fix

* fix
2019-03-14 00:21:02 -07:00