* improve error handling of function modules
* fix abaplint errors
* refactor to hardcoded error strings
* refactor fm error handling to string templates
* removing msag class
* add IDoc Segement support as part of TABL
IDoc Segement type/definition is just customizing and has no own transport object but it generates a structure and is coupled to it
The segment type/definitions have their own XML at the TABL object
* fix abaplint errors
* move segment type/defintion to TABL xml
* Sapscript : sequence of Windows in tdlines files
Hello Lars,
You can find a code modification in the method _read_form of class zcl_abapgit_object_form related to the issue #2188
I have added a logic to sort by windows name the contains of the internal table ET_LINES . It allows to have always thre same sequence of windows code in the file (xxxxxxxxxxgit.form.tdlines). Then file comparison will work with all export.
Regards
Christophe
* Sapscript : sequence of Windows in tdlines files
Hello Lars,
I have moved the code to a new private method _sort_tdlines_by_windows
But I don't add 'ASSERT sy-subrc = 0.'.
The reason is that during my tests I found some windows in the form without elements inside (windows is not used anymore but it sill exists. The devlopper ddin't remove it). In this case the result of the ASSERT is a dump.
Using the loop from SY-TABIX there is no risk. If no entry exists in the internal table then the loop is not executed.
if needed I can add the following condition before doing the loop :
IF line_exists( lt_lines[ tdformat = lv_elt_windows
tdline = ls_form_windows-tdwindow ] ).
Christophe
* Sapscript : sequence of Windows in tdlines files
I have done the adjustments for the CLEAR and to be compatible with 702
Christophe
* Sapscript : sequence of Windows in tdlines files
Whitespace at end of line removed
* SUSC: delete in more direct way - no confirm popup
delete needs to be done with a code copy of FM SUSR_DELETE_OBJECT_CLASS
I really hate this but there is no other way
* SUSC: delete in more direct way - no confirm popup
* test
* test
* naming conventions
* PP
This commit adds an indirection for function module GUI_IS_AVAILABLE
via interface ZIF_ABAPGIT_GUI_FUNCTIONS and factory ZCL_ABAPGIT_UI_FACTORY.
For tests the implementation can be replaced with
ZCL_ABAPGIT_UI_INJECTOR=>SET_GUI_FUNCTIONS
* mark inactive objects in repo list
Inactive object are marked in the repo list
The sort order for changed files is not changed
unchanged inactive files come right after the changed files
* move acitve check to object interface
* add is_active for objects up to F
* add is_active for objects up to P
* add is_active for objects up to T
* add is_active for objects up to X
all core object implement (except SSFO) the standard active check via FM RS_INACTIVE_OBJECTS_WARNING now
* add is_active to plugins bridge - always active
* finish object interface implementation + objects
* add is_active for offline with object interface
* rename returning to RV_
* use returning for serialize
* cleanup, PP, UT
* add code line attribute for leading spaces
Use attribute abapgit-leadig-spaces to store leading spaces of coding lines at serialization. This is used in deserialization to restoreformatting after XML normalization.
* add attribute also for global types and forms
* fix code formatting
Before this commit is applied the FIX_IDS methods was errorneous
and lead to subsequent dump. This commit fixes the algorithm to
replace IDs and IDREFs
* pretty print
* definitions to top of routine
* space before .
* omit parameter names where possible
* double space after if
* remove pseudo comments where possible
* clear PRESP and PWORK
clear username fields PRESP and PWORK
* remove unused FM exceptions
if sy-subrc is analysed (only <> 0) no detailed FM exceptions are needed, only OTHERS
* set PRESP and PWORK on deserialization
PRESP and PWORK is not set to SY-UNAME by default so set it explicitly
* Object Type UDMO Data Model #1905
Support for Object Type UDMO Data Model #1905
* Object Type UDMO Data Model #1905
* Object Type UDMO Data Model #1905
* Object Type UDMO Data Model #1905 Bad formatting correction
* Object Type UDMO Data Model #1905 Bad formatting
* Object Type UDMO Data Model #1905 Reformulation
* Update package.json
* pretty print
Before this commit is applied DDLX source code was recorded
in the xml file. We changed this so that now a separte .asddls
file is created. The change is downward compatible. Previously
recorded DDLX objects will show a diff the next time and the new
.asddls file has to be committed.
* removed popup saving msag
* fixed capitalization
* refactored with variable prefixes
* refactored exceptions and split methods
also removed S messages.
Previous code was mostly copy %26 paste of the original
* Cleaned up
* more cleanup
* enable ADT jump from CI result
* enable ADT jump from CI result for all objects
* cleanup + PP
* cleanup + PP + save/activate in ADT
* remove commented code
* objects: use a different constant for 'R3TR'
The constant rs_c_pgmid_r3tr comes from the package RS which is not
available in pure BASIS systems.
The constant seok_pgmid_r3tr comes from the package SEOK and abapGit is
already using another constants from this package - seok_access_*.
Related to #1826
* objects: replace rs_c_true with abap_true
The constant rs_c_true comes from the package RS which is no available
in pure BASIS systems.
I believe that the constant rs_c_true was used by mistake.
The constant was assigned to a variable which is of the type abap_bool
and the variable is initialized with abap_false.
Related to #1826
This commit adds three new methods to ZCL_ABAPGIT_OBJECTS_SUPER:
- SERIALIZE_LONGTEXTS
- DESERIALIZE_LONGTEXTS
- DELETE_LONGTEXTS
They can be called on demand in concrete object type serializers.
In this commit they were called from DTEL, DOMA and TABL
* correct xml errors of CUA interfaces
Issue error RS_CUA_INTERNAL_WRITE while pulling an old abapgit repository #1807. Same issue as #562 (error RS_CUA_INTERNAL_WRITE) which is solved by correcting manually the XML of the CUA interfaces (fastidious), or by regenerating the XML (but unfortunately sometimes the abapGit repository is from someone else).
Automatically fix this before RS_CUA_INTERNAL_WRITE is called. It's useless having this as a configuration option.
* refactor: extract code to a new method
* Better refactoring of auto correction CUA
