SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 20:32:26 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
4,205 Commits 3 Branches 39 Tags 53 MiB
20c1dc0bda
Commit Graph

543 Commits

Author SHA1 Message Date
Marc Bernard
dd37881589
702: Fix syntax error and missing check variant (#4117) 
* 702: Downport 

No chaining with CHANGING

* 702: Downport

* Syntax check variant

* Too many fields warning

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-11-02 09:29:09 +01:00
Marc Bernard
bdc44f7476
Remove self-references (#4115) 
* Remove self-references

Remove unnecessary self-references (me->)

https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#omit-the-self-reference-me-when-calling-an-instance-method

* 702: Fix syntax error

No chaining with EXPORTING & CHANGING

* remove addiontal me, update abaplint config

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-11-02 09:25:27 +01:00
Alexander Tsybulsky
614a8d60a3
new icons and css adjustments (#4112) 
Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-11-02 09:16:59 +01:00
mariusraht2
ec99d16ec0
Checkout commit: Add menu entry and finish implementation (#4101) 
* Implementation

* Add menu entry for checkout commit

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-10-30 10:24:27 +01:00
Marc Bernard
666dfbda66
UI: Unify rendering of branch, package, transport, user names (#4097) 
* UI: Unify rendering of branch, package, user names

Branch name was already rendered "boxed with a leading icon". The same is now done for package and user names.

See `zcl_abapgit_gui_chunk_lib->render_branch_name, render_package_name, render_user_name`.

Closes #4059

* Lint %26 transport

* Unknown user

* Transport css

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-10-30 10:13:09 +01:00
Marc Bernard
5d480d8e8d
Fix jump links on diff page (#4096) 
Some files that existed locally didn't have a link. After #4084, the state can be evaluated properly to determine if local object exists.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-10-30 10:01:42 +01:00
Frederik Hudák
888bbcb27e
Disable sorting for action column (#4087) 
* Disable sorting for action column

* abaplint

* Revert renamed methods
 2020-10-28 12:23:00 +01:00
mariusraht2
6b336c58f0
ZCL_ABAPGIT_REPO_ONLINE: Change methods fetch_remote and push to be able to retrieve and push objects also by commit hash (#4077) 
* Implementation

* Add changes to push method

* Reset commit hash if branch is being switched

* abapLint: Remove whitespace

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
 2020-10-28 11:56:56 +01:00
mariusraht2
a4172c6acc
ZCL_ABAPGIT_SERVICES_GIT: Add new method checkout_commit to let the user check out commits (#4076) 
* Implementation

* abapLint: Omit exporting

* Omit obsolete variables

* Add caller for checkout_commit

* Extend hash column for 1 character

* Add reset_remote to set_sha1

* Merge branch 'master' into add_checkout_commit

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-10-28 11:08:39 +01:00
mariusraht2
69b6c3c38a
Implementation (#4086) 2020-10-28 10:41:22 +01:00
Marc Bernard
f699812b02
UI: Adjustments to Command Palette (#4080) 
- Add prefix for utilities and help commands
- Remove leading spaces

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-10-28 06:46:53 +01:00
Marc Bernard
46f504a0e8
UI: Adjustments to Hotkeys (#4083) 
- Add hotkey "f" for "new offline"
- Add hotkey "c" for "syntax check"
- Fix #3927
 2020-10-28 06:42:40 +01:00
mariusraht2
3ec07c6493
ZCL_ABAPGIT_SERVICES_GIT: Change signature of method checkout_commit_build_popup (#4072) 
* Implementation

* Remove unrelated pretty printer changes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-10-27 16:14:16 +01:00
mariusraht2
5aebc0c88e
ZCL_ABAPGIT_SERVICES_GIT: Add method checkout_commit_build_list to build the popup selection table for commits (#4070) 
* Implementation

* abapLint: Omit exporting and avoid void types

* Clear all exporting parameters first

* Remove unrelated pretty printer changes
 2020-10-27 16:05:04 +01:00
Jaime Rodriguez Capote
d6fbcc1fb6
Fix repo view class name importing ZIP (#4065) 2020-10-26 10:39:16 +01:00
Fabian Lupa
ceeb95eec1
Fix arrow direction for sort order (#4062) 2020-10-26 08:06:28 +01:00
mariusraht2
54ce6771bd
Issue #4027: Resolve possible crash of AG and add option to be able to suppress showing commit hash on Code Inspector result page (#4028) 
* Replace LEAVE with CALL SCREEN

* Add new option iv_show_commit

Add new option iv_show_commit to GUI_CHUNK_LIB to be able to suppress showing commit hash on GUI_PAGE_CODE_INSP page

* abapLint: Replace 'EQ' by '='

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Hide commit hash on other pages too

Hide commit hash on ZCL_ABAPGIT_GUI_PAGE_REPO_SETT and ZCL_ABAPGIT_GUI_PAGE_SYNTAX pages

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-10-19 11:19:02 +02:00
mariusraht2
9ac7630711
ZABAPGIT_FORMS: Remove obsolete form package_popup and related callback handler (#4029) 
* ZABAPGIT_FORMS: Remove obsolete methods

- Remove branch_popup
- Remove package_popup

* Readd branch_popup

* Readd branch_popup

* Remove related callback handler

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-10-16 09:11:18 +02:00
Alexander Tsybulsky
19c49fd960
Bugfixes in html_form and Finetune add pages to new event (#4011) 
* refactor validation in html_form + UT

* minor UT tweak

* subtle form bugfix (boolc return space string)

* cleanup add forms

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-10-12 16:40:24 +02:00
Alexander Tsybulsky
4b6c424465
html event abstraction, phase 5 - case insensitive query and form_data (#4007) 
* case-insensitive string map

* refactor gui_event and its UTs

* remove query uppercased in pages

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-10-11 10:47:37 +02:00
Marc Bernard
0adb9dec58
Add Offline: Uppercase package name (#4002) 2020-10-09 12:30:07 +02:00
Lars Hvam
f9d064829a
remove more ALIASes (#3986) 
most of these are not in use, but was also public
 2020-10-07 09:05:28 +02:00
Lars Hvam
4e96acd4be
use HEAD symref as default branch (#3983) 
* use HEAD symref as default branch

closes #3974

* autodetect
 2020-10-07 08:59:30 +02:00
Marc Bernard
9672f5b030
Adjust name prefix for types (#3991) 
* Part 1

* Part 2

* Part 3

* Lint

* Part 5

* Part 6

* Part 7

* Part 8

* Part 9

* Enforce type naming prefix

All types need to start with TY_...

* Fix local types
 2020-10-07 08:54:15 +02:00
Alexander Tsybulsky
7c0ec067a1
rename repo related pages (#3982) 2020-10-06 08:22:22 +02:00
Marc Bernard
42c909e688
Refactor: Remove dynamic instantiation of ZCL_ABAPGIT_MESSAGE_HELPER (#3966) 
* Refactor: Remove dynamic instantiation of ZCL_ABAPGIT_MESSAGE_HELPER

Consolidate `ZCL_ABAPGIT_MESSAGE_HELPER` features into `ZCX_ABAPGIT_EXCEPTION` and removes helper.

* Remove helper

* Pretty

* Update chunk_lib

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-10-05 16:50:36 +02:00
Alexander Tsybulsky
6941d9824a
html event abstraction, phase 4 - form_data (#3975) 
* event->post_data logic

* part of pages, commit test

this is also long text
to test

* string_map: port strict() feature

* pages refactoring part 2

* linter

* docs

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-10-05 09:33:01 +02:00
Marc Bernard
25774396e6
Dialogs: add offline repo HTML form (#3960) 
* Dialogs: add offline repo HTML form

* Dialogs: add offline repo HTML form

* Dialogs: add offline repo HTML form

* Lint

* Lint

* Chaining

* Set required attribute

* Check for empty display name

* Change validation

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-10-03 10:18:45 +02:00
Marc Bernard
c9da76b3ee
Fix error from CL_PACKAGE_FACTORY=>LOAD_PACKAGE (#3958) 
* Fix error from CL_PACKAGE_FACTORY=>LOAD_PACKAGE

* Variable

* Change to T100 messages

* super->constructor( )

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-09-29 17:29:02 +02:00
Marc Bernard
5bde9bd549
Fix syntax errors in 702 (#3955) 
* Fix syntax errors in 702

* Fix syntax errors in 702
 2020-09-28 19:58:31 +02:00
Alexander Tsybulsky
e95b6f7806
html event abstraction, phase 3 - query (#3903) 
* event->query

* page db refactoring

* linter fix

* linter fix

* address repo via key= param

* linter

* mv_getdata WIP

* mv_getdata - finish

* cleanup action utils

* linter fix

* another linter fix

* docs for event->query
 2020-09-28 16:41:59 +02:00
Marc Bernard
dc9773bee9
Fix handling of T100 exceptions (#3943) 
* Fix errors raised during deletion

* Fix error handler

* Harmonize top and bottom message banners

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-09-27 10:56:08 +02:00
Lars Hvam
1c1b04fbe9
update lint config, minor refactors (#3948) 2020-09-27 09:24:31 +02:00
Lars Hvam
fff8f1b237
new URL, updates (#3936) 
* Update build.yml

* docs, update urls

* code, update links
 2020-09-24 09:42:52 +02:00
Fabian Lupa
f2defab59e
Add option to synchronize theme with frontend (#3929) 
Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-09-23 12:34:15 +02:00
Fabian Lupa
b7d318d2e9
Add button to launch IEChooser.exe on Windows (#3922) 
* Add button to launch IEChooser.exe on Windows

* Fix CASE statement

* Determine iechooser.exe path using system directory

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-09-23 12:31:01 +02:00
Lars Hvam
03724484f1
use boolc (#3920) 2020-09-23 12:28:13 +02:00
Fabian Lupa
8ad4d130d4
Fix sort by created at in repo overview (#3919) 
Fixes #3918

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-09-22 08:56:58 +02:00
Fabian Lupa
a2f57aeb9a
Split up global settings button and utility menu (#3913) 
* Split settings and dev utils menu

* Fix missing settings hotkey on repo view

* Revert "Fix missing settings hotkey on repo view"

This reverts commit 1444744a5f.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-09-22 08:54:40 +02:00
Lars Hvam
015800b45b
Less DDIC references (#3905) 
* remove uses of CHAR30

* Update abaplint.json

* add basic unit test for ZCL_ABAPGIT_MESSAGE_HELPER

* replace uses of char50

* fix name

* Update abaplint.json

* use sy-uname instead of uname

in ZCL_ABAPGIT_USER_MASTER_RECORD
 2020-09-21 07:39:22 +02:00
Fabian Lupa
a16a903f57
Show repo list button in tutorial (#3910) 
Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-09-20 09:43:54 +02:00
Fabian Lupa
bab9b7ba22
Show tutorial if there are no repos (#3907) 
Fixes #3553

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-09-20 09:40:57 +02:00
Alexander Tsybulsky
aae82485e0
html_form chaining (#3908) 2020-09-20 09:29:12 +02:00
Alexander Tsybulsky
6e515e1063
Unified validate and normalize form params in html_form class (#3904) 
* html_from - validate and normalize form params

* docs
 2020-09-20 07:41:46 +02:00
Alexander Tsybulsky
9574dca828
html event abstraction, phase 2 (action utils usage unification) (#3902) 
* action utils improvements

* page unifications

* linter
 2020-09-19 11:02:01 +02:00
Alexander Tsybulsky
555f2f3d0b
html event abstraction, phase 1 (#3900) 
* event class, interface and gui

* router adaptation

* rest of the pages

* linter fixes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-09-19 07:57:39 +02:00
Fabian Lupa
143a7ccc1c
Downport, fixes #3897 (#3899) 2020-09-19 07:54:36 +02:00
Alexander Tsybulsky
d20cdd07c2
syst_title is missing in 731 (#3896) 
* syst_title is mising in 731

* adjust type

* Update abaplint.json

Co-authored-by: Lars Hvam <larshp@hotmail.com>
 2020-09-17 17:40:38 +02:00
Marc Bernard
475f67d1d8
Remove trailing spaces in HTML output (#3893) 
* Remove trailing spaces from html

* Return string size
 2020-09-17 17:07:46 +02:00
Lars Hvam
9f396366cd
gui refactoring, for web edition (#3890) 
* put cl_gui_html_viewer behind an interface

* cleanup

* injectable html viewer

* method_parameter_names, exclude zif_abapgit_html_viewer

* fix whitespace

* public get_asset_manager

* Update abaplint.json

* add prefixes
 2020-09-16 12:39:23 +02:00