pretty print class ZCL_ABAPGIT_HTML_FORM, and change two static methods to instance, this will make future possible changes to the class easier to see in the history
Follow-up to #3717:
- Proper display of public, protected, and private sections
- Add CLAS prefix to be inline with other object types
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* popup_to_select_from_list can handle element tabs
popup_to_select_from_list can now handle element-based non-structured tables like a table of url strings
Therefore related to #3639
* Update zcl_abapgit_popups.clas.abap
* Fixed wrong value assigning and added assert
* Add performance test
* Fix some linter errors
* Refactor free selections to reduce method length
* Performance test add title to result ALV
* Attempt downport
* Downport
* Pretty Printer VS abaplint
* Undo more changes done by pretty printer
* Adjust performance popup title and ALV layout
* Move free sel dialog to global for abapmerge
* Move some type definitions for abapmerge
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* navigate to repo after ZIP import
* add zip import/export action for offline repos
* rename action labels
* change new state to be dependent on current page
change replacing -> new page if action called from repo list
rerender if in repo view
* add some TODOs, see PR discussion
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Update error msg
* Fix login popup errors and cancelation
* Remove validate/reset methods
* Lint
* Rename iv_repo_online to io_repo_online
* Change to error in status bar
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* refactoring, use interface for html
replace uses of zcl_abapgit_html with zif_abapgit_html
#3460
* replace additional uses of the A alias
* This removes the A alias from the HTML class
This removes the following alias,
"a FOR zif_abapgit_html~a ."
* fix syntax error
* background pull: always overwrite all objects
always choose to overwrite all objects when using the pull in background feature. If the decision is not set the job will fail with a "undecided" error
#3800
* fix page title typo
* Improve display when there are no changes in repo view
* Update view and remove empty_package method
* Empty package msg
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Validate if branch exists when displaying repo
* Validate if branch exists when displaying repo
* Lint
* Lint and 702
* Lint
* Rename validate_branch to validate
* Fix msg and branch display name
* Move msg to UI layer
* Lint
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
* abapGit Emergency Mode
On rare occasions, it is necessary to edit the abapGit settings to overcome an issue (example: https://github.com/larshp/abapGit/issues/3701).
This enhancement allows you to start abapGit in "emergency mode", which directly shows the "Database Utility" for you to view or edit any setting.
How to start abapGit in "Emergency Mode":
1. Go to transaction SU3 to maintain your user profile
2. Maintain parameter DBT with value "ZABAPGIT" (all-caps).
3. Start abapGit
4. After exiting abapGit, go back to SU3 and remove parameter DBT
* Update ref-database-util.md
* Add files via upload
* Update ref-database-util.md
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Use title case for page titles
Other minor changes:
- patch page is no longer called diff
- "code inspector" in main page action menu renamed to "check"
* Two more
* Update zcl_abapgit_gui_page_db_dis.clas.abap
* Update zcl_abapgit_gui_page_repo_sett.clas.abap
* Repo advanced menu
* Commit form labels
* Repo setting lables
* Settings, repo
* Final ones?
* Database util
* Column name in stage page
* abaplint
* Update zcl_abapgit_gui_page_stage.clas.abap
* Hover texts for stage column, commit settings
* lint
Turning on "Details" in Repo Overview will now hide the "Action" column to improve display on smaller screens.
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* show last commit hash w/ link if possible
link to commit is supported for github.com and bitbucket.org
* remove inline data declaration
* add gitlab link support with UT
* add commit icon for non supported provider
* remove inline declaration
* remove new for CRETE OBJECT
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Enhance result view of Code Inspector/Syntax Check
* Enhance result view of Code Inspector/Syntax Check
* Enhance result view of Code Inspector/Syntax Check
* Lint
* Move sort
* Downport: Fix syntax error in 702
Method "ASSERT_TRUE" does not exist in 702
* Downport: Fix syntax error in 702
Co-authored-by: Lars Hvam <larshp@hotmail.com>
After this fix is applied the menu "advanced > open in master language" opens the repo directly and doesn't open the repo list.
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Remember repo list filter
resolves#3552
Changes:
- store filter in local storage instead of session storage, so it is remembered on abapgit restart
- filter is saved whenever it is changed instead of page unload
- removed debug output, it doesn't need to clutter the main page
* Don't resave on page load
* Add semicolons
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Improved staging robustness
- Skipped any objects in the changelist that are not marked for staging prior to processing them , to avoid that they keep other objects without errors from being staged if the user wants to stage parts of the changes
* Reduced line length
* Removed missed whitespace
* Update abaplint.json
* Update abaplint.json
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Fixed faulty translation of post data to parsable string
- Added method TRANSLATE_POSTDATA to ZCL_ABAPGIT_UTILS as a centralized place to translate post data to a string
- Replaced all post data string concatenations with the translation helper method to correctly parse spaces that fall to the end of a table line (this should solve #3073 as well as any other random crash caused by accidental misalignment of the post data)
* Backport ABAP statement to 7.02
* Code cleanup for linter checks
* Code cleanup for linter checks
* Fixed a possible error in parsing
If it_postdata contains an empty last line, the staging fails, because the string may contain a lot of soaces at the end of the previous to last line.
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* HTML: move add_icon to interface
* ZCL_ABAPGIT_HTML_TOOLBAR use interface
* ZCL_ABAPGIT_GUI_REPO_OVER use interface
* ZCL_ABAPGIT_GUI_PAGE_VIEW_REPO use intf
* CI Update
* Raise exception when no .abapgit.xml is found (#3512)
Update
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Updated documentation for repo settings & icons (#3499)
* Completed to-dos
- Updated abapgit.xml example
- Completed missing docu for local settings
* screenshots
* screenshots
* Delete repo_settings_local.png
* screenshots
* Delete repo_settings_local.png
* screenshots
* screenshots
* Combine write-protect setting
* Merged to repo settings
* screenshots
* screenshots
* merged to repo settings
* merged to repo settings
* Adding details
* Added links
* links
* icons
* icons
* icons
* icons
* icons
* icons
* icons
* Update ref-icons.md
* icons
* icons
* Update docs/ref-dot-abapgit.md
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Fix icon display in docs (#3517)
Icons showed on github.com but not on docs.abapgit.org
* +On/offline: If package already in other repo, nav to repo (#3525)
* New method to get repo from package
If package already exists in a repo and it returns the repo and reason why the package can't be used in a new repo
* UI: If package exists in repo, nav to repo
+Online, +Offline - if repo is already versioned, navigate to repo and show message why package could not be used in new repo
Closes https://github.com/larshp/abapGit/issues/3452
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
* Update eslint requirement from ^7.2.0 to ^7.3.0 (#3534)
* Update @abaplint/cli requirement from ^2.36.6 to ^2.36.9 (#3535)
* Fix syntax errors in 702 (#3548)
Caused by https://github.com/larshp/abapGit/pull/3525
* SCP1 Import Order (#3543)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Update .gitlab-ci.yml
* Update eslint requirement from ^7.3.0 to ^7.3.1 (#3556)
* Update @abaplint/cli requirement from ^2.36.9 to ^2.37.2 (#3557)
* Repo overview as main page (#3498)
* Add main menu, toggle favorites
* Make abapgit logo go to overview
* Remove favorite repo links
* Fix remember filter
* Separator between filters
* Remove unused code
* Repo overview to main page
* Fix errors
* Fix naming
* Downport js
* Add separator
* remove unrelated changes
* Fix spacing
* Add package link
* Fix orderby dumping
* Only show tutorial with no favorites
Still have to do something about empty table
* Move abapgit installation info to debug info
* Improve tutorial, resolves#3497
* Add branch switch link
* Reduce line length
* Revert temporary hack
* Working version of removing logo
* No longer show tutorial in repositories
* Code cleanup
* More cleanup, rename tutorial to page
* Fix
* Force order by favorite
* Add checkmark icons
* View repo to page, rework menu
* Fix build
* Return logo
* Fix hotkeys on repo page, rename to page
* Fix show last repo, cleanup
* Abaplint
* Rollback js reformat
* Fix tutorial title, hotkeys
* Try resolve strange situation with PR
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Remove unused method (#3554)
* Remove unused method
* whitespace
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* 1.97.0 (#3561)
* 1.97.0
whitespace
* 1.97.0
* v1.97.0
* fix for apply_order_by (#3566)
* Update zcl_abapgit_repo.clas.abap (#3570)
* Dialogs: add online repo HTML form (#3533)
* first draft
* progress ...
* html->create()
* more progress
* and more
* getting closer
* wiring
* refactor popup_search_help
* refactor create_package to services
* fix services->new_online after rebase
* linter fixes
* more linter fixes
* straing map util
* error handling
* submits for side actions (ugly ... but ...)
* cleanups
* linter fixes
* refactor form values logic
* linter fix
* review fixes
* remove unused var after rebase
* review fixes, better side action layout
* linter fix
* minor css tweaks
* Fix user settings containing invalid repo key (#3569)
* Update zcl_abapgit_persistence_user.clas.abap
* Fix dump when last repo is invalid
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* UI: Fixes for dark theme (#3540)
* Add logo for dark theme
* Dark theme fixes
* Dark theme fixes
* Solve conflict
* Remove logo changes
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
* Missing objects in overwrite confirmation popup (#3558)
* Missing objects in overwrite confirmation popup
Closes https://github.com/larshp/abapGit/issues/3550
* Unit tests
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Fix open url in repo view (#3581)
* Fix open url in repo view
* Move call_browser to gui_router
* CSS and logo fixes (#3578)
* css cleanups
* orange logo
* Revert "orange logo"
This reverts commit b9aa45bbd0.
* update font
* css improvements
* remove logo png
* re-layout page title and footer
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Html form improvements and docs (#3582)
* auto id
* fix html validation (form in ul)
* form groups
* move colors to theme
* docs for html form component
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Generate news instance (#3585)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Update @abaplint/cli requirement from ^2.37.2 to ^2.37.5 (#3588)
* Update eslint requirement from ^7.3.1 to ^7.4.0 (#3589)
* Update .gitlab-ci.yml
* fix repo palette (#3580)
* fix repo palette
* fix page_view_repo after rebase
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Adjust new logo color for dark theme (#3592)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Add deleted objects to overwrite confirm popup (#3591)
* Add deleted objects to overwrite confirm popup
Closes https://github.com/larshp/abapGit/issues/2845
* Pretty print
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Top menu improvements (#3590)
* Use icons, add back menu to repo show page
* Event handling
* Abaplint
* Add menu to tutorial page
* Lint
* More icons
* Update tutorial, reorganize button code
* Move icon css
* Fix error
* Fix menu
* Update .gitlab-ci.yml
* Fix rebase issue
* Fix rebase mess up
* Raise exception when no .abapgit.xml is found (#3512)
Update
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Updated documentation for repo settings & icons (#3499)
* Completed to-dos
- Updated abapgit.xml example
- Completed missing docu for local settings
* screenshots
* screenshots
* Delete repo_settings_local.png
* screenshots
* Delete repo_settings_local.png
* screenshots
* screenshots
* Combine write-protect setting
* Merged to repo settings
* screenshots
* screenshots
* merged to repo settings
* merged to repo settings
* Adding details
* Added links
* links
* icons
* icons
* icons
* icons
* icons
* icons
* icons
* Update ref-icons.md
* icons
* icons
* Update docs/ref-dot-abapgit.md
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Fix icon display in docs (#3517)
Icons showed on github.com but not on docs.abapgit.org
* +On/offline: If package already in other repo, nav to repo (#3525)
* New method to get repo from package
If package already exists in a repo and it returns the repo and reason why the package can't be used in a new repo
* UI: If package exists in repo, nav to repo
+Online, +Offline - if repo is already versioned, navigate to repo and show message why package could not be used in new repo
Closes https://github.com/larshp/abapGit/issues/3452
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
* Update eslint requirement from ^7.2.0 to ^7.3.0 (#3534)
* Update @abaplint/cli requirement from ^2.36.6 to ^2.36.9 (#3535)
* Fix syntax errors in 702 (#3548)
Caused by https://github.com/larshp/abapGit/pull/3525
* SCP1 Import Order (#3543)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Update .gitlab-ci.yml
* Update eslint requirement from ^7.3.0 to ^7.3.1 (#3556)
* Update @abaplint/cli requirement from ^2.36.9 to ^2.37.2 (#3557)
* Repo overview as main page (#3498)
* Add main menu, toggle favorites
* Make abapgit logo go to overview
* Remove favorite repo links
* Fix remember filter
* Separator between filters
* Remove unused code
* Repo overview to main page
* Fix errors
* Fix naming
* Downport js
* Add separator
* remove unrelated changes
* Fix spacing
* Add package link
* Fix orderby dumping
* Only show tutorial with no favorites
Still have to do something about empty table
* Move abapgit installation info to debug info
* Improve tutorial, resolves#3497
* Add branch switch link
* Reduce line length
* Revert temporary hack
* Working version of removing logo
* No longer show tutorial in repositories
* Code cleanup
* More cleanup, rename tutorial to page
* Fix
* Force order by favorite
* Add checkmark icons
* View repo to page, rework menu
* Fix build
* Return logo
* Fix hotkeys on repo page, rename to page
* Fix show last repo, cleanup
* Abaplint
* Rollback js reformat
* Fix tutorial title, hotkeys
* Try resolve strange situation with PR
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Remove unused method (#3554)
* Remove unused method
* whitespace
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* 1.97.0 (#3561)
* 1.97.0
whitespace
* 1.97.0
* v1.97.0
* fix for apply_order_by (#3566)
* Update zcl_abapgit_repo.clas.abap (#3570)
* Dialogs: add online repo HTML form (#3533)
* first draft
* progress ...
* html->create()
* more progress
* and more
* getting closer
* wiring
* refactor popup_search_help
* refactor create_package to services
* fix services->new_online after rebase
* linter fixes
* more linter fixes
* straing map util
* error handling
* submits for side actions (ugly ... but ...)
* cleanups
* linter fixes
* refactor form values logic
* linter fix
* review fixes
* remove unused var after rebase
* review fixes, better side action layout
* linter fix
* minor css tweaks
* Fix user settings containing invalid repo key (#3569)
* Update zcl_abapgit_persistence_user.clas.abap
* Fix dump when last repo is invalid
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* UI: Fixes for dark theme (#3540)
* Add logo for dark theme
* Dark theme fixes
* Dark theme fixes
* Solve conflict
* Remove logo changes
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
* Missing objects in overwrite confirmation popup (#3558)
* Missing objects in overwrite confirmation popup
Closes https://github.com/larshp/abapGit/issues/3550
* Unit tests
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Fix open url in repo view (#3581)
* Fix open url in repo view
* Move call_browser to gui_router
* CSS and logo fixes (#3578)
* css cleanups
* orange logo
* Revert "orange logo"
This reverts commit b9aa45bbd0.
* update font
* css improvements
* remove logo png
* re-layout page title and footer
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Html form improvements and docs (#3582)
* auto id
* fix html validation (form in ul)
* form groups
* move colors to theme
* docs for html form component
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Generate news instance (#3585)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Update @abaplint/cli requirement from ^2.37.2 to ^2.37.5 (#3588)
* Update eslint requirement from ^7.3.1 to ^7.4.0 (#3589)
* Improve message when no branches selectable
* Update .gitlab-ci.yml
* Fix linter issues
* Fix rebase mess up
* Enhanced Error message
* Delete .gitlab-ci.yml
Co-authored-by: Ed Wenmakers <ed.wenmakers@redwood.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Rakshith Gore <58498218+goreraks@users.noreply.github.com>
Co-authored-by: Lukáš Novák <lthenovi@gmail.com>
Co-authored-by: Alexander Tsybulsky <sbcgua@users.noreply.github.com>
Co-authored-by: Jaime Rodriguez Capote <jrodriguez@resultoconsultoria.com>
* Fix issue 3597 (#2 try)
When abapGit is being executed on SAP GUI for HTML, all the links don't work (don't do anything because SAPEVENT isn't being passed back to the application server).
* Fix build errors of previous commit
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Use icons, add back menu to repo show page
* Event handling
* Abaplint
* Add menu to tutorial page
* Lint
* More icons
* Update tutorial, reorganize button code
* Move icon css
* Fix error
* Fix menu
* auto id
* fix html validation (form in ul)
* form groups
* move colors to theme
* docs for html form component
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* css cleanups
* orange logo
* Revert "orange logo"
This reverts commit b9aa45bbd0.
* update font
* css improvements
* remove logo png
* re-layout page title and footer
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Add logo for dark theme
* Dark theme fixes
* Dark theme fixes
* Solve conflict
* Remove logo changes
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
Main and repo are no longer one page, so the `re_render` action does not make sense anymore. `new_page_replacing` is used instead of `new_page` so you cannot navigate back to the removed repo.
* Add main menu, toggle favorites
* Make abapgit logo go to overview
* Remove favorite repo links
* Fix remember filter
* Separator between filters
* Remove unused code
* Repo overview to main page
* Fix errors
* Fix naming
* Downport js
* Add separator
* remove unrelated changes
* Fix spacing
* Add package link
* Fix orderby dumping
* Only show tutorial with no favorites
Still have to do something about empty table
* Move abapgit installation info to debug info
* Improve tutorial, resolves#3497
* Add branch switch link
* Reduce line length
* Revert temporary hack
* Working version of removing logo
* No longer show tutorial in repositories
* Code cleanup
* More cleanup, rename tutorial to page
* Fix
* Force order by favorite
* Add checkmark icons
* View repo to page, rework menu
* Fix build
* Return logo
* Fix hotkeys on repo page, rename to page
* Fix show last repo, cleanup
* Abaplint
* Rollback js reformat
* Fix tutorial title, hotkeys
* Try resolve strange situation with PR
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* New method to get repo from package
If package already exists in a repo and it returns the repo and reason why the package can't be used in a new repo
* UI: If package exists in repo, nav to repo
+Online, +Offline - if repo is already versioned, navigate to repo and show message why package could not be used in new repo
Closes https://github.com/larshp/abapGit/issues/3452
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
* Minor improvement for icons in repo view
* Add Icon Legend in "Debug Info"
A place to see available icons (will copy it to documentation).
* Pretty print
* Reverse icons in debug info
Icons are now in docs. No need for this here
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Fix incorrect status of ignored filed in repo view
After update of repo settings, some ignored files showed as "-/A".
https://github.com/larshp/abapGit/pull/3415
* Whitespace
Co-authored-by: Lars Hvam <larshp@hotmail.com>
