Commit Graph

543 Commits

Author SHA1 Message Date
Frederik Hudák
b34f5c36b5
Remember repo list filter (#3671)
* Remember repo list filter

resolves #3552 

Changes:
- store filter in local storage instead of session storage, so it is remembered on abapgit restart
- filter is saved whenever it is changed instead of page unload
- removed debug output, it doesn't need to clutter the main page

* Don't resave on page load

* Add semicolons

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-01 12:42:20 +02:00
Lars Hvam
837d45bc83
fix whitespace (#3690) 2020-07-31 06:22:01 +02:00
Frederik Hudák
a1ecc65ecc
Improved branching messages (#3685)
* Improvements to branch messages

* Names without refs/heads
2020-07-31 06:15:56 +02:00
Alexander Tsybulsky
525634e42b
page hoc concept (#3626)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-23 15:10:40 +02:00
Michael Käsemann
04e71feabe
Improved staging robustness (#3625)
* Improved staging robustness

- Skipped any objects in the changelist that are not marked for staging prior to processing them , to avoid that they keep other objects without errors from being staged if the user wants to stage parts of the changes

* Reduced line length

* Removed missed whitespace

* Update abaplint.json

* Update abaplint.json

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-23 14:59:22 +02:00
Frederik Hudák
144e53608d
Add action column to repo overview (#3645)
* Add stage, patch buttons to repo overview

* Fix abaplint

* Add syntax check, code inspector

* Add pull

* constant naming

* Last changes

* lint

* lint

* Update abaplint.json

* Update abaplint.json

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-21 07:24:38 +02:00
Michael Käsemann
72ccc986c7
Faulty handling of post data (#3624)
* Fixed faulty translation of post data to parsable string

- Added method TRANSLATE_POSTDATA to ZCL_ABAPGIT_UTILS as a centralized place to translate post data to a string
- Replaced all post data string concatenations with the translation helper method to correctly parse spaces that fall to the end of a table line (this should solve #3073 as well as any other random crash caused by accidental misalignment of the post data)

* Backport ABAP statement to 7.02

* Code cleanup for linter checks

* Code cleanup for linter checks

* Fixed a possible error in parsing

If it_postdata contains an empty last line, the staging fails, because the string may contain a lot of soaces at the end of the previous to last line.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-16 15:51:36 +02:00
Alexander Tsybulsky
07e1f787c6
gui_page cleanups (#3615)
* move test_changed_by from gui_page to services

* kind of linter fix

* move more action to router

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-13 17:42:40 +02:00
Alexander Tsybulsky
144cb8822c
improve missing branch styling (#3619)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-13 11:34:39 +02:00
Lars Hvam
0feae7c1b2
ZCL_ABAPGIT_FRONTEND_SERVICES private (#3617)
private instantiation
2020-07-13 11:17:21 +02:00
Alexander Tsybulsky
d18d4c798e
Fix #3609 (clone uppercase pkg name) (#3613) 2020-07-12 08:56:44 +02:00
Lars Hvam
cd9ea97a63
HTML: move add_icon to interface (#3608)
* HTML: move add_icon to interface

* ZCL_ABAPGIT_HTML_TOOLBAR use interface

* ZCL_ABAPGIT_GUI_REPO_OVER use interface

* ZCL_ABAPGIT_GUI_PAGE_VIEW_REPO  use intf
2020-07-12 08:37:15 +02:00
ed-holland
df48acc015
Clearer error message for no branch (#3605)
* CI Update

* Raise exception when no .abapgit.xml is found (#3512)

Update

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Updated documentation for repo settings & icons (#3499)

* Completed to-dos

- Updated abapgit.xml example
- Completed missing docu for local settings

* screenshots

* screenshots

* Delete repo_settings_local.png

* screenshots

* Delete repo_settings_local.png

* screenshots

* screenshots

* Combine write-protect setting

* Merged to repo settings

* screenshots

* screenshots

* merged to repo settings

* merged to repo settings

* Adding details

* Added links

* links

* icons

* icons

* icons

* icons

* icons

* icons

* icons

* Update ref-icons.md

* icons

* icons

* Update docs/ref-dot-abapgit.md

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Fix icon display in docs (#3517)

Icons showed on github.com but not on docs.abapgit.org

* +On/offline: If package already in other repo, nav to repo (#3525)

* New method to get repo from package

If package already exists in a repo and it returns the repo and reason why the package can't be used in a new repo

* UI: If package exists in repo, nav to repo

+Online, +Offline - if repo is already versioned, navigate to repo and show message why package could not be used in new repo

Closes https://github.com/larshp/abapGit/issues/3452

Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>

* Update eslint requirement from ^7.2.0 to ^7.3.0 (#3534)

* Update @abaplint/cli requirement from ^2.36.6 to ^2.36.9 (#3535)

* Fix syntax errors in 702 (#3548)

Caused by https://github.com/larshp/abapGit/pull/3525

* SCP1 Import Order (#3543)

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Update .gitlab-ci.yml

* Update eslint requirement from ^7.3.0 to ^7.3.1 (#3556)

* Update @abaplint/cli requirement from ^2.36.9 to ^2.37.2 (#3557)

* Repo overview as main page (#3498)

* Add main menu, toggle favorites

* Make abapgit logo go to overview

* Remove favorite repo links

* Fix remember filter

* Separator between filters

* Remove unused code

* Repo overview to main page

* Fix errors

* Fix naming

* Downport js

* Add separator

* remove unrelated changes

* Fix spacing

* Add package link

* Fix orderby dumping

* Only show tutorial with no favorites

Still have to do something about empty table

* Move abapgit installation info to debug info

* Improve tutorial, resolves #3497

* Add branch switch link

* Reduce line length

* Revert temporary hack

* Working version of removing logo

* No longer show tutorial in repositories

* Code cleanup

* More cleanup, rename tutorial to page

* Fix

* Force order by favorite

* Add checkmark icons

* View repo to page, rework menu

* Fix build

* Return logo

* Fix hotkeys on repo page, rename to page

* Fix show last repo, cleanup

* Abaplint

* Rollback js reformat

* Fix tutorial title, hotkeys

* Try resolve strange situation with PR

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Remove unused method (#3554)

* Remove unused method

* whitespace

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* 1.97.0 (#3561)

* 1.97.0

whitespace

* 1.97.0

* v1.97.0

* fix for apply_order_by (#3566)

* Update zcl_abapgit_repo.clas.abap (#3570)

* Dialogs: add online repo HTML form (#3533)

* first draft

* progress ...

* html->create()

* more progress

* and more

* getting closer

* wiring

* refactor popup_search_help

* refactor create_package to services

* fix services->new_online after rebase

* linter fixes

* more linter fixes

* straing map util

* error handling

* submits for side actions (ugly ... but ...)

* cleanups

* linter fixes

* refactor form values logic

* linter fix

* review fixes

* remove unused var after rebase

* review fixes, better side action layout

* linter fix

* minor css tweaks

* Fix user settings containing invalid repo key (#3569)

* Update zcl_abapgit_persistence_user.clas.abap

* Fix dump when last repo is invalid

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* UI: Fixes for dark theme (#3540)

* Add logo for dark theme

* Dark theme fixes

* Dark theme fixes

* Solve conflict

* Remove logo changes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>

* Missing objects in overwrite confirmation popup (#3558)

* Missing objects in overwrite confirmation popup

Closes https://github.com/larshp/abapGit/issues/3550

* Unit tests

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Fix open url in repo view (#3581)

* Fix open url in repo view

* Move call_browser to gui_router

* CSS and logo fixes (#3578)

* css cleanups

* orange logo

* Revert "orange logo"

This reverts commit b9aa45bbd0.

* update font

* css improvements

* remove logo png

* re-layout page title and footer

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Html form improvements and docs (#3582)

* auto id

* fix html validation (form in ul)

* form groups

* move colors to theme

* docs for html form component

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Generate news instance (#3585)

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Update @abaplint/cli requirement from ^2.37.2 to ^2.37.5 (#3588)

* Update eslint requirement from ^7.3.1 to ^7.4.0 (#3589)

* Update .gitlab-ci.yml

* fix repo palette (#3580)

* fix repo palette

* fix page_view_repo after rebase

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Adjust new logo color for dark theme (#3592)

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Add deleted objects to overwrite confirm popup (#3591)

* Add deleted objects to overwrite confirm popup

Closes https://github.com/larshp/abapGit/issues/2845

* Pretty print

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Top menu improvements (#3590)

* Use icons, add back menu to repo show page

* Event handling

* Abaplint

* Add menu to tutorial page

* Lint

* More icons

* Update tutorial, reorganize button code

* Move icon css

* Fix error

* Fix menu

* Update .gitlab-ci.yml

* Fix rebase issue

* Fix rebase mess up

* Raise exception when no .abapgit.xml is found (#3512)

Update

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Updated documentation for repo settings & icons (#3499)

* Completed to-dos

- Updated abapgit.xml example
- Completed missing docu for local settings

* screenshots

* screenshots

* Delete repo_settings_local.png

* screenshots

* Delete repo_settings_local.png

* screenshots

* screenshots

* Combine write-protect setting

* Merged to repo settings

* screenshots

* screenshots

* merged to repo settings

* merged to repo settings

* Adding details

* Added links

* links

* icons

* icons

* icons

* icons

* icons

* icons

* icons

* Update ref-icons.md

* icons

* icons

* Update docs/ref-dot-abapgit.md

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Fix icon display in docs (#3517)

Icons showed on github.com but not on docs.abapgit.org

* +On/offline: If package already in other repo, nav to repo (#3525)

* New method to get repo from package

If package already exists in a repo and it returns the repo and reason why the package can't be used in a new repo

* UI: If package exists in repo, nav to repo

+Online, +Offline - if repo is already versioned, navigate to repo and show message why package could not be used in new repo

Closes https://github.com/larshp/abapGit/issues/3452

Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>

* Update eslint requirement from ^7.2.0 to ^7.3.0 (#3534)

* Update @abaplint/cli requirement from ^2.36.6 to ^2.36.9 (#3535)

* Fix syntax errors in 702 (#3548)

Caused by https://github.com/larshp/abapGit/pull/3525

* SCP1 Import Order (#3543)

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Update .gitlab-ci.yml

* Update eslint requirement from ^7.3.0 to ^7.3.1 (#3556)

* Update @abaplint/cli requirement from ^2.36.9 to ^2.37.2 (#3557)

* Repo overview as main page (#3498)

* Add main menu, toggle favorites

* Make abapgit logo go to overview

* Remove favorite repo links

* Fix remember filter

* Separator between filters

* Remove unused code

* Repo overview to main page

* Fix errors

* Fix naming

* Downport js

* Add separator

* remove unrelated changes

* Fix spacing

* Add package link

* Fix orderby dumping

* Only show tutorial with no favorites

Still have to do something about empty table

* Move abapgit installation info to debug info

* Improve tutorial, resolves #3497

* Add branch switch link

* Reduce line length

* Revert temporary hack

* Working version of removing logo

* No longer show tutorial in repositories

* Code cleanup

* More cleanup, rename tutorial to page

* Fix

* Force order by favorite

* Add checkmark icons

* View repo to page, rework menu

* Fix build

* Return logo

* Fix hotkeys on repo page, rename to page

* Fix show last repo, cleanup

* Abaplint

* Rollback js reformat

* Fix tutorial title, hotkeys

* Try resolve strange situation with PR

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Remove unused method (#3554)

* Remove unused method

* whitespace

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* 1.97.0 (#3561)

* 1.97.0

whitespace

* 1.97.0

* v1.97.0

* fix for apply_order_by (#3566)

* Update zcl_abapgit_repo.clas.abap (#3570)

* Dialogs: add online repo HTML form (#3533)

* first draft

* progress ...

* html->create()

* more progress

* and more

* getting closer

* wiring

* refactor popup_search_help

* refactor create_package to services

* fix services->new_online after rebase

* linter fixes

* more linter fixes

* straing map util

* error handling

* submits for side actions (ugly ... but ...)

* cleanups

* linter fixes

* refactor form values logic

* linter fix

* review fixes

* remove unused var after rebase

* review fixes, better side action layout

* linter fix

* minor css tweaks

* Fix user settings containing invalid repo key (#3569)

* Update zcl_abapgit_persistence_user.clas.abap

* Fix dump when last repo is invalid

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* UI: Fixes for dark theme (#3540)

* Add logo for dark theme

* Dark theme fixes

* Dark theme fixes

* Solve conflict

* Remove logo changes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>

* Missing objects in overwrite confirmation popup (#3558)

* Missing objects in overwrite confirmation popup

Closes https://github.com/larshp/abapGit/issues/3550

* Unit tests

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Fix open url in repo view (#3581)

* Fix open url in repo view

* Move call_browser to gui_router

* CSS and logo fixes (#3578)

* css cleanups

* orange logo

* Revert "orange logo"

This reverts commit b9aa45bbd0.

* update font

* css improvements

* remove logo png

* re-layout page title and footer

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Html form improvements and docs (#3582)

* auto id

* fix html validation (form in ul)

* form groups

* move colors to theme

* docs for html form component

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Generate news instance (#3585)

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Update @abaplint/cli requirement from ^2.37.2 to ^2.37.5 (#3588)

* Update eslint requirement from ^7.3.1 to ^7.4.0 (#3589)

* Improve message when no branches selectable

* Update .gitlab-ci.yml

* Fix linter issues

* Fix rebase mess up

* Enhanced Error message

* Delete .gitlab-ci.yml

Co-authored-by: Ed Wenmakers <ed.wenmakers@redwood.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Rakshith Gore <58498218+goreraks@users.noreply.github.com>
Co-authored-by: Lukáš Novák <lthenovi@gmail.com>
Co-authored-by: Alexander Tsybulsky <sbcgua@users.noreply.github.com>
Co-authored-by: Jaime Rodriguez Capote <jrodriguez@resultoconsultoria.com>
2020-07-11 12:38:55 +02:00
Shai
15f55276e1
Fix issue 3597 (#2 try) (#3601)
* Fix issue 3597 (#2 try)

When abapGit is being executed on SAP GUI for HTML, all the links don't work (don't do anything because SAPEVENT isn't being passed back to the application server).

* Fix build errors of previous commit

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-11 08:28:41 +02:00
Frederik Hudák
d49d0656b0
Top menu improvements (#3590)
* Use icons, add back menu to repo show page

* Event handling

* Abaplint

* Add menu to tutorial page

* Lint

* More icons

* Update tutorial, reorganize button code

* Move icon css

* Fix error

* Fix menu
2020-07-09 09:12:58 +02:00
Marc Bernard
e0c93b0d7c
Add deleted objects to overwrite confirm popup (#3591)
* Add deleted objects to overwrite confirm popup

Closes https://github.com/larshp/abapGit/issues/2845

* Pretty print

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-07 15:31:21 +02:00
Marc Bernard
a980d9812d
Adjust new logo color for dark theme (#3592)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-07 15:21:34 +02:00
Alexander Tsybulsky
2699e2d513
fix repo palette (#3580)
* fix repo palette

* fix page_view_repo after rebase

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-07 14:59:31 +02:00
Alexander Tsybulsky
f80b537c7c
defaul theme fix (grey headings) (#3587)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-06 08:12:47 +02:00
Jaime Rodriguez Capote
fd32cbd951
Generate news instance (#3585)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-05 18:08:51 +02:00
Alexander Tsybulsky
6fe168640c
Html form improvements and docs (#3582)
* auto id

* fix html validation (form in ul)

* form groups

* move colors to theme

* docs for html form component

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-05 17:57:45 +02:00
Alexander Tsybulsky
cae3aae5e2
CSS and logo fixes (#3578)
* css cleanups

* orange logo

* Revert "orange logo"

This reverts commit b9aa45bbd0.

* update font

* css improvements

* remove logo png

* re-layout page title and footer

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-04 12:47:14 +02:00
Jaime Rodriguez Capote
f8d74cc928
Fix open url in repo view (#3581)
* Fix open url in repo view

* Move call_browser to gui_router
2020-07-04 12:35:38 +02:00
Marc Bernard
493bb969b2
UI: Fixes for dark theme (#3540)
* Add logo for dark theme

* Dark theme fixes

* Dark theme fixes

* Solve conflict

* Remove logo changes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-07-02 09:15:31 +02:00
Marc Bernard
7ce457dc8d
Fix user settings containing invalid repo key (#3569)
* Update zcl_abapgit_persistence_user.clas.abap

* Fix dump when last repo is invalid

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-01 15:24:33 +02:00
Frederik Hudák
961afa37f8
Fix error after removing/uninstalling repo (#3572)
Main and repo are no longer one page, so the `re_render` action does not make sense anymore. `new_page_replacing` is used instead of `new_page` so you cannot navigate back to the removed repo.
2020-07-01 15:10:39 +02:00
Alexander Tsybulsky
f5dfd328f5
Dialogs: add online repo HTML form (#3533)
* first draft

* progress ...

* html->create()

* more progress

* and more

* getting closer

* wiring

* refactor popup_search_help

* refactor create_package to services

* fix services->new_online after rebase

* linter fixes

* more linter fixes

* straing map util

* error handling

* submits for side actions (ugly ... but ...)

* cleanups

* linter fixes

* refactor form values logic

* linter fix

* review fixes

* remove unused var after rebase

* review fixes, better side action layout

* linter fix

* minor css tweaks
2020-07-01 08:16:52 +02:00
Lukáš Novák
d621551146
fix for apply_order_by (#3566) 2020-06-30 10:11:27 +02:00
Lars Hvam
051c9c6569
1.97.0 (#3561)
* 1.97.0

whitespace

* 1.97.0

* v1.97.0
2020-06-29 16:52:15 +02:00
Frederik Hudák
e4fd14ee73
Remove unused method (#3554)
* Remove unused method

* whitespace

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-29 16:40:01 +02:00
Frederik Hudák
32cf59ca1e
Repo overview as main page (#3498)
* Add main menu, toggle favorites

* Make abapgit logo go to overview

* Remove favorite repo links

* Fix remember filter

* Separator between filters

* Remove unused code

* Repo overview to main page

* Fix errors

* Fix naming

* Downport js

* Add separator

* remove unrelated changes

* Fix spacing

* Add package link

* Fix orderby dumping

* Only show tutorial with no favorites

Still have to do something about empty table

* Move abapgit installation info to debug info

* Improve tutorial, resolves #3497

* Add branch switch link

* Reduce line length

* Revert temporary hack

* Working version of removing logo

* No longer show tutorial in repositories

* Code cleanup

* More cleanup, rename tutorial to page

* Fix

* Force order by favorite

* Add checkmark icons

* View repo to page, rework menu

* Fix build

* Return logo

* Fix hotkeys on repo page, rename to page

* Fix show last repo, cleanup

* Abaplint

* Rollback js reformat

* Fix tutorial title, hotkeys

* Try resolve strange situation with PR

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-29 16:34:59 +02:00
Marc Bernard
dc95fb3efd
Fix syntax errors in 702 (#3548)
Caused by https://github.com/larshp/abapGit/pull/3525
2020-06-27 16:25:23 +02:00
Marc Bernard
01dce88475
Interface and implementing class in same package (#3528)
* Interface and implementing class in same package

* Interface and implementing class in same package

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-21 10:23:43 +02:00
Marc Bernard
09120cb80d
+On/offline: If package already in other repo, nav to repo (#3525)
* New method to get repo from package

If package already exists in a repo and it returns the repo and reason why the package can't be used in a new repo

* UI: If package exists in repo, nav to repo

+Online, +Offline - if repo is already versioned, navigate to repo and show message why package could not be used in new repo

Closes https://github.com/larshp/abapGit/issues/3452

Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-06-20 14:32:00 +02:00
Marc Bernard
d74284bd8b
Minor improvements of icons in repo view (#3493)
* Minor improvement for icons in repo view

* Add Icon Legend in "Debug Info"

A place to see available icons (will copy it to documentation).

* Pretty print

* Reverse icons in debug info

Icons are now in docs. No need for this here

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-16 16:54:01 +02:00
Marc Bernard
ed09b51855
Fix incorrect status of ignored files in repo view (#3506)
* Fix incorrect status of ignored filed in repo view

After update of repo settings, some ignored files showed as "-/A". 
https://github.com/larshp/abapGit/pull/3415

* Whitespace

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-16 16:00:30 +02:00
Marc Bernard
d006cd0658
Removed default for commit comment (#3513)
* Removed default for commit comment

Closes https://github.com/larshp/abapGit/issues/3511

* Removed default for commit comment

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-16 15:57:04 +02:00
Lars Hvam
024167ce97
replace SYREPID (#3501)
* Update abaplint.json

* replace SYREPID
2020-06-16 07:34:12 +02:00
Christian Günter
58fb961a19
Fix: remove URL validation for offline repos (#3508) 2020-06-15 12:53:40 +02:00
Marc Bernard
38099501b8
Improved validation of URLs (#3486)
* Limit URLs to http and https

* Validate URLs

* Raise error only for validation (not for get_name)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-14 20:14:39 +02:00
Lars Hvam
420e6f5964
replace HTML with interface (#3490)
* replace HTML with interface

part of #3460

* pretty print
2020-06-13 09:39:46 +02:00
Marc Bernard
f5754056f2
Enhanced object list for "Debug Info" (#3480)
Move browser info up
2020-06-10 15:11:47 +02:00
Marc Bernard
19503b8116
Enhanced object list for "Debug Info" (#3475)
* Enhanced object list for "Debug Info"

* Shorter line

* Whitespace
2020-06-09 06:11:53 +02:00
g-back
da9fcd673f
downport loop statement (#3456)
* downport loop statement

* whitespace fix
2020-06-05 15:45:41 +02:00
Lars Hvam
d36b43defe
line break parameters (#3444)
* line break parameters

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* fix
2020-06-04 15:10:35 +02:00
Marc Bernard
40b45f6221
Add master language and ignore files to repo settings (#3415)
Closes https://github.com/larshp/abapGit/issues/3413

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-03 09:17:57 +02:00
Marc Bernard
87241e9f07
Fix for proxy bypass setting (#3439)
Closes https://github.com/larshp/abapGit/issues/3435
2020-05-31 10:30:53 +02:00
Lars Hvam
ea03cc5e4a
Fewer DDIC type references (#3434)
* Fewer DDIC type references

* Update abaplint.json
2020-05-29 06:30:24 +02:00
mariusraht2
b5d40ca2a3
Build commit popup (#3400)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Added new method checkout_commit_build_popup

* abapLint

* Use hash to identify selected popup row

* Moved definitions

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-28 07:23:05 +02:00
Frederik Hudák
657405433d
Add master language setting to new repo popups (#3409)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-26 06:29:31 +02:00
Marc Bernard
f1c249b073
Fix detection of abapGit installation (#3425)
Old logic was failing if transaction ZABAPGIT already existed - typically because it was created manually for the merged version. Testing for program ZABAPGIT would not be any better since that might have been used for the merged version as well. It's more reliable to check a class.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-26 06:05:10 +02:00
Lars Hvam
aec7468aad
Type Hunting (#3414)
* Type Hunting

* update

* update

* flag
2020-05-26 05:55:28 +02:00
Marc Bernard
2e2b8584fb
New syntax-highlighters for CSS, JS, JSON (#3381)
* Add syntax-highlighters for CSS, JS, JSON

* Update W3MI ZABAPGIT_CSS_THEME_DEFAULT

* Fix line size and case statement

* Fix line size

* Update styles, removed operators

* Added highlight for comments in HTML/XML

* Fix menu hover background

This makes the selected menu more visible. 

Also includes color fix for repo name and url in dark theme.

* Fix for W3xx objects with "." in name

* Reverse fix for W3xx

* Remove hover style changes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-25 06:29:03 +02:00
Lars Hvam
5a21bbba7d
remove self interface references (#3412) 2020-05-24 15:28:25 +02:00
Alexander Tsybulsky
5c4c0b882e
Gui refactoring - part 5 (#3403)
* refactor mi_gui_services to getter

* zif_html->set_title (for debug of postponed parts)

* add set_title to all postponed parts

* gui optional rollback on error

* forgotten gui_services call

* docs

* remove gui_page redirect #3404

* forgotten html~set_title in hotkey class

also renamed render_js_part into render_scripts for unification and reuse register_deferred_script - this is why I lost it int the first place

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-24 10:42:06 +02:00
Lars Hvam
411c703e0e
replace use of stringtab with builtin (#3407) 2020-05-24 10:30:51 +02:00
Frederik Hudák
0a67f95c11
Replace assert in gui_page_stage with check (#3392)
* Update zcl_abapgit_gui_page_stage.clas.abap

* Change to exception

* add reference to issue as comment in code

* Update zcl_abapgit_gui_page_stage.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-23 11:42:41 +02:00
Marc Bernard
6d2deece76
Add missing TH closing tag (#3393) 2020-05-23 06:32:34 +02:00
Maxim Engel
f20e13d3ab
Fix for missing-field-popup (#3391)
Fix for missing-field-popup during cloning online repos, due to missing description.

Closes #3390
2020-05-22 17:43:23 +02:00
Frederik Hudák
5d34284805
Highlight hovered line (#3347)
* Highlight hovered line

* Better hover color

* Remove hover border in diffs

* Change bacgkround color

* Fix unrelated syntax errors in css
2020-05-22 10:10:41 +02:00
Marc Bernard
aa204c1e8f
Map blank "last changed by" to "unknown" (#3387)
* Map blank "last changed by" to "unknown" 

Fix blank entry in filter dropdown

* Whitespace
2020-05-22 10:02:33 +02:00
larshp
2d168e170b move stage structures to interface #3377 2020-05-21 07:25:54 +02:00
Frederik Hudák
2886c00592 Fix syntax error in gui_router
Somehow lost this change from #3378. The class no longer exists.
2020-05-21 06:58:26 +02:00
Frederik Hudák
be260435f5
Move explore link (#3378)
* Move explore link

* Update zcl_abapgit_services_abapgit.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-20 19:47:42 +02:00
Frederik Hudák
3335317278
Remove page playground (#3375)
* Remove page playground

* Remove constant
2020-05-20 18:28:03 +02:00
Alexander Tsybulsky
8eae18c0f5
Gui refactoring part 4 (#3362)
* refactoring and remove get_events from gui_page

* cleanups

* more cleanups

* register_deferred_script

* refactor page_stage

* refactor page_diff

* refactor page_commit

* refactor page_debuginfo

* linter fixes

* refactor page_tag

* refactor rage_repo_over

* refactor page_patch

* make gui_page->scripts private
2020-05-20 17:50:00 +02:00
Marc Bernard
aa71ed52ae
Set filter for file open and save dialogs / Add new setting for default commit comment (#3371)
* Set filter for file open and save dialogs

Set the file filter dropdown and default to *.ZIP in file open and save dialogs

* Add new setting for default commit comment

New abapGit setting to define a default for the comment used for commits. Object and/or filename can added to the comment automatically, which works similar to GitHub if a single file is changed. If multiple objects are changed, then object/file count is included in the default for the comment.

* Update CLAS ZCL_ABAPGIT_GUI_PAGE_COMMIT

* Fix text for $object

Fixed case when one object with multiple files was changed

* Pretty print

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-20 12:37:58 +02:00
Marc Bernard
840d818b2d
Minor improvement for debug info (#3372)
- Full SAP GUI patch
- APACK version
2020-05-19 17:46:07 +02:00
Frederik Hudák
202e2d0239
Unify different wordings of 'Diff' (#3367)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-19 07:30:51 +02:00
Alexander Tsybulsky
310d8673dd
Gui refactoring, chapter 3 (#3355)
* zcl_abapgit_html_parts primitive

* integrate parts in GUI

* bughunting and renames

* scripts collection, move hotkeys js to parts

* linter fixes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-13 12:58:43 +02:00
Marc Bernard
40a1ef3a13
Allow setting of display name for offline repos (#3359)
Minor improvement to enable "Display Name" setting for offline projects which is shown in favorites for example
2020-05-13 12:42:23 +02:00
Alexander Tsybulsky
c056076170
Gui refactoring 2 (#3338)
* hotkeys refactoring: draft logic

- new interfaces
- gui services binding
- move render to zcl_hotkeys
- move global hotkeys to hotkeys class
- remove unnecessary stuff from gui_page

* implement zif_abapgit_gui_hotkeys in rel.pages

* settings page draft

* remove zif_abapgit_gui_page_hotkey

* linter fixes

* finalize rendering logic

* finalize settings

* linter fix

* sorting tweak

* fix abapgit_full work

Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-05-08 10:26:54 +02:00
mariusraht2
b91043a270
Refactor Popup (#3310)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Update pull.yml

* Delete pull.yml

* Refactored popup logic

Related to #3040

Refactoring of popup logic/calling to be able to reuse it as commit list.

* Removed reset flag

Removed reset flag cause it doesn't belong to this PR (will be readded later)

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-04 08:36:24 +02:00
Christian Günter
48454c5922
fix page diff dump: use repo instead of repo_online (#3304)
* fix page diff dump: use repo instead of repo_onlin

* make repo online an attribute
2020-04-14 18:57:21 +02:00
Christian Günter
c9241e7cff
Fix zcl_abapgit_gui_component definition (#3299)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-04-09 09:39:35 +02:00
Christian Günter
decc2d4863
Page Patch: fix unit test (#3293) 2020-04-08 15:58:22 +02:00
Alexander Tsybulsky
0eb22a0c87
Gui refactor, part 1 (#3289)
* gui component and event registering

* remove iv_prev_page from event_handler if

* constructors raising zcx_abapgit_exception

* get_gui_services - UT friendly

* linter fixes

* more linter fixes

* zif_gui_services stub all methods

* linter fix

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-04-07 10:30:43 +02:00
Jaime Rodriguez Capote
fce71de4d1
Use constants for Y/N/P (#3291)
* Use constants

* Pretty Printer
2020-04-05 10:55:24 +02:00
Jaime Rodriguez Capote
27ac61e95d
Apack dependencies (#3285)
* Support APACK dependencies

Check installed apack package dependencies for current repository
Display a popup with dependencies

* abaplint checks

* abaplint checks

* abaplint checks

* Popup only when dependency not met

* abaplint checks

* abaplint checks

* Optimization

* abaplint checks

* abaplint checks

* Fix typo "dependeNcies"

* Remove address from dependency check

* Dependencies popup title

* Dependencies popup enhanced

* EXCEPTION column replacing MET
* Enable Git URL hiperlink

* APACK doc - Version dependency support

* Dependencies version check support

* abaplint checks

* abaplint checks

* Version utils

* fix syntax warning

* move set_dot_apack to protected

Co-authored-by: larshp <larshp@hotmail.com>
2020-04-05 08:57:59 +02:00
Christian Günter
803ca23176
Refactor page diff: Introduce subclass for patch (#3283)
* Introduce zcl_abapgit_gui_page_patch as subclass of zcl_abapgit_gui_page_diff

introduce pop-method on GUI stack

fix linter + raising exception when gui stack emp

introduce zcl_abapgit_gui_page_patch

more

add

fix linter

remove go back to patch after commit

fix linter

remove bookmark for stage page

remove pop

src/ui/core/zcl_abapgit_gui.clas.abap

 src/zcl_abapgit_repo_online.clas.abap

* refactor: move more logic to  render_line_split_ro

* refactor move logic to render_diff_head_after_stat

* add logic to render_table_head_non_unified

* extract render_table_head_unified

* extract of is_patch_possible calculation

* fix linter

* move hotkey to patch

* refactor and rename to get_normalized_fname_with_p

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-31 17:14:13 +02:00
Christian Günter
1e4560b32a
Patch: new refresh functions (#3271)
* Patch: Refresh object first working version

* Patch: add refresh local and refresh repo + refact

* add missing stuff

* fix lint

* refactoring and cleanup

* add missing stuff

* refactor

* refactor

* refactor

* add title for menu bar

* Save and restore scroll position

* refactoring and cleanup

* refactor

* cleanup

* cleanup

* cleanup

* remove new hotkey

* disable object refresh for non-object files

* remove restore scrollposition

* cleanup

* refactor

* cleanup

* save scroll position

* Fix: refresh of deleted objects

* Fix dump: refresh new objects

* add hotkey support for refresh all local objects

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-26 12:30:22 +01:00
Frederik Hudák
63640bb3fc
Minor ux improvements (#3253)
* Resize stage list to full width

* Move patch button to the top menu

* Center stage list, increase line width in repo, stage

* Repo page - Increase line height for path column

* Stage list to full size

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-21 09:56:53 +01:00
Eduardo Ferrari Copat
e74d40516c
Diff - Add option to collapse files (#3248)
* Update zcl_abapgit_gui_page_diff.clas.abap

* Update zcl_abapgit_gui_page_diff.clas.abap

* Update zabapgit_css_common.w3mi.data.css

* Update zabapgit_css_common.w3mi.data.css

* test

* Update zabapgit_css_theme_default.w3mi.data.css

* Add collapse to css

* Add user select

* onDiffCollapse

* show source

* src

* Tries text

* hide/show

* uses nodisplay instead of hidden

* good hide

* ===

* Add button

* lint

* lint

* set function as global

* lint

* Exclude gui page diff

* remove extra space

* chevron

* pointer

* class

* Icons

* lint

* lint

* hide

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-12 17:09:00 +01:00
g-back
79a1a667c6
Switch branch protected (#3250)
* add write-protect check for switch branch

* disable link for disabled toolbar functions

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-11 12:54:24 +01:00
larshp
e638e6065a ZCL_ABAPGIT_GUI_PAGE_DIFF propagate exception 2020-03-10 08:17:12 +01:00
Jaime Rodriguez Capote
543114963f
abapOpenCheck - Naming Conventions revision #3239 (#3240)
* abapOpenChecks config file

* Ignore SCI config folder

* checks revision

* Revert "checks revision"

This reverts commit 56a12289df.

* Renaming non-constants

Pending:

* Remove SCI configuration

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-09 17:34:26 +01:00
larshp
8fcf072917 remove call to super->constructor
there is no super class
2020-03-09 17:19:34 +01:00
larshp
b4b3414009 non existing package: fix dump #3224 2020-03-03 10:10:35 +01:00
Daniel Wegner
eb10fae8ef
Proxy bypass (#3221)
* add proxy bypass option in settings

* add proxy bypass popup and persist settings

* add proxy bypass to proxy config class

* Fix Proxy Bypass Button HTML

* Fix indentation

* Implement Method popup_proxy_bypass

* Fix behaviour in case of empty range tab

* Fix behaviour in case of empty range tab 2
2020-03-02 15:30:23 +01:00
Christian Günter
cec926e954
Diff: Only add beacon at beginning while patching (#3218) 2020-02-20 16:43:02 +01:00
Christian Günter
a8d474fab4
Patch: add path to jump target (#3216)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-20 09:39:56 +01:00
Christian Günter
1668e670cf
Fix patch: multiple files with same name (#3213)
- unify id generation
- generate unique filenames

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-19 14:24:04 +01:00
Christian Günter
109c8c3be4
Patch: Remember patched lines when cancel Commit (#3212)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-19 13:55:19 +01:00
Christian Günter
5067e403b7
Patch: add beacon at beginning of objects (#3210)
* Patch: add beacon at beginning of objects

* extract constant + fix unit test
2020-02-19 12:48:26 +01:00
Mauricio Lauffer
a9a505faf4
Prefer RETURNING to EXPORTING (#3204)
* refactor: Prefer RETURNING to EXPORTING

* refactor: Prefer RETURNING to EXPORTING
2020-02-11 10:20:45 +01:00
Lars Hvam
eb7e819b25 refactoring, delete unused variables and methods (#3203)
* zlib

* xml

* processor

* shi5

* remove unused filter parameter

* pinf cleanup

* ssfo delete empty method

* highlighter

* gui page res, remove unused

* remove unused in diff class

* adt link

* gui, remove 2 unused parameters

* branch overview
2020-02-09 09:38:17 +01:00
Jaime Rodriguez Capote
701f83ec2d
Travis-CI Error (#3201)
./src/ui/zcl_abapgit_gui_page_merge.clas.abap[187, 18] - Keep single parameter on one line (keep_single_parameter_on_one_line)

https://travis-ci.org/jrodriguez-rc/abapGit/builds/647280505?utm_medium=notification%26utm_source=github_status
2020-02-07 12:34:59 +01:00
Alexander Tsybulsky
0dba9e5af3
remove DEFINE from zcl_abapgit_gui_view_repo (#3186)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-30 08:10:53 +01:00
Alexander Tsybulsky
0c3cdf639e
remove DEFINED from zcl_abapgit_gui_page_repo_over (#3185)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-30 08:03:19 +01:00
Alexander Tsybulsky
dc96e3b3ef
remove DEFINE from zcl_abapgit_ui_factory (#3184)
* remove DEFINE from zcl_abapgit_ui_factory

* linter fixes

* better approach

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-30 07:57:53 +01:00
larshp
d8047ccad6 use built-in type 2020-01-25 17:47:33 +01:00
Lars Hvam
9872f28d1d
GUI_PAGE_MERGE: refactor DEFINE (#3173)
* GUI_PAGE_MERGE: refactor DEFINE

* fix
2020-01-25 09:48:26 +01:00
Lars Hvam
3e0b0505b1
remove commented code (#3166)
* update abaplint.json

* remove commented code

* remove 2 unused variables
2020-01-24 14:31:04 +01:00
Fabian Lupa
c4f4c713b6 Handle spaces in stage filter (#3153)
* Handle spaces in stage filter

#3073

* Fix JS lint issue

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-14 17:01:56 +01:00
Christian Guenter
bae1e21c5b Refactoring: Delete unused variables 2020-01-13 18:41:52 +01:00
Lars Hvam
75812fb17b
less prefixes (#3144) 2020-01-11 09:24:36 +01:00
Lars Hvam
e201bf566f
remove class prefixes if its current class (#3137)
* remove class prefixes if its current class

* Update abaplint.json
2020-01-06 13:20:19 +01:00
Lars Hvam
b42f3bc485
Refactoring (#3134)
* fully type constants

* moving to single line

* move to single line

* enable keep_single_parameter_on_one_line
2019-12-28 12:11:32 +01:00
mariusraht2
5bee54fff3 Commit icon added (#3124)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Added new icon code-commit via SMW0
2019-12-19 06:20:22 +01:00
Frederik Hudák
c686a7dd3b Unescape '=' character (#3102)
* Unescape '=' character

* fix abaplint
2019-12-05 15:23:47 +01:00
Frederik Hudák
c846801d19 Add adt link to objects on diff page (#3095)
* Add adt link to object name on diff page

* Fix abaplint, improve error handling

* abaplint

* Remove superflous method
2019-12-05 08:59:15 +01:00
sandraros
175f2fabec Code selection by column on DIFF screen (#3091)
* Code selection by column on DIFF screen

Fix of #3089

Two ways to select a text:

1. Position the mouse at the start of the text, press mouse left button, keep pressed, drag to the end of the text, release the button

2. Position the mouse at the start of the text, press mouse left button, release the button, position the mouse to the end of the text, press shift key + mouse left button.

Two ways to copy the selected text:

1. Press Ctrl + C or Ctrl + Ins

2. Mouse right button on the text to display the context menu and choose Copy

SPLIT VIEW (code at the left is the LOCAL code and code at the right is the REMOTE code):
- Text can be selected only at the left side, or only at the right side.
- The dummy empty lines which show the place of lines which exist only at the other side are not copied.

UNIFIED VIEW (LOCAL and REMOTE are mixed in the same column, "green plus" lines correspond to lines only in the LOCAL code, "red minus" lines correspond to lines only in the REMOTE code.
- Only the lines from the REMOTE code are copied

PATCH VIEW (split view + one extra column on the left)
- Same features as the SPLIT VIEW

* corrections lint javascript

* merge latest abapgit changes

* corrections lint javascript

* JS refactor functions to prototyped fns (classes)

* JS lint corrections + minor last minute changes

* conform current common.js standards

* LINT conform to common.js standards

* unused lines removed
2019-12-02 09:32:15 +01:00
mariusraht2
02204d07b4 Improved time conversion (#3096)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Improved time conversion

Preparation for #3040

> rename time%3D>get to time%3D>get_unix
> added time conversion from unix to real (get_real)
> added unit tests for time conversion

* abapLint

* Raise cx_static_check and removed exc handling
2019-12-02 09:28:41 +01:00
Alexander Tsybulsky
39ee3c961f fix #3048, remote only stage js error (#3086) 2019-11-27 06:19:01 +01:00
Lars Hvam
29cb891d23
remove obsolete NO_HANDLER pragmas (#3085)
* remove obsolete NO_HANDLER pragmas

* update lint to latest
2019-11-25 07:35:41 +01:00
mariusraht2
8df12d34e0 Issue 3061: Change default value for creation of playground page (#3062)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Change def. value for creation of playground page

Closes #3061

* Update zcl_abapgit_popups.clas.abap
2019-11-17 10:18:40 +01:00
Alexander Tsybulsky
5edea3acda quick fix unicode char in js (ctrl+enter) #3035 (#3052) 2019-11-11 09:21:22 +01:00
Lars Hvam
04a6d7e484
Update abaplint.json to latest (#3045)
* Update abaplint.json

* chain mainly declarations
2019-11-06 09:35:18 +01:00
mariusraht2
e014efd3f4 log viewer: refactor types (#3041) 2019-11-06 09:30:21 +01:00
Italo N
be9b57a0f2 Commit form should not be cleared on error (#3015)
* Commit form should not be cleared on error

* move the type definition to ZIF_ABAPGIT_DEFINITION

* Move type definition to new interface
2019-11-04 11:48:53 +01:00
Alexander Tsybulsky
f0bb81f04a #3022 patch commit state 2019-11-03 07:57:28 +01:00
Alexander Tsybulsky
d501afdf83 downport (#3026) 2019-11-01 17:25:44 +01:00
Lars Hvam
dca54d2590
refactoring public attributes (#3023)
* testclass for testing and remove public attr

* refactor public vars in local class

* rename
2019-11-01 17:07:17 +01:00
Frederik Hudák
04e196b816 Improve branching messages (#3018)
Mention name of branch which was just deleted/switched to.
2019-10-31 14:35:29 +01:00
Alexander Tsybulsky
4f3bd19a8b stage UX improvements: ctrl-enter, autoadd deleted, remote state bugfix (#3007)
* stage: ctrl-enter, autoadd deleted

* linter fix

* eslint fix

* review fixes
2019-10-31 14:29:23 +01:00
Christian Guenter
99761e37c9 Links: add tooltip with hotkey 2019-10-31 08:42:37 +01:00
Alexander Tsybulsky
1af5648e5f Diff state at stage and commit pages (#3003)
* state at stage and commit pages

* review fix
2019-10-27 11:26:59 +01:00
Italo N
f4c8d13a2c Bug - PROG name contain '%3D' (#2980)
Issue #2923
2019-10-27 11:19:32 +01:00
Alexander Tsybulsky
af97a51fa5 commit selected button (#2993) 2019-10-25 06:46:01 +02:00
Alexander Tsybulsky
fc2c803be5 me filter 2019-10-22 15:27:28 +02:00
David Scheiklies
f4e33039d6 Add commit success message (#2979)
* New version of #2973

* Update zcl_abapgit_gui_page_commit.clas.abap
2019-10-16 21:40:17 -07:00
Alexander Tsybulsky
5c10415b28 possibility to export pkg with master lang only (#2966) 2019-10-13 23:02:42 -07:00
Christian Günter
bc082b15b0 Link Hints: fix start value calculation (#2970)
* Link Hints: fix start value calculation

* fix comment
2019-10-13 22:39:56 -07:00
Alex
17a67933e3 Fix for issue #2922 (#2960)
* added a picture for pull from zip

it can then be used in guide-import-zip.md

* Fix for Issue 2922

https://github.com/larshp/abapGit/issues/2922

Added a new test method find_head_closing_tag.
Implemented fix in method zcl_abapgit_gui_html_processor->find_head_offset.

* Removed dont needed Pull_from_zip.png 

Removed dont needed Pull_from_zip.png

* Restored NewLines handling in patch_html

Restored NewLines handling in patch_html

* Fixed some abapLint Warnings

Fixed some abapLint Warnings

* Fixed some abapLint messages

Fixed some abapLint messages
2019-10-12 03:56:28 -07:00
Lars Hvam
714fe7202d
whitespace fixes (#2964)
* whitespace fixes

* fix sql compare operators
2019-10-11 02:50:16 -07:00
Christian Guenter
8bf4b5df4c Page overview: fix order by column mismatch 2019-10-09 21:14:12 -07:00
Alexander Tsybulsky
f2f82278e7 Serialize master lang only + settings UI improvements (#2954)
* repo settings ui improvements

* serialize_master_lang_only UI

* downport

* connect settings and serialization (MSAG)

* dtel doma tran prog fugr

* linter fixes
2019-10-07 23:03:57 -07:00
Christian Guenter
d7e2833483 Warning at stage when not logged on in master lang 2019-10-06 01:12:33 -07:00
Christian Günter
a40e7f1bbc new function 'add all objects to transport request' (#2942)
* new function 'add all objects to transport req'

* enable cancel
2019-10-06 00:21:51 -07:00
Christian Günter
6decda9c07 Refactor zcl_abapgit_gui_view_repo (#2939)
* refactor build branch/tag dropdown

* refactor build advanced dropdown

* refactor build main toolbar

* cleanup

* cleanup

* post merge conflict fixes
2019-10-05 23:17:27 -07:00
Christian Günter
3905c67edd Order by on repo page (#2933)
* Order by on repo page

* move render_cols_pec to zcl_abapgit_gui_chunk_lib

* cleanup

* cleanup

* first new working version

* fix lint

* add OrderByHelper

* add new feature clear

* rename ICON to CLEAR

* cleanup

* refactor actions

* fix typo in method name

* remove duplication

* rename render_col_spec to render_order_by_table_he

* refactor type

* fix eslint warning

* isoltate repo_tab CSS

* fix non-code and metadata files at the top

* refactor

* cleanup

* new features "diffs first" + remove clear

* refactor

* take directories into account

* cleanup
2019-10-05 22:54:04 -07:00
Christian Günter
ee6d488a07 Branch Overview: fix support for branches with # (#2920) 2019-09-16 04:36:47 -07:00
CASAG-MariusRaht
9ad8973ab6 #2725 (#2907)
* #2725

> Bottom logo is now clickable and links to the repository page on GitHub
> New menu item 'Changelog' under 'Help' which links to the changelog.txt

Special Notes: 
> Link to documentation was already implemented
> Link for menu item 'Tutorials' isn't linked to anything. But that seems to be right, because there isn't a tutorial site separated from the documentation website

* abaplint: Normalization

* Update zcl_abapgit_services_abapgit.clas.abap

* Update zcl_abapgit_services_abapgit.clas.abap

* abaplint: fix max line length error

* abaplint

* Removed "|{}|"
2019-09-15 01:09:27 -07:00
CASAG-MariusRaht
0fd851c8d2 #2723 (#2909)
#2723
> Implemented re-run button for syntax check
2019-09-12 07:33:24 -07:00
Christian Günter
b6f82aa8cf Command palette: Jump to files on Diff/Stage page (#2913)
* Patch/Diff: Command palette for file jump

* change hotkey to F2

* cleanup

* Improve JS func call
2019-09-12 05:29:52 -07:00
CASAG-MariusRaht
0e27d90212 Fix for #2896 (#2906)
> Error message for missing development object
> Reopen "Object to File"-PopUp when object was not found
> Spelling correction for error message
2019-09-09 22:02:12 -07:00
Alexander Tsybulsky
739b14ab6a Command palette: Git actions (#2908)
* enumerateToolbarActions

* command prefix

* docs
2019-09-09 21:34:30 -07:00
Alexander Tsybulsky
587f792026 Command palette (Ctrl+P): Go to repo ... (#2897)
* command palette

* support for Ctrl; case insensitive search

* some wip

* refactor KeyNavigation

* eslint

* commandPalette key navigation improved

* last backspace hides the palette

* minor cleanups and ids
2019-09-07 23:12:49 -07:00
Christian Günter
cb00442062 Diff/Patch: Add Jump to file (#2895)
* Diff/Patch: Add Jump to file

* Patch/Diff: Add bottom margin for scrolling

* Remove filtered files from jump list
2019-08-30 04:17:17 -07:00
Alexander Tsybulsky
883c39bd25 column sorting in repo overview (#2887)
* column sorting draft

* linter fix

* remove old code

* fix toggleDetails - remember state

* eslint fix

* remove unused JS functions

* add column header for macro call
2019-08-26 22:06:27 -07:00