Commit Graph

602 Commits

Author SHA1 Message Date
Lars Hvam
260af61407
ecatt exceptions, test (#4312) 2020-12-12 08:51:49 +01:00
Marc Bernard
869c0bccb5
WDYN: Improve error messages (#4310)
Pass exception text to UI/log

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-11 07:54:19 +01:00
Marc Bernard
46e2dd827b
Package Structure - Part 4 (#4305)
* Package Structure - Part 4

$ABAPGIT_OBJECTS_CORE:

ZCL_ABAPGIT_DEPENDENCIES
ZCL_ABAPGIT_FILE_STATUS
ZCL_ABAPGIT_FOLDER_LOGIC
ZCL_ABAPGIT_OBJECTS
ZCL_ABAPGIT_OBJECTS_ACTIVATION
ZCL_ABAPGIT_OBJECTS_FILES
ZCL_ABAPGIT_SERIALIZE
ZCL_ABAPGIT_TADIR
ZIF_ABAPGIT_COMPARATOR
ZIF_ABAPGIT_OBJECT
ZIF_ABAPGIT_OBJECTS
ZIF_ABAPGIT_TADIR
ZCL_ABAPGIT_SKIP_OBJECTS

$ABAPGIT_OBJECTS_TEXTS:

ZIF_ABAPGIT_LANG_DEFINITIONS

#4253

* ZIF_ABAPGIT_LANG_DEFINITIONS

* Sync

* Sync

* Sync

* Sync

* Move objects

* Sync

* always upload build artifact

* Move type to interface

* Types

* Add package

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-11 07:50:10 +01:00
Lars Hvam
efaa0e65c0
more generic exception catching (#4307) 2020-12-11 07:46:07 +01:00
jan-jezek
c6a54b9912
Fix master language only, duplicate entries for shi3 objects (#4308)
* Fix master language only for shi3 objects

* Fix abaplint

* Fix duplicates in shi3

* Abaplint

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2020-12-11 07:43:52 +01:00
Marc Bernard
8fcc5c2f95
DSYS: Get changed by (#4303)
Get "changed by" user

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-09 09:27:11 +01:00
Marc Bernard
8118ab836d
SMIM: Improve error messages (#4304)
Pass T100 messages to UI/log

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-09 08:02:55 +01:00
Marc Bernard
eb1a6fab90
SOTS: Get changed by (#4302)
Get "changed by" user
2020-12-09 05:27:13 +01:00
Marc Bernard
b31885796d
Fix pull errors related to files deleted remotely (#4281)
In case files are deleted remotely, the files are now ignored during a pull. In other words, "pull" will not touch objects that exist only locally and not remotely.

To delete such objects locally, use "reset local (forced pull)" which will show a popup for these objects and let you delete them.

Closes #4277

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-08 17:16:04 +01:00
Marc Bernard
0fc7b43a35
PROG: Fix transport and work area (#4242)
* PROG: Remove objects from work area 

Fixes issue with incomplete deletion of inactive objects

Closes #4151

* Lint

* Add correction

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-07 09:38:56 +01:00
Marc Bernard
5ed2f5bb22
DOMA: Fix serialize for missing translations (#4283)
Closes #4278

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-04 09:01:24 +01:00
Marc Bernard
1c8f8038c5
Package Structure - Part 3 (#4286)
$ABAPGIT_OBJECTS_OO:

ZCL_ABAPGIT_OO_BASE
ZCL_ABAPGIT_OO_CLASS
ZCL_ABAPGIT_OO_FACTORY
ZCL_ABAPGIT_OO_INTERFACE
ZCL_ABAPGIT_OO_SERIALIZER
ZIF_ABAPGIT_OO_OBJECT_FNC

#4253

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-04 08:51:43 +01:00
Marc Bernard
58024be52e
TRAN: Improve error messages (#4280)
* TRAN: Improve error messages

Pass T100 messages to UI/log

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-04 08:46:08 +01:00
Marc Bernard
d11c82148e
Package Structure - Part 2 (#4273)
* Package Structure - Part 2

$ABAPGIT_OBJECTS_TEXTS:

ZCL_ABAPGIT_LONGTEXTS
ZCL_ABAPGIT_SOTR_HANDLER
ZIF_ABAPGIT_LANG_DEFINITIONS
ZIF_ABAPGIT_LONGTEXTS

$ABAPGIT_OBJECTS_ENH:

ZCL_ABAPGIT_OBJECT_ENHO_BADI
ZCL_ABAPGIT_OBJECT_ENHO_CLASS
ZCL_ABAPGIT_OBJECT_ENHO_CLIF
ZCL_ABAPGIT_OBJECT_ENHO_FUGR
ZCL_ABAPGIT_OBJECT_ENHO_HOOK
ZCL_ABAPGIT_OBJECT_ENHO_INTF
ZCL_ABAPGIT_OBJECT_ENHO_WDYC
ZCL_ABAPGIT_OBJECT_ENHO_WDYN
ZCL_ABAPGIT_OBJECT_ENHS_BADI_D
ZCL_ABAPGIT_OBJECT_ENHS_HOOK_D
ZIF_ABAPGIT_OBJECT_ENHO ENHO
ZIF_ABAPGIT_OBJECT_ENHS ENHS

$ABAPGIT_OBJECTS_TEST:

ZCL_ABAPGIT_OBJECTS_CI_TESTS
ZCL_ABAPGIT_PERFORMANCE_TEST
ZCL_ABAPGIT_TEST_SERIALIZE

* Interfaces for ENHx

* Git platform subpackage

* Git_platform, test packages

* Update package.devc.xml

* Update package.devc.xml

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-04 08:41:35 +01:00
Marc Bernard
a3c98afbef
PINF: Missing transport entry (#4275)
* PINF: Missing transport entry

- Added recording into transport for PINF 
- Added description for FTGL "Feature toggle"

* ftgl

* ftgl

* ftlg
2020-12-03 15:12:55 +01:00
Marc Bernard
5ca21a837d
CLIF: Improve error messages (#4271)
Pass T100 messages to UI/log

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-02 13:08:42 +01:00
Marc Bernard
7f61ebd645
UI: Clear progress bar (#4249)
* UI: Clear progress bar

Clears status/progress bar at end of process and removes leftover messages. 

Closes #3505

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-27 10:18:52 +01:00
Marc Bernard
ca0ff368c3
Remove obsolete late_deser from metadata (#4243)
* Remove obsolete late_deser from metadata

Final part to remove late_deser flag. Solution remains compatible with old bridge class which still uses the flag.

* Call

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-25 09:59:33 +01:00
Marc Bernard
e36486901d
Check objects when installing into main package (#4244)
* Check objects when installing into main package

Closes https://github.com/abapGit/abapGit/issues/2273

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-25 09:53:56 +01:00
Marc Bernard
bdcb725fc9
Replace cl_aunit_assert with cl_abap_unit_assert (#4239)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-24 17:28:43 +01:00
Lars Hvam
01d968c1f8
show log, remove title parameter (#4234)
* show log, remove title parameter

the log objec already have the title as part of the object, another input is not required

this aligns the code to always use the title from the object

closes #4223

* zif_abapgit_log, change title to csequence input
2020-11-24 15:41:26 +01:00
Lars Hvam
d3b68b8a48
remove broken dynamic call (#4221)
closes #4195

but lets keep #3453 open
2020-11-24 07:52:58 +01:00
Lars Hvam
381d40e35a
ZCL_ABAPGIT_HASH add shorthand methods (#4220)
This adds shorthand methods for the SHA1 calculation of the different git artifacts.
More logic in ZCL_ABAPGIT_HASH, but easier to read and less application logic.
2020-11-23 14:30:31 +01:00
Jaime Rodriguez Capote
9ef961cc8a
DDLS newline serialization in 750 and lower (#4143)
* DDLS: Empty line at serialization

Change included in 751+

* Newline serialization remove spaces

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-22 09:47:20 +01:00
Lars Hvam
4a30a3c079
VIEW file format updates (#4010) 2020-11-22 09:45:34 +01:00
Fabian Lupa
6c0df0f5bd
Support JUMP in SHI3 for GHIER (#4209) 2020-11-20 16:51:26 +01:00
Marc Bernard
46470da59d
Improvements for uninstall (#4198)
* Improvements for uninstall

- Improve error handling on deletion collecting errors in log
Closes #4197

- Remove limit of 3 loops which allows deleting objects with deeper dependencies
(Follow-up https://github.com/abapGit/abapGit/issues/3228#issuecomment-728800249)

* Exception

* Error msg

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-19 09:31:31 +01:00
Fabian Lupa
cac7cd42fb
Implement JUMP for SHI5 (#4202) 2020-11-18 18:27:53 +01:00
Marc Bernard
e93cbc5a1f
Move ty_deserialization, ty_step_data, ty_repo_ref_tt (#4181)
* Move ty_deserialization, ty_step_data

Remove dependencies from `zif_abapgit_definitions` (see https://github.com/abapGit/abapGit/issues/4179)

* Move to interface

* Move ty_repo_ref_tt
2020-11-16 08:34:29 +01:00
Lars Hvam
95e427b970
Move type ty_seocompotx_tt (#4168) 2020-11-12 14:29:42 +01:00
Marc Bernard
3d26041779
DEVC: Remove obsolete TADIR entries during uninstall (#4150)
* DEVC: Remove obsolete TADIR entries 

In case a package is local (ie no transports), abapGit will now check if objects still exist in the package. In case an object does not exist anymore, the corresponding TADIR entry will be removed. This allows empty local packages to be uninstalled automatically.

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-12 08:55:18 +01:00
Marc Bernard
cc6a207926
DDLS: Uninstall CDS views even if references exist (#4149)
Uninstall will now remove CDS views even if they are referenced in other views.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-12 08:48:48 +01:00
Marc Bernard
b25a67acea
Terminology: Inclusive Language - Part 2 (#4159)
* Terminology: Inclusive Language - Part 2

Change "Master Language" to "Main Language" in UI and comments (documentation and variables next)

* Docs

* Docs

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-11 10:36:38 +01:00
Marc Bernard
098682dcbb
PROG: Remove inactive sources during uninstall (#4141) 2020-11-07 09:24:34 +01:00
Lars Hvam
a53776ab5a
delete unused method in ZCL_ABAPGIT_OBJECT_CHDO (#4130)
* delete unused method

delete unused method GET_GENERIC in class zcl_abapgit_object_chdo

* enable rule unused_methods
2020-11-03 14:55:01 +01:00
Mike Pokraka
c1b2cf10a0
Update unit tests to use CI (#4106)
* Update unit tests to use CI

* Make test repo configurable

* Remove local tests and use CI

* Lint fixes

* Replace local tests with CI

* Add Type Group constants to abaplint

* Update constants and replace assert_true

* Revert constants

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-03 08:49:22 +01:00
Lars Hvam
c2492dd47e
delete unused methods (#4125)
* ZCL_ABAPGIT_REPO_FILTER

delete ZCL_ABAPGIT_REPO_FILTER->GET_PACKAGE
ZCL_ABAPGIT_REPO_FILTER delete MV_PACKAGE

* testclass, delete method given_fstate

* delete ZCL_ABAPGIT_GUI_PAGE_PATCH->IS_EVERY_CHANGE

delete method delete ZCL_ABAPGIT_GUI_PAGE_PATCH->IS_EVERY_CHANGED_LINE_PATCHED

* delete ZCL_ABAPGIT_OBJECTS_SUPER->CHECK_TIMESTAMP
2020-11-03 08:45:21 +01:00
Lars Hvam
df652f0436
delete various unused local variables (#4126) 2020-11-03 08:43:04 +01:00
Marc Bernard
f6cd2e12bd
Fix DDIC activation issues (#4111)
* Fix DDIC activation issues

- Avoid double activation of DDIC objects in case of "LATE" processing
- Derive DDIC id for XINX and MCID (same as for INDX)

Closes #4103

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:40:33 +01:00
Marc Bernard
e7b5281dde
Remove todo about unknown user id (#4113)
It's not feasible to use transports to determine who changed an object last (see https://github.com/abapGit/abapGit/pull/4056#issuecomment-719956576).

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:33:30 +01:00
Marc Bernard
20c1dc0bda
Remove obsolete late_deser from metadata (#4116)
The field `late_deser` in `ZIF_ABAPGIT_DEFINITIONS=>ty_metadata` is obsolete:

```abap
  TYPES:
    BEGIN OF ty_metadata,
      class        TYPE string,
      version      TYPE string,
      late_deser   TYPE abap_bool, " refactor: can be removed later. replaced by steps
      delete_tadir TYPE abap_bool,
      ddic         TYPE abap_bool,
    END OF ty_metadata .
```

The PR removes the remaining usage with one exception: `ZCL_ABAPGIT_OBJECTS_BRIDGE->GET_DESERIALIZE_STEPS` still depends on the field. In order to remove it completely, the plug-in interface `zif_abapgitp_plugin` (https://github.com/abapGit/abapGit-Plugins/blob/master/src/zif_abapgitp_plugin.intf.abap) will have to be changed.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:30:55 +01:00
Marc Bernard
dd37881589
702: Fix syntax error and missing check variant (#4117)
* 702: Downport 

No chaining with CHANGING

* 702: Downport

* Syntax check variant

* Too many fields warning

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:29:09 +01:00
Marc Bernard
bdc44f7476
Remove self-references (#4115)
* Remove self-references

Remove unnecessary self-references (me->)

https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#omit-the-self-reference-me-when-calling-an-instance-method

* 702: Fix syntax error

No chaining with EXPORTING & CHANGING

* remove addiontal me, update abaplint config

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:25:27 +01:00
Mike Pokraka
9cc515340a
Add option to specify own repo path (#4107)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-30 09:58:34 +01:00
Marc Bernard
92ba04d00e
TABL: Fix "exists" check (#4105)
Tables could exist in "new" (or other) version that is not included in nametab.
2020-10-30 09:53:54 +01:00
Philipp R
27aca4b382
Remove System Id from SOTR object type (#4104)
Co-authored-by: Rembold Rembold <philipp.rebold@sap.com>
2020-10-29 18:58:54 +01:00
Christian Günter
d14393dac5
TABL: Skip data check for GTTs (#4075)
* TABL: Skip data check for GTT

fixes #4074

* undo case change

* TABL: use fm DD_EXISTS_DATA for data check

* remove formatting change

* Data existence check only for DB tables

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-28 06:45:04 +01:00
Marc Bernard
caea4865bf
Integration of unit test with CI (#3993)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-27 08:15:52 +01:00
Frederik Hudák
d04b1b057c
DEVC - Clear obsolete fields (#4054)
* DEVC - Clear obsolete fields

* Remove on deserialize side
2020-10-22 19:04:41 +02:00
Lars Hvam
958c894d4b
issue #4032, downport (#4033) 2020-10-16 08:36:23 +02:00