This commit refactors the logic from zcl_abapgit_syntax_check to the new class zcl_abapgit_adhoc_code_insp. Which can be used to run arbitrary code inspections adhoc. zcl_abapgit_syntax_check delegates to zcl_abapgit_adhoc_code_insp.
Additionally the new class zcl_abapgit_abap_unit_tests is introduced to run ABAP unit tests for a particular package (hierarchy). It can be acessed via zcl_abapgit_factory%3D>get_abap_unit_tests.
This commit adds an indirection for function module GUI_IS_AVAILABLE
via interface ZIF_ABAPGIT_GUI_FUNCTIONS and factory ZCL_ABAPGIT_UI_FACTORY.
For tests the implementation can be replaced with
ZCL_ABAPGIT_UI_INJECTOR=>SET_GUI_FUNCTIONS
* mark inactive objects in repo list
Inactive object are marked in the repo list
The sort order for changed files is not changed
unchanged inactive files come right after the changed files
* move acitve check to object interface
* add is_active for objects up to F
* add is_active for objects up to P
* add is_active for objects up to T
* add is_active for objects up to X
all core object implement (except SSFO) the standard active check via FM RS_INACTIVE_OBJECTS_WARNING now
* add is_active to plugins bridge - always active
* finish object interface implementation + objects
* add is_active for offline with object interface
* rename returning to RV_
* use returning for serialize
* cleanup, PP, UT
* add code line attribute for leading spaces
Use attribute abapgit-leadig-spaces to store leading spaces of coding lines at serialization. This is used in deserialization to restoreformatting after XML normalization.
* add attribute also for global types and forms
* fix code formatting
Before this commit is applied the FIX_IDS methods was errorneous
and lead to subsequent dump. This commit fixes the algorithm to
replace IDs and IDREFs
* pretty print
* definitions to top of routine
* space before .
* omit parameter names where possible
* double space after if
* remove pseudo comments where possible
* clear PRESP and PWORK
clear username fields PRESP and PWORK
* remove unused FM exceptions
if sy-subrc is analysed (only <> 0) no detailed FM exceptions are needed, only OTHERS
* set PRESP and PWORK on deserialization
PRESP and PWORK is not set to SY-UNAME by default so set it explicitly
* Object Type UDMO Data Model #1905
Support for Object Type UDMO Data Model #1905
* Object Type UDMO Data Model #1905
* Object Type UDMO Data Model #1905
* Object Type UDMO Data Model #1905 Bad formatting correction
* Object Type UDMO Data Model #1905 Bad formatting
* Object Type UDMO Data Model #1905 Reformulation
* Update package.json
* pretty print
Before this commit is applied DDLX source code was recorded
in the xml file. We changed this so that now a separte .asddls
file is created. The change is downward compatible. Previously
recorded DDLX objects will show a diff the next time and the new
.asddls file has to be committed.
* add smart response checks for ref discovery
Added content-type check and content regex check for reference discovery
see https://github.com/schacon/igithub/blob/master/http-protocol.txt
* move ref check constants to TRANSPORT class
the check constants - content regex and responce Content-Type - don't have to be global right now so moved from zif_abapgit_definitionsto zcl_abapgit_git_transport
* PP and activate
* removed popup saving msag
* fixed capitalization
* refactored with variable prefixes
* refactored exceptions and split methods
also removed S messages.
Previous code was mostly copy %26 paste of the original
* Cleaned up
* more cleanup
* enable ADT jump from CI result
* enable ADT jump from CI result for all objects
* cleanup + PP
* cleanup + PP + save/activate in ADT
* remove commented code
git patch, added to staging page
serialize all longtexts
ENQU clear redundant fields
suppress SHMA package popup
branch overview sorted by parent instead of time
handle error from RS_CUA_INTERNAL_FETCH
fix problem with branch list from bitbucket.org
allow empty blobs
* Staging smaller chunks of code like git add -p
With this commit a new feature which works similar to git add -p
is added. We are now able to patch, which means that we can
commit on line basis. And are not restricted anymore to commit
only on file basis.
* move get_page_patch to stage page
* Refactor JS
* Refactor JS
* objects: use a different constant for 'R3TR'
The constant rs_c_pgmid_r3tr comes from the package RS which is not
available in pure BASIS systems.
The constant seok_pgmid_r3tr comes from the package SEOK and abapGit is
already using another constants from this package - seok_access_*.
Related to #1826
* objects: replace rs_c_true with abap_true
The constant rs_c_true comes from the package RS which is no available
in pure BASIS systems.
I believe that the constant rs_c_true was used by mistake.
The constant was assigned to a variable which is of the type abap_bool
and the variable is initialized with abap_false.
Related to #1826
With this commit the hotkey 'd' for diff always shows the
global diff. Previously only the last file diff was shown.
We changed the implementation so that the first matched href
specified by the hotkey is called.
This commit adds three new methods to ZCL_ABAPGIT_OBJECTS_SUPER:
- SERIALIZE_LONGTEXTS
- DESERIALIZE_LONGTEXTS
- DELETE_LONGTEXTS
They can be called on demand in concrete object type serializers.
In this commit they were called from DTEL, DOMA and TABL
* Insert initial line before bothsequence and action
* Change settings boolean read to support Java GUI
Standard netweaver and Java GUI netweaver parse differently the checkboxes on HTML pages. This commit consider the value on the checkbox aseither "on" or "X".
With this commit we are able to define global hotkeys. Which means
that the hotkey is active on all pages. The global hotkeys are
defined in ZCL_ABAPGIT_GUI_PAGE=>GET_HOTKEY_ACTIONS. The first
globally defined hotkey is the hotkey overview with the default
hotkey '?' assigned to it. This was previously hard coded in the js.
* Introduce customizable hotkeys
With this commit customizable hotkeys are introduced. They can
be defined in the user specific settings. Currently we support
only one letter keybindigs e.g. 's', 't' or 'x' and no modifiers.
Every page in the UI can decide which actions it offers for the
hotkeys. Therefore we introduce the interface ZIF_ABAPGIT_GUI_PAGE_HOTKEY
with the method GET_HOTKEY_ACTIONS. At this point in time only
the main page offers actions for hotkeys, but the mechanism works
already for all pages. New actions for hotkeys can be defined
easily.
Hotkeys are only available for installed abapGit repositories.
Because we need to detect the classes which implement the above
mentioned interface and it seems that there is no easy way to do
that for local classes. Maybe we can add it later when we know more.
We don't supply default key bindings. So it is totally up to the
user to define them.
* provide default hotkeys
Refactoring
Downport
Descriptions in new online popup
Optimized git object handling
SSST package popup fixed
PARA popup fixed
Package validations
Diff still shows after pushing
TABL field ROWORCOLST cleared
Staging page optimizations
Correct CUA if needed during pull
* correct xml errors of CUA interfaces
Issue error RS_CUA_INTERNAL_WRITE while pulling an old abapgit repository #1807. Same issue as #562 (error RS_CUA_INTERNAL_WRITE) which is solved by correcting manually the XML of the CUA interfaces (fastidious), or by regenerating the XML (but unfortunately sometimes the abapGit repository is from someone else).
Automatically fix this before RS_CUA_INTERNAL_WRITE is called. It's useless having this as a configuration option.
* refactor: extract code to a new method
* Better refactoring of auto correction CUA
When we try to add a new online repository and we have a repository
whose package does not exist in abapGit we get a short dump caused
by assert in the method zif_abapgit_sap_package~read_parent of
the class zcl_abapgit_sap_pacakge.
This commit makes sure we skip such repositories because we believe it
does not make sense to prevent us from cloning in these cases.
Thank you Petr Benes <petr.benes@sap.com>!
https://github.com/larshp/abapGit/issues/1575
Deletion of PARA caused a popup in FM RS_PARAMETER_DELETE.
To avoid that, the logic of the FM had to be implemented directly in the delete method.
* Optimized git object handling
- Introduced secondary indices for ZIF_ABAPGIT_DEFINITIONS=>TY_OBJECTS_TT to allow fast access to git objects by SHA1 and TYPE
- Added a new column INDEX to ZIF_ABAPGIT_DEFINITIONS=>TY_OBJECT to allow reconstruction of the correct sort order of git objects when after processing in ZCL_ABAPGIT_GIT_PACK
- Optimized git object accesses in ZCL_ABAPGIT_GIT_PACK, ZCL_ABAPGIT_GIT_PORCELAIN and ZCL_ABAPGIT_MERGE by using the newly introduced indices
* Removed excess fields
Removed excess fields from secondary index definitions of ´ty_objects_tt´, since they are not required.
TADIR performance #1756
All usages of TADIR aligned to use the same structure.
DELFLAG added in the structure.
2 identical structure definitions deleted.
todo: test this PR works after abapmerge has run
* change merge and staging
always push to the top of the currently selected branch
* remove branch and sha1 from stage object #365
* REPO not longer part of GIT_PORCELAIN
SET_OBJECTS moved to private
* and remove fields from constructor
Change methods INITIALIZE + RESET_STATUS to private in ZCL_ABAPGIT_REPO_ONLINE
One external call of INITIALIZE changed to use REFRESH instead
Part of refactoring for issue #1757
* LOG: extra ADD_* methods
Methods ADD_ERROR, ADD_INFO, and ADD_WARNING added to log class
* refactor background to use log object
refactor background to use log object instead of WRITE
- Stage button in diff screen removed
+ Vimium like link hint navigation, enable in settings
* ecatt downport
* Performance optimizations
* SSFO fix jump to text module
* Vimium like link hint navigation
After this commit is applied, the link hint navigation can be used.
The feature can be activated and configured in the user settings.
Role model is the link hint navigation in the Google Chrome plugin
Vimium.
* refactoring: introduce KeyNavigation prototype
* refactoring: introduce LinkHints prototype
* Optimized ZCL_ABAPGIT_TADIR=>BUILD for better performance
- Using the optimizations in ZCL_ABAPGIT_FOLDER_LOGIC (PR #1723) and ZCL_ABAPGIT_SAP_PACKAGE (PR #1724) to optimize the TADIR build method, by first determining all relevant subpackages and then processing them in one go instead of having to recurse and read information from the DB separately.
- Note that the optimization can also be used without the changes in #1723 and #1724, but the effect will be less or worse and the coding requires adaptations.
* Fixes coding artifact of #1723
Removed a coding artifact that makes use of importing parameter ÌO_FOLDER_LOGIC`, which is no longer needed in the flat BUILD processing.
* Adapted for rework in #1724
After adapting PR #1724 to no longer use buffering, but instead select packages with a level-based selection, the buffering parameter in `ZCL_ABAPGIT_SAP_PACKAGE=>LIST_SUBPACKAGES` no longer exists and should not be used in this PR.
* Compressed IF/ELSE construct
* Removed whitespaces
* Fixed auto-merge issue
Removed a double variable declaration resulting from git auto-merge
* Added Buffering to ZCL_ABAPGIT_SAP_PACKAGE
- Added a buffering option to ZCL_ABAPGIT_SAP_PACKAGE=>LIST_SUBPACKAGES, which gives a performance increase in repos with a deep tree structure, because all relevant packages are read from the DB only once and then the determination of subpackages is performed on an internal buffer table.
* Used buffered SAP package information determination in file status processing
* Level-based Subpackage Selection
- Replaced buffered package access with level-based subpackage selection
* Minor fix for select statements to avoid warnings
* Added Buffering to ZCL_ABAPGIT_FOLDER_LOGIC
- Converted ZCL_ABAPGIT_FOLDER_LOGIC=>PACKAGE_TO_PATH and ZCL_ABAPGIT_FOLDER_LOGIC=>PATH_TO_PACKAGE to instance methods, so they can work with buffered data when constructiing path information. This gives a performance advantage in repos with a depp tree structure and multiple leaf packages
- Adapted all calling code to use an instance of ZCL_ABAPGIT_FOLDER_LOGIC instead of the previously available static methods
- Where applicaple PACKAGE_TO_PATH and PATH_TO_PACKAGE were called in an instance of ZCL_ABAPGIT_FOLDER_LOGIC, which was instanced outside of a processing loop and thus profited from the introduced buffering
* Fixed errors
* Removed obsolete coding artifacts
Removed an obsolete parameter, that accidentally got merged into the code when building the pull request
* Forwarded FOLDER_LOGIC instance to recursed calls
Forwarded ZCL_ABAPGIT_FOLDER_LOGIC instance to subsequent BUILD calls to make use of buffering, until the optimizations in #1725 are in place.
Background mode must be reconfigured after installing this version
New interface ZIF_ABAPGIT_BACKGROUND for implementing custom handlers
Background mode will now push deletions
* pretty print, trigger reordering of methods
* skip PGP signature
* change PARSE_COMMITS to static
change PARSE_COMMITS to static and add unit tests class
* add simple unit test and fix CI findings
After this commit is applied all calls of "SET PARAMETER 'EUK'"
are replaced with the call of objects_super->set_default_package.
The method uses the ABAP memory which is in this case more reliable.
* CHAR: fix package popup during pull
* Remove superfluous ABAP memory clearance
memory is already cleared in RS_CORR_INSERT
* Introduce objects_super set_default_package
Refactor set default package logic to super class
zcl_abapgit_objects_super method set_default_package.
Before this commit it wasn't possible to run code inspection
for offline repos. A dump occured.
With this commit it is possible to run code inspections
for offline repos, too.
Before this commit is applied BRANCH_LIST is called twice while
refreshing an online repo. This leads to two identical HTTP calls.
After this commit is applied BRANCH_LIST is only called once and
therefore only one HTTP request is sent.
* Remove local SHA1 from online repository
In this commit we remove the local SHA1 and all its references from
ZCL_ABAPGIT_REPO_ONLINE. SHA1 is also removed from repo persistency.
SHA1 insn't needed anymore. All where-used places were either migrated to
remote_SHA1 or removed.
* reintroduce logic after push
If the short text of the function group has changed in the remote repo,
it's currently not possible to pull that change.
With this commit the short text is pulled properly.
The data in table ICFAPPLCUST (Application Customizing Data) isn't
deleted by cl_icf_tree=>if_icf_tree~delete_node( ). Before this commit
is applied it's not possible to delete ICF nodes with data in that table.
With this commit we delete the data in the table. It's the same as
transaction SICF does.
Before this commit VCLS jump calls VIEWCLUSTER_MAINTENANCE_CALL
which opens inplace. But that's not compatible with abapGit UI
and nothing is visible.
And the semantics changed. The above mentioned FM call the view
cluster for data maintenance and not the development object.
To be aligned with abapGit logic now the transaction SE54 is called.
Unfortunately, we are versioning AVAS objects that can be instantiated
only in SAP systems but we use the repo also in sandbox Customer
systems.
Whenever I open the repository I get an exception of the type
cx_pak_invalid_data.
Without this commit I see the error message:
"AVAS error".
With this commit I see the error message:
"AVAS $GUID: invalid data: The functionality is not supported in
customer systems"
* delete checks: set transport request if needed
this ensures that the transport request is set when deleting objects.
E.g. uninstalling the repositoy or reset local.
* separate type for delete checks
- new default behaviour is that the last seen repo isn't deserialized automatically. Instead the user has to choose a repo to work with
- old behaviour can be reactivated via user setting
- Changed: Since X_TO_BITBYTE only converts a single byte to a bitstring, it is faster to use direct addressing instead of a loop/concatenate pair, since concatenate on characters has to process the whole char array in each run.
Moved the progress percentage calculation into the execution block, because we don't need to calculate the percentage if we are not going to display it.
Fixed an issue with the progress indicator updates, where updates of the progress indicator would flush the message queue of SAP GUI and cause a GUI crash or hang.
The problem is described in SAP note #2084109 and seems to occur for large repositories (especially after installing SAP GUI 7.50 PL6)
- new local setting to set check variant
- new local setting to block pull if code inspector check fails
- check is executed before staging
- new page to display code inspector results
We are developing in an infinity system which is somehow cloned into a
new releases system. When we need to backport a bug fixes we do
cherry-pick the commits and pull them the release system. However, in
those systems we need to use the task type Repair.
Hence, we need to overwrite the default value of the parameter
wi_task_type of the function TRINT_ORDER_CHOICE which is 'S'
(Development/Correction) with the value 'R'.
I use the function TRINT_GET_REQUEST_TYPE and for the sake of simplicity
I assume that it is enough to know the transport type of the repository
package - in other words, it is no necessary to check every deserialized
object.
Related to #1446
For the parameters WI_ORDER_TYPE and WI_TASK_TYPE of the function
TRINT_ORDER_CHOICE called from the method popup_transport_request
of the class zcl_abapgit_popups.
Sometimes we need a repair task but the function TRINT_ORDER_CHOICE
searches for Development/Correction tasks.
I hope that we can decide what task type is needed by a package (DEVC).
Related to #1446
DDLS objects are not cheked in a transport in their deserialize method.
The parallel activation does not call RS_WORKING_OBJECTS_ACTIVATE which
checks in the activated object in a transport.
Therefor, DDLS objecst are never checked in a transport when
the parallel activation is in place (the option experimental features
is enabled - which is enabled by default on all our systems).
I wanted to use TRINT_OBJECTS_CHECK_AND_INSERT because this function
is used by ADT:
CL_WB_ADT_REST_RESOURCE~post
CL_WB_ADT_REST_RESOURCE_DATA
~if_wb_adt_rest_resource_data~get_transport_key
CL_WB_OBJECT~get_transport_key -> PGMID%3DR3TR, OBJTYPE%3DDDLS
CL_WB_ADT_REST_RESOURCE~lock
CL_WB_ADT_REST_RESOURCE~check_obj_in_transport_request
CL_ADT_CTS_MANAGEMENT~check_objects_in_request
CL_ADT_CTS_MANAGEMENT~LCL_DB_PERSISTENCE~check_objects
CALL FUNCTION CTS_WBO_API_CHECK_OBJECTS
CALL FUNCTION TRINT_WBO_IMPL_CHECK_OBJECTS
SAPLCTS_WBO_API_IMPL /
LCTS_WBO_API_IMPLF06 /
FORM CALL_OBJECTS_CHECK_AND_INSERT
CALL FUNCTION
TRINT_OBJECTS_CHECK_AND_INSERT
But it is not enough to call this function, hence, I use RS_CORR_INSERT
which was mentioned by @larshp in our slack conversation. The function
internally use calls TRINT_OBJECTS_CHECK_AND_INSERT.
I tested this patch with modification of a CDS view and also with
adding a new CDS view.
Closes#1466
The short description contains "(unused)".
For some strange reason, I saw that field set to D in one of our sandbox
systems.
Addresses the issue #1427.
Old code generate error of duplicity because SPRAS is case sensitive, but the name of files not.
New code use the 2-caracteres code for language.
Examples (T002):
SPRAS: 'C' -> LAISO: CS -> 'Czech'
SPRAS: 'c' -> LAISO: CA -> 'Catalan'
* Merging per Textfile
* Add files via upload
* Delete WolfTreak_ABAPGIT_Merging
* Refactoring vom Coding, Darstellung verbessert
* Merging page changed and also merging class extended to instance and conflict methods added
* Refactoring for Travis
* Refactoring for Travis
* Escaping of merged content functions now correct
