Commit Graph

44 Commits

Author SHA1 Message Date
Marc Bernard
c83ebbe82c
SSFO: Store smartform code as separate ABAP files (#7071)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2024-11-04 10:23:51 +01:00
francisco-milan
7bff32b718
Fix typos and adjust comments within source code. (#6778)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2024-01-28 09:21:14 +01:00
Marc Bernard
ef9f640fea
Downport: Fix 702 syntax errors (#6669) 2023-11-28 08:54:26 +01:00
Marc Bernard
98ea342593
SSFO: Fix order of T_CAPTION data (#6609)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-11-03 10:28:31 -04:00
Marc Bernard
caaa543b37
Refactor: Naming of class constants (#6529) 2023-10-04 09:20:07 -04:00
Lars Hvam
a8bce57373
move get_jumper() to new objects factory (#6363) 2023-07-23 15:07:06 +02:00
Marc Bernard
39d2e88be3
Enhance Serializer Interface - Follow-up (#6233) 2023-04-20 17:34:03 +02:00
Marc Bernard
5f1dc6d5e0
Enhance Serializer Interface (#6229) 2023-04-20 16:20:01 +02:00
Marc Bernard
25bbbf89cd
Refactor: Remove delete_tadir flag (#5949)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-01-06 15:56:12 +01:00
Marc Bernard
0ab3ee0a06
Remove aliases from object classes (#5588) 2022-06-04 10:33:42 +02:00
Marc Bernard
1af60a9f42
SSFO: Avoid side-effect in is_active (#5564) 2022-05-18 14:37:53 +02:00
Lars Hvam
f0b3c96474
Align pragma style (#5535) 2022-05-07 09:08:34 +02:00
Christian Günter
2ba6151355
JUMP: Switch execution order - first specific then generic (#5357)
* Switch jump order

* fix DDLS

* fix SHI3
2022-02-18 05:48:36 +01:00
Marc Bernard
074ae5a69b
Refactor: Calling batch input (#5252)
* Refactor: Calling batch input

Standardizes calling batch input API and handling errors.

* Fix indent

* Add new window

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-10 09:27:17 +01:00
Marc Bernard
73576ee60e
Improve error messages (#4472)
* Improve error messages

Pass T100 messages to UI/log

* T100 errors

* APACK

* OO

* DEVC

* DRUL

* DTDC

* SRVB

* OBJS

* Program

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-03 16:31:55 +01:00
Marc Bernard
bdc44f7476
Remove self-references (#4115)
* Remove self-references

Remove unnecessary self-references (me->)

https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#omit-the-self-reference-me-when-calling-an-instance-method

* 702: Fix syntax error

No chaining with EXPORTING & CHANGING

* remove addiontal me, update abaplint config

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:25:27 +01:00
Marc Bernard
9672f5b030
Adjust name prefix for types (#3991)
* Part 1

* Part 2

* Part 3

* Lint

* Part 5

* Part 6

* Part 7

* Part 8

* Part 9

* Enforce type naming prefix

All types need to start with TY_...

* Fix local types
2020-10-07 08:54:15 +02:00
Lars Hvam
9c41a2b7d8
remove text pragmas and pseudo comments (#3827)
* remove text pragmas and pseudo comments

* fix whitespace

* fix carriage return

* test

* test

* Update zcl_abapgit_repo.clas.abap
2020-09-03 09:13:47 +02:00
Lars Hvam
17b6411cdb
remove unused variables (#3721)
* remove unused

* remove fstate

* remove

* false

* AVAS, delete method insert_links

* fstate

* sotr

* WAPA

* ssfo

* ddls mock
2020-08-11 18:11:39 +02:00
Lars Hvam
eb7e819b25 refactoring, delete unused variables and methods (#3203)
* zlib

* xml

* processor

* shi5

* remove unused filter parameter

* pinf cleanup

* ssfo delete empty method

* highlighter

* gui page res, remove unused

* remove unused in diff class

* adt link

* gui, remove 2 unused parameters

* branch overview
2020-02-09 09:38:17 +01:00
Lars Hvam
3e0b0505b1
remove commented code (#3166)
* update abaplint.json

* remove commented code

* remove 2 unused variables
2020-01-24 14:31:04 +01:00
Lars Hvam
e201bf566f
remove class prefixes if its current class (#3137)
* remove class prefixes if its current class

* Update abaplint.json
2020-01-06 13:20:19 +01:00
Lars Hvam
b42f3bc485
Refactoring (#3134)
* fully type constants

* moving to single line

* move to single line

* enable keep_single_parameter_on_one_line
2019-12-28 12:11:32 +01:00
Martin Fuchs
9f2db446b1 simplified GET_DESERIALIZE_STEPS
Since all object handler contains exactly the same CASE statement for STEP definition, I would recommend that each object handler simply returns the STEP he belongs to.
This fix should "simply" issue #2499.
2019-05-05 00:57:52 -07:00
larshp
3084bb2c60 SSFO fixes for leading spaces #2640 2019-04-22 22:45:33 -07:00
GoWa
21527528c6 call redefined method of IF 2019-03-12 21:49:15 -07:00
larshp
25f6284493 implement GET_DESERIALIZE_STEPS
this is a quick fix, field LATE_DESER will be removed in future
2019-03-12 07:37:56 -07:00
Lars Hvam
3213d0c2dd
Deserialization performance, refactor COMPARE_TO_REMOTE_VERSION (#2438)
* core part refactored #2436

* indentation

* fix implementations

* delete ZCL_ABAPGIT_COMPARISON_NULL

* pretty print

* Update serializers.md

* downport
2019-02-20 22:20:24 -08:00
Lars Hvam
25d4c9ea07
Remove HAS_CHANGED_SINCE #1021 (#2401)
* core part removed

* remove method implementations
2019-02-15 06:51:57 -08:00
larshp
aae099b93d naming conventions 2018-11-11 17:45:12 +01:00
larshp
6415f9e249 update abaplint to latest 2018-11-08 06:26:32 +01:00
larshp
28ae85e270 naming conventions 2018-11-08 06:15:07 +01:00
Lars Hvam
89e5010fd0
Naming conventions fixes, #2053 (#2058)
* fix more naming conventions

* more naming conventions fixes
2018-11-07 12:05:27 +01:00
Domi Bigl
b8ed4589af SSFO: change workarea range_node_code type 2018-11-01 07:16:43 +01:00
larshp
d82b9daf0e SSFO: do not use STTY_SR_STRING_RANGE 2018-11-01 06:23:24 +01:00
Domi Bigl
cf05295170 mark inactive objects in repo list #1943 (#2017)
* mark inactive objects in repo list

Inactive object are marked in the repo list
The sort order for changed files is not changed
unchanged inactive files come right after the changed files

* move acitve check to object interface

* add is_active for objects up to F

* add is_active for objects up to P

* add is_active for objects up to T

* add is_active for objects up to X

all core object implement (except SSFO) the standard active check via FM RS_INACTIVE_OBJECTS_WARNING now

* add is_active to plugins bridge - always active

* finish object interface implementation + objects

* add is_active for offline with object interface

* rename returning to RV_

* use returning for serialize

* cleanup, PP, UT
2018-10-31 15:54:57 +01:00
Domi Bigl
1c396d9f19 add code line attribute for leading spaces #2011 (#2014)
* add code line attribute for leading spaces

Use attribute abapgit-leadig-spaces to store leading spaces of coding lines at serialization. This is used in deserialization to restoreformatting after XML normalization.

* add attribute also for global types and forms

* fix code formatting
2018-10-26 07:11:38 +02:00
Christian Guenter
cdf3be54c1 SSFO: fix method FX_IDS
Before this commit is applied the FIX_IDS methods was errorneous
and lead to subsequent dump. This commit fixes the algorithm to
replace IDs and IDREFs
2018-10-19 08:00:47 +02:00
Christian Guenter
fa61f45886 SSFO: fix jump to text module
After this commit is applied jump to smartforms
text modules works as expected.
2018-07-31 13:46:30 +02:00
Frederik Hudák
c4639f65ce Removed endmethod and endclass comments - objects folder 2018-07-28 10:10:16 +02:00
christianguenter2
002f5ba73d Implement IS_LOCKED for W3*, TTYP, TRAN, SSFO, SSST 2018-06-19 18:05:09 +02:00
christianguenter2
6521d09470 Block pull if any of deserialized object is locked 2018-06-18 14:18:58 +02:00
Christian Guenter
ce89e75eb9 SSFO deserialization: catch cx_ssf_fb 2018-06-13 19:39:35 +00:00
Lars Hvam
f14ac831ba
Objects to global (#1187)
* add global classes for objects

* fix metadata

* comment old code

fix serializer class
move missing interfaces

* keep objects and bridge as local

* fix syntax errors

and remove SICF -> tadir dependency, instead tadir -> SICF

* remove dependency TABL -> lcl_popups

* fix indentation

* remove old includes

* fix parser errors

* fix deserializing
2018-02-11 09:16:16 +01:00