Commit Graph

5185 Commits

Author SHA1 Message Date
sandraros
68e2cfa5c2
Fix data elem type ref to class in same repository (#5370)
* Fix data elem type ref to class in same repository

* simpler solution by testing refkind and reftype

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-02-21 17:20:39 +01:00
Marc Bernard
6a85f93312
Update CSS for password fields and buttons (#5364)
Minor addition to CSS

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-21 16:38:45 +01:00
Alexandr Razinkin
353f748bd6
Don't fail if a dictionary object is activated with warnings (#5362)
* Fix proposal for issue #5347: added support for 'TYPE REF TO DATA' DDIC data elements as components in DDIC structures

* Fix proposal for issue #5347. Added support for 'REF TO DATA' DTEL DDIC element residing in DDIC structure

* Fix proposal for issue #5347, added support for 'TYPE REF TO DATA' DDIC data element residing in DDIC data structurees

* REF TO DATA for DDIC element support (#5347)

* No error if ddic type has warning (abapGit#5361) during import

* Update zcl_abapgit_objects_activation.clas.abap

* Fix for (abapGit#5361). Warnings during DDIC objects activation shouldn't be considered as error but will be shown as 'yellow' messages after activation

* Fix for (#5361).
Warnings during DDIC objects activation shouldn't be considered as error but will be shown as 'yellow' messages after activation

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-20 11:39:09 +01:00
Alexander Tsybulsky
91cd4c3653
Separate zif_abapgit_repo (#5329)
* zif_repo basis

* all but zcl_abapgit_repo_srv

* fix zcl_abapgit_repo_srv

* remove create_new_log from interface

* "hack" -> "TODO"

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-19 09:22:46 +01:00
Lars Hvam
414a8fe1b2
refactor github actions (#5356)
* refactor github actions

* fixes

* split into build
2022-02-19 09:13:45 +01:00
Lars Hvam
4ac0183df2
unit testing updates (#5354) 2022-02-19 09:02:13 +01:00
Christian Günter
2ba6151355
JUMP: Switch execution order - first specific then generic (#5357)
* Switch jump order

* fix DDLS

* fix SHI3
2022-02-18 05:48:36 +01:00
Alexandr Razinkin
256007685e
DTEL: REF TO DATA for DDIC element support (#5350) 2022-02-15 07:39:27 +01:00
yellappam
1246e2718f
Sort includes (#5352)
In some systems, function modules RS_GET_ALL_INCLUDES returns an include *T00. Where *T00 include is not returned, abapGit adds to the internal table. This results in different sorting order in different systems. Sort to keep the same order.
2022-02-15 06:37:58 +01:00
Lars Hvam
c1dcebd8aa
unit test updates (#5351) 2022-02-14 09:08:37 +01:00
Marc Bernard
92b583bb18
Improve progress bar and log for pull (#5311)
- Eliminate flashing of progress bar during deserialize
- Updated description for deserialize steps
- Add steps to log (see below)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-14 08:25:27 +01:00
Lars Hvam
21ab83330f
update to latest npm packages (#5330)
* update to latest

* upd

* update

* upd

* update
2022-02-14 08:22:00 +01:00
Shyam Balachandran
371b1d4137
Fix for Service Binding issue #5212 (#5344)
Fix for SRVB (Service Binding) is lost in version 1.113.0 #5212

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-02-11 16:58:28 +01:00
g-back
cce8be5f1b
persist "show folder view" option (#5343)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-10 12:01:54 +01:00
Lars Hvam
09936744e9
SICF, clear ICFALIASNO (#5338) 2022-02-10 11:58:12 +01:00
Frederik Hudák
baa09083e6
Repo view - show paths below object name (#5323)
* Repo view - show paths below object name

* rework table rows

* fix syntax

* remove old comment
2022-02-09 08:48:12 +01:00
Albert Mink
9ddad8b559
CHKO et al.: Raise if deleting TADIR fails (#5337)
This behavior will be defined centrally in #5263. But for now, just raise if something with the TADIR fails.
2022-02-08 09:34:11 +01:00
Christian Günter
a4a13e56f7
Repo page: remove orphaned hotkey 'x' aG settings (#5334)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-02-07 12:10:52 -05:00
Albert Mink
8c2840e517
fix type for the dynamic calls (#5333)
fixes #5332
2022-02-07 12:05:56 -05:00
Albert Mink
d79a38eec2
Enable AFF to delete TADIR entries (#5326)
* Enable AFF to delete TADIR entries

* AbapLint policy I

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* AbapLine policy II

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* AbapLint policy III

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* AbapLint policy IV

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* AbapLint policy V

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* AbapLint XY

* don't call AFF for trivial tasks

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2022-02-07 10:12:44 +01:00
Lars Hvam
83534ecfeb
update to latest npm packages (#5324) 2022-02-03 16:25:49 +01:00
Marc Bernard
b5b252744d
Detect JSON files during pull (#5313) 2022-02-02 14:24:38 -05:00
Albert Mink
a18d7542e7
CHKO et al.: Do write TADIR entry (#5320) 2022-02-02 14:12:16 -05:00
Albert Mink
fee5c18761
Deserialize active when calling ABAP file formats (#5319) 2022-02-02 14:08:54 -05:00
Christian Günter
f178b2539f
zcl_abapgit_git_commit, update shorttext (#5316)
* update shorttext

* remove shorttext sync
2022-02-02 09:28:25 +01:00
Marc Bernard
631132736d
UI: Center Popups - Part (#5315)
Adjusting more popups #5275
2022-02-02 07:35:02 +01:00
Marc Bernard
65dd5f7568
Update object descriptions - Part 1 (#5314) 2022-02-02 07:31:54 +01:00
Marc Bernard
5086b7226d
Add refresh after pull errors (#5312)
* Add refresh after pull errors

Follow-up #5303

* Indent
2022-02-01 16:41:58 +01:00
Marc Bernard
ec9ff1a29f
TABL: Properly show inactive objects (#5303)
* TABL: Properly show inactive objects

Current `is_active` check is insufficient for DDIC objects and can't detect "new" or "partically active" objects.

Introduces a new `is_active_ddic` method in `zcl_abapgit_objects_super` which should be used by all DDIC types (follow-up). 

Ref #5294

* Update zcl_abapgit_objects.clas.abap

* Update
2022-02-01 16:11:18 +01:00
Marc Bernard
ce31e33688
Refactor: Activation log (#5302)
* Refactor: Activation log

- Merges the activation log into the regular pull log
- Removes duplicate messages

* Update

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-01 15:24:35 +01:00
Marc Bernard
a828d80044
DOMA: Fix serialize of translations (#5304)
Closes #5296

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-01 14:36:31 +01:00
DerGuteWolf
6da51326b1
WAPA: Fix repeated pull of BSP page (Fiori) (#5310)
* Fix for #5179 Do not mess with mo_files during deserialize

* style fix
2022-02-01 13:38:44 +01:00
Lars Hvam
84571615d3
update npm dependencies (#5309) 2022-02-01 09:10:09 +01:00
Lars Hvam
3f23668561
unit tests (#5293)
* unit tests

* upd

* update note

* update to latest

* update

* upd

* run to_abap

* run validate3

* skip validate3

* add note

* update notes

* update to latest
2022-01-31 18:40:10 +01:00
Fabian Lupa
42a642ccd0
Set window title for log viewer (#5300) 2022-01-30 14:19:13 -05:00
Marc Bernard
e3fc3e57d6
Branch is optional when creating online repo (#5299) 2022-01-30 14:11:49 -05:00
Marc Bernard
6efaa0e0b4
Refactor: Remove ddic flag (#5295)
Closes #5264

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-30 16:37:56 +01:00
Marc Bernard
927587880f
Remove UI dependency from test (#5298) 2022-01-30 16:34:20 +01:00
Marc Bernard
884a71e00e
Forms: Radio options and minor fixes (#5291)
- Allow for radio options to be arranged in column (instead of side-by-side)
- Render maxlength for text fields only when provided

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-26 19:54:09 +01:00
Marc Bernard
254e6d51e3
UI: Center Popups - Part 2 (#5290)
* UI: Center Popups - Part 2

Adjusting more popups #5275

* Refactor for method length

* Lint indent
2022-01-25 18:40:20 +01:00
Lars Hvam
eda6f27a9f
unit tests, update to latest (#5280) 2022-01-25 10:16:00 +01:00
Frank Müller
c932426b44
Pre Filter Backend and GUI Logic (#5227)
* Initial

* Adjustments

* Router

* Abaplint

* abaplint

* diff between eclipse and vscode

* Multiple Adjustments

* Split Backend And GUI Logic

* Multiple Adjustments

* No Unit Tests

* abaplint

* Rename ZCL_ABAPGIT_REPO_PRE_FILTER to ...TR

* Multiple Adjustments

* Refactor the OVP action links into a toolbar

* abaplint

* Replace BAPI_MSG by STRING

* Rename Pre Filter to Object Filter

* Rename Pre Filter also in abap_transpile.json

* restore from main

* Check if <ls_item>-li_class is filled in Toolbar

* Adj. toolbars and move TR Req to zif_abapgit_popup

* abaplint

* Move  ty_trrngtrkor_tt to zif_abapgit_definitions

* abaplint

* Move and rename filter menu entries

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: IBM <mbox-060-sap-extern-tbom@daimler.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-01-25 10:00:09 +01:00
Marc Bernard
d7cdb65243
Forms: Minimum text field length (#5287) 2022-01-24 17:10:40 +01:00
Marc Bernard
656e94c612
Change icon for user settings (#5282)
* Change icon for user settings

Reduce confusion because of same icon for different settings.

Closes https://github.com/abapGit/abapGit/issues/5088

* Icon

* Update toolbars

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-24 14:21:02 +01:00
Marc Bernard
fd167aa13b
Avoid double deserialize of text symbols (#5273)
* Avoid double deserialize of text symbols

Text symbols are already deserialized in `ZCL_ABAPGIT_OBJECTS_PROGRAM->DESERIALIZE_TEXTPOOL`.

* remove method

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-24 14:16:50 +01:00
Marc Bernard
cf9ede7d7c
UI: Center Popups (#5274)
* UI: Center Popups

GUI popups were showing up all over the screen. On bigger screens, they often display outside the abapGit HTML frame.

With this change, most popups will show nicely centered or close to it (some fine tuning might still be required).

Notes: 
- Some popups like the one prompting for a transport request do not allow to influence the screen position. 
- Follow-up: Consolidate "Tag Popups" from `ZCL_ABAPGIT_TAG_POPUPS` to `ZCL_ABAPGIT_POPUPS` and adjust accordingly.

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-23 08:50:11 +01:00
Marc Bernard
5e3e5b60e4
Fix status for new sub-packages (#5278) 2022-01-22 08:57:08 +01:00
Marc Bernard
3eee3fc797
Update "Ignore Files" (#5281)
Since https://github.com/abapGit/abapGit/pull/3996 it's not necessary to list files outside of /src/. The currently listed files are automatically ignored.
2022-01-21 18:30:28 +01:00
Alexander Tsybulsky
cb90be9ce7
Fix lost remote on favorite refresh (#5277)
* Fix reinstantiation on fav_refresh

* rename list_favorites to list_by_keys

* linter fix
2022-01-20 12:05:54 +01:00
Lars Hvam
0db2c9c085
unit testing updates (#5266) 2022-01-18 10:41:10 +01:00