Commit Graph

5304 Commits

Author SHA1 Message Date
Marc Bernard
7258fdc315
Repo view: Show icon for different source system (#5514)
In case an objects originates from a different system (`<> sy-sysid`), an icon will be shown after the object. On hover, you can see the id of the original system. 

Closes https://github.com/abapGit/abapGit/issues/3865
2022-05-21 08:13:41 +02:00
Marc Bernard
ba425e0318
Repo stats: don't count lines of ignored files (#5576)
Size and lines of code incorrectly included files that are ignored (outside of `/src/`).
2022-05-19 19:35:13 +02:00
Marc Bernard
3a27ff760f
Uninstall: Fix order for dependencies (#5559)
- Set order for uninstalling `WEBI`, `SPRX`, `IOBJ`, `ODSO`, and `PINF`
2022-05-19 11:03:58 +02:00
Marc Bernard
6a84341a27
PINF: Fix error when changing packages (#5560)
- Set parent package for package interface elements
- Raise error in case of mismatched packages
2022-05-19 10:47:15 +02:00
Marc Bernard
eaeba0f1cb
Fix syntax error in systems with BW (#5572)
abapGit should support systems without SAP_BW component. Therefore, references to BW data types have to be replaced by generic types and BW classes have to be replaced by dynamic calls.

Follow-up to #5556

Closes #5565
2022-05-18 22:10:38 +02:00
Marc Bernard
297708b054
Repo view: fix "order by transport" dump (#5571)
* Repo view: fix "order by transport"

Partly regression of #5323

Closes #5570

* Add flag

* Improve sort
2022-05-18 21:25:43 +02:00
Lars Hvam
9f048abeff
CHAR: take only serialize main language into accou (#5566)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-05-18 18:04:40 +02:00
Marc Bernard
6d2510c84e
Fix tag popup message (#5567)
Tag popup is used for delete and switch therefore the message must be moved to the switch method.
2022-05-18 17:54:15 +02:00
Marc Bernard
ee2c77e6af
Refactor: Email validation (#5568)
Move `is_valid_email` to utitlity class for reuse
2022-05-18 17:42:45 +02:00
Marc Bernard
38f99380da
FDT0: Add check of local/transportable apps (#5561)
It's not possible to import local apps into transportable packages or vice versa. The check raises corresponding error messages (and avoids a slew of cryptic errors you would get otherwise).

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-18 15:04:01 +02:00
Marc Bernard
1af60a9f42
SSFO: Avoid side-effect in is_active (#5564) 2022-05-18 14:37:53 +02:00
Christian Günter
722a954c43
Improve error message for language mismatch (#5544)
* Improve error message for language mismatch

* refactor

* refactor

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-17 13:31:25 +02:00
Marc Bernard
5802f0df37
CHDO: Fix deletion of TADIR entries (#5555)
Test mode needs to be set explicitly to false.
2022-05-16 08:26:18 +02:00
Marc Bernard
ff0fc72891
IOBJ/ODSO: Fix errors if objects exist already (#5551)
Implementation worked only for new objects (argh)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-11 12:38:20 +02:00
Marc Bernard
b0a31b0e3b
IAxx: Fix locking of objects (#5545)
Fixes missing locking and unlocking of `IARP`, `IASP`, and `IATU` (other `IAxx` objects are ok)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-11 09:45:56 +02:00
Marc Bernard
d4a69e160a
SHI3: Fix exists check (#5546)
Skip buffer and read object status from DB
2022-05-10 12:03:51 +02:00
Marc Bernard
db91c9bb08
ASFC,SPLO,SPPF: Fix missing transport entry (#5541)
In certain cases, the default transport set by abapGit does not work and there's no API to pass the transport for the object type. Therefore, we need to set the transport via ABAP memory (similar to setting the default package).

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-09 08:11:49 +02:00
Marc Bernard
5127bfdb9d
DDIC: Improve active/inactive check (#5486)
* DDIC: Improve active/inactive check

Use `is_active_ddic` (function `DDIF_STATE_GET`) for all DDIC object types. This is more accurate than the current method (function `RS_INACTIVE_OBJECTS_WARNING`) since it detects newly created but not active objects as well.

* Fix const

* Remove "no active version" error

* Update comment

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-09 08:08:32 +02:00
Marc Bernard
a96fed4b26
ENHC: Fix diffs due to OTR (#5538)
`cl_enh_composite` already handles OTR shorttext and there's no need to use `zcl_abapgit_sotr_handler`.

Update test case:
https://github.com/abapGit-tests/ENHC

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-07 10:04:14 +02:00
Marc Bernard
882a64cb68
UDMO: Fix wrong parameter value (#5540)
* UDMO: Fix wrong parameter value and exceptions

- `mode` is char 1
- fix exception overlap

* subrc

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-07 09:49:15 +02:00
Marc Bernard
13b12e6087
Improve error handling during activation phase (#5506)
When the "Activation Popup" is turned off in "Personal Settings", any errors during activation will lead to "Activation cancelled. Check the inactive objects" which is not very helpful.

The change will add the errors to the abapGit log. 

It will also handle the special case when activation of includes leads to error "Include is used in multiple main programs" (EU 404). In such case, you can turn on the activation popup and repeat the abapGit process successfully.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-07 09:29:19 +02:00
Lars Hvam
f0b3c96474
Align pragma style (#5535) 2022-05-07 09:08:34 +02:00
Marc Bernard
2af39232e6
AVAS,CHDO,DDLS,SPRX: Add objects to transport (#5542) 2022-05-06 12:39:47 +02:00
Marc Bernard
d993a081fa
AMSD: Fix "Step DDIC is only for DDIC objects" (#5539)
AMSD is not supported by mass activation. Assigns AMSD to "Step ABAP"
2022-05-06 12:10:36 +02:00
Lars Hvam
5a5630c198
update to latest npm packages (#5501)
* update to latest npm packages

* update

* update abaplint config to latest
2022-05-06 09:10:03 +02:00
Marc Bernard
73c9763a15
Fix "DB delete failed" (#5534) 2022-05-05 17:11:26 +02:00
Marc Bernard
1b4582bc03
Fix commit message encoding (#5508)
* Fix commit message encoding

- Properly encode % and & symbols
- Add unit test for special characters

Closes https://github.com/abapGit/abapGit/issues/2448

* Exclude testclass

* Comment

* update to 2.0.17

* update to 2.0.18

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-05 15:29:38 +02:00
Marc Bernard
f3028e21c2
Fix "DB delete failed" (#5517)
Closes #5515

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-05 15:26:05 +02:00
dependabot[bot]
01549fa5e5
Bump peter-evans/create-pull-request from 3 to 4 (#5528)
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 3 to 4.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](https://github.com/peter-evans/create-pull-request/compare/v3...v4)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-04 14:05:09 +02:00
Christian Günter
497b432199
OTGR: Downport (#5532)
* OTGR: Downport

* fix lint
2022-05-04 13:08:44 +02:00
dependabot[bot]
f5d8611380
Bump actions/setup-node from 2 to 3 (#5527)
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 2 to 3.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](https://github.com/actions/setup-node/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-04 10:10:34 +02:00
dependabot[bot]
c8de4579ed
Bump actions/checkout from 2 to 3 (#5526)
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-04 10:04:37 +02:00
Naveen
be3f3f0234
chore: Included githubactions in the dependabot config (#5523)
This should help with keeping the GitHub actions updated on new releases. This will also help with keeping it secure.

Dependabot helps in keeping the supply chain secure https://docs.github.com/en/code-security/dependabot

GitHub actions up to date https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot

https://github.com/ossf/scorecard/blob/main/docs/checks.md#dependency-update-tool
Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-04 10:01:39 +02:00
Marc Bernard
6524d2fcee
UENO: Clear/fill user, date, and time fields (#5520)
Apply clear/fill rules to user and time-specific fields

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-04 09:31:49 +02:00
Marc Bernard
d35e3548d8
OTGR: Fix errors with parent/child (#5518)
- Fix "error while instantiating CL_CLS_OBJECT_TYPE_GROUP"
- Remove children since they are created automatically
2022-05-04 09:26:48 +02:00
Marc Bernard
9ba5db8497
WDYN: Add documentation and fix diffs (#5490)
- Add documentation for Web Dynpro component and controllers
- Fix diffs of view components due to missing sort
- Updated https://github.com/abapGit-tests/WDYN

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-04 09:03:02 +02:00
Marc Bernard
e049144e87
SPRX: Add objects to transport (#5521)
- Add proxy to transport in deserialize
- Add objects to transport in delete

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-03 07:01:57 +02:00
Marc Bernard
5ac80b0316
G4BA,G4BS: Clear/fill user and timestamp fields (#5519) 2022-05-03 06:48:43 +02:00
Fabian Lupa
872339dfe8
Refactor remote settings (#5483)
* Add get_switched_origin to repo_online

* Add onclick action for radiobuttons

* Refactor remote settings to allow for direct input

without using value helps

* Adjust branch overview error message

Inform the user about the possibility of changing HEAD directly without using the value help (that failed to show up).

* Fix hidden form fields taking up vertical space

* Add min/max restriction to commit field

on remote settings page

* Implement basic validation for commit id

on remote settings page

* Load previous branch/tag when PR is selected

in remote settings page to be able to switch back to it more easily

* Use current form data in PR and tag selection

on remote settings page, where possible. Otherwise check the form values are the same as the repo instance values.

* Fix issue when changing URL and switching from PR

at the same time

* Remove repo dependency in PR enumerator

to be able to list PRs for the current url on the repo remote settings page

* Update zcl_abapgit_branch_overview.clas.abap

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-05-02 13:22:23 +02:00
Marc Bernard
588fb00cb0
Remove "branch overview" class/interface (#5503)
* Remove "branch overview" class/interface

* Remove unused

* Trigger checks

* Update src/zcl_abapgit_factory.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-01 12:32:59 +02:00
Marc Bernard
375092c370
DEVC: Clean-up OTR entries (#5507)
Uninstalling objects like `ENHC` just removes their references to OTR entries (`sotr_use/u` tables). Therefore, when the package is uninstalled, the remaining OTR entries will be completely removed.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-01 12:18:08 +02:00
dependabot[bot]
9a9719e526
Update @abaplint/cli requirement from ^2.89.13 to ^2.89.14 (#5513)
Updates the requirements on [@abaplint/cli](https://github.com/abaplint/abaplint) to permit the latest version.
- [Release notes](https://github.com/abaplint/abaplint/releases)
- [Commits](https://github.com/abaplint/abaplint/commits)

---
updated-dependencies:
- dependency-name: "@abaplint/cli"
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-01 10:19:35 +02:00
Lars Hvam
5426e32989
update npm packages to latest (#5512) 2022-05-01 10:09:37 +02:00
Marc Bernard
8888256eed
Fix ignore count in repo statistics (#5505) 2022-04-30 14:54:37 +02:00
Marc Bernard
78c4b37666
Fix status calculation (#5500)
Regression #5427

Closes https://github.com/abapGit/abapGit/issues/5499
2022-04-29 11:58:55 +02:00
Marc Bernard
183fff654a
Fix syntax error in BW jump (#5498)
* Fix syntax error in BW jump

* Lint
2022-04-29 11:12:03 +02:00
Marc Bernard
2bc6e2a8ff
SOTR: Refactor (#5441) 2022-04-29 08:51:17 +02:00
Marc Bernard
43b0d95335
IOBJ, ODSO: Add jump (#5495)
* IOBJ, ODSO: Add jump

Support navigation to BW objects

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-29 08:38:12 +02:00
Marc Bernard
3240baea18
1.115.0 (#5485)
* Update changelog.txt

* Update changelog.txt

* Update changelog.txt

* 1.115.0

* Update changelog.txt

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Update changelog.txt

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-28 15:36:54 +02:00
Lars Hvam
bbc92c4c0f
update to latest npm packages (#5492) 2022-04-28 12:56:26 +02:00