Commit Graph

2713 Commits

Author SHA1 Message Date
Lars Hvam
2ff25e27dd
pretty print ZCL_ABAPGIT_HTML_FORM and static (#3880)
pretty print class ZCL_ABAPGIT_HTML_FORM, and change two static methods to instance, this will make future possible changes to the class easier to see in the history
2020-09-12 06:50:31 +02:00
Marc Bernard
53bb303272
SHI3: Fix "IMG structure ID still used" (#3873)
Closes #3869

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-12 05:18:16 +02:00
Lars Hvam
f0208ae883
html, use interfaces (#3871)
* html, use interfaces

#3460

* fix syntax, remove alias

* last one 🎉
2020-09-12 05:16:21 +02:00
Marc Bernard
69fa5655c8
PROG: Add program class to deserialize (#3874)
Closes https://github.com/larshp/abapGit/issues/3870
2020-09-11 16:42:01 +02:00
Marc Bernard
7e4ae44fea
Enhance result view of Code Inspector/Syntax Check (#3861)
Follow-up to #3717: 
- Proper display of public, protected, and private sections
- Add CLAS prefix to be inline with other object types

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-11 11:23:33 +02:00
mariusraht2
4dce10e83c
popup_to_select_from_list can handle element-based tables (#3858)
* popup_to_select_from_list can handle element tabs

popup_to_select_from_list can now handle element-based non-structured tables like a table of url strings

Therefore related to #3639

* Update zcl_abapgit_popups.clas.abap

* Fixed wrong value assigning and added assert
2020-09-11 09:25:21 +02:00
Lars Hvam
42a532b9eb
reduce usage of ddic types (#3859)
* add SAP_BOOL as forbidden void type

* reduce

* Update abaplint.json

* sychar10

* sylangu

* Update abaplint.json
2020-09-10 15:30:25 +02:00
mariusraht2
a8df9c286f
upload_pack_by_branch: Replace deepen with deepen_level (#3835)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Update pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Delete pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Replaced deepen boolean with deepen_level

* Replaced numc2 by n length 2

* Removed restriction of deepen_level

* N alone is of length 1 and not numeric

Co-authored-by: mariusraht1 <mariusraht+1@gmail.com>
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-09 09:50:00 +02:00
mariusraht2
6f130d0edc
Client must send an empty packfile (#3856) 2020-09-09 08:39:05 +02:00
Fabian Lupa
dc5725b49c
Add performance test (#3847)
* Add performance test

* Fix some linter errors

* Refactor free selections to reduce method length

* Performance test add title to result ALV

* Attempt downport

* Downport

* Pretty Printer VS abaplint

* Undo more changes done by pretty printer

* Adjust performance popup title and ALV layout

* Move free sel dialog to global for abapmerge

* Move some type definitions for abapmerge

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-08 10:39:20 +02:00
Fabian Lupa
1df03232d8
Remove GitHub 2FA implementation (#3839)
* Remove GitHub 2FA implementation

as it relies on a soon to be deprecated authentication mechanism.

Fixes #3150

See https://developer.github.com/changes/2020-02-14-deprecating-password-auth/

* Deprecation warning for found 2FA implementations

* Fix linter issues

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-08 10:35:57 +02:00
g-back
3e4ce7bf73
Offline Repos: add ZIP Import/Export to actions (#3823)
* navigate to repo after ZIP import

* add zip import/export action for offline repos

* rename action labels

* change new state to be dependent on current page


change replacing -> new page if action called from repo list
rerender if in repo view

* add some TODOs, see PR discussion

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-08 10:32:17 +02:00
Lars Hvam
6739b768e9
html refactoring (#3843)
* html refactoring

change A() to instance method
remove ADD_CHECKBOX alias

* removes ICON alias

* more
2020-09-06 09:45:51 +02:00
mariusraht2
24cba9e221
Suppress popup on autostart after update (#3844)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-06 09:28:43 +02:00
Marc Bernard
b0d1d04ade
Automatically repair ZCX_ABAPGIT_EXCEPTION (#3840)
* Automatically repair ZCX_ABAPGIT_EXCEPTION

See #3833

* Add TODO

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-06 09:11:19 +02:00
Lars Hvam
1668a95b53
remove NO_HANDLER pseudo comments when handlers exist (#3846)
* remove NO_HANDLER pseudo comments when handlers exist

* Update zcl_abapgit_url.clas.testclasses.abap
2020-09-06 09:07:23 +02:00
Marc Bernard
c09cc67c83
Fix startup of repo view (#3831)
* Update error msg

* Fix login popup errors and cancelation

* Remove validate/reset methods

* Lint

* Rename iv_repo_online to io_repo_online

* Change to error in status bar

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-04 09:32:38 +02:00
Lars Hvam
428575fb58
1.99.1 (#3832)
* v1.99.1

* 1.99.1

* linter, enable rule line_break_style
2020-09-03 09:30:44 +02:00
Lars Hvam
9c41a2b7d8
remove text pragmas and pseudo comments (#3827)
* remove text pragmas and pseudo comments

* fix whitespace

* fix carriage return

* test

* test

* Update zcl_abapgit_repo.clas.abap
2020-09-03 09:13:47 +02:00
Marc Bernard
e70875879b
Restart abapGit in case of self-update (#3804)
* Restart abapGit in case of self-update

Closes #3358

* Fix abapgit url detection

Old logic incorrectly matched for example https://github.com/abapGit-tests/CHAR

* Github only

* Separate method

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-03 09:07:57 +02:00
Lars Hvam
44d4952d13
class parsing, show line number causing error (#3828)
In case there are errors while parsing the CLAS source code, the line number causing the error will now be shown in the error message
2020-09-03 09:04:28 +02:00
ed-holland
cb851f4ab1
Added Utility method and used it in ENHS (#3658)
* Update zcx_abapgit_exception.clas.abap

* Added Utility class and adjusted exception raises

* Fix Linter

Co-authored-by: Ed Wenmakers <ed.wenmakers@redwood.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-09-03 09:02:01 +02:00
Lars Hvam
98a261df1b
remove some unused variables (#3825) 2020-09-01 16:32:44 +02:00
Lars Hvam
a16f6f3d17
Cleanup, remove unused TYPEs (#3824) 2020-09-01 16:29:53 +02:00
mariusraht2
3a75ade563
Rename upload_pack to upload_pack_by_branch (#3818)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Update pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Delete pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Rename upload_pack to upload_pack_by_branch

* Renamed missed references

Co-authored-by: mariusraht1 <mariusraht+1@gmail.com>
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-01 16:23:30 +02:00
Lars Hvam
ca5f6f6d1f
filename encoding of < and > (#3820)
Windows cannot store filenames containing "<" and ">"

These two characters are now uri encoded, same approach as already deployed for some characters

#3817
2020-09-01 09:39:12 +02:00
Marc Bernard
ac26e5b7ab
OTGR: Enable parents (#3806)
* OTGR: Enable parents

* OTGR: Enable parents

* Replace cx_root

* Remove inactivate logic

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-01 09:34:53 +02:00
Lars Hvam
86657cc691
HTML refactoring (#3813)
* HTML refactoring

* removes the ADD_ICON alias

#3460

* remove IS_EMPTY alias

* more

* refactoring
2020-08-31 09:37:36 +02:00
Lars Hvam
c9dbee83b4
XML refactoring (#3814)
* XML refactoring

+ DTEL

* ENHO_CLIF + FUGR

* INTF
2020-08-31 09:35:10 +02:00
Lars Hvam
271e365f06
html, use interfaces (#3811)
* html, use interfaces

* more

* more

* more

* this removes the ADD_A alias
2020-08-29 08:00:56 +02:00
Lars Hvam
6f698c4c8b
fix syntax warning (#3812)
this fixes the following syntax warning raised in local class

"
The exception ZCX_ABAPGIT_EXCEPTION is not caught or declared in the RAISING clause of "HEADERS"
"
2020-08-29 07:57:26 +02:00
Jakub Filak
5468985b57
objects: remove superfluous RSTAT from some class XMLs (#3810)
The removed fields have no real use as no other CLAS object contains
that field.

It was added in the commit:
b0d54f97e3

Besides, it causes me troubles in sapcli when I do checkin.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-28 06:53:15 +02:00
Lars Hvam
8e51b8782f
v1.99.0 (#3807)
* 1.99.0

* v1.99.0
2020-08-27 08:15:28 +02:00
Lars Hvam
84c80a761c
refactoring, use interface for html (#3793)
* refactoring, use interface for html

replace uses of zcl_abapgit_html with zif_abapgit_html

#3460

* replace additional uses of the A alias

* This removes the A alias from the HTML class

This removes the following alias,
"a FOR zif_abapgit_html~a ."

* fix syntax error
2020-08-27 07:51:51 +02:00
Alexander Tsybulsky
a4e6c87985
Switching to PRs (#3695)
* string map: public entries (read only)

* port http agent

* draft wip

* drafting

* fix SSL

* port ajson

* integrate ajson and http_agent

* agent global headers

* github enumerator

* update ajson

* draft wip

* enumerator factory

* http_agent via factory

* proxy

* repo->switch_origin draft

* refactor enum factory

* Revert "refactor enum factory"

This reverts commit bcfef40b38991adfe5f73677919db6bd0c652f7c.

* page wiring draft

* scripts draft

* "let it work!"

* repo setings page draft

* linter

* linter

* linter

* linter

* linter

* better settings page

* finetune page

* cleanups

* change hotkey

* fix ajson_error

* Update src/zcl_abapgit_repo_online.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* abaplint nesting 6

* remove description

* back to good old popups

* linter

* move commands to branches dropdown

* auth helpers

* move json to separate package

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-27 07:47:27 +02:00
Lars Hvam
681f60a265
background pull: always overwrite all objects (#3802)
* background pull: always overwrite all objects

always choose to overwrite all objects when using the pull in background feature. If the decision is not set the job will fail with a "undecided" error

#3800

* fix page title typo
2020-08-27 07:38:18 +02:00
g-back
8fc08b9c22
Add success messages for repo removal/uninstall (#3797)
* add success messages for repo removal/uninstall

* remove single quotes, add packg name to remove msg

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-27 07:33:55 +02:00
Lars Hvam
bb6785812e
styling, fix background color on background settin (#3801) 2020-08-27 07:30:41 +02:00
Marc Bernard
f1f3673b09
Improve display when there are no changes in repo view (#3803)
* Improve display when there are no changes in repo view

* Update view and remove empty_package method

* Empty package msg

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-27 07:27:24 +02:00
Marc Bernard
5bddba99d4
CHAR: Fix OTGR dependency order and activation (#3805)
* CHAR: Fix OTGR dependency order and activation

* Update order and activation

Also fixes uninstall
2020-08-27 07:15:26 +02:00
Lars Hvam
f582225bf8
start refactoring to use XML interfaces (#3796)
* start refactoring to use XML interfaces

#3531

* TABL + TRAN + UDMO + UENO

start using the interfaces for xml instead of class references
2020-08-26 06:50:47 +02:00
Lars Hvam
978389a070
conversion, add singletons (#3792)
add singletons for string conversions in ZCL_ABAPGIT_CONVERT, in order to try improving performance

closes #3612
2020-08-25 07:36:57 +02:00
Lars Hvam
a9d22356a1
test (#3791) 2020-08-25 07:29:12 +02:00
Frederik Hudák
380857a896
Reposition repo filters (#3779)
* Reposition repo filters

* Remove show order by logic

* Fix diffs first being backwards

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-25 07:14:50 +02:00
Lars Hvam
dcc655eccf
syntax check page, show variant used (#3790)
* syntax check page, show variant used

closes #3660

* unify variant rendering
2020-08-25 07:05:32 +02:00
Lars Hvam
408485dfce
WDCC, fix syntax error in compiled report (#3794)
the PUBLIC keyword was placed in such a way it was not recognized by abapmerge, this should fix the compiled report
2020-08-24 13:51:06 +02:00
Lars Hvam
e88f522e83
OTGR: syntax error, disable parents temporarily (#3787)
* OTGR: syntax error, disable parents temporarily

* Update abaplint.json
2020-08-24 11:36:58 +02:00
Marc Bernard
af5b898a37
Refactor branch constants (#3784)
* Branch constants

* Refactor branch constants

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-24 11:25:46 +02:00
Jakub Filak
65e8522bd1
otgr: initial object support (#3777)
* otgr: initial object support

This commit replaces the generic SOBJ support with native support for
the object type OTGR and the format is not backward compatible,
so repos containing SOBJ serialized objects could not be pulled anymore
(it's necessary to pull them with previous version of abapGit and push
them with the new version of abapGit).

The new OTGR handler supports only master language description because
there is no API which would allow us to maintain other languages and
I am not willing to re-implement parts of ABAP platform just to version
texts which nobody cares about. Also, the texts dealing part is not
that straightforward - one has to think about keeping the texts
in sync which requires lot of code.

I did the following optimizations to the XML format:
- removed the activation state from all elements because we
  always serialize only Active and deserialize as Inactive
- removed the foreign key name from texts and other details
  because we know which object type group is currently being handled
- used short names for root elements of details to avoid redundancy
  because the detail's table name is used for child XML elements -
  e.g. TEXTS vs. CLS_TYPE_GROUPT.

Closes #1515

* Update ref-supported.md

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-24 11:23:36 +02:00
Marc Bernard
e4bafbe715
Validate if branch exists when displaying repo (#3749)
* Validate if branch exists when displaying repo

* Validate if branch exists when displaying repo

* Lint

* Lint and 702

* Lint

* Rename validate_branch to validate

* Fix msg and branch display name

* Move msg to UI layer

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-08-24 11:15:46 +02:00