Commit Graph

3484 Commits

Author SHA1 Message Date
Marc Bernard
1bed7ae318
Repo view: Set minimum width of status column (#5180)
* Repo view: Set minimum width of status column

As seen in https://github.com/abapGit/abapGit/issues/5178, if the repo view table is very wide, the status column might not wide enough and be wrapped. 

Change ensures a minimum width of the column.

* Reduce

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-12-08 11:57:25 -05:00
Marc Bernard
97821c8428
Add user exit for adjusting display of filenames (#5185)
The filenames can become very long, for example, usage of many sub-packages, namespaces, objects like function groups, or BSP/Fiori apps with many sub-objects, or a long paths as starting folder. This can make the repository view very busy or render the output as a very wide table (see #5169, #5178).

This exit allows to adjust the filename according to your own rules. 

Here's an example for shortening the display of files for sub-objects:

```abap
  METHOD zif_abapgit_exit~adjust_display_filename.

    DATA:
      lv_path TYPE string,
      lv_name TYPE string,
      lv_ext1 TYPE string,
      lv_ext2 TYPE string.

    SPLIT iv_filename AT '.' INTO lv_path lv_name lv_ext1 lv_ext2.

    IF lv_ext2 IS INITIAL.
      " Main object
      rv_filename = iv_filename.
    ELSE.
      " Sub object
      rv_filename = |…{ lv_ext1 }.{ lv_ext2 }|.
    ENDIF.

  ENDMETHOD.
```
2021-12-08 08:07:45 +01:00
Christian Günter
451ab7cadf
WebGUI: Disable jump (#5184)
Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
2021-12-06 16:13:24 -05:00
Christian Günter
ad5bad77cb
Webgui: fix path + file encoding issue (#5182)
Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
2021-12-06 15:34:30 -05:00
Marc Bernard
b5af548ed8
Fix "Remove" button for data tables (#5177)
The remove button was not working because it was defined as a second `main` button.
2021-12-03 22:02:46 -05:00
Christian Günter
94e6bdc20b
Patch: Fix link hints (#5176) 2021-12-03 09:10:04 -05:00
Marc Bernard
4910506b35
Fix vimium links (#5175)
* Fix vimium links

* Lint
2021-12-02 07:52:58 +01:00
Christian Günter
29f35b0d47
remove superfluous function name (#5174)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-12-01 09:30:18 -05:00
Marc Bernard
29a9201a3b
Commit page: option to hide author fields (#5171)
* Commit page: option to hide author fields

The vast majority of time the committer is the same as the author (I assume). This adds an option to hide the author name and email fields on the commit form.

* Update docs

* Update docs

Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-12-01 09:27:30 -05:00
Marc Bernard
3fa3323b2e
Refactor: Jump to Object Logic (#5158)
* Refactor: Jump to Object Logic

Continue #5114

- Removes jump_adt and jump_se11 from zcl_abapgit_objects_super
- Remove almost all object-specific jump handlers (zif_abapgit_object~jump) since they are covered by GUI Jumper now

* Remove ZCL_ABAPGIT_OBJECT_SICF

* Remove obsolete RS_TOOL_ACCESS

* FUGR

* IATU

* PDXX

* SRVD

* XINX

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-11-29 15:52:13 -05:00
Marc Bernard
9778ec5258
Diff/Patch: Adjust view menu (#5168)
"Ignore Indentation" was not accurate. Renamed it to "Ignore Whitespace".
2021-11-26 10:10:14 -05:00
Lars Hvam
d73825c222
1.113.0 (#5166)
* 1.113.0

* v1.113.0
2021-11-26 08:21:42 +01:00
Shyam Balachandran
9aa0dd154e
SRVB: Service Binding object changes (#4976)
* Fix issue 3443

Service Binding(SRVB) object changes

* Correcting abap lint findings

* Correcting abaplint findings 2

* Update zcl_abapgit_object_srvb.clas.abap

Changes to serialize and exists methods

* Update zcl_abapgit_object_srvb.clas.abap

Correct serialize and exists method

* Update zcl_abapgit_object_srvb.clas.abap

abapgit lint fixes

* Update zcl_abapgit_object_srvb.clas.abap

- Correcting exists method based on feedback
- Removing incorrect DDIC options for SRVB

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-11-26 08:06:50 +01:00
Christian Günter
13c4d57dd3
Patch: enable new view options similar to Diff (#5162)
* enable new view options on patch page

* add unit test

* new constant for unchanged lines
2021-11-26 07:41:57 +01:00
Marc Bernard
095c35f49b
Diff: Add options to ignore indent, comments, case (#5146)
* Diff: Add options to ignore indent, comments, case

Continuing on #2804

Enjoy!

* Skip new tests

* Trigger actions

* Trigger action

* Trigger action

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-25 07:33:48 +01:00
g-back
510441d486
Decouple last direct usage of CL_GUI_FRONTEND_SERVICES (#5145)
* Add new methods 


directory_create and directory_exis

* clean up whitespace

* normalize whitespace, formatting, comments

* decouple direct usage of cl_gui_frontend_services

* downport + concatenate to string template

* move param to single line

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-23 09:09:38 -05:00
Marc Bernard
928300a5c2
Repo View: Remove file path in folder view (#5159)
No need to show path when in folder view.

Before:

After:
2021-11-22 19:21:29 -05:00
Marc Bernard
4ecbc30a2e
Add DRUL and DTDC to mass activation (#5156)
* Add DRUL and DTDC to mass activation

DDIC mass activation supports Dependency Rules (DRUL) and Dynamic Cache (DTDC) object

* Len

* Update abap_transpile.json
2021-11-22 13:30:19 -05:00
Alexander Tsybulsky
a671bb8dc3
Expand TABL includes before PUT (#5153) 2021-11-22 12:57:38 -05:00
Lars Hvam
4301d3e8c8
no chained assignment (#5140)
* no chained assignment

* bugfix
2021-11-19 16:19:27 +01:00
Christian Günter
b6b0aef3b6
add links inside forms to command palette (#5144) 2021-11-18 15:32:19 -05:00
Christian Günter
2dc5626e70
add form actions to command palette (#5141)
* add form actions to command palette

* fix attribute

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-11-18 14:17:52 -05:00
Marc Bernard
543969e870
Fix icon hover in repo bar (#5143)
Closes #5142
2021-11-18 12:12:26 -05:00
Christian Günter
9d0e19feb9
add more toolbars to CommandPalette (#5136) 2021-11-17 07:52:47 +01:00
Frank Müller
6d02555f96
Check that include belongs to the same fugr (#5134)
* Check that include belongs to the same fugr

* abaplint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-15 16:50:44 +01:00
Marc Bernard
86262f4e54
Diff/Patch: Add "Filter by Object Type" (#5129)
* Diff/Patch: Add "Filter by Object Type"

Enhancement of filter options:

- Renamed "Type" to "Extension"
- Added "Object Type" 

Closes #3249

* Switch to INSERT

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-11-15 16:48:19 +01:00
Christian Günter
500d7eeb9f
hotkeys for form actions (#5133) 2021-11-14 14:55:38 +01:00
Christian Günter
e4b29954a4
Show implicit form hotkeys (#5132)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-14 07:45:44 +01:00
Marc Bernard
060abb8635
Make exceptions compatible with 702 (#5116)
* Make exceptions compatible with 702

702 does not deserialize exception classes correctly that have a constructor in a super class (see #1273). Adding an explicit constructor that calls the super-constructor, the issue is avoided.

* Pretty

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-14 07:28:38 +01:00
Marc Bernard
8f28a1aab3
Adjust syntax highlighter output (#5128)
* Adjust syntax highlighter output

Minor adjustment to output of syntax highlighter. There's no need to escape quotes, so `e_html_text` is sufficient.

PS: Change will make implementing "Highlight parts where a changed line is changed" a bit easier (#2804)

* Adjust tests

* Update abap_transpile.json

* Update test case

* Revert

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-12 06:55:02 +01:00
Marc Bernard
0d957aac17
Exclude package from AJSON mirror (#5125)
* Exclude package from AJSON mirror

Just copy `z*` objects which keeps `package.devc.xml`

* Update package.devc.xml

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-10 16:45:10 +01:00
g-back
289f22d79d
Add Feature: Create New Branch for Commit (#5123)
* add feature: create new branch for commit

* add clarifying comments

* add check for empty branch name

* remove check box, add condense to new branch name

* add duplicate check for branch name

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-11-10 09:19:47 -05:00
Marc Bernard
51aeea2bc5
Update descriptions of MIME objects (#5124) 2021-11-09 17:22:25 -05:00
Marc Bernard
53951dc2ad
Remove more unused variables (#5112)
* Remove more unused variables

* rm

* rm

* rm

* rm

* needed for refactor later

* rm

* Needed for callback

* rm

* rm

* Pragma

* rm enho

* rm

* rm

* Setting unused_variables

* Revert unused_variables setting

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-09 16:22:29 +01:00
Derby
0ee847e383
bug: When Imoprt ZIP does not display error log. (#5121)
In case of offline + Import ZIP, error log is not showed.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-09 16:14:49 +01:00
Christian Günter
4c919b2aa6
Hotkey overview: Show link hint activation key (#5122) 2021-11-09 08:34:09 -05:00
Christian Günter
02a06cae8f
LinkHints/Hotkey: Unify activation (#5108)
Use hotkey activation logic also for link hints. Previously it was possble to activate link hints on some input fields (e.g. search on stage page). This is now fixed.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-09 05:45:57 +01:00
Marc Bernard
285fbb21ff
SHI3: Set buffer mode (#5115)
Activates buffer mode for menus (same logic as in function BMENU_CREATE_TREE). 

Closes #5077

Co-authored-by: Alexander Tsybulsky <sbcgua@users.noreply.github.com>
2021-11-09 04:33:21 +01:00
Marc Bernard
ebf397b0f0
Fix regression for ADT Jump (#5120)
* Fix regression for ADT Jump

Regression from #5114 . Closes #5119
2021-11-07 14:53:53 -05:00
Marc Bernard
a37cf58e01
Refactor: Jump to Object Logic (#5114)
* Refactor: Jump to Object Logic

The goal is to greatly simplify the code to jump to an object, and to separate UI and object layers some more.

This PR introduces GUI Jumper (`zcl/if_abapgit_gui_jumper`), which covers all generic options to show an object. It tries the following options in order:
- ADT (if enabled)
- Workbench with line number
- Workbench without line number
- Transport System (new)

Only if all fail, abapGit will call the object-specific handler. 

Next steps:

- Remove `jump_adt` and `jump_se11` from `zcl_abapgit_objects_super` and replace by GUI Jumper
- Remove almost all object-specific jump handler since they are covered by GUI Jumper now

* Add class

* Lint

* Misleading name
2021-11-07 08:15:08 +01:00
Marc Bernard
9f689e4e4f
Title case for hotkey descriptions (#5113)
Closes #5089
2021-11-05 17:22:37 +01:00
Lars Hvam
2bee3c8253
remove unused variables (#5107)
* remove unused variables

* rm

* rm

* rm

* rm

* rm
2021-11-05 15:20:56 +01:00
Frank Müller
1ed9ca21e9
Performance Optimization with Namespace (#5097) 2021-11-05 05:35:36 +01:00
Christian Günter
53343a98d6
Files: Introduce secondary keys (#5101)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-05 05:32:39 +01:00
Christian Günter
57879a87ed
Patch: improve performance - new secondary keys (#5102)
* Patch: improve performance - new secondary keys

* cleanup

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-05 05:30:17 +01:00
Marc Bernard
3da00146b7
WEBI: Fix changed_by, is_active, exists (#5106)
* WEBI: Last changed by

* Update zcl_abapgit_object_webi.clas.abap
2021-11-05 05:27:59 +01:00
Christian Günter
663320cfee
Commit page: limit comment input length (#5100)
As comment length is limited, we should only allow inputs up to that limit.
2021-11-04 06:40:19 +01:00
Lars Hvam
59704957fd
1.112.0 (#5094)
* 1.112.0

* v1.112.0
2021-11-03 05:16:19 +01:00
Marc Bernard
0e6a46e076
SUSH: Fix check for lock (#5093)
* SUSH: Fix check for lock

* Error handling
2021-11-03 04:57:40 +01:00
Alexander Tsybulsky
412b61b9b9
strip FUGR generator comments (#5076)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-11-02 15:20:45 -04:00
Alexander Tsybulsky
d103d2fb2e
Remove obsolete screens on PROG deserialize (#5075)
* Remove obsolete screens on PROG deserialize

* remove commented code

* align RS_SCRP_DELETE params

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-02 14:58:02 -04:00
Marc Bernard
ffbd178318
UI: Sticky Top (#5061)
* UI: Sticky Top

With this change, the top bar will become sticky. Meaning, it remains on the top of the page when scrolling down.

It's CSS + JS since IE does not support the "sticky" CSS feature.

There's a bit of a "wiggle" when scrolling begins and alignment is not the best on the diff page (which has full width). Maybe some of you CSS wizards can figure these things out.

Closes #5035

* Upload with LF + UTF8

* Remove todo

- already includes changes of 5083

Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-02 16:57:33 +01:00
Lars Hvam
e45bdfc4e4
unit testing updates (#5080)
* wip, unit testing

* refactor popup

* update abaplint

* transpile additional classes

* all data classes

* all git

* update

* fix

* change type

* all gui

* all http

* ZCL_ABAPGIT_USER_RECORD

* all zlib

* all exceptions

* all xml

* all html

* all html zif

* all gui zif

* all xml zif

* all repo zif

* more generic

* star

* zif_abapgit_longtexts

* sort

* zcl_abapgit_news

* zcl_abapgit_adt_link

* ZCL_ABAPGIT_DIFF

* more

* add zcl_abapgit_services_git
2021-11-02 16:50:30 +01:00
Marc Bernard
9fa3579739
Commit Page: Repo Header and Summary (#5087)
* Commit Page: Repo Header and Summary

- Added repo header back
- Changed summary as suggested by @sbcgua
- Adjusted display of details accordingly

* Remove var

* Revert color on details

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-02 14:12:53 +01:00
Christian Günter
882ef7dc8d
New hotkeys for remote settings page (#5083)
* New hotkeys for remote settings page

* Enable hotkeys for non-input fields

* Prioritize link hint activation key over hotkey

* cleanup

* resolve 2

* resolve 3

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-11-02 14:09:23 +01:00
Alexander Tsybulsky
c0ad1a96d0
Better multi-lang class tpool handling (#5074)
* better multilang class tpool handling

* dont save lang list on empty clas docu

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-02 06:10:03 +01:00
Alexander Tsybulsky
aa6bd86e9b
.gitattributes (#5081)
* git attributes

* renormalize endings

* text auto

* add shell scripts
2021-11-02 06:08:13 +01:00
Derby
53ddddb8e3
bug in zcl_abapgit_file_status->check_namespace (#5069)
Fix regular expression

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-11-01 14:57:06 -04:00
Marc Bernard
a3e598ac1f
FUGR/PROG: Keep field text in case of masking (#5072)
* FUGR/PROG: Keep field text in case of masking

If masking is used with a dynpro field, then the text (mask) must not be cleared.

Closes #5071
2021-10-29 11:30:00 -04:00
Christian Günter
0dc66c6246
new algorithm for binary file detection (#5068)
* new algorithm for binary file detection

* only check first 1000 bytes

* cleanup

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-28 15:36:02 +02:00
Marc Bernard
01df821def
Repo view: Switch "Path" and "Changed by" columns (#5062)
Closes #5059

Before:

After:

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-28 15:34:06 +02:00
Christian Günter
64b7de74ee
Page patch: fix for binary files involved (#5067) 2021-10-28 09:04:19 +02:00
Christian Günter
fea99f89ab
Page patch: fix mixed-up tooltips (#5065) 2021-10-27 17:11:44 +02:00
Marc Bernard
679f2050b0
Diff and Patch Pages Update (#5056)
* Diff and Patch Pages Update

- Fix refresh of a single file on diff page (it was displaying all diffs afterwards)
- Add some hotkey assignments
- Replace "Refresh" after filename with icon

normal:

hover:

* Local refresh on patch page

* Update zcl_abapgit_gui_page_patch.clas.abap

* Patch page: Add js for refresh all hotkey

Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-10-27 07:28:17 +02:00
Marc Bernard
aa60faa299
Commit Page Update (#5048)
* Commit Page Update

Here's the redesigned commit page moving to the HTML forms you know form other dialogs (goes together with #5047 for best look).

New features:
- check of mandatory entries
- validation of email address format
- link to docs (t.b..d.)
- summary of changes on top, list of changed filed on bottom
- placeholder for body

Closes #5029

* rm > remove

* Create guide-stage-commit.md

* Add files via upload

* Update guide-stage-commit.md

* Delete commit_done.png

* Add files via upload

* Update guide-moving-package.md

* Add files via upload

* Add files via upload

* Update zcl_abapgit_gui_page_patch.clas.xml

* Update zcl_abapgit_gui_page_stage.clas.xml

* Update zcl_abapgit_gui_page_merge.clas.xml

* Update zcl_abapgit_gui_page_commit.clas.xml

* Update zcl_abapgit_gui_page_code_insp.clas.xml

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-25 16:12:06 +02:00
Marc Bernard
c15b58400a
Enhance diff class (#5044)
* Enhance diff class

- Refactor `zcl_abapgit_diff` to use `RS_CMP_COMPUTE_DELTA` instead of `SVRS_COMPUTE_DELTA_REPS` (needs less code in abapGit)
- Replace `abaptxt_255` with `rswsourcet` which removes 255 character per line limit. Now diffs on long lines are calculated properly.
- Add "ignore indent", "ignore comments", and "ignore case" options. These correspond to the options for the Split Screen Editor in SAP GUI and work the same way. The options are *not* exposed to the UI yet.

Same functionality, same performance.

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-25 16:06:27 +02:00
Marc Bernard
45806c5a95
Refactor serializer class (#4994)
* Refactor serializer class

- Consolidate i18n parameters
- Move determination of translation languages into serializer class
- Pass translation language setting when parallel processing (was a bug)

* Lint

* Add unit tests

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-25 16:01:40 +02:00
Marc Bernard
91f77324ea
CSS adjustments (#5047)
* CSS adjustments 

I made a few small CSS adjustments to make things a bit more consistent

- Repo overview: Adjust hightlight for current row 
- Repo: Add background color to table header to match staging
- Repo: Fix hightlight for current row 
- Staging: Slight color and table border adjustments
- Forms: Slight color adjustments for textarea placeholder
- DB Utility: Add hightlight for current row

* Update to dark theme

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-25 15:50:01 +02:00
Frederik Hudák
ea0c834992
Fix syntax check warnings (#5055)
* Fix syntax check warnings

* The classes can be final
2021-10-25 15:33:13 +02:00
g-back
1e5befc44a
Decouple cl_gui_frontend_services (#5046)
* add additional methods

* fix whitespace

* add parameter prefixes

* zip: refactor usage of frontend_services

* debug info: refactor usage of frontend_services

* services basis: refactor frontend_services usage

* objects_super: refactor usage of frontend_services

* router: refactor usage of frontend_services

* services_abapgit: refactor usage of frontend_serv

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-20 17:54:23 +02:00
github-actions[bot]
27eca9b766
ajson, Automatic Update (#5036)
* [create-pull-request] automated change

* upd

* fix

Co-authored-by: larshp <larshp@users.noreply.github.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-20 17:50:51 +02:00
Marc Bernard
e85e2f51d3
Measure backend render time (#5043)
This measures the time it takes in the backend to prepare the HTML page. Result is shown when hovering over abapGit logo in the page footer.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-19 06:38:56 +02:00
Marc Bernard
e8a6cb8a51
XSLT: Fix activation error (#5042)
Remove activation from `deserialize` and use `zcl_abapgit_objects_activation` instead.
2021-10-18 15:08:44 -04:00
Christian Günter
a8e7518348
enable command palette for Diff/Patch/Stage (#5040)
* enable command palette for Diff/Patch

* enable command palette for Stage

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-10-18 15:06:34 -04:00
Christian Günter
bf5634d243
Diff/Patch: Split view - enable line hover (#5039)
* patch page: enable line hover

* improve CSS + enable for unified

* add more CSS classes to table rows
2021-10-18 15:00:25 -04:00
Marc Bernard
7c977f4c4d
UI: Correct placeholder color for textarea (#5037) 2021-10-15 09:31:43 -04:00
Derby
9b582b039a
WDCA: Add support for appl. config content (#5030)
* object WDCA

object WDCA
+ wdy_config_appl-xcontent
+ wdy_config_appt

* Update zcl_abapgit_object_wdca.clas.abap

* Update src/objects/zcl_abapgit_object_wdca.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/objects/zcl_abapgit_object_wdca.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update zcl_abapgit_object_wdca.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-15 07:35:03 +02:00
g-back
4b5b654b49
Online Repo: URL to clipboard (#5034)
* import latest icon set

* Add export URL to clipboard for online repos

* omit parameter name

* adjust indent

* add url class

* Update src/ui/zcl_abapgit_gui_chunk_lib.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2021-10-15 07:30:41 +02:00
Christian Günter
0b71f14f93
'add objects to tr' - fix log display (#5032)
Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-14 16:57:35 +02:00
Christian Günter
e340131487
Log viewer - hide empty columns (#5033)
* Log viewer - hide empty columns

* reduce popup width

* adjust popup width

Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
2021-10-14 12:10:05 +02:00
Alexander Tsybulsky
65701dbcc8
pull on package reassign (#4999)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-13 06:12:19 +02:00
Alexander Tsybulsky
8a3aa38d82
fix SERVICES_REPO=>POPUP_DECISIONS (#4998)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-13 06:10:31 +02:00
Alexander Tsybulsky
253d6abec7
switch back from PR bugfix (#5028)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-11 07:47:31 +02:00
Christian Günter
4ce32ba7a6
Diff-page: enable refresh functions (#4992)
* Diff-page: Enable refresh functions

* cleanup

* Diff: add refresh local hotkey

* Rename 'Refresh' to 'Refresh All'

Co-authored-by: Alexander Tsybulsky <sbcgua@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2021-10-09 07:06:55 +02:00
Alexander Tsybulsky
372a2ab7ae
SCI result at stage and commit pages (#5002)
* sci result at stage and commit pages

* improvements

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-10-09 07:04:57 +02:00
Frederik Hudák
423cdd1009
Change abapgit font to 72 (#5026) 2021-10-07 10:10:40 +02:00
Marc Bernard
bdafff8581
Fix stage filter (#5023)
* Fix stage filter

* Update js

* Update js

* Lint

Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2021-10-06 14:15:02 -04:00
Frederik Hudák
4a5cf13eca
Don't lowercase transport request id (#5022)
* Don't lowercase transport request id

* fix error

* uppercase username and package too
2021-10-06 20:10:09 +02:00
Frederik Hudák
87e435dc5d
Main page - don't suppress titles for favorites (#5025) 2021-10-06 20:08:08 +02:00
Frederik Hudák
bd1ffd1f2e
Add pull and diff buttons to main page (#5021)
* Add more action buttons to main page

* Fix line length
2021-10-06 19:36:39 +02:00
Lars Hvam
93d14fcc81
repo content list: keep last changed_by in memory (#5019)
#5016
2021-10-06 15:36:51 +02:00
Frederik Hudák
00934cfdaf
Only show favorites on startup (#4997)
* Only load favorites on startup

* downport

* Escape sql

* Fix select, refactoring

* Fix parameter name

* Refactoring

* Update src/repo/zcl_abapgit_repo_srv.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/repo/zcl_abapgit_repo_srv.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/repo/zcl_abapgit_repo_srv.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* indent

* remove me

* Add type column to select

* lint

* Add info message at the bottom of the list

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-06 08:04:09 +02:00
Marc Bernard
51ce0b4df9
FUGR: Fix performance issue (#5017)
Optimize selection of function group includes.
2021-10-06 08:01:51 +02:00
Marc Bernard
1783f70bc0
Docs: Update links for settings help (#5014)
* Docs: Update links

After #5008

* Update zcl_abapgit_gui_page_sett_info.clas.abap

* Update zcl_abapgit_gui_page_sett_locl.clas.abap

* Update zcl_abapgit_gui_page_sett_remo.clas.abap

* Update zcl_abapgit_gui_page_sett_repo.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-05 18:44:01 +02:00
Frederik Hudák
3f4a92cfe3
Repo page - inform on bottom if only changes are shown (#5011) 2021-10-05 15:04:17 +02:00
Marc Bernard
2b8c21bdbc
SXCI: Inactive classic BAdIs (#5006)
* SXCI: Inactive classic BAdIs

Implements a workaround since SAP does not show inactive classic BAdIs properly (missing entry in table `dwinactive`).

* Update zcl_abapgit_object_sxci.clas.abap

* Update src/objects/zcl_abapgit_object_sxci.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Change by

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-05 06:12:45 +02:00
Marc Bernard
0379bc6d11
Change Package Assignment (#4980)
* Change Package Assignment

Previously, if an object was assigned to another package (but not changed otherwise), AG would delete and re-create the object. This was also visible in the "Selective Pull" popups:



The new process is smarter and detects such changes. It re-assigns the package (via a TADIR change) and avoids dropping and re-creating. The package overwrite popup is also avoided (it will still appear if the object itself was changed, too):

* Better icon

* Add unit test

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Alexander Tsybulsky <sbcgua@users.noreply.github.com>
2021-10-05 06:02:20 +02:00
Marc Bernard
3e14313f32
SMIM: Last Changed By (#5009)
If "last changed" user is not found on logical object, try selection on physical object
2021-10-05 05:57:46 +02:00
Marc Bernard
0d8b4dd7f5
WDCC: Fix syntax error on lower releases (#5005) 2021-10-04 12:10:43 -04:00
Marc Bernard
c276c719d8
XSLT: Add late activation (#5003)
* XSLT: Add late activation 

In case a transformation depends on other objects like a class, the transformation will not activate if it's deserialized before the dependent objects. 

This change adds the transformation to the late activation step.

* lint

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-04 16:59:05 +02:00
Alexander Tsybulsky
a223df0292
Don't show github note at password dialog on non-github repos (#5004)
* dont show github note on non-github repos

* better hiding
2021-10-03 16:43:31 -04:00
Marc Bernard
b41831868f
Fix dump during "New Online" (#4977)
* Fix dump during "New Online" 

I accidentally used a copied link `sapevent:url?url=https://github.com/abapGit-tests/TABL` into the "New Online" diaplog. AG would dump in this case.

Now you get a proper error message.

* Strip leading/trailing spaces for URLs

* Add

* Update

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: g-back <27279305+g-back@users.noreply.github.com>
2021-10-02 09:09:18 +02:00
Marc Bernard
84e6971bf8
Remove unused variable from settings (#4993) 2021-10-01 11:57:47 -04:00
Marc Bernard
ef8f830734
Refactor hotkey controller (#4990)
- Removed "class analysis logic" from hotkey collection
- Hotkeys are now registered directly in the hotkey controller (similar to asset manager)
- `zif_abapgit_hotkeys->get_hotkey_actions` was changed to instance method and can therefore be redefined in subclasses
- Renamed the controller class to match the interface name

Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-01 08:43:25 +02:00
Lars Hvam
b9f3a36b07
1.111.0 (#4991) 2021-10-01 08:33:20 +02:00
Marc Bernard
dc4b370521
Naming of class constants - Part 3 (#4984) 2021-10-01 08:20:15 +02:00
Jaime Rodriguez Capote
bdedad5592
Delete child number from SICF node (#4988)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-01 08:18:22 +02:00
Lutzi3
e6f029b097
WDCC:Support all Config Types (#4985) 2021-10-01 08:14:16 +02:00
yellappam
34b2fb3222
FUGR: Clear TEXT when referring to dictionary (#4973)
In dynpro screen, when a field is referring to a data element and text is taken from dictionary, no need to serialize the text as it is always taken from dictionary. If the text is included then it will show unnecessary diffs when data element text changes.

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-01 08:12:18 +02:00
Marc Bernard
cfb185b87c
Naming of class constants - Part 2 (#4983)
Ref #4945

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-01 08:04:36 +02:00
Marc Bernard
2db538ed97
Minor improvements for DB Utility (#4989)
- Display descriptions for PACKAGE, USER, ad SETTINGS keys
- Avoid text wrapping of description column
2021-09-30 14:08:02 -04:00
Marc Bernard
23172c4f92
Diff: Improve beacons (#4982)
* Diff: Improve beacons

Add a few modularization statements to beacon detection. Mostly relevant for longer programs with list events.

* More beacons
2021-09-29 08:02:41 +02:00
Marc Bernard
e0a9f1ccac
SRVD: Remove unused aliases (#4981)
* SRVD: Remove unused aliases

* Update
2021-09-27 16:12:19 -04:00
Lars Hvam
3f711a7fa5
1.110.0 (#4970) 2021-09-24 06:46:10 +02:00
Christian Günter
d51643f026
SUSH: Clear metadata (#4967)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-24 06:35:30 +02:00
Marc Bernard
9038b31921
ENHO: Split code into separate files (#4951)
* ENHO: Split code into separate files

Similarly to class enhancements where enhanced methods are stored as individual files, this change separates the code for implicit enhancements (type `HOOK_IMPL`) into abap-files.

This makes the code more readable (instead of being embedded and escaped into XML) and allows for linting.

* Switch to filenames with hash

* CI

* Filenames in XML

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-24 06:34:01 +02:00
yellappam
6761998a5d
TABL: CLEAR dd05m-leng (#4950)
* CLEAR dd05m-leng

In S/4HANA system some of the data element lengths changed. Example: MATNR length changed from 18 characters to 40 characters. It would show as diff when this repo is pulled into S/4HANA. dd05m-leng is for information only hence, cleared it to avoid diffs.

* Replace tab with space

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Replace tab with 6 spaces

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-24 06:32:31 +02:00
Frederik Hudák
35e3ce8640
DOMA - clear domname from fixed values (#4941)
* DOMA  - clear valpos, domname from fixed values

* undo clear of valpos

* retrigger ci

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-24 06:30:52 +02:00
Marc Bernard
3fdf50a2af
Fix help link in repo stats (#4969)
Closes #4957
2021-09-23 17:44:43 -04:00
Marc Bernard
3393aaaf94
CLAS: Replace APACK references (#4968)
Also replaces references to APACK types
2021-09-23 17:35:03 -04:00
Marc Bernard
81a70274be
Catch exception in exit form (#4966)
Closes #4965
2021-09-22 09:12:01 -04:00
github-actions[bot]
7e55a358cf
ajson, Automatic Update (#4961) 2021-09-18 15:30:47 +02:00
Lars Hvam
117aa2b474
CLAS serialization bugfix (#4960)
closes #4959
2021-09-18 06:50:33 +02:00
Marc Bernard
c63d92e6f1
Post-processing option for custom class serializer (#4953)
* Post-processing option for custom class serializer

When using the current exit for serializing classes, you have to code the complete serialization yourself (i.e. reading and formatting the code). 
https://docs.abapgit.org/ref-exits.html#custom_serialize_abap_clif

With this change, you get the option to let abapGit serialize the class first and then post-process the source in the exit. The change is compatible with existing implementations of the exit.

To use the post-processing option, add the following code to the beginning of the exit:

```abap
IF it_source IS INITIAL.
  RETURN.
ENDIF.
```

* Update ref-exits.md

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-18 06:23:06 +02:00
Marc Bernard
a72d3314cb
Remove exception from changed_by (#4952)
Simplify some code since `zcl_abapgit_objects=>changed_by` does not raise any exceptions.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-16 09:44:05 +02:00
Marc Bernard
6fcc223c31
Rename "Reset Local to "Selective Pull" (#4954)
Renames "Advanced" > "Reset Local (Forced Pull)" to "Selective Pull" and removes popup to simplify process.
2021-09-16 07:40:29 +02:00
Marc Bernard
b331de6bc7
Naming of class constants (#4945)
* Naming of class constants

This is in preparation of enforcing a naming convention for constants in classes/interfaces. At the end, the following lint rule shall be set:

```json
    "class_attribute_names": {
      "constants": "^C_.+$",
...
    },
```

After this, the only remaining constants not following this rule are in `zcl_abapgit_version`.

* Update zif_abapgit_dot_abapgit.intf.abap

* Update zcl_abapgit_gui_chunk_lib.clas.abap

* Update zcl_abapgit_gui_router.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-14 16:47:48 +02:00
Marc Bernard
68c4f10e02
SRFC: Improvements (#4912)
* SRFC: Improvements

- Check if `SRFC` is supported in `constructor`. This will ensure proper error handling (closes #4899). Note: Using the constructor is how it should be checked for other object types as well. 
- Added `changed_by` logic
- Simplified catch code

* SRFC: Improvements

* SRFC: Improvements

* Update message

* Raise

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-12 10:09:33 -04:00
Marc Bernard
a94d06d493
DDLS: Fix dump in lower releases (#4915)
* DDLS: Fix dump in lower releases

- Add requirements check to constructor
- Prevent delete call in case object does not exist

Ref #4899

* Update message

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-12 10:07:41 -04:00
Marc Bernard
61e629cd1f
Improvements for Objects Class (#4944)
* Improvements for Objects Class

This introduces a new `is_type_supported` method for `zcl_abapgit_objects` which is about 30x faster than the current `is_supported` method.

`is_type_supported` is used in the other methods like `changed_by` and `exists` to avoid instanciating or calling the object class unnecessarily. It won't be necessary to check for support before using these methods which will alllow simplifying the calling programs (separate PR).

There are also some new test cases for `is_type_supported` and for serializing a commom interface.

* No user id for unsupported objects

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-12 07:33:41 +02:00
github-actions[bot]
c2d96c0327
ajson, Automatic Update (#4947)
* [create-pull-request] automated change

* upd

Co-authored-by: larshp <larshp@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-12 07:31:03 +02:00
Marc Bernard
cd5d43977a
Filter code inspection/syntax check (#4946)
* Filter code inspection/syntax check

In case of generated maintenance screens, the code inspection/syntax check include findings in SAP code (`LSVIM*` includes). This change removes those findings.

* Update zcl_abapgit_code_inspector.clas.abap
2021-09-12 07:12:53 +02:00
Lars Hvam
ab701df97e
SPPF support (#4938)
* SPPF support

#4839

* update docs

* pretty print

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-09-10 11:01:02 -04:00
Lars Hvam
e7e8af832e
align package descripions (#4939)
prefix all package descriptions with "abapGit - "
2021-09-10 10:58:36 -04:00
Lars Hvam
3b67d90e76
5 additional unit tests running (#4935) 2021-09-10 07:46:05 +02:00
Marc Bernard
bbfc90420a
Dialogs: Clarify comment on password popup (#4932)
* Dialogs: Clarify comment on password popup

* Update zabapgit_password_dialog.prog.abap
2021-09-02 10:34:32 -04:00
Marc Bernard
08f90dd1f7
Fix "Cannot switch origin twice" in remote settings (#4921)
Closes #4919

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@gmail.com>
2021-08-31 07:31:12 +02:00
Lars Hvam
2bdb06519c
check exists() before changed_by() (#4925)
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-08-31 07:29:10 +02:00
Lars Hvam
54036c11dd
workaround changed_by (#4924)
* workaround changed_by

* ugh
2021-08-30 10:46:19 +02:00
github-actions[bot]
b028446d57
ajson, Automatic Update (#4922)
* [create-pull-request] automated change

* Update zcl_abapgit_ajson.clas.testclasses.abap

* Update zcl_abapgit_ajson.clas.testclasses.abap

* skip unit test parse_error

Co-authored-by: larshp <larshp@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-08-30 07:35:00 +02:00
Jacek W
5f6b5a73c8
Add "Last changed by" to repo page (#4920)
* Add "Last changed by" to repo page

Proposition for #3267

* Add "Last changed by" to repo page

For #3267
- add "Changed by" also for local items

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-08-30 07:26:02 +02:00
Marc Bernard
de8b3e4fb2
JavaGUI: Workaround for trailing null values (#4903)
SAP GUI for Java 7.70 has trailing null values in postdata (if data >256 characters). This is a bug that SAP will have to fix.

As a workaround, abapGit will strip the trailing null values.  The workaround shall be removed 2022-12-31 latest.

Closes #4832

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-08-29 13:05:05 +02:00
Jacek W
549fc9a2ef
Add icon link for changing remote repo on the list (#4907)
* Add icon link for changing remote repo on the list

Proposition for #4737

* Add icon link for changing remote repo on the list

- corrections for PR #4907
- fixed syntax

* Update zcl_abapgit_gui_page_repo_over.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-08-29 12:54:03 +02:00
Marc Bernard
e86e2267c0
Improve message if object type is not supported (#4913)
Minor text change
2021-08-27 14:53:20 -04:00
Marc Bernard
6b81d7d958
Improve message for subpackage errors (#4911)
Clarify error and resolution options in case subpackage already exists in system but is not included in pack hierarchy of repo root package.

Closes #4904
2021-08-27 12:58:12 -04:00
Marc Bernard
f2a801ad1a
Dialogs: Add comment to password popup (#4910)
Temporarily, adding a comment to the password popup regarding Github login. 

To be removed end of 2021

https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/

Closes #4909
2021-08-27 12:46:28 -04:00
Lars Hvam
40fa13278d
xml input: add basic unit test case (#4894) 2021-08-25 08:11:02 +02:00
Lars Hvam
7556bf6951
1.109.0 (#4896) 2021-08-16 08:32:43 +02:00
github-actions[bot]
41c9e0880b
ajson, Automatic Update (#4895) 2021-08-16 08:20:05 +02:00
Lars Hvam
329fd9dc0e
interface and factory for ZCL_ABAPGIT_PERSIST_SETTINGS (#4882)
the old get_instance() method in ZCL_ABAPGIT_PERSIST_SETTINGS has been moved to a method in zcl_abapgit_persist_factory, plus interface added. Added to persist injector
2021-08-03 15:13:16 +02:00