Commit Graph

5236 Commits

Author SHA1 Message Date
Marc Bernard
a96fed4b26
ENHC: Fix diffs due to OTR (#5538)
`cl_enh_composite` already handles OTR shorttext and there's no need to use `zcl_abapgit_sotr_handler`.

Update test case:
https://github.com/abapGit-tests/ENHC

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-07 10:04:14 +02:00
Marc Bernard
882a64cb68
UDMO: Fix wrong parameter value (#5540)
* UDMO: Fix wrong parameter value and exceptions

- `mode` is char 1
- fix exception overlap

* subrc

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-07 09:49:15 +02:00
Marc Bernard
13b12e6087
Improve error handling during activation phase (#5506)
When the "Activation Popup" is turned off in "Personal Settings", any errors during activation will lead to "Activation cancelled. Check the inactive objects" which is not very helpful.

The change will add the errors to the abapGit log. 

It will also handle the special case when activation of includes leads to error "Include is used in multiple main programs" (EU 404). In such case, you can turn on the activation popup and repeat the abapGit process successfully.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-07 09:29:19 +02:00
Lars Hvam
f0b3c96474
Align pragma style (#5535) 2022-05-07 09:08:34 +02:00
Marc Bernard
2af39232e6
AVAS,CHDO,DDLS,SPRX: Add objects to transport (#5542) 2022-05-06 12:39:47 +02:00
Marc Bernard
d993a081fa
AMSD: Fix "Step DDIC is only for DDIC objects" (#5539)
AMSD is not supported by mass activation. Assigns AMSD to "Step ABAP"
2022-05-06 12:10:36 +02:00
Lars Hvam
5a5630c198
update to latest npm packages (#5501)
* update to latest npm packages

* update

* update abaplint config to latest
2022-05-06 09:10:03 +02:00
Marc Bernard
73c9763a15
Fix "DB delete failed" (#5534) 2022-05-05 17:11:26 +02:00
Marc Bernard
1b4582bc03
Fix commit message encoding (#5508)
* Fix commit message encoding

- Properly encode % and & symbols
- Add unit test for special characters

Closes https://github.com/abapGit/abapGit/issues/2448

* Exclude testclass

* Comment

* update to 2.0.17

* update to 2.0.18

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-05 15:29:38 +02:00
Marc Bernard
f3028e21c2
Fix "DB delete failed" (#5517)
Closes #5515

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-05 15:26:05 +02:00
dependabot[bot]
01549fa5e5
Bump peter-evans/create-pull-request from 3 to 4 (#5528)
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 3 to 4.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](https://github.com/peter-evans/create-pull-request/compare/v3...v4)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-04 14:05:09 +02:00
Christian Günter
497b432199
OTGR: Downport (#5532)
* OTGR: Downport

* fix lint
2022-05-04 13:08:44 +02:00
dependabot[bot]
f5d8611380
Bump actions/setup-node from 2 to 3 (#5527)
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 2 to 3.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](https://github.com/actions/setup-node/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-04 10:10:34 +02:00
dependabot[bot]
c8de4579ed
Bump actions/checkout from 2 to 3 (#5526)
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-04 10:04:37 +02:00
Naveen
be3f3f0234
chore: Included githubactions in the dependabot config (#5523)
This should help with keeping the GitHub actions updated on new releases. This will also help with keeping it secure.

Dependabot helps in keeping the supply chain secure https://docs.github.com/en/code-security/dependabot

GitHub actions up to date https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot

https://github.com/ossf/scorecard/blob/main/docs/checks.md#dependency-update-tool
Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-04 10:01:39 +02:00
Marc Bernard
6524d2fcee
UENO: Clear/fill user, date, and time fields (#5520)
Apply clear/fill rules to user and time-specific fields

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-04 09:31:49 +02:00
Marc Bernard
d35e3548d8
OTGR: Fix errors with parent/child (#5518)
- Fix "error while instantiating CL_CLS_OBJECT_TYPE_GROUP"
- Remove children since they are created automatically
2022-05-04 09:26:48 +02:00
Marc Bernard
9ba5db8497
WDYN: Add documentation and fix diffs (#5490)
- Add documentation for Web Dynpro component and controllers
- Fix diffs of view components due to missing sort
- Updated https://github.com/abapGit-tests/WDYN

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-04 09:03:02 +02:00
Marc Bernard
e049144e87
SPRX: Add objects to transport (#5521)
- Add proxy to transport in deserialize
- Add objects to transport in delete

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-03 07:01:57 +02:00
Marc Bernard
5ac80b0316
G4BA,G4BS: Clear/fill user and timestamp fields (#5519) 2022-05-03 06:48:43 +02:00
Fabian Lupa
872339dfe8
Refactor remote settings (#5483)
* Add get_switched_origin to repo_online

* Add onclick action for radiobuttons

* Refactor remote settings to allow for direct input

without using value helps

* Adjust branch overview error message

Inform the user about the possibility of changing HEAD directly without using the value help (that failed to show up).

* Fix hidden form fields taking up vertical space

* Add min/max restriction to commit field

on remote settings page

* Implement basic validation for commit id

on remote settings page

* Load previous branch/tag when PR is selected

in remote settings page to be able to switch back to it more easily

* Use current form data in PR and tag selection

on remote settings page, where possible. Otherwise check the form values are the same as the repo instance values.

* Fix issue when changing URL and switching from PR

at the same time

* Remove repo dependency in PR enumerator

to be able to list PRs for the current url on the repo remote settings page

* Update zcl_abapgit_branch_overview.clas.abap

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-05-02 13:22:23 +02:00
Marc Bernard
588fb00cb0
Remove "branch overview" class/interface (#5503)
* Remove "branch overview" class/interface

* Remove unused

* Trigger checks

* Update src/zcl_abapgit_factory.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-01 12:32:59 +02:00
Marc Bernard
375092c370
DEVC: Clean-up OTR entries (#5507)
Uninstalling objects like `ENHC` just removes their references to OTR entries (`sotr_use/u` tables). Therefore, when the package is uninstalled, the remaining OTR entries will be completely removed.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-01 12:18:08 +02:00
dependabot[bot]
9a9719e526
Update @abaplint/cli requirement from ^2.89.13 to ^2.89.14 (#5513)
Updates the requirements on [@abaplint/cli](https://github.com/abaplint/abaplint) to permit the latest version.
- [Release notes](https://github.com/abaplint/abaplint/releases)
- [Commits](https://github.com/abaplint/abaplint/commits)

---
updated-dependencies:
- dependency-name: "@abaplint/cli"
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-01 10:19:35 +02:00
Lars Hvam
5426e32989
update npm packages to latest (#5512) 2022-05-01 10:09:37 +02:00
Marc Bernard
8888256eed
Fix ignore count in repo statistics (#5505) 2022-04-30 14:54:37 +02:00
Marc Bernard
78c4b37666
Fix status calculation (#5500)
Regression #5427

Closes https://github.com/abapGit/abapGit/issues/5499
2022-04-29 11:58:55 +02:00
Marc Bernard
183fff654a
Fix syntax error in BW jump (#5498)
* Fix syntax error in BW jump

* Lint
2022-04-29 11:12:03 +02:00
Marc Bernard
2bc6e2a8ff
SOTR: Refactor (#5441) 2022-04-29 08:51:17 +02:00
Marc Bernard
43b0d95335
IOBJ, ODSO: Add jump (#5495)
* IOBJ, ODSO: Add jump

Support navigation to BW objects

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-29 08:38:12 +02:00
Marc Bernard
3240baea18
1.115.0 (#5485)
* Update changelog.txt

* Update changelog.txt

* Update changelog.txt

* 1.115.0

* Update changelog.txt

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Update changelog.txt

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-28 15:36:54 +02:00
Lars Hvam
bbc92c4c0f
update to latest npm packages (#5492) 2022-04-28 12:56:26 +02:00
Marc Bernard
0306a11ddc
Add "Changed by" to several objects (#5493)
* Add "Changed by" to several objects

Complete todos: ENSC, TRAN, TYPE, VCLS, XINX

* Lint
2022-04-27 07:28:32 +02:00
Marc Bernard
252101ea8c
SPRX: Fix suppress_dialog error (#5491)
On old support package levels, `suppress_dialog` parameter does not exit
2022-04-26 17:24:28 +02:00
Marc Bernard
dd85924244
Properly ignore files during deserialize (#5427)
* Properly ignore files during deserialize

Closes #5426

This moves the ignore logic from `zcl_abapgit_files_status->prepare_remote` to an option of `zcl_abapgit_repo->get_files_remote`. Deserialize can then ignore the files already when getting them via `get_files_remote`.

PS: Required for https://github.com/exercism/abap/pull/82

* Update zcl_abapgit_repo.clas.abap

* Update zcl_abapgit_repo.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2022-04-26 16:52:19 +02:00
yellappam
e50a7dcc3c
Clear metadata fields (#5464)
* Add zcl_abapgit_rule and zif_abapgit_rule

* Insert clear and fill logic

* Pass rule to the generic serializer in IWSG class

* Remove extra space

* Remove inline declaration

* Format the code

* Replace CHECK with IF

* Rename class/interface

* Multiple changes

Rename method name
Change method signature
Remove clear field

* loop over all fields of given fields

* Align method call parameters

* Remove class reference for member

* Use string template to convert to type

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-04-26 16:33:21 +02:00
Alex
0ec0fd077b
Allow different user/password per repository in background mode (#5488)
* Allow different user/password per repository 

Clear auth buffer to allow different user/password per repository in background mode

* Uppercase for class name

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-04-26 16:11:40 +02:00
sandraros
b3c89a8ff2
Create empty classes/interfaces before DDIC (#5393)
* Force XSLT activation during deserialize

* Revert "Force XSLT activation during deserialize"

This reverts commit 7d6fc64ddb.

* Create empty class/interface before DDIC phase

Fix #5392

* pretty printer ZCL_ABAPGIT_OBJECT_INTF

* abaplint zcl_abapgit_object_clas

* Update zcl_abapgit_object_clas.clas.abap

* Update zcl_abapgit_object_dtel.clas.abap

* Update zcl_abapgit_object_intf.clas.abap

* Update zcl_abapgit_object_tabl.clas.abap

* Update zcl_abapgit_object_ttyp.clas.abap

* Update zcl_abapgit_objects.clas.abap

* Update zcl_abapgit_object_clas.clas.abap

* Update zcl_abapgit_object_intf.clas.abap

* Update zif_abapgit_object.intf.abap

* Update src/objects/zcl_abapgit_object_intf.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update order numbers

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-26 16:07:15 +02:00
BeckerWdf
9974246775
DTDCs no longer have an own data class (#5478)
Starting with ABAP Platform 2208 DTDC does no longer have an own workbench data class but instead uses CL_BLUE_SOURCE_OBJECT_DATA directly.

In addition:
The field that carries the ABAP language version changed from ABAP_LANGUAGE_VERSION to ABAP_LANGU_VERSION in ABAP Platform 2208. So to make it work in both releases < and >= ABAP Platform 2208 we have to try to clear both versions of that field.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-04-26 16:02:09 +02:00
Marc Bernard
df2c88223a
FUGR: Fix diff of includes (#5489)
Sort list of includes to avoid diff
2022-04-26 14:40:20 +02:00
Marc Bernard
79da4eb385
Refactor: Database Utility (#5487)
- Update and harmonize description of DB entries
- Fix description for repo checksums
- Increase width of display and edit areas
- Split long method
2022-04-26 07:54:00 +02:00
Marc Bernard
0fea49b74c
Remove "Tag Overview" popup (#5463)
* Remove "Tag Overview" popup

- The "Tag > Overview" feature has been removed (because of bad performance and low value)
- The tag select popup has been refactored. The code has been moved to `zcl/if_abapgit_popups`. Only change is that the popup is now centered like the others.
- Therefore, class `zcl_abapgit_tag_popups` has been removed

* Update injectors

* Remove interface

* Secondary key
2022-04-25 07:28:07 +02:00
Lars Hvam
97a0da735c
Actions: fix syntax? (#5481)
* Actions: fix syntax?

* fix
2022-04-22 07:50:32 +02:00
Alexander Tsybulsky
302178db78
cleaner action names (#5479) 2022-04-22 07:45:19 +02:00
Marc Bernard
3742f2b0d6
UI: Transport popup (#5453) 2022-04-22 07:37:15 +02:00
BeckerWdf
adfcedc7cb
DDLX: clear ABAP_LANGU_VERSION 2022-04-20 07:49:26 +02:00
BeckerWdf
497ad94180
DDLS: clear ABAP_LANGU_VERSION 2022-04-20 07:39:32 +02:00
github-actions[bot]
647617a6a2
ajson, Automatic Update (#5471) 2022-04-18 08:58:02 +02:00
Lars Hvam
836cedf4fd
update to latest npm packages (#5465) 2022-04-18 08:42:04 +02:00
Naveen
d6d1e9e8cb
Set permissions for GitHub actions (#5470)
- Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions

https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

[Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/)

 Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
2022-04-15 08:24:36 +02:00