Commit Graph

4232 Commits

Author SHA1 Message Date
Lars Hvam
3162b23c39
Move git url repo methods (#4147)
* Move git url repo methods

This moves methods GET_COMMIT_DISPLAY_URL and GET_DEFAULT_COMMIT_DISPLAY_URL from the repo class to new class in new package GIT_PLATFORM.

we want to keep the repo class small, as its quite complex and central

#4085

* fix line length
2020-11-10 06:34:16 +01:00
dependabot-preview[bot]
443850751a
Update eslint requirement from ^7.12.1 to ^7.13.0 (#4146)
Updates the requirements on [eslint](https://github.com/eslint/eslint) to permit the latest version.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v7.12.1...v7.13.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-09 09:26:18 +01:00
dependabot-preview[bot]
e1e87dc06e
Update @abaplint/cli requirement from ^2.59.0 to ^2.59.4 (#4145)
Updates the requirements on [@abaplint/cli](https://github.com/abaplint/abaplint) to permit the latest version.
- [Release notes](https://github.com/abaplint/abaplint/releases)
- [Commits](https://github.com/abaplint/abaplint/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-09 09:24:39 +01:00
Marc Bernard
5df956a37a
Toggle display of hidden characters on diff page (#4136)
* Toggle display of hidden characters on diff page

Time for something new...

I added a toggle switch to the diff page that allows you to show otherwise hidden characters.
- CR end-of-line 
- Spaces
- Tabs
- Byte-order-mark

Closes https://github.com/abapGit/abapGit/issues/2124
Closes https://github.com/abapGit/abapGit/issues/3676
Improves https://github.com/abapGit/abapGit/issues/2804

* Add ini

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-07 09:54:38 +01:00
Lars Hvam
85404ce72f
Refactor ZCL_ABAPGIT_PERSIST_BACKGROUND (#4123)
+ remove MT_JOBS
+ add GET_BY_KEY that can be used instead of LIST

closes #1455
2020-11-07 09:52:00 +01:00
Marc Bernard
098682dcbb
PROG: Remove inactive sources during uninstall (#4141) 2020-11-07 09:24:34 +01:00
Lars Hvam
e9e90a4ff1
Update other-articles-and-presentations.md (#4139) 2020-11-05 10:52:40 +01:00
Marc Bernard
5c1298697d
Trigger main command when pressing enter in form (#4102)
* Triggers main command when pressing enter in form

Adds hidden button that triggers main command when pressing the enter key

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-05 09:46:21 +01:00
Marc Bernard
b408cad115
Backup and restore for abapGit persistency (#4137)
* Backup and restore for abapGit persistency

Backup complete content of abapGit persistency to a ZIP file and restore when necessary.

* Messages

* 702

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-05 09:28:48 +01:00
Fabian Lupa
465c88fd0f
Adjust password field visible length (#4138) 2020-11-05 08:42:48 +01:00
Marc Bernard
87a3806ce1
UI: Unify rendering of transport, user names - part 2 (#4133)
- Added icon for user
- Changed icon for transport to truck
- Adapted "staging" page 
- Renamed CSS-classes because of conflict with classes used on staging page

Screenshots #4097
Closes #4098

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-04 14:51:34 +01:00
Fabian Lupa
71fe8683b7
Workaround for special chars in password dialog (#4135)
at the cost of limiting password length to 255 characters

Fixes #4055
2020-11-04 14:24:45 +01:00
Lars Hvam
01ec664981
Rename .github/workflows/FUNDING.yml to .github/FUNDING.yml (#4132) 2020-11-03 19:35:24 +01:00
Lars Hvam
0be6b72773
Create FUNDING.yml (#4131) 2020-11-03 19:32:24 +01:00
Lars Hvam
a53776ab5a
delete unused method in ZCL_ABAPGIT_OBJECT_CHDO (#4130)
* delete unused method

delete unused method GET_GENERIC in class zcl_abapgit_object_chdo

* enable rule unused_methods
2020-11-03 14:55:01 +01:00
Frederik Hudák
990441dbe0
Retrieve transport and changed by for deletions (#4056)
* Retrieve transport and changed by for deletions

* Refactor

* Remove breakpoint

* Update src/ui/zcl_abapgit_gui_page_stage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/ui/zcl_abapgit_gui_page_stage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/ui/zcl_abapgit_gui_page_stage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Abaplint

* ABAPLINT

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-03 08:52:49 +01:00
Mike Pokraka
c1b2cf10a0
Update unit tests to use CI (#4106)
* Update unit tests to use CI

* Make test repo configurable

* Remove local tests and use CI

* Lint fixes

* Replace local tests with CI

* Add Type Group constants to abaplint

* Update constants and replace assert_true

* Revert constants

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-03 08:49:22 +01:00
Lars Hvam
266ffb2a7c
/git/: remove unused param, add unit test (#4124)
UPLOAD_PACK_BY_BRANCH
- remove unused parameter EO_BRANCH_LIST

add unit test to ZCL_ABAPGIT_GIT_UTILS
2020-11-03 08:47:12 +01:00
Lars Hvam
c2492dd47e
delete unused methods (#4125)
* ZCL_ABAPGIT_REPO_FILTER

delete ZCL_ABAPGIT_REPO_FILTER->GET_PACKAGE
ZCL_ABAPGIT_REPO_FILTER delete MV_PACKAGE

* testclass, delete method given_fstate

* delete ZCL_ABAPGIT_GUI_PAGE_PATCH->IS_EVERY_CHANGE

delete method delete ZCL_ABAPGIT_GUI_PAGE_PATCH->IS_EVERY_CHANGED_LINE_PATCHED

* delete ZCL_ABAPGIT_OBJECTS_SUPER->CHECK_TIMESTAMP
2020-11-03 08:45:21 +01:00
Lars Hvam
df652f0436
delete various unused local variables (#4126) 2020-11-03 08:43:04 +01:00
Marc Bernard
6779e90448
UI: Sort "Switch origin" by PR number (#4127)
- Sort descending by PR number
- Rename menu items

Closes https://github.com/abapGit/abapGit/issues/4031

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-03 08:41:06 +01:00
Marc Bernard
e6acd28bda
Fix invalid HTML (#4128)
* Fix invalid HTML

- Fix HTML in case changelog contains `<, >, &` characters

* Invalid unquoted attribute value

* No tags after </body>
2020-11-03 08:38:02 +01:00
Lars Hvam
307177bcbf
1.101.0 (#4122)
* 1.101.0

* v1.101.0
2020-11-02 15:03:13 +01:00
Lars Hvam
bda8280ba0
abaplint: enable parser_702_chaining rule (#4121) 2020-11-02 14:51:47 +01:00
Marc Bernard
f6cd2e12bd
Fix DDIC activation issues (#4111)
* Fix DDIC activation issues

- Avoid double activation of DDIC objects in case of "LATE" processing
- Derive DDIC id for XINX and MCID (same as for INDX)

Closes #4103

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:40:33 +01:00
Marc Bernard
29aea372a5
UI: Adjustments to Repo Palette (#4079)
* UI: Adjustments to Repo Palette

- Sort alphabetically
- Pad offline icon (using CSS)

* CSS

* CSS

* Remove css changes

Css is fixed in #4112

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Alexander Tsybulsky <sbcgua@users.noreply.github.com>
2020-11-02 09:38:33 +01:00
Marc Bernard
e7b5281dde
Remove todo about unknown user id (#4113)
It's not feasible to use transports to determine who changed an object last (see https://github.com/abapGit/abapGit/pull/4056#issuecomment-719956576).

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:33:30 +01:00
Marc Bernard
20c1dc0bda
Remove obsolete late_deser from metadata (#4116)
The field `late_deser` in `ZIF_ABAPGIT_DEFINITIONS=>ty_metadata` is obsolete:

```abap
  TYPES:
    BEGIN OF ty_metadata,
      class        TYPE string,
      version      TYPE string,
      late_deser   TYPE abap_bool, " refactor: can be removed later. replaced by steps
      delete_tadir TYPE abap_bool,
      ddic         TYPE abap_bool,
    END OF ty_metadata .
```

The PR removes the remaining usage with one exception: `ZCL_ABAPGIT_OBJECTS_BRIDGE->GET_DESERIALIZE_STEPS` still depends on the field. In order to remove it completely, the plug-in interface `zif_abapgitp_plugin` (https://github.com/abapGit/abapGit-Plugins/blob/master/src/zif_abapgitp_plugin.intf.abap) will have to be changed.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:30:55 +01:00
Marc Bernard
dd37881589
702: Fix syntax error and missing check variant (#4117)
* 702: Downport 

No chaining with CHANGING

* 702: Downport

* Syntax check variant

* Too many fields warning

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:29:09 +01:00
Marc Bernard
bdc44f7476
Remove self-references (#4115)
* Remove self-references

Remove unnecessary self-references (me->)

https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#omit-the-self-reference-me-when-calling-an-instance-method

* 702: Fix syntax error

No chaining with EXPORTING & CHANGING

* remove addiontal me, update abaplint config

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:25:27 +01:00
Alexander Tsybulsky
614a8d60a3
new icons and css adjustments (#4112)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:16:59 +01:00
dependabot-preview[bot]
7386b5a190
Update eslint requirement from ^7.12.0 to ^7.12.1 (#4119)
Updates the requirements on [eslint](https://github.com/eslint/eslint) to permit the latest version.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v7.12.0...v7.12.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-02 09:08:26 +01:00
dependabot-preview[bot]
f1dd9cc8b8
Update @abaplint/cli requirement from ^2.58.12 to ^2.58.27 (#4118)
Updates the requirements on [@abaplint/cli](https://github.com/abaplint/abaplint) to permit the latest version.
- [Release notes](https://github.com/abaplint/abaplint/releases)
- [Commits](https://github.com/abaplint/abaplint/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-11-02 09:05:10 +01:00
mariusraht2
ec99d16ec0
Checkout commit: Add menu entry and finish implementation (#4101)
* Implementation

* Add menu entry for checkout commit

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-30 10:24:27 +01:00
Marc Bernard
666dfbda66
UI: Unify rendering of branch, package, transport, user names (#4097)
* UI: Unify rendering of branch, package, user names

Branch name was already rendered "boxed with a leading icon". The same is now done for package and user names.

See `zcl_abapgit_gui_chunk_lib->render_branch_name, render_package_name, render_user_name`.

Closes #4059

* Lint %26 transport

* Unknown user

* Transport css

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-30 10:13:09 +01:00
Marc Bernard
5d480d8e8d
Fix jump links on diff page (#4096)
Some files that existed locally didn't have a link. After #4084, the state can be evaluated properly to determine if local object exists.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-30 10:01:42 +01:00
Mike Pokraka
9cc515340a
Add option to specify own repo path (#4107)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-30 09:58:34 +01:00
Marc Bernard
92ba04d00e
TABL: Fix "exists" check (#4105)
Tables could exist in "new" (or other) version that is not included in nametab.
2020-10-30 09:53:54 +01:00
Philipp R
27aca4b382
Remove System Id from SOTR object type (#4104)
Co-authored-by: Rembold Rembold <philipp.rebold@sap.com>
2020-10-29 18:58:54 +01:00
mariusraht2
b75c6f8515
Add selected commit to repo persistence (#4095)
* Implementation

* Remove old source code

* Clear selected_commit on switch_repo_type

* Reset selected commit or branch on select

* Don't clear the branch name if commit selected
2020-10-29 06:48:41 +01:00
Lars Hvam
1c63b6b2d7
bugfix, the selected commit is not the current commit (#4091)
* bugfix, the selected commit is not the current com

* update
2020-10-28 13:54:33 +01:00
Frederik Hudák
888bbcb27e
Disable sorting for action column (#4087)
* Disable sorting for action column

* abaplint

* Revert renamed methods
2020-10-28 12:23:00 +01:00
mariusraht2
6b336c58f0
ZCL_ABAPGIT_REPO_ONLINE: Change methods fetch_remote and push to be able to retrieve and push objects also by commit hash (#4077)
* Implementation

* Add changes to push method

* Reset commit hash if branch is being switched

* abapLint: Remove whitespace

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2020-10-28 11:56:56 +01:00
mariusraht2
a4172c6acc
ZCL_ABAPGIT_SERVICES_GIT: Add new method checkout_commit to let the user check out commits (#4076)
* Implementation

* abapLint: Omit exporting

* Omit obsolete variables

* Add caller for checkout_commit

* Extend hash column for 1 character

* Add reset_remote to set_sha1

* Merge branch 'master' into add_checkout_commit

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-28 11:08:39 +01:00
mariusraht2
69b6c3c38a
Implementation (#4086) 2020-10-28 10:41:22 +01:00
Domi Bigl
15dcf41984
add user exit for commit display URL (#4073)
* add user exit for commit display URL

  METHODS adjust_display_commit_url
    IMPORTING iv_repo_url    TYPE zif_abapgit_persistence=>ty_repo-url
              iv_commit_hash TYPE zif_abapgit_definitions=>ty_sha1
    CHANGING  cv_display_url TYPE zif_abapgit_persistence=>ty_repo-url

* adjust UT

* provide also repo name and key in the exit

* Update ref-exits.md

* Update ref-exits.md

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-28 07:00:37 +01:00
Marc Bernard
ba0c1257c8
Fix state calculation for deleted objects (#4084)
* Fix state calculation for deleted objects

In case objects are deleted locally or remotely, abapGit now compares against the last known state (checksum). 

Closes https://github.com/abapGit/abapGit/issues/4030

* Added test case

Covers known local and remote states

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-28 06:57:27 +01:00
Marc Bernard
f699812b02
UI: Adjustments to Command Palette (#4080)
- Add prefix for utilities and help commands
- Remove leading spaces

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-28 06:46:53 +01:00
Christian Günter
d14393dac5
TABL: Skip data check for GTTs (#4075)
* TABL: Skip data check for GTT

fixes #4074

* undo case change

* TABL: use fm DD_EXISTS_DATA for data check

* remove formatting change

* Data existence check only for DB tables

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-28 06:45:04 +01:00
Marc Bernard
46f504a0e8
UI: Adjustments to Hotkeys (#4083)
- Add hotkey "f" for "new offline"
- Add hotkey "c" for "syntax check"
- Fix #3927
2020-10-28 06:42:40 +01:00