Commit Graph

2726 Commits

Author SHA1 Message Date
Christian Guenter
7b9578a11b implement missing interface methods 2018-06-14 18:25:00 +00:00
Lars Hvam
eec7a7d096
refactor file status unit tests (#1499)
* refactor file status unit tests

one method per check
tests in ltcl_file_status2 now successful

* more tests

add helper class
2018-06-14 08:13:37 +02:00
Lars Hvam
602bdf6d96
Merge pull request #1498 from christianguenter2/issue_1494
SSFO deserialization: catch cx_ssf_fb
2018-06-14 06:29:05 +02:00
Lars Hvam
b7fc27cfcf
Merge pull request #1497 from christianguenter2/issue_1493
Pass log object to user exit method change_tadir
2018-06-14 06:28:46 +02:00
Lars Hvam
b71b96fc9f
Merge pull request #1496 from larshp/repo_srv
interface for ZCL_ABAPGIT_REPO_SRV
2018-06-14 06:27:51 +02:00
Lars Hvam
655ef4c99b
Merge pull request #1495 from larshp/docs
docs: more about development
2018-06-14 06:27:25 +02:00
Lars Hvam
de23d5bf95
Merge pull request #1484 from larshp/issue_1390
first dependency injection, TADIR #1390
2018-06-14 06:27:04 +02:00
Christian Guenter
ce89e75eb9 SSFO deserialization: catch cx_ssf_fb 2018-06-13 19:39:35 +00:00
Christian Guenter
a38d9feaff Pass log object to user exit method change_tadir 2018-06-13 19:15:53 +00:00
Lars Hvam
a8fb4d47a4
docs, rephrase 2018-06-13 19:08:12 +02:00
larshp
45aa71f2da interface for ZCL_ABAPGIT_REPO_SRV 2018-06-13 17:28:56 +02:00
larshp
2d108246fb docs: move on development 2018-06-13 15:05:23 +00:00
Lars Hvam
b7c045210b
Merge pull request #1490 from filak-sap/issue_1446
Use the required transport type
2018-06-13 06:53:54 +02:00
Jakub Filak
fb6efabfb9 tp: use the correct transport type in the tr popup
We are developing in an infinity system which is somehow cloned into a
new releases system. When we need to backport a bug fixes we do
cherry-pick the commits and pull them the release system. However, in
those systems we need to use the task type Repair.

Hence, we need to overwrite the default value of the parameter
wi_task_type of the function TRINT_ORDER_CHOICE which is 'S'
(Development/Correction) with the value 'R'.

I use the function TRINT_GET_REQUEST_TYPE and for the sake of simplicity
I assume that it is enough to know the transport type of the repository
package - in other words, it is no necessary to check every deserialized
object.

Related to #1446
2018-06-12 13:33:49 +02:00
Jakub Filak
56c58b7a29 SAP Package: add the method get_transport_type
For the parameters WI_ORDER_TYPE and WI_TASK_TYPE of the function
TRINT_ORDER_CHOICE called from the method popup_transport_request
of the class zcl_abapgit_popups.

Sometimes we need a repair task but the function TRINT_ORDER_CHOICE
searches for Development/Correction tasks.

I hope that we can decide what task type is needed by a package (DEVC).

Related to #1446
2018-06-12 13:33:49 +02:00
Lars Hvam
f846f250a6
Merge pull request #1492 from christianguenter2/1355
disable "no changes" for offline projects
2018-06-12 08:42:20 +02:00
Christian Guenter
a62eae188a disable "no changes" for offline projects 2018-06-11 14:49:20 +00:00
Lars Hvam
ea66f8d70c
Merge pull request #1489 from larshp/issue_1488
DDLS: fix dump #1488
2018-06-11 16:19:46 +02:00
larshp
334ce44c0d DDLS: fix dump #1488 2018-06-11 12:03:59 +02:00
Lars Hvam
0634c60e5d
Merge pull request #1487 from christianguenter2/1486
Quick fix: duplicate type definition
2018-06-10 19:57:02 +02:00
Christian Guenter
3e3cd365a8 Quick fix: duplicate type definition 2018-06-10 17:51:21 +00:00
larshp
4e67e884de first dependency injection #1390
* extract public methods of ZCL_ABAPGIT_TADIR to new interface
* create factory ZCL_ABAPGIT_FACTORY
* refactor existing calls
2018-06-10 12:11:48 +00:00
Lars Hvam
fbadb3537b
Merge pull request #1481 from christianguenter2/tadir_userexit
New exit: change_tadir
2018-06-10 13:57:28 +02:00
larshp
4219c6d162 cl_aunit_assert is obsolete 2018-06-10 11:45:39 +00:00
Christian Guenter
c7179ed509 new exit: change_tadir 2018-06-10 10:59:00 +02:00
Lars Hvam
edba396450
Merge pull request #1480 from larshp/issue_1477
main package is also part of repo #1477
2018-06-10 08:26:01 +02:00
larshp
dcf423bc09 main package is also part of repo #1477 2018-06-10 06:24:13 +00:00
Lars Hvam
f18e2f74f9
docs: remove jquery #1479 2018-06-09 13:13:59 +02:00
Lars Hvam
c4993dedb6
v1.69.0 2018-06-09 11:56:22 +02:00
larshp
806fbe1a69 1.69.0 2018-06-09 09:54:20 +00:00
Lars Hvam
6af7b9730e
Merge pull request #1476 from christianguenter2/1355
fix gui: show changes only
2018-06-09 11:51:00 +02:00
Lars Hvam
745a10af71
Merge pull request #1474 from christianguenter2/1471
fix checkout annotated tags
2018-06-09 11:50:39 +02:00
Lars Hvam
bd1fefd41d
Merge pull request #1468 from filak-sap/issue_1446_check_ddls
Mass activation: re-check DDIC objs in transport
2018-06-09 11:50:25 +02:00
Lars Hvam
63318afa88
Merge pull request #1465 from christianguenter2/1464
set new remote: supply remote SHA1
2018-06-09 11:49:45 +02:00
Lars Hvam
3e61a0fdfa
Merge pull request #1430 from juancarlosrodriguezf/master
FORM: Error of duplicity because SPRAS is case sensitive
2018-06-09 11:49:19 +02:00
Christian Guenter
8ddeacade5 fix gui show changes only 2018-06-08 08:35:20 +02:00
Christian Guenter
6afa45c5ed fix checkout annotated tags 2018-06-07 21:05:11 +02:00
Lars Hvam
9f5eebf404
Merge pull request #1472 from christianguenter2/1440
Deactivate pull after switching branches and tags
2018-06-07 20:38:45 +02:00
Lars Hvam
78f8854b33
Merge pull request #1473 from christianguenter2/1470
COMMIT WORK AND WAIT after switching tags
2018-06-07 20:37:47 +02:00
Christian Guenter
8074aa3272 COMMIT WORK AND WAIT after switching tags 2018-06-07 17:30:43 +00:00
Christian Guenter
c32306f54c deactivate pull after switching branches 2018-06-07 17:01:14 +00:00
Jakub Filak
17b808c8a5 Mass activation: re-check DDIC objs in transport
DDLS objects are not cheked in a transport in their deserialize method.
The parallel activation does not call RS_WORKING_OBJECTS_ACTIVATE which
checks in the activated object in a transport.
Therefor, DDLS objecst are never checked in a transport when
the parallel activation is in place (the option experimental features
is enabled - which is enabled by default on all our systems).

I wanted to use TRINT_OBJECTS_CHECK_AND_INSERT because this function
is used by ADT:

CL_WB_ADT_REST_RESOURCE~post
    CL_WB_ADT_REST_RESOURCE_DATA
    ~if_wb_adt_rest_resource_data~get_transport_key
        CL_WB_OBJECT~get_transport_key -> PGMID%3DR3TR, OBJTYPE%3DDDLS
    CL_WB_ADT_REST_RESOURCE~lock
        CL_WB_ADT_REST_RESOURCE~check_obj_in_transport_request
            CL_ADT_CTS_MANAGEMENT~check_objects_in_request
                CL_ADT_CTS_MANAGEMENT~LCL_DB_PERSISTENCE~check_objects
                    CALL FUNCTION CTS_WBO_API_CHECK_OBJECTS
                        CALL FUNCTION TRINT_WBO_IMPL_CHECK_OBJECTS
                            SAPLCTS_WBO_API_IMPL /
                            LCTS_WBO_API_IMPLF06 /
      FORM CALL_OBJECTS_CHECK_AND_INSERT
                                CALL FUNCTION
                                TRINT_OBJECTS_CHECK_AND_INSERT


But it is not enough to call this function, hence, I use RS_CORR_INSERT
which was mentioned by @larshp in our slack conversation. The function
internally use calls TRINT_OBJECTS_CHECK_AND_INSERT.

I tested this patch with modification of a CDS view and also with 
adding a new CDS view.

Closes #1466
2018-06-07 16:10:23 +02:00
juancarlosrodriguezf
857947b03d
Use the 2-character code for language. Downwards compatibility.
Check first the new 2-character file name, if fail, use the old name.
2018-06-07 12:02:24 +02:00
Lars Hvam
6ca5ab4459
docs: supported, mention customizing 2018-06-07 11:04:53 +02:00
Christian Guenter
41d09125d4 set new remote: supply remote SHA1 2018-06-07 11:01:56 +02:00
Lars Hvam
38eef6717a
docs: information about docs 2018-06-07 10:57:40 +02:00
Lars Hvam
e738322783
docs, SCP1 2018-06-06 17:11:04 +02:00
Lars Hvam
d6f77810f5
v1.68.3 2018-06-06 16:55:12 +02:00
larshp
61fb07bffc 1.68.3 2018-06-06 14:44:22 +00:00
Lars Hvam
2f2712d146
Merge pull request #1463 from christianguenter2/1088_01
redesign create tag page
2018-06-06 16:40:00 +02:00