Commit Graph

22 Commits

Author SHA1 Message Date
Marc Bernard
30371b9a8f
Check if package name is allowed (#5416)
* Check if package name is allowed

When validating SAP packages, it now checks the naming conventions.

* Move method

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-03-31 14:57:48 +02:00
Lars Hvam
4301d3e8c8
no chained assignment (#5140)
* no chained assignment

* bugfix
2021-11-19 16:19:27 +01:00
Marc Bernard
40efc567f6
Automatic creation of top repository package (#4431)
* Automatic creation of top repository package

When adding a repository, it is not necessary anymore that the top SAP package assigned to the repository exists. Just enter a package name and clone (works for offline, too). 

The initial diff will now show that the top package exists remotely only. Therefore, when pulling, you will not get the "confirm overwrite package" popup anymore. Yippie!

* Typo

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-23 10:11:54 +01:00
Marc Bernard
6dac984acc
Improve error message for getting request type (#4421)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-18 09:31:12 +01:00
Lars Hvam
f9d064829a
remove more ALIASes (#3986)
most of these are not in use, but was also public
2020-10-07 09:05:28 +02:00
Marc Bernard
c9da76b3ee
Fix error from CL_PACKAGE_FACTORY=>LOAD_PACKAGE (#3958)
* Fix error from CL_PACKAGE_FACTORY=>LOAD_PACKAGE

* Variable

* Change to T100 messages

* super->constructor( )

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-29 17:29:02 +02:00
Christian Günter
caf7c92eaf
SAP Package: Replace ASSERT with RAISE (#3421)
* Package read_parent: RAISE instead of ASSERT

* remove pseudo comment

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-26 06:09:17 +02:00
Jaime Rodriguez Capote
543114963f
abapOpenCheck - Naming Conventions revision #3239 (#3240)
* abapOpenChecks config file

* Ignore SCI config folder

* checks revision

* Revert "checks revision"

This reverts commit 56a12289df.

* Renaming non-constants

Pending:

* Remove SCI configuration

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-09 17:34:26 +01:00
Frederik Hudák
1bb195b344 Removed the rest of endmethod/endclass comments 2018-10-18 07:27:27 +02:00
Michael Käsemann
aa90f278b7 Added Buffering to ZCL_ABAPGIT_SAP_PACKAGE (#1724)
* Added Buffering to ZCL_ABAPGIT_SAP_PACKAGE

- Added a buffering option to ZCL_ABAPGIT_SAP_PACKAGE=>LIST_SUBPACKAGES, which gives a performance increase in repos with a deep tree structure, because all relevant packages are read from the DB only once and then the determination of subpackages is performed on an internal buffer table.

* Used buffered SAP package information determination in file status processing

* Level-based Subpackage Selection

- Replaced buffered package access with level-based subpackage selection

* Minor fix for select statements to avoid warnings
2018-07-31 17:31:18 +02:00
larshp
06d06e23fe list_subpackages: order by primary key
list_subpackages: order by primary key, to fix HANA warning
2018-07-27 13:17:29 +02:00
mkaesemann
e132c17205 Fixed spelling error 2018-07-25 06:44:07 +02:00
Michael Käsemann
a80ae3c4f5 Fixed naming and missing data element definition 2018-07-25 06:44:07 +02:00
Michael Käsemann
9f50c2d59e ZIF_ABAPGIT_SAP_PACKAGE~LIST_SUBPACKAGES in ZCL_ABAPGIT_SAP_PACKAGE returned duplicate entries for subpackages with more than 1 hierarchy level, because the recursion selected all subpackages of a given package and added them to the list and then parsed the added subpackages again, which would in turn again select the subpackages of the subpackage. 2018-07-25 06:44:07 +02:00
Lars Hvam
1b154ccf7f
list superpackages, fix double entries #1612 (#1632)
list superpackages, fix double entries #1612
2018-07-14 06:50:33 +02:00
Christian Guenter
36f257f0bb Dependency injection for ZCL_ABAPGIT_SAP_PACKAGE 2018-06-18 15:37:16 +02:00
Jakub Filak
56c58b7a29 SAP Package: add the method get_transport_type
For the parameters WI_ORDER_TYPE and WI_TASK_TYPE of the function
TRINT_ORDER_CHOICE called from the method popup_transport_request
of the class zcl_abapgit_popups.

Sometimes we need a repair task but the function TRINT_ORDER_CHOICE
searches for Development/Correction tasks.

I hope that we can decide what task type is needed by a package (DEVC).

Related to #1446
2018-06-12 13:33:49 +02:00
Christian Guenter
582a3ab02a refactor transport popup 2018-05-08 19:09:30 +02:00
Jakub Filak
1448a3f7b2 package: a child inherits parent's appl. component
If a new package is not meant to be a local or a private package, it
must have assigned Application Component; otherwise the method
cl_package->if_package~create_new_package() raises the message
e050(pak) - component_missing.
2018-04-22 23:26:49 +02:00
Lars Hvam
803148fa0f
fix some naming conventions #1132 (#1211) 2018-02-17 13:55:12 +01:00
Christian Günter
eb2db0653c Fix issue #1152 2018-01-17 19:59:05 +01:00
larshp
e2197ab344 lcl_sap_package to global 2018-01-12 11:36:33 +00:00