Commit Graph

78 Commits

Author SHA1 Message Date
Marc Bernard
3c598bbf60
Improve "Cannot find .abapgit.xml" situation (#4240)
* Improve ""Cannot find .abapgit.xml" situation

Skip check during creating of repo and increase file count.

Closes #4174

* New online

* Add UT

* Move check to content list

* Update zcl_abapgit_repo_srv.clas.abap

* Lint

* Rename to check_repo_size

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-08 15:35:31 +01:00
Lars Hvam
efa6aa9347
Remove two places wih repo class insantiation (#4250)
* zip, method encode_files as public

* refactor instantiation

* remove filter input parameter
2020-11-30 11:23:36 +01:00
Philipp R
45770773f5
unify rebuild_local_checksums method (#4237)
* unify rebuild_local_checksums method

redefinition of rebuild local checksums is reduced to redefinition of "get_remotes"

* fix formatting

* remove duplicate method implementations

* remove duplicate method implementation

* update zcl_abapgit_repo_online

Co-authored-by: Rembold Rembold <philipp.rebold@sap.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Philipp Rembold <Philipp.Rembold@sap.com>
2020-11-26 11:48:05 +01:00
Lars Hvam
a3ff1a2e4a
move files logic to serialize class (#4231)
* move apack file build to apack package

* move files logic to serialize class
2020-11-24 15:45:44 +01:00
Lars Hvam
6bd3242ecf
dot abapgit file, move file build (#4226)
move responsibility for building the dotabapgit file to the dotabapgit class instead of the repo

https://github.com/abapGit/abapGit/issues/2127#issuecomment-732262897
2020-11-24 07:55:15 +01:00
Lars Hvam
381d40e35a
ZCL_ABAPGIT_HASH add shorthand methods (#4220)
This adds shorthand methods for the SHA1 calculation of the different git artifacts.
More logic in ZCL_ABAPGIT_HASH, but easier to read and less application logic.
2020-11-23 14:30:31 +01:00
Marc Bernard
b25a67acea
Terminology: Inclusive Language - Part 2 (#4159)
* Terminology: Inclusive Language - Part 2

Change "Master Language" to "Main Language" in UI and comments (documentation and variables next)

* Docs

* Docs

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-11 10:36:38 +01:00
Lars Hvam
c2492dd47e
delete unused methods (#4125)
* ZCL_ABAPGIT_REPO_FILTER

delete ZCL_ABAPGIT_REPO_FILTER->GET_PACKAGE
ZCL_ABAPGIT_REPO_FILTER delete MV_PACKAGE

* testclass, delete method given_fstate

* delete ZCL_ABAPGIT_GUI_PAGE_PATCH->IS_EVERY_CHANGE

delete method delete ZCL_ABAPGIT_GUI_PAGE_PATCH->IS_EVERY_CHANGED_LINE_PATCHED

* delete ZCL_ABAPGIT_OBJECTS_SUPER->CHECK_TIMESTAMP
2020-11-03 08:45:21 +01:00
mariusraht2
b75c6f8515
Add selected commit to repo persistence (#4095)
* Implementation

* Remove old source code

* Clear selected_commit on switch_repo_type

* Reset selected commit or branch on select

* Don't clear the branch name if commit selected
2020-10-29 06:48:41 +01:00
Marc Bernard
ba0c1257c8
Fix state calculation for deleted objects (#4084)
* Fix state calculation for deleted objects

In case objects are deleted locally or remotely, abapGit now compares against the last known state (checksum). 

Closes https://github.com/abapGit/abapGit/issues/4030

* Added test case

Covers known local and remote states

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-28 06:57:27 +01:00
Marc Bernard
9672f5b030
Adjust name prefix for types (#3991)
* Part 1

* Part 2

* Part 3

* Lint

* Part 5

* Part 6

* Part 7

* Part 8

* Part 9

* Enforce type naming prefix

All types need to start with TY_...

* Fix local types
2020-10-07 08:54:15 +02:00
pokrakam
00e01c7232
Extend unit tests to handle edge cases (#3952)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-29 07:46:25 +02:00
Marc Bernard
34955f98cb
Performance: Remove double check during deserialize (#3875)
* Performance: Remove double check during deserialize

Closes https://github.com/larshp/abapGit/issues/3757

* check_write_protected check_language

* Add calls to find methods

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-14 12:47:45 +02:00
mariusraht2
24cba9e221
Suppress popup on autostart after update (#3844)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-06 09:28:43 +02:00
Marc Bernard
c09cc67c83
Fix startup of repo view (#3831)
* Update error msg

* Fix login popup errors and cancelation

* Remove validate/reset methods

* Lint

* Rename iv_repo_online to io_repo_online

* Change to error in status bar

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-04 09:32:38 +02:00
Lars Hvam
9c41a2b7d8
remove text pragmas and pseudo comments (#3827)
* remove text pragmas and pseudo comments

* fix whitespace

* fix carriage return

* test

* test

* Update zcl_abapgit_repo.clas.abap
2020-09-03 09:13:47 +02:00
Marc Bernard
e70875879b
Restart abapGit in case of self-update (#3804)
* Restart abapGit in case of self-update

Closes #3358

* Fix abapgit url detection

Old logic incorrectly matched for example https://github.com/abapGit-tests/CHAR

* Github only

* Separate method

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-03 09:07:57 +02:00
Alexander Tsybulsky
a4e6c87985
Switching to PRs (#3695)
* string map: public entries (read only)

* port http agent

* draft wip

* drafting

* fix SSL

* port ajson

* integrate ajson and http_agent

* agent global headers

* github enumerator

* update ajson

* draft wip

* enumerator factory

* http_agent via factory

* proxy

* repo->switch_origin draft

* refactor enum factory

* Revert "refactor enum factory"

This reverts commit bcfef40b38991adfe5f73677919db6bd0c652f7c.

* page wiring draft

* scripts draft

* "let it work!"

* repo setings page draft

* linter

* linter

* linter

* linter

* linter

* better settings page

* finetune page

* cleanups

* change hotkey

* fix ajson_error

* Update src/zcl_abapgit_repo_online.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* abaplint nesting 6

* remove description

* back to good old popups

* linter

* move commands to branches dropdown

* auth helpers

* move json to separate package

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-27 07:47:27 +02:00
Marc Bernard
e4bafbe715
Validate if branch exists when displaying repo (#3749)
* Validate if branch exists when displaying repo

* Validate if branch exists when displaying repo

* Lint

* Lint and 702

* Lint

* Rename validate_branch to validate

* Fix msg and branch display name

* Move msg to UI layer

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-08-24 11:15:46 +02:00
Marc Bernard
b7e0f15448
Fix status calculation (#3698)
Return checksum only if local item exists

Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-09 08:38:50 +02:00
Marc Bernard
8e031e0498
Update zcl_abapgit_repo.clas.abap (#3570) 2020-06-30 17:28:01 +02:00
Christian Günter
50cff91259
Raise exception when no .abapgit.xml is found (#3512)
Update

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-16 13:10:03 +02:00
Jaime Rodriguez Capote
fce71de4d1
Use constants for Y/N/P (#3291)
* Use constants

* Pretty Printer
2020-04-05 10:55:24 +02:00
Jaime Rodriguez Capote
27ac61e95d
Apack dependencies (#3285)
* Support APACK dependencies

Check installed apack package dependencies for current repository
Display a popup with dependencies

* abaplint checks

* abaplint checks

* abaplint checks

* Popup only when dependency not met

* abaplint checks

* abaplint checks

* Optimization

* abaplint checks

* abaplint checks

* Fix typo "dependeNcies"

* Remove address from dependency check

* Dependencies popup title

* Dependencies popup enhanced

* EXCEPTION column replacing MET
* Enable Git URL hiperlink

* APACK doc - Version dependency support

* Dependencies version check support

* abaplint checks

* abaplint checks

* Version utils

* fix syntax warning

* move set_dot_apack to protected

Co-authored-by: larshp <larshp@hotmail.com>
2020-04-05 08:57:59 +02:00
Christian Günter
1e4560b32a
Patch: new refresh functions (#3271)
* Patch: Refresh object first working version

* Patch: add refresh local and refresh repo + refact

* add missing stuff

* fix lint

* refactoring and cleanup

* add missing stuff

* refactor

* refactor

* refactor

* add title for menu bar

* Save and restore scroll position

* refactoring and cleanup

* refactor

* cleanup

* cleanup

* cleanup

* remove new hotkey

* disable object refresh for non-object files

* remove restore scrollposition

* cleanup

* refactor

* cleanup

* save scroll position

* Fix: refresh of deleted objects

* Fix dump: refresh new objects

* add hotkey support for refresh all local objects

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-26 12:30:22 +01:00
Lars Hvam
a85db8c8b8
SRFC: clear some admin fields (#3225)
* SRFC: clear some admin fields

* fix lock problem and delete problem
2020-03-04 06:34:58 +01:00
Jaime Rodriguez Capote
2ca3a3da91
CHDO change document object #802 (#3207)
* Support for CHDO

* Remove dependency from GENERIC

* Skip gen. objects by CHDO

* abaplint checks

* Moved filter to zcl_abapgit_repo

* Adjusted filter logic

* Delete unused methods

* Extract apply filter methods

New class zcl_abapgit_repo_filter generated with apply filter methods

* docs: update supported with CHDO

* Clear serialization fields

* Set package at deserialize

* Check errors at deserialize
2020-03-04 06:29:31 +01:00
Lars Hvam
b42f3bc485
Refactoring (#3134)
* fully type constants

* moving to single line

* move to single line

* enable keep_single_parameter_on_one_line
2019-12-28 12:11:32 +01:00
Lars Hvam
714fe7202d
whitespace fixes (#2964)
* whitespace fixes

* fix sql compare operators
2019-10-11 02:50:16 -07:00
Alexander Tsybulsky
f2f82278e7 Serialize master lang only + settings UI improvements (#2954)
* repo settings ui improvements

* serialize_master_lang_only UI

* downport

* connect settings and serialization (MSAG)

* dtel doma tran prog fugr

* linter fixes
2019-10-07 23:03:57 -07:00
larshp
90e012a1ae for low number of obj run single thread 2019-10-07 22:41:36 -07:00
Martin Fuchs
4aab0166ac Pass log to deserialization API and show log (#2729)
* Pass log interface for de-serialization

Interface ZIF_ABAPGIT_LOG is now passed for deseriaization API.
This includes:
- Log messages for FUGR: Imported function modules and includes
- Improved error messages for TABL compare
- Log objects w/o changes
- Log is shown in the UI if available ("Log" entry appears if a log exists, no persistence!)
This PR enhances #2534 and #2694

Another important change: In case an object fails (or a single function module in a group fails), the import continues with the next object!

* small pretty printer changes

small pretty printer changes

* fix abaplint issues

reduce line sizes and ensure 7.02 compatibility

* show errors and warnings from pull

Errors and warnings after a pull are now part of the "message list" above the object list in the main screen and will be shown immediately. The new"Log" button shows errors, warnings and success messages on demand.
The log title is now part of the ZIF_ABAPGIT_LOG interface.

* fix abaplint issue

fix abaplint issue
2019-06-21 23:05:10 -07:00
larshp
ff6725e759 replace uses of log with interface 2019-03-17 01:39:52 -07:00
Lars Hvam
f9318305e9
Minor fixes (#2532)
* minor fixes regarding unused variables

* minor code inspector fixes
2019-03-15 05:54:39 -07:00
Sebastian Wolf
a5de7a8769 Add serialization for APACK manifests (#2485)
* Add serialization for APACK manifests

* Add documentation for APACK serialization

* APACK docs: Add more information about dependency format

* APACK: Some words about transporting ZIF_APACK_MANIFEST

* APACK: Move definitions in own interface

* APACK: Don't build the manifest file twice...
2019-03-11 23:34:32 -07:00
Christian Guenter
f73e18d587 Online repo "display name" to overrule default name 2019-02-25 07:20:01 -08:00
larshp
5b44d8e89b REPO, remove method RUN_CODE_INSPECTOR
the successful flag is now saved in code inspector class instead
2019-02-20 22:00:36 -08:00
Lars Hvam
ffcd6c82ed
Refactor code inspector (#2412)
* delete method GET_INSPECTION

delete method GET_INSPECTION, not called from anywhere

* delete class ZCL_ABAPGIT_ABAP_UNIT_TESTS

* delete class ZCL_ABAPGIT_SYNTAX_CHECK

* delete class ZCL_ABAPGIT_ADHOC_CODE_INSP

* move VARIANT to importing in RUN

instead of in the constructor

* one variable containing the name

instaed of 2 with same contents

* linting
2019-02-19 21:37:40 -08:00
larshp
c02aa72e99 move get_local_checksums method to private 2019-02-17 01:29:11 -08:00
Lars Hvam
25d4c9ea07
Remove HAS_CHANGED_SINCE #1021 (#2401)
* core part removed

* remove method implementations
2019-02-15 06:51:57 -08:00
Lars Hvam
1a60384e84
move method get_unnecessary_local_objs #2127 (#2315)
* move method get_unnecessary_local_objs #2127

move method get_unnecessary_local_objs #2127

* interface for progress class

* oops, rollback previous commit
2019-01-23 06:27:29 +01:00
Christian Guenter
1913b7eaeb AdHoc code inspection: ask user for check variant 2019-01-16 09:33:13 +01:00
Christian Guenter
ca41c7d783 Better error message when repo isn't opened in ML
Better error message when repo isn't opened in master language
2019-01-04 05:40:24 +01:00
Alexander Tsybulsky
dd52f33497 move isola to zcl_abapgit_convert 2018-12-30 08:07:19 +01:00
sbcgua
e809df8384 repo->set refactoring, disconnect repo from persistence (#2164)
* 1st attempt (events)

* temp stash

* split persistence and repo, beta

* fix

* fix2

* fix3

* linter fixes

* review fixes
2018-12-02 09:10:55 +01:00
sbcgua
c465a6b2e8 Offline improvements (#2156)
* local reset in zip-based

* rebuild_local_checksums on new offline
2018-11-28 07:19:27 +01:00
larshp
7b2b0a6cd8 make sure the remote .abapgit.xml is found #2113 2018-11-26 18:28:04 +01:00
Fabian Lupa
2a2b30d6eb Backport "open in master language"
#2132
2018-11-23 16:35:57 +01:00
Lars Hvam
69cd1f5d19
parallel serialization #1714 (#2129)
* parallel serialization #1714

* use latest abaplint

* Update abaplint.json

* add function group

* fallback to sequential

* fix error when running in background mode
2018-11-23 12:16:47 +01:00
Lars Hvam
54e0155891
parallel: refactoring, #2121 (#2122)
* parallel: refactoring, #2121

* move cache handling outside of main loop

* fix error found by abaplint
2018-11-22 05:07:49 +01:00