Commit Graph

4805 Commits

Author SHA1 Message Date
Marc Bernard
45806c5a95
Refactor serializer class (#4994)
* Refactor serializer class

- Consolidate i18n parameters
- Move determination of translation languages into serializer class
- Pass translation language setting when parallel processing (was a bug)

* Lint

* Add unit tests

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-25 16:01:40 +02:00
Marc Bernard
91f77324ea
CSS adjustments (#5047)
* CSS adjustments 

I made a few small CSS adjustments to make things a bit more consistent

- Repo overview: Adjust hightlight for current row 
- Repo: Add background color to table header to match staging
- Repo: Fix hightlight for current row 
- Staging: Slight color and table border adjustments
- Forms: Slight color adjustments for textarea placeholder
- DB Utility: Add hightlight for current row

* Update to dark theme

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-25 15:50:01 +02:00
Frederik Hudák
ea0c834992
Fix syntax check warnings (#5055)
* Fix syntax check warnings

* The classes can be final
2021-10-25 15:33:13 +02:00
g-back
1e5befc44a
Decouple cl_gui_frontend_services (#5046)
* add additional methods

* fix whitespace

* add parameter prefixes

* zip: refactor usage of frontend_services

* debug info: refactor usage of frontend_services

* services basis: refactor frontend_services usage

* objects_super: refactor usage of frontend_services

* router: refactor usage of frontend_services

* services_abapgit: refactor usage of frontend_serv

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-20 17:54:23 +02:00
github-actions[bot]
27eca9b766
ajson, Automatic Update (#5036)
* [create-pull-request] automated change

* upd

* fix

Co-authored-by: larshp <larshp@users.noreply.github.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-20 17:50:51 +02:00
Marc Bernard
e85e2f51d3
Measure backend render time (#5043)
This measures the time it takes in the backend to prepare the HTML page. Result is shown when hovering over abapGit logo in the page footer.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-19 06:38:56 +02:00
Lars Hvam
d54940075b
update npm dependencies (#5045) 2021-10-19 06:36:29 +02:00
Marc Bernard
e8a6cb8a51
XSLT: Fix activation error (#5042)
Remove activation from `deserialize` and use `zcl_abapgit_objects_activation` instead.
2021-10-18 15:08:44 -04:00
Christian Günter
a8e7518348
enable command palette for Diff/Patch/Stage (#5040)
* enable command palette for Diff/Patch

* enable command palette for Stage

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-10-18 15:06:34 -04:00
Christian Günter
bf5634d243
Diff/Patch: Split view - enable line hover (#5039)
* patch page: enable line hover

* improve CSS + enable for unified

* add more CSS classes to table rows
2021-10-18 15:00:25 -04:00
Marc Bernard
7c977f4c4d
UI: Correct placeholder color for textarea (#5037) 2021-10-15 09:31:43 -04:00
Derby
9b582b039a
WDCA: Add support for appl. config content (#5030)
* object WDCA

object WDCA
+ wdy_config_appl-xcontent
+ wdy_config_appt

* Update zcl_abapgit_object_wdca.clas.abap

* Update src/objects/zcl_abapgit_object_wdca.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/objects/zcl_abapgit_object_wdca.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update zcl_abapgit_object_wdca.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-15 07:35:03 +02:00
g-back
4b5b654b49
Online Repo: URL to clipboard (#5034)
* import latest icon set

* Add export URL to clipboard for online repos

* omit parameter name

* adjust indent

* add url class

* Update src/ui/zcl_abapgit_gui_chunk_lib.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2021-10-15 07:30:41 +02:00
Christian Günter
0b71f14f93
'add objects to tr' - fix log display (#5032)
Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-14 16:57:35 +02:00
Christian Günter
e340131487
Log viewer - hide empty columns (#5033)
* Log viewer - hide empty columns

* reduce popup width

* adjust popup width

Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
2021-10-14 12:10:05 +02:00
Alexander Tsybulsky
65701dbcc8
pull on package reassign (#4999)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-13 06:12:19 +02:00
Alexander Tsybulsky
8a3aa38d82
fix SERVICES_REPO=>POPUP_DECISIONS (#4998)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-13 06:10:31 +02:00
Marc Bernard
df35124b71
Docs: Update font details (#5031) 2021-10-12 18:02:33 +02:00
Lars Hvam
cf642470d6
unit testing updates (#5027)
update to eslint 8
run 4 more unit test methods
update abaplint stuff to latest
2021-10-11 14:30:51 +02:00
Alexander Tsybulsky
253d6abec7
switch back from PR bugfix (#5028)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-11 07:47:31 +02:00
Christian Günter
4ce32ba7a6
Diff-page: enable refresh functions (#4992)
* Diff-page: Enable refresh functions

* cleanup

* Diff: add refresh local hotkey

* Rename 'Refresh' to 'Refresh All'

Co-authored-by: Alexander Tsybulsky <sbcgua@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2021-10-09 07:06:55 +02:00
Alexander Tsybulsky
372a2ab7ae
SCI result at stage and commit pages (#5002)
* sci result at stage and commit pages

* improvements

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-10-09 07:04:57 +02:00
Frederik Hudák
423cdd1009
Change abapgit font to 72 (#5026) 2021-10-07 10:10:40 +02:00
Marc Bernard
bdafff8581
Fix stage filter (#5023)
* Fix stage filter

* Update js

* Update js

* Lint

Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2021-10-06 14:15:02 -04:00
Frederik Hudák
4a5cf13eca
Don't lowercase transport request id (#5022)
* Don't lowercase transport request id

* fix error

* uppercase username and package too
2021-10-06 20:10:09 +02:00
Frederik Hudák
87e435dc5d
Main page - don't suppress titles for favorites (#5025) 2021-10-06 20:08:08 +02:00
Frederik Hudák
bd1ffd1f2e
Add pull and diff buttons to main page (#5021)
* Add more action buttons to main page

* Fix line length
2021-10-06 19:36:39 +02:00
Lars Hvam
93d14fcc81
repo content list: keep last changed_by in memory (#5019)
#5016
2021-10-06 15:36:51 +02:00
Frederik Hudák
00934cfdaf
Only show favorites on startup (#4997)
* Only load favorites on startup

* downport

* Escape sql

* Fix select, refactoring

* Fix parameter name

* Refactoring

* Update src/repo/zcl_abapgit_repo_srv.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/repo/zcl_abapgit_repo_srv.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/repo/zcl_abapgit_repo_srv.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* indent

* remove me

* Add type column to select

* lint

* Add info message at the bottom of the list

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-06 08:04:09 +02:00
Marc Bernard
51ce0b4df9
FUGR: Fix performance issue (#5017)
Optimize selection of function group includes.
2021-10-06 08:01:51 +02:00
Marc Bernard
1783f70bc0
Docs: Update links for settings help (#5014)
* Docs: Update links

After #5008

* Update zcl_abapgit_gui_page_sett_info.clas.abap

* Update zcl_abapgit_gui_page_sett_locl.clas.abap

* Update zcl_abapgit_gui_page_sett_remo.clas.abap

* Update zcl_abapgit_gui_page_sett_repo.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-05 18:44:01 +02:00
Marc Bernard
b4c5e2e401
Docs: Add "Remote Settings" (#5008)
* Docs: Add "Remote Settings"

* Update ref-dot-abapgit.md

* Delete repo_settings_remote.png

* Add files via upload

* Update link

* Update link

* Add "Repo Settings" to navigation

* Update and rename ref-dot-abapgit.md to settings-dot-abapgit.md

* Update settings-dot-abapgit.md

* Create settings-local.md

* Create settings-remote.md

* Update settings-local.md

* Update and rename other-background-mode.md to settings-background-mode.md

* Update settings-background-mode.md

* Update and rename ref-settings-stats.md to settings-stats.md

* Update zcl_abapgit_gui_page_sett_remo.clas.abap

* Update zcl_abapgit_gui_page_sett_locl.clas.abap

* Update zcl_abapgit_gui_page_sett_bckg.clas.abap

* Update zcl_abapgit_gui_page_sett_info.clas.abap

* Update zcl_abapgit_gui_page_sett_repo.clas.abap

* Update zcl_abapgit_gui_page_sett_bckg.clas.abap

* Update zcl_abapgit_gui_page_sett_info.clas.abap

* Update zcl_abapgit_gui_page_sett_locl.clas.abap

* Update zcl_abapgit_gui_page_sett_remo.clas.abap

* Update zcl_abapgit_gui_page_sett_repo.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-05 18:40:42 +02:00
Marc Bernard
6b7318a78c
Docs: Add example for staging (#5012) 2021-10-05 18:32:34 +02:00
Frederik Hudák
3f4a92cfe3
Repo page - inform on bottom if only changes are shown (#5011) 2021-10-05 15:04:17 +02:00
Marc Bernard
8ec439b9a0
Docs: Add example for casting to API doc (#5010)
* Docs: Add example for casting to API doc

* Update api.md
2021-10-05 14:57:04 +02:00
Marc Bernard
2b8c21bdbc
SXCI: Inactive classic BAdIs (#5006)
* SXCI: Inactive classic BAdIs

Implements a workaround since SAP does not show inactive classic BAdIs properly (missing entry in table `dwinactive`).

* Update zcl_abapgit_object_sxci.clas.abap

* Update src/objects/zcl_abapgit_object_sxci.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Change by

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-05 06:12:45 +02:00
Marc Bernard
0379bc6d11
Change Package Assignment (#4980)
* Change Package Assignment

Previously, if an object was assigned to another package (but not changed otherwise), AG would delete and re-create the object. This was also visible in the "Selective Pull" popups:



The new process is smarter and detects such changes. It re-assigns the package (via a TADIR change) and avoids dropping and re-creating. The package overwrite popup is also avoided (it will still appear if the object itself was changed, too):

* Better icon

* Add unit test

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Alexander Tsybulsky <sbcgua@users.noreply.github.com>
2021-10-05 06:02:20 +02:00
Marc Bernard
3e14313f32
SMIM: Last Changed By (#5009)
If "last changed" user is not found on logical object, try selection on physical object
2021-10-05 05:57:46 +02:00
Marc Bernard
0d8b4dd7f5
WDCC: Fix syntax error on lower releases (#5005) 2021-10-04 12:10:43 -04:00
Marc Bernard
c276c719d8
XSLT: Add late activation (#5003)
* XSLT: Add late activation 

In case a transformation depends on other objects like a class, the transformation will not activate if it's deserialized before the dependent objects. 

This change adds the transformation to the late activation step.

* lint

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-04 16:59:05 +02:00
Alexander Tsybulsky
a223df0292
Don't show github note at password dialog on non-github repos (#5004)
* dont show github note on non-github repos

* better hiding
2021-10-03 16:43:31 -04:00
Marc Bernard
b41831868f
Fix dump during "New Online" (#4977)
* Fix dump during "New Online" 

I accidentally used a copied link `sapevent:url?url=https://github.com/abapGit-tests/TABL` into the "New Online" diaplog. AG would dump in this case.

Now you get a proper error message.

* Strip leading/trailing spaces for URLs

* Add

* Update

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: g-back <27279305+g-back@users.noreply.github.com>
2021-10-02 09:09:18 +02:00
Marc Bernard
84e6971bf8
Remove unused variable from settings (#4993) 2021-10-01 11:57:47 -04:00
Marc Bernard
ef8f830734
Refactor hotkey controller (#4990)
- Removed "class analysis logic" from hotkey collection
- Hotkeys are now registered directly in the hotkey controller (similar to asset manager)
- `zif_abapgit_hotkeys->get_hotkey_actions` was changed to instance method and can therefore be redefined in subclasses
- Renamed the controller class to match the interface name

Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-01 08:43:25 +02:00
Lars Hvam
b9f3a36b07
1.111.0 (#4991) 2021-10-01 08:33:20 +02:00
Marc Bernard
dc4b370521
Naming of class constants - Part 3 (#4984) 2021-10-01 08:20:15 +02:00
Jaime Rodriguez Capote
bdedad5592
Delete child number from SICF node (#4988)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-01 08:18:22 +02:00
Lutzi3
e6f029b097
WDCC:Support all Config Types (#4985) 2021-10-01 08:14:16 +02:00
yellappam
34b2fb3222
FUGR: Clear TEXT when referring to dictionary (#4973)
In dynpro screen, when a field is referring to a data element and text is taken from dictionary, no need to serialize the text as it is always taken from dictionary. If the text is included then it will show unnecessary diffs when data element text changes.

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-01 08:12:18 +02:00
Marc Bernard
cfb185b87c
Naming of class constants - Part 2 (#4983)
Ref #4945

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-01 08:04:36 +02:00