Commit Graph

73 Commits

Author SHA1 Message Date
Marc Bernard
fcdb07a7a6
TABL: Fix deserialize if foreign key exists (#5773) 2022-10-02 09:19:33 +02:00
Marc Bernard
f1c1aad740
Delete obsolete longtexts on pull (#5751)
* Delete obsolete longtexts on pull

Longtexts that exist in the system but not in the remote repository are deleted when pulling.

Closes #5202

* Refactor

* Constant

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-09-23 09:57:44 -04:00
Albert Mink
0bf8388a6e
Use sy-uname instead cl_abap_syst->get_user_name (#5685) 2022-07-13 09:13:41 +02:00
Marc Bernard
0ab3ee0a06
Remove aliases from object classes (#5588) 2022-06-04 10:33:42 +02:00
Gregor Wolf
276ad4e808
Exclude technical language from intf, clas, prog, dtel, doma and tabl (#5598)
* exclude technical language from DOMA

* exclude technical language from DTEL

* exclude technical language from TABL

* exclude technical language from CLAS

* exclude technical language from PROG

* exclude technical language from INTF

* fix abaplint issue: Place pragma at end of statem.

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-05-30 12:18:32 +02:00
Marc Bernard
5127bfdb9d
DDIC: Improve active/inactive check (#5486)
* DDIC: Improve active/inactive check

Use `is_active_ddic` (function `DDIF_STATE_GET`) for all DDIC object types. This is more accurate than the current method (function `RS_INACTIVE_OBJECTS_WARNING`) since it detects newly created but not active objects as well.

* Fix const

* Remove "no active version" error

* Update comment

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-09 08:08:32 +02:00
sandraros
b3c89a8ff2
Create empty classes/interfaces before DDIC (#5393)
* Force XSLT activation during deserialize

* Revert "Force XSLT activation during deserialize"

This reverts commit 7d6fc64ddb.

* Create empty class/interface before DDIC phase

Fix #5392

* pretty printer ZCL_ABAPGIT_OBJECT_INTF

* abaplint zcl_abapgit_object_clas

* Update zcl_abapgit_object_clas.clas.abap

* Update zcl_abapgit_object_dtel.clas.abap

* Update zcl_abapgit_object_intf.clas.abap

* Update zcl_abapgit_object_tabl.clas.abap

* Update zcl_abapgit_object_ttyp.clas.abap

* Update zcl_abapgit_objects.clas.abap

* Update zcl_abapgit_object_clas.clas.abap

* Update zcl_abapgit_object_intf.clas.abap

* Update zif_abapgit_object.intf.abap

* Update src/objects/zcl_abapgit_object_intf.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update order numbers

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-26 16:07:15 +02:00
sandraros
5e53bb9626
Fix DDIC errors related to ref to class/interface (#5369) 2022-02-27 17:23:13 +01:00
Marc Bernard
ec9ff1a29f
TABL: Properly show inactive objects (#5303)
* TABL: Properly show inactive objects

Current `is_active` check is insufficient for DDIC objects and can't detect "new" or "partically active" objects.

Introduces a new `is_active_ddic` method in `zcl_abapgit_objects_super` which should be used by all DDIC types (follow-up). 

Ref #5294

* Update zcl_abapgit_objects.clas.abap

* Update
2022-02-01 16:11:18 +01:00
Marc Bernard
6efaa0e0b4
Refactor: Remove ddic flag (#5295)
Closes #5264

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-30 16:37:56 +01:00
Marc Bernard
3fa3323b2e
Refactor: Jump to Object Logic (#5158)
* Refactor: Jump to Object Logic

Continue #5114

- Removes jump_adt and jump_se11 from zcl_abapgit_objects_super
- Remove almost all object-specific jump handlers (zif_abapgit_object~jump) since they are covered by GUI Jumper now

* Remove ZCL_ABAPGIT_OBJECT_SICF

* Remove obsolete RS_TOOL_ACCESS

* FUGR

* IATU

* PDXX

* SRVD

* XINX

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-11-29 15:52:13 -05:00
Alexander Tsybulsky
a671bb8dc3
Expand TABL includes before PUT (#5153) 2021-11-22 12:57:38 -05:00
Lars Hvam
4301d3e8c8
no chained assignment (#5140)
* no chained assignment

* bugfix
2021-11-19 16:19:27 +01:00
yellappam
6761998a5d
TABL: CLEAR dd05m-leng (#4950)
* CLEAR dd05m-leng

In S/4HANA system some of the data element lengths changed. Example: MATNR length changed from 18 characters to 40 characters. It would show as diff when this repo is pulled into S/4HANA. dd05m-leng is for information only hence, cleared it to avoid diffs.

* Replace tab with space

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Replace tab with 6 spaces

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-24 06:32:31 +02:00
Marc Bernard
7c32f824df
TABL: Clear DB Indexname (#4850)
Fixes diffs because platform specific DB index names. 

Updated test repo: https://github.com/abapGit-tests/TABL_with_index

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-07-01 14:15:32 +02:00
Lars Hvam
096aded586
LANGU rollbacks (#4829)
* LANGU rollbacks

#4828

* Update abaplint.json
2021-06-08 16:42:20 +02:00
Marc Bernard
e2a156a326
Replace deprecated LANGU type (#4815)
* Replace deprecated LANGU type

Replace with `sy-langu` and update abaplint rule

* Replace langu

* Add langu to void types

* Replace table of langu
2021-06-02 08:04:05 +02:00
Marc Bernard
8a0af2fc67
DDIC: Error message in case of "new" versions (#4584)
In case DDIC objects exist as "new" version only , the system will now raise an error message to alert the user that "No active version was found". 

Note: The log will disappear after some navigation and such objects will not be included in the repo view if they only exist locally (until they are activated).
2021-03-02 17:38:26 +01:00
Marc Bernard
f8076e9ca2
TABL: Remove field position from serialization (#4508)
* TABL: Remove field position from serialization

It's not necessary to serialize field position (`DD03P-POSTION`). Fields can simply be numberred sequentially during deserialize.

This avoid issues with include structures that have different number of fields in original and target systems.

Closes #4506

* Clear tabname, ddlanguage

* Lint

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Clear dd08v-ddlanguage

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-28 10:47:16 +01:00
Lars Hvam
8e07d46f4b
jump_se11, remove unused parameters (#4498) 2021-02-09 15:50:27 +01:00
Marc Bernard
73576ee60e
Improve error messages (#4472)
* Improve error messages

Pass T100 messages to UI/log

* T100 errors

* APACK

* OO

* DEVC

* DRUL

* DTDC

* SRVB

* OBJS

* Program

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-03 16:31:55 +01:00
DerGuteWolf
4c07c33c21
TABL, default ROWORCOLST on deserialize (#4430)
* Fix for #4425

* Remove whitespace at end of line

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Remove whitespace at end of line

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2021-01-21 06:21:23 +01:00
Marc Bernard
31a550db0f
Refactor I18N settings (#4423)
* Refactor I18N settings

- Consolidate I18N parameters into a structure and pass it to xml and serializer classes (#4415)
- Continue change of terminology (#4043)

* Remove changes to serializer class

* Main lang

* DSYS

* OTGR

* Repo view

* Main langu

* Repo view %26 stage

* Serialize

* Settings

* Repo view

* Defs

* Stage

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-19 14:29:09 +01:00
Lars Hvam
8b506aa077
omit some default parameter names (#4370)
* apack, omit parameter names

* mass and objects

* omit

* omit
2021-01-04 10:41:20 +01:00
Marc Bernard
b25a67acea
Terminology: Inclusive Language - Part 2 (#4159)
* Terminology: Inclusive Language - Part 2

Change "Master Language" to "Main Language" in UI and comments (documentation and variables next)

* Docs

* Docs

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-11 10:36:38 +01:00
Marc Bernard
bdc44f7476
Remove self-references (#4115)
* Remove self-references

Remove unnecessary self-references (me->)

https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#omit-the-self-reference-me-when-calling-an-instance-method

* 702: Fix syntax error

No chaining with EXPORTING & CHANGING

* remove addiontal me, update abaplint config

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:25:27 +01:00
Marc Bernard
92ba04d00e
TABL: Fix "exists" check (#4105)
Tables could exist in "new" (or other) version that is not included in nametab.
2020-10-30 09:53:54 +01:00
Christian Günter
d14393dac5
TABL: Skip data check for GTTs (#4075)
* TABL: Skip data check for GTT

fixes #4074

* undo case change

* TABL: use fm DD_EXISTS_DATA for data check

* remove formatting change

* Data existence check only for DB tables

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-28 06:45:04 +01:00
Marc Bernard
caea4865bf
Integration of unit test with CI (#3993)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-27 08:15:52 +01:00
Marc Bernard
9672f5b030
Adjust name prefix for types (#3991)
* Part 1

* Part 2

* Part 3

* Lint

* Part 5

* Part 6

* Part 7

* Part 8

* Part 9

* Enforce type naming prefix

All types need to start with TY_...

* Fix local types
2020-10-07 08:54:15 +02:00
Marc Bernard
b940572f2a
Fix deserialize of TABL with foreign keys (#3945)
Activation of foreign keys now uses with same logic as #3545:
- remove keys during DDIC phase
- add keys during LATE phase

Closes #3867

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-27 11:12:15 +02:00
g-back
7871d23fef
XML Input/Output: Remove Aliases (#3898)
* change XML reference to interface

* remove aliases from XML in/out classes

* change XML references to interfaces
2020-09-18 14:01:44 +02:00
g-back
6f8147036e
XML Refactoring: Various Objects (#3891)
* change xml references

* change xml reference
2020-09-16 15:23:14 +02:00
g-back
4dde63360e
XML Refactoring: Comparator/OO_Object_FNC (#3888)
* change xml references to interfaces


changed reference in interfaces:
- zif_abapgit_comparator
- zif_abapgit_oo_object_fnc

* change reference of xml in dependent objects

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-16 12:43:40 +02:00
Lars Hvam
42a532b9eb
reduce usage of ddic types (#3859)
* add SAP_BOOL as forbidden void type

* reduce

* Update abaplint.json

* sychar10

* sylangu

* Update abaplint.json
2020-09-10 15:30:25 +02:00
Lars Hvam
9c41a2b7d8
remove text pragmas and pseudo comments (#3827)
* remove text pragmas and pseudo comments

* fix whitespace

* fix carriage return

* test

* test

* Update zcl_abapgit_repo.clas.abap
2020-09-03 09:13:47 +02:00
Lars Hvam
f582225bf8
start refactoring to use XML interfaces (#3796)
* start refactoring to use XML interfaces

#3531

* TABL + TRAN + UDMO + UENO

start using the interfaces for xml instead of class references
2020-08-26 06:50:47 +02:00
Lars Hvam
1433fe2fe9
DTEL and TABL EXISTS performance (#3748) 2020-08-19 09:00:28 +02:00
Marc Bernard
3cb70cce20
TABL: Add translations (#3691)
* TABL: Add translations

* TABL: Add translations

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-01 15:03:35 +02:00
Christian Günter
679bef9ce0
Fix Warning - ABAP doc param is not part of meth (#3697) 2020-08-01 12:32:56 +02:00
Domi Bigl
395116e481
add TABL authorization group handling (#3621)
* add TABL authorization group handling 

fixes #1328
test repo https://github.com/abapGit-tests/TABL-AuthorizationGroup.git
Authorization Group (TDDAT) is handled with TABL and TOBJ now

* fix linter errors

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-25 17:36:14 +02:00
Marc Bernard
4f0a5480a1
Improved error message when uninstalling DDIC objects (#3562)
* Update zcl_abapgit_object_doma.clas.abap

* Uninstall DDIC

* DDIC uninstall

* Pretty print

* DOMA delete append

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-07 15:36:13 +02:00
Marc Bernard
5f7c7dc2bc
DDIC with reference to class/interface, Search Help with Exit Function (#3545)
* Update zcl_abapgit_objects.clas.abap

* DDIC with reference to class/interface

* DDIC with reference to class/interface

* Search help with exit function

* Table with reference to search help

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-28 10:47:39 +02:00
Lars Hvam
d36b43defe
line break parameters (#3444)
* line break parameters

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* fix
2020-06-04 15:10:35 +02:00
Jaime Rodriguez Capote
543114963f
abapOpenCheck - Naming Conventions revision #3239 (#3240)
* abapOpenChecks config file

* Ignore SCI config folder

* checks revision

* Revert "checks revision"

This reverts commit 56a12289df.

* Renaming non-constants

Pending:

* Remove SCI configuration

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-09 17:34:26 +01:00
Lars Hvam
29cb891d23
remove obsolete NO_HANDLER pragmas (#3085)
* remove obsolete NO_HANDLER pragmas

* update lint to latest
2019-11-25 07:35:41 +01:00
Lars Hvam
48222ca050
indentation fixes (#2820)
* indentation fixes

* fixes
2019-07-31 00:49:10 -07:00
Martin Fuchs
9f2db446b1 simplified GET_DESERIALIZE_STEPS
Since all object handler contains exactly the same CASE statement for STEP definition, I would recommend that each object handler simply returns the STEP he belongs to.
This fix should "simply" issue #2499.
2019-05-05 00:57:52 -07:00
Christian Günter
9e2f7e7caf TABL: Simplify control flow (#2552)
* TABL: Simplify control flow

When this commit is applied the control flow in object serializer TABL
is eased. The idoc check returns now a boolean instead of raising an exception. Main purpose is to ease debugging due to reducing the use of 
zcx_abapgit_exception%3D>raise.

* TABL: fill rv_deleted on early exit
2019-03-19 10:05:15 -07:00
Lars Hvam
f9318305e9
Minor fixes (#2532)
* minor fixes regarding unused variables

* minor code inspector fixes
2019-03-15 05:54:39 -07:00