Commit Graph

5291 Commits

Author SHA1 Message Date
Lars Hvam
ddf1c048a0
add authorization exit on startup (#5630)
#5629
2022-06-17 11:49:53 +02:00
Alexander Tsybulsky
380508d72c
FUGR: Better maintenance view auto comments cleanups (#5622) 2022-06-13 12:00:09 +02:00
Marc Bernard
20e15a19c2
Adjust screen element naming (#5625)
Prep for additional abaplint rule
2022-06-08 19:16:25 +02:00
Marc Bernard
188996e417
UI: Message box improvements (#5616)
- Align width of message box to width of abapGit div (instead of full window width)
- Don't render "Message (00/001)" for generic messages

Closes #5614
2022-06-08 07:54:29 +02:00
github-actions[bot]
3131fc6cf8
ajson, Automatic Update (#5620) 2022-06-06 15:30:14 +02:00
Lars Hvam
3349b6a42d
run more unit tests via transpiler (#5615) 2022-06-06 15:15:36 +02:00
Marc Bernard
6e5f41277f
W3xx: Replace call with TADIR_INSERT (#5618) 2022-06-06 07:48:10 +02:00
Marc Bernard
7ba88d4345
Remove aliases - Common AFF (#5619)
Continue #5580
2022-06-05 21:45:38 +02:00
Marc Bernard
bb13a1ff10
Add exceptions to TR_TADIR_INTERFACE (#5617)
Better support for debugging
2022-06-05 21:29:04 +02:00
Marc Bernard
da24dba592
Fix dump when switching repo to offline (#5613) 2022-06-05 18:46:31 +02:00
Fabian Lupa
1052ce6e85
Support direct longtexts in exceptions (#5592)
* Support direct longtexts in exceptions

as opposed to already supported indirect T100-based longtexts

* Lint

* Remove direct longtext variable support

* Add unit tests for exception longtext

* Add longtext message to language mismatch error

* Fix missing preserve_newline handling

* Adjust longtext display in error message box

- Convert newlines to html line breaks
- Indicate if a longtext is available on hover

* Fix duplicate preserve newline handling

* Adjust exception longtext rendering

Render linebreaks as html paragraphs

* Align error message box buttons to bottom right

so they do not move on hover when a longtext is available

* Refactor exception unit tests

* Skip failing transpiled tests

* Adjust longtext indicator for error message

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-06-05 18:40:34 +02:00
Marc Bernard
2855e7e7bf
Small git utils improvements (#5611)
* Small git utils improvements

- Saves ~20ms per call of `length_uft8_hex`
- Improve test coverage

* Update test

* Update abap_transpile.json

* no skip, fixed

* Update test

* Update abap_transpile.json

* update

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-06-05 14:37:57 +02:00
Marc Bernard
2415a5c0c0
SOTR: Fix uninstall (#5558)
After all OTR usage has been removed, uninstall will now also delete the TADIR entry for SOTR. This is necessary in order to delete the corresponding package.
2022-06-04 13:41:50 +02:00
Marc Bernard
0ab3ee0a06
Remove aliases from object classes (#5588) 2022-06-04 10:33:42 +02:00
Marc Bernard
c88e1aba5d
AFF: Fix exception handling (#5609)
Catch exceptions when calling `TADIR` deletion

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-06-02 10:06:01 +02:00
Marc Bernard
380f297bc7
DSYS: Fix exceptions (#5608)
Replace exceptions with correct names
2022-06-01 11:18:22 +02:00
Marc Bernard
1a394ff173
INTF: Remove syntax warning (#5607)
Replaces with exception with parent
2022-06-01 10:33:57 +02:00
Lars Hvam
24deed4d60
update npm dependencies (#5605) 2022-06-01 08:05:55 +02:00
Fabian Lupa
799334dfe2
Add exposure to workflow class attributes (#5603)
* Add exposure to workflow class attributes

* Add constant seoc_state_implemented to abaplint

* Also add seoc_state_implemented to ci/abaplint

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-31 20:33:17 +02:00
Fabian Lupa
c04f7b8d7f
Show installation flavour in footer (#5604) 2022-05-31 18:02:02 +02:00
Marc Bernard
a0bd3a903c
INTF: Add to deletion transport and fix locking (#5562)
- Add object to transport on deletion
- Unlock object (proxy interface) in case of errors
2022-05-31 17:42:58 +02:00
Marc Bernard
36ce3944ae
Repo view: Source system not part of item sig (#5599)
Source system is not part of item signature but supplemental info for item.

Follow-up to #5514
2022-05-31 13:40:41 +02:00
Marc Bernard
bcf01fbfb0
Refactor: Create Tag (#5591)
* Refactor: Create Tag 

Replaces the old style page with a nice HTML form for creating a new tag.

* Update validation

* Allow empty comment and tagger

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-31 09:48:03 +02:00
Gregor Wolf
276ad4e808
Exclude technical language from intf, clas, prog, dtel, doma and tabl (#5598)
* exclude technical language from DOMA

* exclude technical language from DTEL

* exclude technical language from TABL

* exclude technical language from CLAS

* exclude technical language from PROG

* exclude technical language from INTF

* fix abaplint issue: Place pragma at end of statem.

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-05-30 12:18:32 +02:00
Christian Günter
5e7cf0b27e
LXE: Downport (#5597)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-30 10:12:26 +02:00
Fabian Lupa
cbaf3711b4
Exclude technical languages (#5601)
from get_installed_languages in lxe_texts
2022-05-29 14:50:28 +02:00
Marc Bernard
e149594dae
Refactor: is_active logic (#5557)
- Move `is_active` from `zcl_abapgit_objects_super` to `zcl_abapgit_objects_activation`
- Consolidate `is_ddic_type` logic
- Add unit tests for `zcl_abapgit_objects_activation`
2022-05-29 09:47:39 +02:00
Fabian Lupa
288e1008dd
Fix object deletions not working (#5594)
Package is now required for CLAS deletion for RS_CORR_INSERT but was not correctly determined for object deletions because of different field names when using MOVE-CORRESPONDING and another missing assignment.

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-05-28 16:52:33 +02:00
Gregor Wolf
143f7d4d3b
fix: exclude Translation Object Detective language for MSAG objects (#5596)
* fix: exclude Translation Object Detective language

Excludes Translation Object Detective language from serialization
Provides a solution for object type MSAG in issue #5595

* fix: Contains non 7 bit ascii character

* fix: exclude also Pseudo Translation

* refactoring based on the PR suggestion

* fix abaplint issues

* fix further abaplint issues
2022-05-28 12:00:15 +02:00
Marc Bernard
ddd7e47425
Refactor: Commit list popup (#5569)
* Refactor: Commit list popup

- Move popup for selecting a commit to `zcl_abapgit_popup`
- Allow to skip sorting of commits in `zcl_abapgit_git_commit` which often led to "too many commits" error (on GitHub you get the 300 most recent commits)

Popup will be used in `zcl_abapgit_gui_page_sett_remo` and `zcl_abapgit_gui_page_tags` (separate PR)

* Fix test classes

* Replace popup in remote settings

* Remove type

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-24 16:43:46 +02:00
Marc Bernard
ca5023c6d0
CLAS: Add to deletion transport (#5563)
Fix missing transport entry
2022-05-23 18:16:22 +02:00
Marc Bernard
5ae7f618f3
Repo view: Source system for packages/namespace (#5587)
Follow-up to #5514
2022-05-23 15:30:11 +02:00
Marc Bernard
1dd5ebcb42
Fix dump for repos using data tables (#5581)
* Fix dump for repos using data tables

Fixes dump in `zcl_abapgit_data_util` in case the data table does not exist yet.

* Method

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-23 13:50:44 +02:00
NicolasBusson
a8ecd8fb77
Fix dump ASSERTION_FAILED during table content deserialization (#5586)
* Data import: fix dump ITAB_DUPLICATE_KEY

System dumps during serialization of customizing table comprizing of include structures. Example: WCFC_GIL_COMPROP.

* Fix error "Object type TABU is not supported"

* Fix date format incorrect during serialization

* Fix /data/ serialization package issue

* Commit table content after deserialization

* Cleaning some code

* Rollback code change concerning /data/ folder

Doesn't seem to be necessary in the end...

* Renamed variable <tab> to <lt_tab>

* Fix ASSERTION_FAILED table content deserialization

Issue https://github.com/abapGit/abapGit/issues/5585

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-23 10:35:19 +02:00
github-actions[bot]
0e5e3b0cf5
ajson, Automatic Update (#5584) 2022-05-23 09:38:34 +02:00
Lars Hvam
2ffdab2526
Update ajson_mirror.yaml (#5583) 2022-05-23 09:13:59 +02:00
Marc Bernard
97631dd2fe
SICF: Display object name in upper case (#5547)
Align case of object name with other object types
2022-05-21 08:39:38 +02:00
Marc Bernard
7258fdc315
Repo view: Show icon for different source system (#5514)
In case an objects originates from a different system (`<> sy-sysid`), an icon will be shown after the object. On hover, you can see the id of the original system. 

Closes https://github.com/abapGit/abapGit/issues/3865
2022-05-21 08:13:41 +02:00
Marc Bernard
ba425e0318
Repo stats: don't count lines of ignored files (#5576)
Size and lines of code incorrectly included files that are ignored (outside of `/src/`).
2022-05-19 19:35:13 +02:00
Marc Bernard
3a27ff760f
Uninstall: Fix order for dependencies (#5559)
- Set order for uninstalling `WEBI`, `SPRX`, `IOBJ`, `ODSO`, and `PINF`
2022-05-19 11:03:58 +02:00
Marc Bernard
6a84341a27
PINF: Fix error when changing packages (#5560)
- Set parent package for package interface elements
- Raise error in case of mismatched packages
2022-05-19 10:47:15 +02:00
Marc Bernard
eaeba0f1cb
Fix syntax error in systems with BW (#5572)
abapGit should support systems without SAP_BW component. Therefore, references to BW data types have to be replaced by generic types and BW classes have to be replaced by dynamic calls.

Follow-up to #5556

Closes #5565
2022-05-18 22:10:38 +02:00
Marc Bernard
297708b054
Repo view: fix "order by transport" dump (#5571)
* Repo view: fix "order by transport"

Partly regression of #5323

Closes #5570

* Add flag

* Improve sort
2022-05-18 21:25:43 +02:00
Lars Hvam
9f048abeff
CHAR: take only serialize main language into accou (#5566)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-05-18 18:04:40 +02:00
Marc Bernard
6d2510c84e
Fix tag popup message (#5567)
Tag popup is used for delete and switch therefore the message must be moved to the switch method.
2022-05-18 17:54:15 +02:00
Marc Bernard
ee2c77e6af
Refactor: Email validation (#5568)
Move `is_valid_email` to utitlity class for reuse
2022-05-18 17:42:45 +02:00
Marc Bernard
38f99380da
FDT0: Add check of local/transportable apps (#5561)
It's not possible to import local apps into transportable packages or vice versa. The check raises corresponding error messages (and avoids a slew of cryptic errors you would get otherwise).

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-18 15:04:01 +02:00
Marc Bernard
1af60a9f42
SSFO: Avoid side-effect in is_active (#5564) 2022-05-18 14:37:53 +02:00
Christian Günter
722a954c43
Improve error message for language mismatch (#5544)
* Improve error message for language mismatch

* refactor

* refactor

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-17 13:31:25 +02:00
Marc Bernard
5802f0df37
CHDO: Fix deletion of TADIR entries (#5555)
Test mode needs to be set explicitly to false.
2022-05-16 08:26:18 +02:00