Commit Graph

43 Commits

Author SHA1 Message Date
Marc Bernard
c09cc67c83
Fix startup of repo view (#3831)
* Update error msg

* Fix login popup errors and cancelation

* Remove validate/reset methods

* Lint

* Rename iv_repo_online to io_repo_online

* Change to error in status bar

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-04 09:32:38 +02:00
Lars Hvam
9c41a2b7d8
remove text pragmas and pseudo comments (#3827)
* remove text pragmas and pseudo comments

* fix whitespace

* fix carriage return

* test

* test

* Update zcl_abapgit_repo.clas.abap
2020-09-03 09:13:47 +02:00
Alexander Tsybulsky
a4e6c87985
Switching to PRs (#3695)
* string map: public entries (read only)

* port http agent

* draft wip

* drafting

* fix SSL

* port ajson

* integrate ajson and http_agent

* agent global headers

* github enumerator

* update ajson

* draft wip

* enumerator factory

* http_agent via factory

* proxy

* repo->switch_origin draft

* refactor enum factory

* Revert "refactor enum factory"

This reverts commit bcfef40b38991adfe5f73677919db6bd0c652f7c.

* page wiring draft

* scripts draft

* "let it work!"

* repo setings page draft

* linter

* linter

* linter

* linter

* linter

* better settings page

* finetune page

* cleanups

* change hotkey

* fix ajson_error

* Update src/zcl_abapgit_repo_online.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* abaplint nesting 6

* remove description

* back to good old popups

* linter

* move commands to branches dropdown

* auth helpers

* move json to separate package

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-27 07:47:27 +02:00
Marc Bernard
af5b898a37
Refactor branch constants (#3784)
* Branch constants

* Refactor branch constants

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-24 11:25:46 +02:00
Marc Bernard
e4bafbe715
Validate if branch exists when displaying repo (#3749)
* Validate if branch exists when displaying repo

* Validate if branch exists when displaying repo

* Lint

* Lint and 702

* Lint

* Rename validate_branch to validate

* Fix msg and branch display name

* Move msg to UI layer

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-08-24 11:15:46 +02:00
Domi Bigl
20f93ff514
show last commit hash with link if possible (#3731)
* show last commit hash w/ link if possible

link to commit is supported for github.com and bitbucket.org

* remove inline data declaration

* add gitlab link support with UT

* add commit icon for non supported provider

* remove inline declaration

* remove new for CRETE OBJECT

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-13 15:41:45 +02:00
Marc Bernard
38099501b8
Improved validation of URLs (#3486)
* Limit URLs to http and https

* Validate URLs

* Raise error only for validation (not for get_name)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-14 20:14:39 +02:00
larshp
2d168e170b move stage structures to interface #3377 2020-05-21 07:25:54 +02:00
Lars Hvam
714fe7202d
whitespace fixes (#2964)
* whitespace fixes

* fix sql compare operators
2019-10-11 02:50:16 -07:00
Christian Guenter
f73e18d587 Online repo "display name" to overrule default name 2019-02-25 07:20:01 -08:00
larshp
ea40225d1c ZCL_ABAPGIT_REPO_ONLINE add testclass include
add testclass include in order to avoid evil dumps while upgrading/reset local
2019-02-24 09:25:50 +00:00
larshp
5b44d8e89b REPO, remove method RUN_CODE_INSPECTOR
the successful flag is now saved in code inspector class instead
2019-02-20 22:00:36 -08:00
larshp
82296484d4 allow changing remote and branch for write protect
allow changing remote and branch for write protected repos. In the old days changing remote and branch triggered a pull, this is decoupled, so there should be no changes to the local code when switching remote or branch
2019-02-07 03:08:39 -08:00
Lars Hvam
e8b6b0020d
Add interface for ZCL_ABAPGIT_PROGRESS #2303 (#2316)
* interface for progress class

* adjust branch overview

* adjust git pack

* adjust diff page

* adjust objects class

* adjust activation class

* adjust repo online class

* adjust serialize class

few methods moved

* adjust tadir class
2019-01-23 06:28:54 +01:00
sbcgua
c465a6b2e8 Offline improvements (#2156)
* local reset in zip-based

* rebuild_local_checksums on new offline
2018-11-28 07:19:27 +01:00
sbcgua
af86d5b969 Refactor repo class, part1 (#2096)
* repo refactoring

* repo refactoring - part 2

* review fixes

* more review fixes
2018-11-17 06:12:20 +01:00
larshp
7cdbbc92b6 remove some unreferenced variables 2018-11-08 16:35:08 +01:00
Frederik Hudák
1bb195b344 Removed the rest of endmethod/endclass comments 2018-10-18 07:27:27 +02:00
Johannes Konings
d25bfaf725 fix some naming conventions
https://github.com/larshp/abapGit/issues/1132
2018-08-17 09:24:22 +02:00
Lars Hvam
65657a831b
Change git PUSH and PULL methods to functional (#1803)
* remove branch list from PULL

* change git push and pull to functional methods
2018-08-08 14:59:16 +02:00
larshp
91a5e05546 diff still shows after pushing #1797 2018-08-08 07:15:33 +02:00
Lars Hvam
18573089e2
Refactor staging + git + online repo (#1769)
* change merge and staging

always push to the top of the currently selected branch

* remove branch and sha1 from stage object #365

* REPO not longer part of GIT_PORCELAIN

SET_OBJECTS moved to private

* and remove fields from constructor
2018-08-06 12:55:13 +02:00
larshp
02cccf6995 delete method set_new_remote in online repo
delete method set_new_remote in online repo

#1757
2018-08-05 13:12:36 +02:00
larshp
f77b798f4c Interface ZIF_ABAPGIT_GIT_OPERATIONS
Interface ZIF_ABAPGIT_GIT_OPERATIONS for git operations in repo online class
2018-08-05 13:05:08 +02:00
larshp
1d035cf1ab create_branch refactored 2018-08-05 12:47:54 +02:00
larshp
703b1022f5 separate repo from PULL 2018-08-05 12:17:34 +02:00
larshp
742f3e5e2c Sacrifice HEAD_BRANCH feature in repo
Sacrifice  HEAD_BRANCH feature in repo, suggest instead implementing a branch list cache later

#1757
2018-08-05 11:52:56 +02:00
larshp
48e5a247f2 Online: method INITIALIZE + RESET_STATUS to privat
Change methods INITIALIZE + RESET_STATUS to private in ZCL_ABAPGIT_REPO_ONLINE

One external call of INITIALIZE changed to use REFRESH instead

Part of refactoring for issue #1757
2018-08-05 11:28:50 +02:00
Christian Guenter
5d439e3699 Code inspector for offline repositories
Before this commit it wasn't possible to run code inspection
for offline repos. A dump occured.
With this commit it is possible to run code inspections
for offline repos, too.
2018-07-25 06:47:59 +02:00
Christian Guenter
bb82f2c8bd Refresh online repo: call BRANCH_LIST just once
Before this commit is applied BRANCH_LIST is called twice while
refreshing an online repo. This leads to two identical HTTP calls.
After this commit is applied BRANCH_LIST is only called once and
therefore only one HTTP request is sent.
2018-07-25 06:43:21 +02:00
larshp
640839ad0e Do not delete repo at pull error #1675
Some time ago, the repo was pulled immediately after creation, this has been changed, so we do not need this workaround anymore. Also see #843
2018-07-22 11:55:13 +02:00
Christian Günter
7ac8dc15b6 Remove local SHA1 from online repository #1485, #1509 (#1666)
* Remove local SHA1 from online repository

In this commit we remove the local SHA1 and all its references from
ZCL_ABAPGIT_REPO_ONLINE. SHA1 is also removed from repo persistency.
SHA1 insn't needed anymore. All where-used places were either migrated to
remote_SHA1 or removed.

* reintroduce logic after push
2018-07-22 10:11:09 +02:00
Christian Guenter
10b29556f7 fix bug in run_code_inspection 2018-06-28 13:47:07 +00:00
christianguenter2
ea798193d0 Block commit/push if code inspection has errors
- new local setting to set check variant
- new local setting to block pull if code inspector check fails
- check is executed before staging
- new page to display code inspector results
2018-06-28 13:21:29 +02:00
larshp
4e67e884de first dependency injection #1390
* extract public methods of ZCL_ABAPGIT_TADIR to new interface
* create factory ZCL_ABAPGIT_FACTORY
* refactor existing calls
2018-06-10 12:11:48 +00:00
Christian Guenter
41d09125d4 set new remote: supply remote SHA1 2018-06-07 11:01:56 +02:00
Christian Guenter
582a3ab02a refactor transport popup 2018-05-08 19:09:30 +02:00
Lars Hvam
7152b4281a
Refactoring (#1279)
* URL: rename and add validation method

plus validate url in NEW_ONLINE

* optimize select

* move write protection check

* start refactoring gui away from deserializati/pull

* mvoe ZCL_ABAPGIT_SERVICES_ABAPGIT to UI

* delete ZCL_ABAPGIT_SERVICES_BKG

moved to GUI page

* move ZCL_ABAPGIT_SERVICES_GIT to UI

* move ZCL_ABAPGIT_SERVICES_REPO to UI

* fix indentation

* overwrite popup refactored to UI
2018-03-29 14:29:03 +02:00
Lars Hvam
b9cc65017f
Code inspector (#1272)
* code inspector

+ delete unused methods
+ move methods to private
+ remove commented code

* few more
2018-03-28 08:08:20 +02:00
Lars Hvam
f17985b27e
Add option for "Only local objects", issue 1260 (#1268)
* refactor write protect and ignore subpackages

to local settings structure, this makes it a lot easier to exetend, plus adds structure

* delete method GET_MASTER_LANGUAGE

* add local settings to repo settings page

* add setting for only local objects #1260
2018-03-26 12:23:01 +02:00
Lars Hvam
59c1f277ab
more renaming #1132 (#1212)
* more renaming #1132

* fix indentation
2018-02-18 10:04:26 +01:00
Lars Hvam
68d0571516
More classes to global (#1209)
* lcl_background to global

* lcl_branch_overview to global

* lcl_services_git to global

* lcl_services_repo and lcl_services_db to global

* lcl_services_abapgit to global

* lcl_gui_chunk_lib to global

* lcl_gui_view_tutorial to global

* lif_auth to global

* lcl_auth and lcl_gui_view_repo to global

* lcl_view_repo

* lcl_gui_page_syntax to global

* 2 pages to global

* refactor router, less dynamic references

* background pages to global

* branch overview to global

* settings page to global

* repo settings page to global

* explore page to global

* diff page to global

* debug info to global

* main page to global

* refactor router, no dynamic references

* db pages to global

* router to global

* gui to global

* clean up includes

* move type definnition to interface

to avoid syntax error after abapmerge

* move types to interface

* move types to interface

* rename tyep

* move type

* move types

* move type
2018-02-17 12:40:54 +01:00
Lars Hvam
18ea5d637c
lcl_repo (#1205)
* lcl_repo and more to global

* cleanup includes

* fix indentation
2018-02-15 15:10:13 +01:00