Commit Graph

44 Commits

Author SHA1 Message Date
Lars Hvam
4e96acd4be
use HEAD symref as default branch (#3983)
* use HEAD symref as default branch

closes #3974

* autodetect
2020-10-07 08:59:30 +02:00
Marc Bernard
9672f5b030
Adjust name prefix for types (#3991)
* Part 1

* Part 2

* Part 3

* Lint

* Part 5

* Part 6

* Part 7

* Part 8

* Part 9

* Enforce type naming prefix

All types need to start with TY_...

* Fix local types
2020-10-07 08:54:15 +02:00
Marc Bernard
25774396e6
Dialogs: add offline repo HTML form (#3960)
* Dialogs: add offline repo HTML form

* Dialogs: add offline repo HTML form

* Dialogs: add offline repo HTML form

* Lint

* Lint

* Chaining

* Set required attribute

* Check for empty display name

* Change validation

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-03 10:18:45 +02:00
Marc Bernard
af5b898a37
Refactor branch constants (#3784)
* Branch constants

* Refactor branch constants

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-24 11:25:46 +02:00
Lars Hvam
f878f3b4c3
remove some double spaces (#3740) 2020-08-16 08:24:12 +02:00
antonioyanez
a98ba1dfe1
fix bug of ignore subpackages flag (#3715)
Closes #3712
2020-08-06 11:53:58 +02:00
Marc Bernard
3a48d01201
Remove repo from favorites at delete/purge (#3641)
Closes https://github.com/larshp/abapGit/issues/3640
2020-07-16 08:38:32 +02:00
Alexander Tsybulsky
f5dfd328f5
Dialogs: add online repo HTML form (#3533)
* first draft

* progress ...

* html->create()

* more progress

* and more

* getting closer

* wiring

* refactor popup_search_help

* refactor create_package to services

* fix services->new_online after rebase

* linter fixes

* more linter fixes

* straing map util

* error handling

* submits for side actions (ugly ... but ...)

* cleanups

* linter fixes

* refactor form values logic

* linter fix

* review fixes

* remove unused var after rebase

* review fixes, better side action layout

* linter fix

* minor css tweaks
2020-07-01 08:16:52 +02:00
Marc Bernard
09120cb80d
+On/offline: If package already in other repo, nav to repo (#3525)
* New method to get repo from package

If package already exists in a repo and it returns the repo and reason why the package can't be used in a new repo

* UI: If package exists in repo, nav to repo

+Online, +Offline - if repo is already versioned, navigate to repo and show message why package could not be used in new repo

Closes https://github.com/larshp/abapGit/issues/3452

Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-06-20 14:32:00 +02:00
Marc Bernard
6d0861a7bd
Fix "repo not found" error (#3416)
Fix for https://github.com/larshp/abapGit/issues/2938

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-27 15:06:52 +02:00
Frederik Hudák
657405433d
Add master language setting to new repo popups (#3409)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-26 06:29:31 +02:00
Jaime Rodriguez Capote
543114963f
abapOpenCheck - Naming Conventions revision #3239 (#3240)
* abapOpenChecks config file

* Ignore SCI config folder

* checks revision

* Revert "checks revision"

This reverts commit 56a12289df.

* Renaming non-constants

Pending:

* Remove SCI configuration

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-09 17:34:26 +01:00
Lars Hvam
e201bf566f
remove class prefixes if its current class (#3137)
* remove class prefixes if its current class

* Update abaplint.json
2020-01-06 13:20:19 +01:00
g-back
033b32de7d Repository-Validation: More specific Error Message (#2965)
* add additional read to better specifiy error msg

issue #2914

* add line break in error message
2019-10-15 22:23:23 -07:00
CASAG-MariusRaht
9ad8973ab6 #2725 (#2907)
* #2725

> Bottom logo is now clickable and links to the repository page on GitHub
> New menu item 'Changelog' under 'Help' which links to the changelog.txt

Special Notes: 
> Link to documentation was already implemented
> Link for menu item 'Tutorials' isn't linked to anything. But that seems to be right, because there isn't a tutorial site separated from the documentation website

* abaplint: Normalization

* Update zcl_abapgit_services_abapgit.clas.abap

* Update zcl_abapgit_services_abapgit.clas.abap

* abaplint: fix max line length error

* abaplint

* Removed "|{}|"
2019-09-15 01:09:27 -07:00
larshp
2db46137fc #2783, update error description 2019-07-14 23:31:33 -07:00
Srinivasu Reddy
2f43ee4591 Changes to compare operators to align code 2019-05-24 06:50:15 -07:00
Jakub Filak
77cea9c92a New repo with Folder Logic and Ignore Sub-packages params (#2561)
* repo: do not validate sub-packages when ignored

In our landscape, we often need to version a package which has
sub-packages and those sub-packages have own repositories - the super
package provides framework and the sub-packages provides production
functionality.

When adding a new repository for these "framework" super-packages,
we need want to configure "Ignore sub-packages" because they are
already versioned in standalone repositories.

We also need to turn of the sub-package repo package check which is done
by this patch.

Dependency of #2395

* repo: allow creating with folder logic and ignore package

I need to enable users to add a new online repo with ignored
sub-packages and PREFIX folder logic because we often deal with
framework + implementations packages hierarchies.

Dependency of #2395

* repo: add folder logic and ign. sub.pkg to the new repo popup

This patch adds the parameters Folder logic and Ignore subpackages to
the new online repo popup to help us deal with old package which do not
follow the prefix approach for subpackages and to allow us to version
superpackages (which are shared by many developers) in separate
repositories.

I am not sure how to add a check-box to the popup window. I think I need
to find the right table with the righ column of the type char(1).

Closes #2395
2019-03-22 05:50:46 -07:00
Jakub Filak
903b794aa2 ux: help users to get that package is versioned
I was approached by a colleague of mine who was not sure how to deal
with the message:

- 'Package $FOO_BAR already in use'

I thought it was caused by the fact that some super or sub-package was
already watched by abapgit but whenI found the message in source codes I
figured out that there is already a repo for that package.

This patch should make the message easier to understand, so the new
version is:

- 'Package $FOO_BAR already versioned as FOO by DEVELOPER'
2019-03-16 03:52:17 -07:00
larshp
c93998abe0 Add auth check exit for repo creation 2019-03-14 10:45:38 +01:00
Christian Guenter
f73e18d587 Online repo "display name" to overrule default name 2019-02-25 07:20:01 -08:00
Lars Hvam
cb4479b95b
Cleanup (#2361)
* pretty print

* move identical code outside IF

* remove space before .

* remove unreferenced variables

* remove unreferenced variables

* remove unreferenced variables

* fix pseudo comment

* remove unreferenced field symbols
2019-02-04 23:08:29 -08:00
Christian Guenter
ad7809e4f2 Offline repo: Folder logic in create popup 2019-01-28 00:57:50 -08:00
larshp
e0841e3bec indentation and se80 reorderings
no logic changes
2018-12-26 06:35:55 +01:00
sbcgua
e809df8384 repo->set refactoring, disconnect repo from persistence (#2164)
* 1st attempt (events)

* temp stash

* split persistence and repo, beta

* fix

* fix2

* fix3

* linter fixes

* review fixes
2018-12-02 09:10:55 +01:00
Frederik Hudák
1bb195b344 Removed the rest of endmethod/endclass comments 2018-10-18 07:27:27 +02:00
Lars Hvam
fa39fcd43f
Code inspector fixes (#1997)
* pretty print

* definitions to top of routine

* space before .

* omit parameter names where possible

* double space after if

* remove pseudo comments where possible
2018-10-12 07:56:27 +02:00
Jakub Filak
6f6338bc67 repo: skip missing packages in new repo validation
When we try to add a new online repository and we have a repository
whose package does not exist in abapGit we get a short dump caused
by assert in the method zif_abapgit_sap_package~read_parent of
the class zcl_abapgit_sap_pacakge.

This commit makes sure we skip such repositories because we believe it
does not make sense to prevent us from cloning in these cases.

Thank you Petr Benes <petr.benes@sap.com>!
2018-08-10 07:02:46 +02:00
larshp
273947240c interface and factory for persist_repo 2018-08-10 07:02:30 +02:00
larshp
1f75651f90 validate packages: ignore sub packages if set
validate packages: ignore sub packages if set #1779
2018-08-07 09:31:45 +02:00
larshp
48e5a247f2 Online: method INITIALIZE + RESET_STATUS to privat
Change methods INITIALIZE + RESET_STATUS to private in ZCL_ABAPGIT_REPO_ONLINE

One external call of INITIALIZE changed to use REFRESH instead

Part of refactoring for issue #1757
2018-08-05 11:28:50 +02:00
Christian Günter
7ac8dc15b6 Remove local SHA1 from online repository #1485, #1509 (#1666)
* Remove local SHA1 from online repository

In this commit we remove the local SHA1 and all its references from
ZCL_ABAPGIT_REPO_ONLINE. SHA1 is also removed from repo persistency.
SHA1 insn't needed anymore. All where-used places were either migrated to
remote_SHA1 or removed.

* reintroduce logic after push
2018-07-22 10:11:09 +02:00
Christian Günter
4f9f47cd59 Set transport request if needed during uninstall or reset local (#1596)
* delete checks: set transport request if needed

this ensures that the transport request is set when deleting objects.
E.g. uninstalling the repositoy or reset local.

* separate type for delete checks
2018-07-11 16:18:08 +02:00
COPAT
e3676de797 validate sub and super packages from repos
validate sub and super packages from repos
2018-07-05 23:35:29 +02:00
Lars Hvam
b71b96fc9f
Merge pull request #1496 from larshp/repo_srv
interface for ZCL_ABAPGIT_REPO_SRV
2018-06-14 06:27:51 +02:00
larshp
45aa71f2da interface for ZCL_ABAPGIT_REPO_SRV 2018-06-13 17:28:56 +02:00
larshp
4e67e884de first dependency injection #1390
* extract public methods of ZCL_ABAPGIT_TADIR to new interface
* create factory ZCL_ABAPGIT_FACTORY
* refactor existing calls
2018-06-10 12:11:48 +00:00
Lars Hvam
e2b430779d
clone without pull #832 (#1371)
* create online without pull #832

* update tutorial

* fix indentation
2018-05-11 10:14:51 +02:00
Lars Hvam
7a9bec815a
Seperate UI and logic (#1286)
* no activation popup in background

* purge: seperate ui and logic

* order by primary key
2018-03-30 12:28:00 +02:00
Lars Hvam
7152b4281a
Refactoring (#1279)
* URL: rename and add validation method

plus validate url in NEW_ONLINE

* optimize select

* move write protection check

* start refactoring gui away from deserializati/pull

* mvoe ZCL_ABAPGIT_SERVICES_ABAPGIT to UI

* delete ZCL_ABAPGIT_SERVICES_BKG

moved to GUI page

* move ZCL_ABAPGIT_SERVICES_GIT to UI

* move ZCL_ABAPGIT_SERVICES_REPO to UI

* fix indentation

* overwrite popup refactored to UI
2018-03-29 14:29:03 +02:00
Lars Hvam
b9cc65017f
Code inspector (#1272)
* code inspector

+ delete unused methods
+ move methods to private
+ remove commented code

* few more
2018-03-28 08:08:20 +02:00
Lars Hvam
59c1f277ab
more renaming #1132 (#1212)
* more renaming #1132

* fix indentation
2018-02-18 10:04:26 +01:00
Lars Hvam
68d0571516
More classes to global (#1209)
* lcl_background to global

* lcl_branch_overview to global

* lcl_services_git to global

* lcl_services_repo and lcl_services_db to global

* lcl_services_abapgit to global

* lcl_gui_chunk_lib to global

* lcl_gui_view_tutorial to global

* lif_auth to global

* lcl_auth and lcl_gui_view_repo to global

* lcl_view_repo

* lcl_gui_page_syntax to global

* 2 pages to global

* refactor router, less dynamic references

* background pages to global

* branch overview to global

* settings page to global

* repo settings page to global

* explore page to global

* diff page to global

* debug info to global

* main page to global

* refactor router, no dynamic references

* db pages to global

* router to global

* gui to global

* clean up includes

* move type definnition to interface

to avoid syntax error after abapmerge

* move types to interface

* move types to interface

* rename tyep

* move type

* move types

* move type
2018-02-17 12:40:54 +01:00
Lars Hvam
18ea5d637c
lcl_repo (#1205)
* lcl_repo and more to global

* cleanup includes

* fix indentation
2018-02-15 15:10:13 +01:00