SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-04 05:47:17 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
3,410 Commits 4 Branches 39 Tags 53 MiB
53dd60c07b
Commit Graph

253 Commits

Author SHA1 Message Date
Lars Hvam
d0a721b2cf
Move methods to private (#2416) 
* ZCL_ABAPGIT_GUI_CHUNK_LIB move 2 methods private

* HTML_ACTION_UTILS move two methods private

* move calculate_skip_testclass to private

* move BUILD_ASX_NODE to private
 2019-02-18 05:27:49 -08:00
Mattias Johansson
add9450d37 Ignore files not in local repo (#2404) 
* Changed default text in branch popup

* Downgrade to Abap 7.02 syntax

* Reduce line length of commit (for abaplint)

* Ignore files that are not in local repo

Ignore files that are not in local repo when doing transport to branch

* Changed line indent

* More indentation fixes
 2019-02-15 06:52:36 -08:00
larshp
426f815bee downport #2389 2019-02-14 21:10:07 -08:00
larshp
5018eae46c refactor public attributes #2369 
refactor public attributes #2369
 2019-02-09 23:28:22 -08:00
Lars Hvam
cb4479b95b
Cleanup (#2361) 
* pretty print

* move identical code outside IF

* remove space before .

* remove unreferenced variables

* remove unreferenced variables

* remove unreferenced variables

* fix pseudo comment

* remove unreferenced field symbols
 2019-02-04 23:08:29 -08:00
Mattias Johansson
0467707a5b Changed default text in branch popup (#2344) 
* Changed default text in branch popup

* Downgrade to Abap 7.02 syntax

* Reduce line length of commit (for abaplint)
 2019-02-02 03:52:14 -08:00
Christian Guenter
ad7809e4f2 Offline repo: Folder logic in create popup 2019-01-28 00:57:50 -08:00
Lars Hvam
e8b6b0020d
Add interface for ZCL_ABAPGIT_PROGRESS #2303 (#2316) 
* interface for progress class

* adjust branch overview

* adjust git pack

* adjust diff page

* adjust objects class

* adjust activation class

* adjust repo online class

* adjust serialize class

few methods moved

* adjust tadir class
 2019-01-23 06:28:54 +01:00
Lars Hvam
1a60384e84
move method get_unnecessary_local_objs #2127 (#2315) 
* move method get_unnecessary_local_objs #2127

move method get_unnecessary_local_objs #2127

* interface for progress class

* oops, rollback previous commit
 2019-01-23 06:27:29 +01:00
Lars Hvam
3f494f091f
Use built-in types (#2306) 
* remove uses of DTEL BOOLEAN

* remove uses of DTEL BOOLE_D

* remove uses of DTEL FLAG

* remove uses of DTEL SAP_BOOL

* remove uses of DTEL XFELD

* Update zcl_abapgit_popups.clas.abap
 2019-01-20 07:59:24 +01:00
Lars Hvam
ba9968123f
limit shown code inspector findings #2271 (#2307) 
* codi_base will now render the full list

* limit list to show first 500
 2019-01-20 07:51:41 +01:00
Christian Guenter
4b96b7469d Check if package exists before pack.create popup 2019-01-18 07:06:33 +01:00
Christian Guenter
1913b7eaeb AdHoc code inspection: ask user for check variant 2019-01-16 09:33:13 +01:00
Christian Guenter
67068136e1 UI: Replace 'Overwrite object' popup with sellist 2019-01-13 07:29:01 +01:00
Christian Guenter
0b36ce0c88 move js and css to UI 2019-01-13 07:23:07 +01:00
Domi Bigl
cb15695570 switch to css class mega-octicon for HiDPI #2275 (#2276) 
* switch to css class mega-octicon for HiDPI

* change css repo overview icon
 2019-01-12 10:24:11 +01:00
sambarza
2fc8087de1 In the popup for the creation of a new offline project the OK button is missing or better is there but without a text, it's a quite difficult to find it ;-) 
Fixed with label "OK"
 2019-01-03 06:36:34 +01:00
Christian Guenter
20be1e7eef Page branch overview: skip orphaned commits 2019-01-03 06:36:00 +01:00
sbcgua
95b8120ef0 Repo overview UX/design (#2245) 
* reorderings

* moving around disarranged tags

* draft

* toggleDetail js and tuning

* remove unnecessary firstrow

* tunings
 2018-12-31 06:30:53 +01:00
sbcgua
60bf29dd38 refactor zcl_abapgit_zip (#2241) 
* zip->load

* remove import and file_upload

* linter fix

* minor fix
 2018-12-30 08:06:16 +01:00
pokrakam
d3e75796ab Fix #2171 - removed dependency on field order (#2226) 
* Fix #2171 - removed dependency on field order

* Fix #2171 - removed dependency on field order
 2018-12-26 06:36:16 +01:00
larshp
6385caade6 fix whitespace and other minor changes 2018-12-20 09:23:01 +01:00
Lars Hvam
5f9df74463
reduce method length, #2146 (#2212) 
* TRAN: refactor method SPLIT_PARAMETERS

new method SHIFT_PARAM added

* settings page: refactoring

rename BUILD_SETTINGS to POST
split contents into smaller methods
 2018-12-20 09:22:33 +01:00
larshp
d838dce879 align test class naming #2210 2018-12-20 09:21:11 +01:00
Eduardo Ferrari Copat
d47027ad6c Remove redundant class and interface metadata (#2195) 
* Remove CLSFINAL from VSEOCLASS serialization

* Remove EXPOSURE from VSEOCLASS serialization

* Remove clsabstrct from VSEOCLASS serialization

* Remove EXPOSURE from VSEOINTERF serialization

* Revert "Remove EXPOSURE from VSEOINTERF serialization"

This reverts commit 4036b7d015.
 2018-12-12 14:31:42 +01:00
Christian Guenter
729c009747 Fix: Stage > Patch ignore binary files 2018-12-12 13:11:16 +01:00
Christian Günter
d6c063090d Branch overview: show commit details when hover #1821 (#2190) 
* Branch overview: show commit details when hover

* update external libraries to gitgraph 1.14.0

* refactor function names

* refactor js + add comments
 2018-12-09 07:51:21 +01:00
Alexander Tsybulsky
66c3d0c0b7 zcl_abapgit_string_utils 2018-12-09 07:50:34 +01:00
Alexander Tsybulsky
806b474851 zip matching banner 2018-12-09 07:49:26 +01:00
sbcgua
4dee27fc1e Gui internals refactoring (#2180) 
* GUI internals refactoring

* unify string conversion calls part1
 2018-12-04 06:33:35 +01:00
Christian Guenter
746b114223 Initialize ADT context after start with package 
- Open abapGit with package from ADT just once
- Initialzie ADT context because it is kept in shared memory
 2018-12-03 12:46:43 +01:00
Christian Guenter
0c1a8f745a Package parameter for ADT 2018-12-02 12:14:58 +01:00
sbcgua
e809df8384 repo->set refactoring, disconnect repo from persistence (#2164) 
* 1st attempt (events)

* temp stash

* split persistence and repo, beta

* fix

* fix2

* fix3

* linter fixes

* review fixes
 2018-12-02 09:10:55 +01:00
Christian Guenter
f2970abc2a Set start repo from package: Downport 2018-12-02 09:02:40 +01:00
Christian Günter
a708f18840 Start abapGit with package and open the #2160 (#2165) 
* Start abapGit with package and open the repo

Set parameter 'PACKAGE' to start abapGit for a package

* Fix whitespace + exit loop
 2018-11-30 07:10:45 +01:00
Christian Günter
b3996f2cfa Fix abapGit repo existence check 
Before this commit is applied forked abapGit repos aren't recognized
 2018-11-29 06:28:21 +01:00
sbcgua
c465a6b2e8 Offline improvements (#2156) 
* local reset in zip-based

* rebuild_local_checksums on new offline
 2018-11-28 07:19:27 +01:00
sbcgua
48bb8be737 hotkeys in fixed position 2018-11-28 07:18:03 +01:00
Alexander Tsybulsky
8966f493c9 transport icon improvement 2018-11-28 07:17:41 +01:00
Christian Guenter
505cda20ee Reset sy-langu after open repo in master language 2018-11-28 07:17:29 +01:00
larshp
d68e4e6d4e fix dump regarding hotkeys #2157 2018-11-27 12:26:21 +01:00
sbcgua
299ff5d9d5 Hotkey improvements (#2143) 
* hotkey improvements

* linter fixes
 2018-11-26 18:27:48 +01:00
Lars Hvam
f3702fc5a4
router: refactor on_event to multiple methods (#2140) 
* router: refactor on_event to multiple methods

* bugfix
 2018-11-25 07:12:43 +01:00
Fabian Lupa
2a2b30d6eb Backport "open in master language" 
#2132
 2018-11-23 16:35:57 +01:00
larshp
158d54aceb pretty print: keywords upper case 2018-11-23 12:17:00 +01:00
Alexander Tsybulsky
558ece49c5 2-step zip import 2018-11-23 05:57:42 +01:00
larshp
378e3e0ca1 fix staging screen columns #2120 2018-11-22 05:08:09 +01:00
Christian Günter
b96abd8eb4 New repo option 'Open in master language' #2105 (#2117) 
* New repo option 'Open in master language'

* Replace sy-langu + conversion exit

* Fix lint error

* Add Success message
 2018-11-22 05:06:36 +01:00
sbcgua
af86d5b969 Refactor repo class, part1 (#2096) 
* repo refactoring

* repo refactoring - part 2

* review fixes

* more review fixes
 2018-11-17 06:12:20 +01:00
larshp
aae099b93d naming conventions 2018-11-11 17:45:12 +01:00
Christian Guenter
7f312f8634 Patch: fix regression 2018-11-10 08:09:40 +01:00
larshp
9270a58b62 cleanup unreference variables 2018-11-09 11:55:47 +01:00
larshp
02a5c78e2c IS REQUESTED is obsolete 2018-11-09 05:37:02 +01:00
Fabian Lupa
b08ee6a498 CTS integration (#2061) 
* Implement facade for Change Transport System

* Render lock item in VIEW_REPO

* Add jump to SE01

* Display transport on stage page

* Optimize transport read on stage page

* Error handling CTS

* Fix indentation

* Disable transport column for local packages

* Code review changes
 2018-11-09 05:36:44 +01:00
larshp
7cdbbc92b6 remove some unreferenced variables 2018-11-08 16:35:08 +01:00
Lars Hvam
06616580eb
Naming conventions (#2059) 
* fix naming conventions

* naming conventions
 2018-11-07 12:50:20 +01:00
Lars Hvam
89e5010fd0
Naming conventions fixes, #2053 (#2058) 
* fix more naming conventions

* more naming conventions fixes
 2018-11-07 12:05:27 +01:00
larshp
788a7fedb9 naming conventions #2053 2018-11-07 09:00:12 +01:00
Christian Guenter
45a2ba1cd1 add factory for GUI_IS_AVAILABLE 
This commit adds an indirection for function module GUI_IS_AVAILABLE
via interface ZIF_ABAPGIT_GUI_FUNCTIONS and factory ZCL_ABAPGIT_UI_FACTORY.

For tests the implementation can be replaced with
ZCL_ABAPGIT_UI_INJECTOR=>SET_GUI_FUNCTIONS
 2018-11-03 08:42:32 +01:00
Domi Bigl
cf05295170 mark inactive objects in repo list #1943 (#2017) 
* mark inactive objects in repo list

Inactive object are marked in the repo list
The sort order for changed files is not changed
unchanged inactive files come right after the changed files

* move acitve check to object interface

* add is_active for objects up to F

* add is_active for objects up to P

* add is_active for objects up to T

* add is_active for objects up to X

all core object implement (except SSFO) the standard active check via FM RS_INACTIVE_OBJECTS_WARNING now

* add is_active to plugins bridge - always active

* finish object interface implementation + objects

* add is_active for offline with object interface

* rename returning to RV_

* use returning for serialize

* cleanup, PP, UT
 2018-10-31 15:54:57 +01:00
Frederik Hudák
1bb195b344 Removed the rest of endmethod/endclass comments 2018-10-18 07:27:27 +02:00
Lars Hvam
fa39fcd43f
Code inspector fixes (#1997) 
* pretty print

* definitions to top of routine

* space before .

* omit parameter names where possible

* double space after if

* remove pseudo comments where possible
 2018-10-12 07:56:27 +02:00
Alexander Tsybulsky
7be37d4acd Fix diff colors for MM state #1991 2018-10-11 10:16:36 +02:00
Lars Hvam
f8075e77d7
add missing spaces (#1984) 
* add missing spaces

* plus change the approach for this unit test
 2018-10-02 16:08:43 +02:00
Domi Bigl
246b943b87 hide current branch and HEAD in delete popup #1908 (#1961) 
* hide current branch and HEAD in delete popup

* refactoring and cleanup

* hide also HEAD symref

* throw  branch delete refused
 2018-09-29 08:53:55 +02:00
Lars Hvam
10ea325ca8
interface for zcl_abapgit_stage_logic #1955 (#1956) 
* interface for zcl_abapgit_stage_logic #1955

* factory, fix injection
 2018-09-27 15:03:29 +02:00
Marcello Urbani
eb34b7eeec Share output and event handler for code inspector 2018-09-25 16:23:07 +02:00
Christian Guenter
2b4ff9529b Page Stage: Preserve filter value 
On page stage the filter value is preserved while navigating
to diff or commit page and navigate back.
 2018-09-21 09:20:36 +02:00
Domi Bigl
529bfc478e add handling of deleted branches in branchoverview (#1928) 
* add handling of deleted branches in branchoverview

also display deleted branches in branch overview but w/o a branch name

* PP #1823
 2018-09-21 09:12:38 +02:00
Domi Bigl
f61eb50dbf Code inspector results do not respect 'Jump to ADT first' setting #1892 (#1903) 
* enable ADT jump from CI result

* enable ADT jump from CI result for all objects

* cleanup + PP

* cleanup + PP + save/activate in ADT

* remove commented code
 2018-09-16 10:05:38 +02:00
Domi Bigl
29ce3e8170 handle abapgit_home in CI page 2018-09-10 16:12:00 +02:00
Christian Günter
0fa50309a1 Staging smaller chunks of code like git add -p (#1842) 
* Staging smaller chunks of code like git add -p

With this commit a new feature which works similar to git add -p
is added. We are now able to patch, which means that we can
commit on line basis. And are not restricted anymore to commit
only on file basis.

* move get_page_patch to stage page

* Refactor JS

* Refactor JS
 2018-09-08 08:58:25 +02:00
Domi Bigl
93c518a142 Branch OV - Sort by parents instead of time + PP #577 (#1890) 
* Branch OV - Sort by parents instead of time #577

* Branch OV - Sort by parents PP #577
 2018-09-08 08:30:42 +02:00
Christian Guenter
2fa5ba0dcf UI: Change repo urls to hyperlinks 
This commit changes the repo urls on the main and overview
pages to hyperlinks.
 2018-08-29 12:35:49 +02:00
Christian Guenter
f167adecd2 Fix layout in merge mode 2018-08-28 08:30:23 +02:00
Eduardo Ferrari Copat
de90a9c1b8 Fixes #1229: Enable SAP GUI for Java settings (#1865) 
* Insert initial line before bothsequence and action

* Change settings boolean read to support Java GUI

Standard netweaver and Java GUI netweaver parse differently the checkboxes on HTML pages. This commit consider the value on the checkbox aseither "on" or "X".
 2018-08-27 10:04:40 +02:00
Christian Guenter
97c40c8f8f Fix: Impossible to save a dummy variant for backgr 2018-08-22 06:30:48 +02:00
Christian Guenter
491306ff41 Fix: hotkey overview close key dynamically 2018-08-20 18:27:04 +02:00
Christian Guenter
98cae2c9fd Introduce global hotkeys 
With this commit we are able to define global hotkeys. Which means
that the hotkey is active on all pages. The global hotkeys are
defined in ZCL_ABAPGIT_GUI_PAGE=>GET_HOTKEY_ACTIONS. The first
globally defined hotkey is the hotkey overview with the default
hotkey '?' assigned to it. This was previously hard coded in the js.
 2018-08-18 06:57:25 +02:00
Christian Günter
f46e1e1c59 Fix close hotkey overview popup #1833 (#1835) 
* Fix close hotkey overview popup

* Add text how to close hotskeys overview
 2018-08-17 13:34:09 +02:00
Christian Guenter
d329a2d69f Add switch branch hotkey 2018-08-17 10:47:43 +02:00
Christian Guenter
f0415a22fd More hotkeys 
More on page main and code inspector,
plus changed default for settings.
 2018-08-17 09:55:09 +02:00
Christian Guenter
e699e7b0c9 Offline repo: make name obligatory 2018-08-17 09:26:55 +02:00
Christian Guenter
5c2a646809 Hotkey overview 
After this commit is applied one can open the hotkey overview
with '?'.
 2018-08-17 09:26:12 +02:00
Johannes Konings
d25bfaf725 fix some naming conventions 
https://github.com/larshp/abapGit/issues/1132
 2018-08-17 09:24:22 +02:00
Johannes Konings
c3691622ed fix some naming conventions 
https://github.com/larshp/abapGit/issues/1132
 2018-08-16 06:32:19 +02:00
Christian Günter
fc1df4b9ee Introduce customizable hotkeys #1728 (#1820) 
* Introduce customizable hotkeys

With this commit customizable hotkeys are introduced. They can
be defined in the user specific settings. Currently we support
only one letter keybindigs e.g. 's', 't' or 'x' and no modifiers.

Every page in the UI can decide which actions it offers for the
hotkeys. Therefore we introduce the interface ZIF_ABAPGIT_GUI_PAGE_HOTKEY
with the method GET_HOTKEY_ACTIONS. At this point in time only
the main page offers actions for hotkeys, but the mechanism works
already for all pages. New actions for hotkeys can be defined
easily.

Hotkeys are only available for installed abapGit repositories.
Because we need to detect the classes which implement the above
mentioned interface and it seems that there is no easy way to do
that for local classes. Maybe we can add it later when we know more.

We don't supply default key bindings. So it is totally up to the
user to define them.

* provide default hotkeys
 2018-08-16 06:32:03 +02:00
larshp
6044d3e7b2 move PERSIST_USER behind interface 
move PERSIST_USER behind interface

will be moved to instantiate via factory in follow up PR
 2018-08-13 18:34:28 +02:00
Lars Hvam
1dbc2195f8
update gitgraph to latest (#1814) 
* update gitgraph to latest

* docs: dependencies, update gitgraph to latest
 2018-08-13 18:33:45 +02:00
larshp
273947240c interface and factory for persist_repo 2018-08-10 07:02:30 +02:00
larshp
e9a2d30950 optimize ZCL_ABAPGIT_GUI_PAGE_STAGE 
optimize performance in ZCL_ABAPGIT_GUI_PAGE_STAGE, it will now only find changed_by once per item instead of per file #1794
 2018-08-09 07:28:25 +02:00
larshp
e49b404b58 delete some unreferenced variables 2018-08-07 16:01:29 +02:00
Christian Guenter
0fa4ed299e downport 702 2018-08-07 10:26:57 +02:00
Johannes Konings
8e556701c3 New online popup, fix descriptions #1752 
https://github.com/larshp/abapGit/issues/1752
 2018-08-06 20:06:17 +02:00
larshp
f0fb0f0470 TADIR performance 
TADIR performance #1756

All usages of TADIR aligned to use the same structure. 
DELFLAG added in the structure.
2 identical structure definitions deleted.

todo: test this PR works after abapmerge has run
 2018-08-06 15:39:15 +02:00
Christian Günter
400846e036 Downport method call chains to 702 + IF_OO_SOURCE_POS_INDEX_HELPER #1775 (#1776) 
* Downport method call chains to 702 + IF_OO_SOURCE_POS_INDEX_HELPER

* catch exception if interfaces doesn't exist

Catch exception if IF_OO_SOURCE_POS_INDEX_HELPER doesn't exist
 2018-08-06 15:11:40 +02:00
Johannes Konings
6ddd20e2b5 fix some naming convention #1132 (#1771) 
* fix some naming convention

https://github.com/larshp/abapGit/issues/1132

* fix abaplint Reduce line length

https://github.com/larshp/abapGit/pull/1771
 2018-08-06 13:10:03 +02:00
Lars Hvam
18573089e2
Refactor staging + git + online repo (#1769) 
* change merge and staging

always push to the top of the currently selected branch

* remove branch and sha1 from stage object #365

* REPO not longer part of GIT_PORCELAIN

SET_OBJECTS moved to private

* and remove fields from constructor
 2018-08-06 12:55:13 +02:00
larshp
02cccf6995 delete method set_new_remote in online repo 
delete method set_new_remote in online repo

#1757
 2018-08-05 13:12:36 +02:00
larshp
1d035cf1ab create_branch refactored 2018-08-05 12:47:54 +02:00