Commit Graph

413 Commits

Author SHA1 Message Date
Jaime Rodriguez Capote
543114963f
abapOpenCheck - Naming Conventions revision #3239 (#3240)
* abapOpenChecks config file

* Ignore SCI config folder

* checks revision

* Revert "checks revision"

This reverts commit 56a12289df.

* Renaming non-constants

Pending:

* Remove SCI configuration

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-09 17:34:26 +01:00
Lars Hvam
c227d473df
Authorization objects in transactions #3233 (#3237)
* Support authorization in TRAN

* abaplint checks

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-05 18:43:58 +01:00
Jaime Rodriguez Capote
c9ae5ac122
Transaction, unknown cinfo #3223 (#3232)
* Determination transaction type

* Determine TX type

* abaplint checks
2020-03-04 06:41:04 +01:00
Lars Hvam
a85db8c8b8
SRFC: clear some admin fields (#3225)
* SRFC: clear some admin fields

* fix lock problem and delete problem
2020-03-04 06:34:58 +01:00
Jaime Rodriguez Capote
2ca3a3da91
CHDO change document object #802 (#3207)
* Support for CHDO

* Remove dependency from GENERIC

* Skip gen. objects by CHDO

* abaplint checks

* Moved filter to zcl_abapgit_repo

* Adjusted filter logic

* Delete unused methods

* Extract apply filter methods

New class zcl_abapgit_repo_filter generated with apply filter methods

* docs: update supported with CHDO

* Clear serialization fields

* Set package at deserialize

* Check errors at deserialize
2020-03-04 06:29:31 +01:00
Lars Hvam
4b35ecffb3
FUGR: Give proper error messages for RFC parameter (#3222)
* FUGR: Give proper error messages for RFC parameter

* reduce line length
2020-03-03 10:21:33 +01:00
Alexander Tsybulsky
0961429903
#3209 DOCU master lang only (#3217) 2020-02-20 08:28:12 +01:00
Mauricio Lauffer
a9a505faf4
Prefer RETURNING to EXPORTING (#3204)
* refactor: Prefer RETURNING to EXPORTING

* refactor: Prefer RETURNING to EXPORTING
2020-02-11 10:20:45 +01:00
Lars Hvam
eb7e819b25 refactoring, delete unused variables and methods (#3203)
* zlib

* xml

* processor

* shi5

* remove unused filter parameter

* pinf cleanup

* ssfo delete empty method

* highlighter

* gui page res, remove unused

* remove unused in diff class

* adt link

* gui, remove 2 unused parameters

* branch overview
2020-02-09 09:38:17 +01:00
Jaime Rodriguez Capote
d5bc9b89c6
Img structure enhancement (#3200)
* Structure sequence extension

* Selection ORDER BY PRIMARY KEY
2020-02-08 09:02:51 +01:00
Jens Schwarz
9285dd29b3
Fix for issue #1044 (#3167)
* Fix for issue #1044

* Change of local variable names

* fix of bad indentation

* Update src/objects/zcl_abapgit_objects_files.clas.abap

Co-Authored-By: Lars Hvam <larshp@hotmail.com>

* Update zcl_abapgit_objects_files.clas.abap

* Also always add BOM in abapgit.xml file

* Update zcl_abapgit_dot_abapgit.clas.abap

* Update zcl_abapgit_objects_files.clas.abap

* Update zcl_abapgit_convert.clas.abap

* Update zcl_abapgit_convert.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-01 07:43:08 +01:00
Jakub Filak
3314e00069 fugr: do not uncoditionally add T00 include (#3164)
I know don't why but on our systems the "include for generated
maintenance views" is returned from the function module
RS_GET_ALL_INCLUDES, so when we add it in the method
zcl_abapgit_object_fugr=>includes we have the file twice which cause
duplicate errors on our systems.

I didn't remove the code because we are supposed to run on all ABAP
rutime versions and the problem with duplicates for the T00 includes has
started occurring only recently, so the older versions need this
artificial include (I guess).

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-24 16:02:01 +01:00
Lars Hvam
3e0b0505b1
remove commented code (#3166)
* update abaplint.json

* remove commented code

* remove 2 unused variables
2020-01-24 14:31:04 +01:00
Paweł Wiejkut
fa07c370a6 ODSO Support - new (#3146)
* IOBJ fix #3105

* Variable fix

* BW function modules check

* ODSO Support

* update

* Data type fixes

* check fix

* refactoring, variables simplification

* IOBJ support extension

Extension of current IOBJ support by handling of:
-attributes
-compondings
-hierarchy

* IOBJ downgrade

* Dynamic method fix

* lint fixes

* space fix

* Remove unused variables

* table type fix

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2020-01-19 08:39:39 +01:00
Christian Günter
92f8ee0d62 DOCT: consider all versions (#3161)
* DOCT: consider version - use ZCL_ABAPGIT_LONGTEXTS

* fix linter

* switch to factory

* fix linter
2020-01-19 08:34:48 +01:00
Christian Günter
2df559ebdd IOBJ: Refactoring - remove RTTC + cleanup (#3156)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-13 18:48:58 +01:00
Christian Guenter
bae1e21c5b Refactoring: Delete unused variables 2020-01-13 18:41:52 +01:00
Paweł Wiejkut
c9e8ca2c93 IOBJ support enhancement (#3147)
* IOBJ fix #3105

* Variable fix

* BW function modules check

* Enhancement of iobj support

Enhancement of iobj support which enable handling of:
-attributes,
-compoundings,
-hierarchies

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-11 10:11:57 +01:00
Christian Günter
f9dfa6c22a MSAG: fix, order by primary key (#3149)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-11 10:04:28 +01:00
Lars Hvam
75812fb17b
less prefixes (#3144) 2020-01-11 09:24:36 +01:00
Jaime Rodriguez Capote
9e3c73b277 Issue 3066: Class text elements translation (#3078)
* Issue 3066: Class text elements translation

* Removed comments for Issue 3066

* Pull request checks

* Travis-CI checks fixes

* Travis-CI checks fixes - Identation

* Interfaces pretty printed

* Travis-CI identation check

* Travis-CI identation check

* Changes type tt_langu and serialization

Type tt_langu moved from zif_abapgit_definitions to ZCL_ABAPGIT_OBJECTS_PROGRAM
Encapsulated code to serialize DOCU, TPOOL and SOTR for classes

* abaplint corrections

* abaplint corrections

* Encapsulated serialization %26 new IF lang def.

* zif_abapgit_definitions types indentation

* Restore zif_abapgit_definitions

* Revert zcl_abapgit_object_clas

* Revert zcl_abapgit_object_clas

* Revert zcl_abapgit_objects_program

* Revert zif_abapgit_oo_object_fnc.intf.abap

* Revert zcl_abapgit_object_clas.clas.abap

* Class text language

* Class text language

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-08 07:36:36 +01:00
mariusraht2
1f49f7a76d Issue 3130: TYPE: Type Group/Pool isn't being recognized (#3131)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Remove select for exists check

Due to the language flag-specific select a type group/pool couldn't be found. Removed the select at all because the following FM also recognizes unexistent type groups/pools and sets sy-subrc to something <> 0.

* Fill description if available in login language

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-08 07:14:21 +01:00
Christian Günter
baac63ce87 IOBJ: Downport BAPI* structures (#3142)
* IOBJ: Downport BAPI* structures

* fix linter

* Update zcl_abapgit_object_iobj.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-08 07:10:34 +01:00
Geert-Jan Klaps
1bed3ba6e7 Fix activation error 7.40 EhP 4 (IARP/IASP) #3139 (#3140) 2020-01-07 11:47:04 +01:00
Lars Hvam
e201bf566f
remove class prefixes if its current class (#3137)
* remove class prefixes if its current class

* Update abaplint.json
2020-01-06 13:20:19 +01:00
Christian Günter
a256a0b406 Refactor IARP + IASP API calls (#3135)
* Refactor IARP

* Refactor IARP

* Refactor IASP

* Update zcl_abapgit_object_iasp.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2019-12-28 12:23:54 +01:00
Lars Hvam
b42f3bc485
Refactoring (#3134)
* fully type constants

* moving to single line

* move to single line

* enable keep_single_parameter_on_one_line
2019-12-28 12:11:32 +01:00
Christian Guenter
ade359ecd3 Implement jump for IWMO, IWPR, IWSV and IWVB 2019-12-19 13:58:38 +01:00
Christian Günter
82486ec350 IOBJ: Use RSD_S_VIOBJ instead of RSD_S_VI_OBJ (#3121) 2019-12-17 08:44:17 +01:00
Michael Schneider
2ae0e1e4cf Fix protected redefinitions
During creation of classes with redefinitions in the protected section, entries in table SEOREDEF are not updated properly.

Reason: The buffer of Class Builder does not recognize the creation of the inheritance in the active version.  During the creation of the super class relationship in SEO_INHERITANCE_CREATE_F_DATA only the inactive buffer is updated. The buffer for the active version has still the state that the class has no super class.

Therefore, SEOREDEF is filled with an empty super class name. 

If the buffer is refreshed before the metadata is updated, the super class is read correctly before SEOREDEF entries are created.
2019-12-17 08:41:21 +01:00
Christian Günter
60a57cf356 Add package parameter to zif_abapgit_object~delete (#3114) 2019-12-11 10:42:45 +01:00
Paweł Wiejkut
01b6d9d92a IOBJ fix - issue 3105 (#3108)
* IOBJ fix #3105

* Variable fix

* BW function modules check
2019-12-11 07:10:15 +01:00
Frederik Hudák
c846801d19 Add adt link to objects on diff page (#3095)
* Add adt link to object name on diff page

* Fix abaplint, improve error handling

* abaplint

* Remove superflous method
2019-12-05 08:59:15 +01:00
Lars Hvam
a616f5d3f5
fix protected redef #3053 (#3100) 2019-12-04 10:21:12 +01:00
Paweł Wiejkut
0b5b1b60df InfoObject support (#3058)
* InfoObject support

* Checks fixes

* Code corrections - return and lock check

* Check fix

* addend infoobjects information

* transport and package support

* check fix

* Update ref-supported.md

* metadata change

* Transport fixes
2019-11-27 06:23:54 +01:00
Italo N
0f379b950a DOMA: consider clearing VALPOS (#3083) 2019-11-26 07:39:25 +01:00
g-back
965082510b Exchange sy-langu usage with mv_language for consistency (#3082) 2019-11-26 07:29:59 +01:00
Lars Hvam
29cb891d23
remove obsolete NO_HANDLER pragmas (#3085)
* remove obsolete NO_HANDLER pragmas

* update lint to latest
2019-11-25 07:35:41 +01:00
mariusraht2
6491967d76 Issue 3029: TABL: SAPGUI data preview doesn't work when opened (#3059)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* TABL: SAPGUI data preview doesn't work when opened

Fixes #3029

> Call RS_TOOL_ACCESS instead of ABAP4_CALL_TRANSACTION

* Delete pull.yml
2019-11-17 10:42:21 +01:00
Christian Günter
83a781e1d7 IWVB: SAP Gateway Business Suite Enablement -Vocab (#3049) 2019-11-12 11:03:04 +01:00
Christian Günter
93f5186b1d Object serializer descriptions (#3050) 2019-11-11 09:15:03 +01:00
Christian Günter
061245a33b IAXU: downport no static call of CL_W3_API_XML3 (#3047)
* IAXU: downport no static call of CL_W3_API_XML3

* downport check_duplicates
2019-11-08 13:02:12 +01:00
mariusraht2
4f1ed3b8b6 Exception Handling: IATU refactored (#3043)
* Create pull.yml

* Refactored IATU

* Delete pull.yml

* abapLint
2019-11-06 09:46:35 +01:00
mariusraht2
fb527126ef Fix applied (#3037) 2019-11-06 09:42:47 +01:00
g-back
7c05815437 Small refactorings (#3033)
* remove unusued variables

* surround "recover_version" calls with try-catch
2019-11-05 08:09:47 +01:00
Italo N
7d587e1a1a Issue #2957 (#2975)
But It's generate a lot of DIFF, when XML remote has the INDEX filled.
2019-10-31 15:07:59 +01:00
Christian Günter
c99ff03253 FTGL: feature toggle (#3004)
* FTGL: feature toggle

* update ref-supported

* Update ref-supported.md
2019-10-27 08:46:57 +01:00
mariusraht2
3900842392 Add object type IAXU (#2978)
* Possible Solution #1

* Update zcl_abapgit_objects_super.clas.xml

* abapLint

* Removed german language flag

* Fixes

* Removed flag for german language

* Removed test code

* abapLint

* Implemented suggestions from PR

> mo_xml_api is just local now
> li_service removed
> implemented exception handling for calls of xml api methods set_changeable, delete and save
> integrated sy-subrc into all exception calls
> wrote update routine if IAXU object already exists (object will be deleted first and after that local method save is called)

* abapLint

* abapLint

* String template, restructured api methods

* Remove descriptions

* abapLint

* Fixed issues after restructuring api methods calls

* Alternative error handling for existence check

* Use api existence check instead of load

* Fixed some bugs
2019-10-24 05:53:12 +02:00
Christian Günter
b7d0f2115e SMTG: OM: Email Template implementation (#2976) 2019-10-15 22:32:03 -07:00
ThomasPloski
dcb4d94275 Support of Baseinfo String for DDLS Object Handler (#2967)
* support of baseinfo string in ddls

* fixes abaplint findings

* fixes abaplint issues
2019-10-11 05:41:01 -07:00