Commit Graph

864 Commits

Author SHA1 Message Date
Lars Hvam
5a5630c198
update to latest npm packages (#5501)
* update to latest npm packages

* update

* update abaplint config to latest
2022-05-06 09:10:03 +02:00
Christian Günter
497b432199
OTGR: Downport (#5532)
* OTGR: Downport

* fix lint
2022-05-04 13:08:44 +02:00
Marc Bernard
6524d2fcee
UENO: Clear/fill user, date, and time fields (#5520)
Apply clear/fill rules to user and time-specific fields

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-04 09:31:49 +02:00
Marc Bernard
d35e3548d8
OTGR: Fix errors with parent/child (#5518)
- Fix "error while instantiating CL_CLS_OBJECT_TYPE_GROUP"
- Remove children since they are created automatically
2022-05-04 09:26:48 +02:00
Marc Bernard
9ba5db8497
WDYN: Add documentation and fix diffs (#5490)
- Add documentation for Web Dynpro component and controllers
- Fix diffs of view components due to missing sort
- Updated https://github.com/abapGit-tests/WDYN

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-04 09:03:02 +02:00
Marc Bernard
e049144e87
SPRX: Add objects to transport (#5521)
- Add proxy to transport in deserialize
- Add objects to transport in delete

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-03 07:01:57 +02:00
Marc Bernard
5ac80b0316
G4BA,G4BS: Clear/fill user and timestamp fields (#5519) 2022-05-03 06:48:43 +02:00
Marc Bernard
375092c370
DEVC: Clean-up OTR entries (#5507)
Uninstalling objects like `ENHC` just removes their references to OTR entries (`sotr_use/u` tables). Therefore, when the package is uninstalled, the remaining OTR entries will be completely removed.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-01 12:18:08 +02:00
Marc Bernard
78c4b37666
Fix status calculation (#5500)
Regression #5427

Closes https://github.com/abapGit/abapGit/issues/5499
2022-04-29 11:58:55 +02:00
Marc Bernard
183fff654a
Fix syntax error in BW jump (#5498)
* Fix syntax error in BW jump

* Lint
2022-04-29 11:12:03 +02:00
Marc Bernard
2bc6e2a8ff
SOTR: Refactor (#5441) 2022-04-29 08:51:17 +02:00
Marc Bernard
43b0d95335
IOBJ, ODSO: Add jump (#5495)
* IOBJ, ODSO: Add jump

Support navigation to BW objects

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-29 08:38:12 +02:00
Marc Bernard
0306a11ddc
Add "Changed by" to several objects (#5493)
* Add "Changed by" to several objects

Complete todos: ENSC, TRAN, TYPE, VCLS, XINX

* Lint
2022-04-27 07:28:32 +02:00
Marc Bernard
252101ea8c
SPRX: Fix suppress_dialog error (#5491)
On old support package levels, `suppress_dialog` parameter does not exit
2022-04-26 17:24:28 +02:00
Marc Bernard
dd85924244
Properly ignore files during deserialize (#5427)
* Properly ignore files during deserialize

Closes #5426

This moves the ignore logic from `zcl_abapgit_files_status->prepare_remote` to an option of `zcl_abapgit_repo->get_files_remote`. Deserialize can then ignore the files already when getting them via `get_files_remote`.

PS: Required for https://github.com/exercism/abap/pull/82

* Update zcl_abapgit_repo.clas.abap

* Update zcl_abapgit_repo.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2022-04-26 16:52:19 +02:00
yellappam
e50a7dcc3c
Clear metadata fields (#5464)
* Add zcl_abapgit_rule and zif_abapgit_rule

* Insert clear and fill logic

* Pass rule to the generic serializer in IWSG class

* Remove extra space

* Remove inline declaration

* Format the code

* Replace CHECK with IF

* Rename class/interface

* Multiple changes

Rename method name
Change method signature
Remove clear field

* loop over all fields of given fields

* Align method call parameters

* Remove class reference for member

* Use string template to convert to type

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-04-26 16:33:21 +02:00
sandraros
b3c89a8ff2
Create empty classes/interfaces before DDIC (#5393)
* Force XSLT activation during deserialize

* Revert "Force XSLT activation during deserialize"

This reverts commit 7d6fc64ddb.

* Create empty class/interface before DDIC phase

Fix #5392

* pretty printer ZCL_ABAPGIT_OBJECT_INTF

* abaplint zcl_abapgit_object_clas

* Update zcl_abapgit_object_clas.clas.abap

* Update zcl_abapgit_object_dtel.clas.abap

* Update zcl_abapgit_object_intf.clas.abap

* Update zcl_abapgit_object_tabl.clas.abap

* Update zcl_abapgit_object_ttyp.clas.abap

* Update zcl_abapgit_objects.clas.abap

* Update zcl_abapgit_object_clas.clas.abap

* Update zcl_abapgit_object_intf.clas.abap

* Update zif_abapgit_object.intf.abap

* Update src/objects/zcl_abapgit_object_intf.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update order numbers

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-26 16:07:15 +02:00
BeckerWdf
9974246775
DTDCs no longer have an own data class (#5478)
Starting with ABAP Platform 2208 DTDC does no longer have an own workbench data class but instead uses CL_BLUE_SOURCE_OBJECT_DATA directly.

In addition:
The field that carries the ABAP language version changed from ABAP_LANGUAGE_VERSION to ABAP_LANGU_VERSION in ABAP Platform 2208. So to make it work in both releases < and >= ABAP Platform 2208 we have to try to clear both versions of that field.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-04-26 16:02:09 +02:00
Marc Bernard
df2c88223a
FUGR: Fix diff of includes (#5489)
Sort list of includes to avoid diff
2022-04-26 14:40:20 +02:00
BeckerWdf
adfcedc7cb
DDLX: clear ABAP_LANGU_VERSION 2022-04-20 07:49:26 +02:00
BeckerWdf
497ad94180
DDLS: clear ABAP_LANGU_VERSION 2022-04-20 07:39:32 +02:00
Alexander Tsybulsky
2cc3f53fc5
Rework checksums (#5328) 2022-04-13 11:29:23 +02:00
Marc Bernard
583d215114
Add paramter iv_show_log to serialize package (#5457)
Pass along paramter `iv_show_log`(should have been an "unused variable/parameter" check).
2022-04-08 15:43:48 +02:00
Marc Bernard
e6378ac17f
DEVC: Fix DYNPRO_SEND_IN_BACKGROUND (#5461)
When deserializing SAP packages that do not exist in background, AG will dump with `DYNPRO_SEND_IN_BACKGROUND`. This is caused by a popup asking for the transport.

Fixed by passing the transport to the save method.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-08 11:33:18 +02:00
Marc Bernard
62443633fd
Improve LXE error handling (#5440)
* Improve LXE error handling

Raise exception in case of error messages

* Remove space

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-06 10:48:58 +02:00
Marc Bernard
00e1505613
DEVC: Raise error for main/structure packages (#5444)
* DEVC: Raise error for main/structure packages

Main or structure package and cannot be used in local packages (`$...`). 

abapGit will now raise an error, if one tries to pull main or structure packages into a local package.

* Split into two messages

* Locally

* Local

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-06 09:17:09 +02:00
Marc Bernard
8d8d537fcf
DOMA: Deletion of domains with append (#5445)
* DOMA: Deletion of domains with append

On newer releases, suppressing the confirmation popup does not work since the parameter has changed.

Added a call using the new parameter.

* No if

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-05 18:00:27 +02:00
Marc Bernard
250feae861
Add transport for deletions in generic serializer (#5434)
Closes #5421

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-05 16:41:03 +02:00
Marc Bernard
3574521d2d
Record objects in transports (#5435)
* Record objects in transports

Follow-up to #5419

* Record objects in transports

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-05 16:26:07 +02:00
Marc Bernard
287539ed4a
CHDO: Avoid double pull and fix uninstall (#5439)
Change documents left a diff when pulled once that would go away after second pull. In debugging warning CD 763 could be seen "No TADIR entry found'. The `tadir` entry is now created properly.

Uninstall would fail with "Function group ... does not exist". Reason was that the function group was already deleted by `chdo` object. The deletion of such generated function groups is now skipped.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-05 16:04:14 +02:00
Christian Günter
e0742e5181
CUS1: fix jump (#5447) 2022-04-05 10:31:04 +02:00
Marc Bernard
3666dda767
Rename methods returning boolean (#5436)
Just a bit of Clean ABAP:
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-nouns-for-classes-and-verbs-for-methods

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-03 10:40:12 +02:00
Marc Bernard
3d158a3fbc
DDLS: Avoid dump and show error (#5437)
* DDLS: Avoid dump and show error

Ref https://github.com/abapGit/abapGit/issues/4624

* Typo
2022-04-03 10:10:58 +02:00
Marc Bernard
453c430723
Deserialize textpool for some objects (#5417)
* Deserialize textpool for some objects

Fixes inserting the textpool for objects that are not handled by `RPY_PROGRAM_INSERT`. This applies for example to function groups and exit includes (`zx...`).

* Fix deserialize_textpool

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-01 17:51:32 +02:00
Marc Bernard
014d40db1c
Fix "dynpro_send_in_background" (#5430)
* Fix "dynpro_send_in_background"

Suppresses dialog processes for ENHC, ENHS, ENSC, SPRX, and TRAN.

Closes #5420

* Update zcl_abapgit_object_enho.clas.abap

* Update zcl_abapgit_object_enhs.clas.abap

* Update zcl_abapgit_object_ensc.clas.abap

* Update zcl_abapgit_object_sprx.clas.abap

* Update zcl_abapgit_object_tran.clas.abap

* exit
2022-04-01 17:40:28 +02:00
Marc Bernard
485bb12cc1
Record objects in transports (#5419)
CI tests have shown that several object types are not properly recorded in transports. For some objects there was no transport entry when creating the objects, for others when deleting it. 

This PR add the necessary calls to `corr_insert()`. 

(some SE80 reorders)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-03-31 15:20:25 +02:00
Marc Bernard
f712eb17a5
Folder logic "mixed" (#5413)
* Folder logic "mixed"

Introduces a new folder logic named `mixed` which combines `prefix` and `full`. The root package name will be used as prefix for all sub-packages but the package names are *not* concatenated recursively. This will allow for using significantly logic package names.

Also includes several new unit tests especially for nested packages which had not been tested before.

Closes #5410

Todo: Update docs

* Add constant

* Add options to UI

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-03-31 13:35:34 +02:00
Marc Bernard
6e927e63c5
UENO: Fix diff related to release (#5422) 2022-03-31 06:48:57 +02:00
Marc Bernard
ba09c6e92d
DDLX: Delete before DDLS (#5414)
Fix order of deletion
2022-03-29 23:28:41 +02:00
Marc Bernard
ab19fec80b
Fix deserialize order (#5399)
* Fix deserialize order

Fix order for 
- CLAS, INTF, XSLT
- IASP, IARP, IATU

* iaxu
2022-03-16 11:38:46 +01:00
Marc Bernard
c88dc9f216
SRVB: Fix uncaught exception (#5398)
Fixes dumps due to uncaught exceptions and gives proper error message
2022-03-15 18:43:04 +01:00
ThomasPloski
38db43ce13
Update zcl_abapgit_object_srvd.clas.abap (#5395)
* Update zcl_abapgit_object_srvd.clas.abap

* Update src/objects/zcl_abapgit_object_srvd.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2022-03-10 08:44:30 +01:00
yellappam
bcdeebb3ad
Sort internal tables (#5390)
Function module WEBI_GET_OBJECT returns several internal tables. Sometimes, the sorting order of these internal tables is different in each system ex: S/4HANA and non-S/4HANA. This fixes #5389.
2022-03-02 14:37:23 +01:00
Marc Bernard
524f6eebc5
CLAS/INTF: Fix serialize/deserialize of documentation (#5374)
* INTF: Fix serialize/deserialize of documentation

Documentation of interfaces (document class IF) was missing and has been added.

* Fix translations
2022-02-28 14:25:52 +01:00
sandraros
0f6267688e
Fix pull/activate table type ref to data type (#5384)
Fix #5383

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-02-27 17:45:29 +01:00
sandraros
5e53bb9626
Fix DDIC errors related to ref to class/interface (#5369) 2022-02-27 17:23:13 +01:00
Marc Bernard
a491dcf875
SOTS: Fix dump in case of lower case language code (#5381)
Closes #5380
2022-02-25 10:02:33 +01:00
sandraros
68e2cfa5c2
Fix data elem type ref to class in same repository (#5370)
* Fix data elem type ref to class in same repository

* simpler solution by testing refkind and reftype

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-02-21 17:20:39 +01:00
Alexandr Razinkin
353f748bd6
Don't fail if a dictionary object is activated with warnings (#5362)
* Fix proposal for issue #5347: added support for 'TYPE REF TO DATA' DDIC data elements as components in DDIC structures

* Fix proposal for issue #5347. Added support for 'REF TO DATA' DTEL DDIC element residing in DDIC structure

* Fix proposal for issue #5347, added support for 'TYPE REF TO DATA' DDIC data element residing in DDIC data structurees

* REF TO DATA for DDIC element support (#5347)

* No error if ddic type has warning (abapGit#5361) during import

* Update zcl_abapgit_objects_activation.clas.abap

* Fix for (abapGit#5361). Warnings during DDIC objects activation shouldn't be considered as error but will be shown as 'yellow' messages after activation

* Fix for (#5361).
Warnings during DDIC objects activation shouldn't be considered as error but will be shown as 'yellow' messages after activation

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-20 11:39:09 +01:00
Christian Günter
2ba6151355
JUMP: Switch execution order - first specific then generic (#5357)
* Switch jump order

* fix DDLS

* fix SHI3
2022-02-18 05:48:36 +01:00