Commit Graph

127 Commits

Author SHA1 Message Date
Marc Bernard
b331de6bc7
Naming of class constants (#4945)
* Naming of class constants

This is in preparation of enforcing a naming convention for constants in classes/interfaces. At the end, the following lint rule shall be set:

```json
    "class_attribute_names": {
      "constants": "^C_.+$",
...
    },
```

After this, the only remaining constants not following this rule are in `zcl_abapgit_version`.

* Update zif_abapgit_dot_abapgit.intf.abap

* Update zcl_abapgit_gui_chunk_lib.clas.abap

* Update zcl_abapgit_gui_router.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-14 16:47:48 +02:00
Lars Hvam
2bdb06519c
check exists() before changed_by() (#4925)
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-08-31 07:29:10 +02:00
Lars Hvam
54036c11dd
workaround changed_by (#4924)
* workaround changed_by

* ugh
2021-08-30 10:46:19 +02:00
Jacek W
5f6b5a73c8
Add "Last changed by" to repo page (#4920)
* Add "Last changed by" to repo page

Proposition for #3267

* Add "Last changed by" to repo page

For #3267
- add "Changed by" also for local items

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-08-30 07:26:02 +02:00
Lars Hvam
329fd9dc0e
interface and factory for ZCL_ABAPGIT_PERSIST_SETTINGS (#4882)
the old get_instance() method in ZCL_ABAPGIT_PERSIST_SETTINGS has been moved to a method in zcl_abapgit_persist_factory, plus interface added. Added to persist injector
2021-08-03 15:13:16 +02:00
Lars Hvam
e075b951a4
align use of unescape_url() (#4878) 2021-07-29 16:49:38 +02:00
Marc Bernard
6ff7074aec
Auto creation of package during new online (#4814)
* Auto creation of package during new online 

If you create a new online repository and the repo does not contain any SAP package, then abapGit will prompt you for the package attributes and create the package for you. This is, for example, the case when you use an newly created online repo as a starting point. 

If the repo does contain a package, then the package will be created automatically when you pull from the repo (as described in [docs](https://docs.abapgit.org/ref-packages.html)).

Closes #4538

* Update docs

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-07-09 15:28:55 +02:00
Marc Bernard
ad244abacd
Terminology: Inclusive Language - Part 6 (#4791)
* Terminology: Inclusive Language - Part 6

Change remaining variables and switch setting to main_language. 

Finally closes #4043

* Add todo

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-28 13:15:00 +02:00
Christian Günter
f97320f1dc
Create branch: Add existence check (#4794)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-28 06:09:27 +02:00
Marc Bernard
c2e9e58319
Enhance "Force Pull" to become "Selective Pull" (#4733)
* Enhance "Force Pull" to become "Selective Pull"

With this PR you can now peform a selective pull. Yay!

- Changes "Force Pull" to show *all* changed objects in the usual "Overwrite Popup". This allows you to select individual objects to be pulled no matter if they were changed locally or remotely.
- Does *not* change the regular "Pull" logic

Closes #413, #4282

* Combine delete and overwrite popups

* Add icons to abaplint.json

* Change if to case

* Add icons to abaplint.json

* Enhance UTs

* show_icon

* Show icon

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-20 06:19:00 +02:00
Marc Bernard
d47c72f429
Remote Settings: Toolbar icon & clean-up (#4724)
* Remote Settings: Clean-up

Continue #4718

- Branch > Switch to PR: removed
- Advanced > Checkout commit: removed
- Advanced > Make Offline / Online: removed menu items and popups
- Advanced > Change Remote: removed menu item and page

* Remove ty_popups

* Remove checkout_commit

* Remove repo_view switch_to_pr

* Remove get_switched

* Add "Edit" icon also for offline

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-27 19:03:06 +02:00
Marc Bernard
a225e05950
New "Remote" tab in repo settings (#4705)
* New "Switch" tab in repo settings

This PR adds a new tab to the repo settings which combines all options for switching the repository to a different source:

- Switch between "Online" and "Offline"
- Switch to Branch, Tag, Commit, or Pull Request

Note 1: Value help for URL history has not been implemented yet.

Note 2: None of the existing related menu items have been removed yet.

* Clean-up

* Clean-up

* Clean-up

* Clean-up

* Clean-up

* Change to "Remote"

- rename class 
- add "autosave" for on/offline switch
- change "Switch" to "Remote"

* Update on/offline switch

* Update on/offline switch

* Update zcl_abapgit_gui_page_sett_remo.clas.abap

* Grammar

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-25 09:59:00 +02:00
Marc Bernard
f18a8ee82b
Terminology: Inclusive Language - Part 5 (#4702)
* Terminology: Inclusive Language - Part 5

Change of terminology (#4043)

- Replace `get_master_language` with `get_main_language` and remove it

* File Status

* Jump

* Language

* Main language

* Main language
2021-04-15 08:32:09 +02:00
Marc Bernard
1104c88e48
Data deserialize (#4654)
* Data deserialize

Continuing on #3441 

- Fixes issue with namespaced tables 
- Adds deserialize of table content during pull but does NOT persist changes to database

`zcl_abapgit_repo->deserialize` now contains the following call to deserialize "data":

```abap
    zcl_abapgit_data_factory=>get_deserializer( )->deserialize(
      ii_config  = get_data_config( )
      it_files   = get_files_remote( )
      iv_persist = abap_false ). "<<no persisting, just test for now
```

Closes #4650

* Fixes and max record check

* Get result preview

* Split deser/actualize

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-23 06:40:09 +01:00
yellappam
0f2020b5c1
Unsupported object count in repo statistics (#4601)
* Add unsupported object count in repo statistics

* lint fix: Keep single parameter on one line

* Fix indentation

* Undo changes to TADIR and DEFINITIONS

Undo changes to ZCL_ABAPGIT_TADIR and ZIF_ABAPGIT_DEFINITIONS

* Refactor code

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-09 12:13:10 +01:00
Alexander Tsybulsky
3df4863feb
LXE langs refactoring (#4494)
* main refactoring part

* linter fix

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-01 07:02:04 +01:00
Frederik Hudák
add83f5b94
Repo overview performance improvements (#4541)
* Repo overview performance improvements

* Rework map_repo_list_to_overview

* Reduce usages of get_key

* Fix inline data

* Don't load package descriptions in repo overview

the select is expensive

* suppress titles for non-favorite repositories

* lint

* Update src/ui/zcl_abapgit_gui_page_repo_over.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* optimize render_repo_palette

* Optimize gui_router

* Update zcl_abapgit_gui_page_repo_over.clas.abap

* Update zcl_abapgit_migrations.clas.abap

* remove unused variable

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-21 11:29:01 +01:00
Marc Bernard
8c9bca3a4f
Fix display of log after uninstall (#4490)
The uninstall log was dropped too early during refresh of repo. Now it's passed properly to the UI.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-09 07:37:04 +01:00
JustACasual
bcbc3d527d
I18N: LXE Translations (#4415)
* Issue 2424

https://github.com/abapGit/abapGit/issues/2424

* Issue 2424

https://github.com/abapGit/abapGit/issues/2424

* Update src/objects/zcl_abapgit_object_fugr.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Fixing LINT issues

* Fixing LINT issues

* TABL, default ROWORCOLST on deserialize (#4430) (#4)

* Fix for #4425

* Remove whitespace at end of line

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Remove whitespace at end of line

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: DerGuteWolf <DerGuteWolf@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Centralize LXE functionality

* Fix FUGR LXE

* delete issue reference comments

* Delete issue reference comments

* Remove Aliases for LXE types

* Review Changes

* Copy from #4452

Integrate changes from #4452 into #4415

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: DerGuteWolf <DerGuteWolf@users.noreply.github.com>
Co-authored-by: Sebastian Koitka <sebastian.koitka@dematic.com>
Co-authored-by: Marc Bernard <marc@marcbernardtools.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-01-31 10:36:28 +01:00
Marc Bernard
40efc567f6
Automatic creation of top repository package (#4431)
* Automatic creation of top repository package

When adding a repository, it is not necessary anymore that the top SAP package assigned to the repository exists. Just enter a package name and clone (works for offline, too). 

The initial diff will now show that the top package exists remotely only. Therefore, when pulling, you will not get the "confirm overwrite package" popup anymore. Yippie!

* Typo

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-23 10:11:54 +01:00
Alexander Tsybulsky
47dae10ab0
I18n settings (#4416)
* dot abapGit i18n_langs

* rewrite dot abapgit (better design)

* settings

* linter fix

* review fixes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-18 09:32:55 +01:00
Lars Hvam
db6db7cf79
remove more unused variables (#4413) 2021-01-15 17:22:51 +01:00
Lars Hvam
889d062e1c
data, basic serialization (#4369)
* data

* refactor ZCL_ABAPGIT_SERIALIZE

* upd

* serializing

* cleanup

* fix

* fix

* rename
2021-01-09 10:50:58 +01:00
Marc Bernard
9f91e4f3ad
Move method is_sap_object_allowed (#4385)
Closes https://github.com/abapGit/abapGit/issues/4382

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-08 12:06:06 +01:00
Lars Hvam
8b506aa077
omit some default parameter names (#4370)
* apack, omit parameter names

* mass and objects

* omit

* omit
2021-01-04 10:41:20 +01:00
Lars Hvam
4f95be22ad
REPO changes (#4361)
* method ZCL_ABAPGIT_REPO->FIND_REMOTE_DOT_APACK changed to private
* method ZCL_ABAPGIT_REPO->RESET_LOG deleted

#2127
2021-01-02 09:02:52 +01:00
Marc Bernard
98ecc1a51c
Package Structure - Part 5 (#4360)
* Package Structure - Part 5

Final part of package structure reorg. Moving repo related classes and interfaces.

$ABAPGIT_REPO:

ZCL_ABAPGIT_DOT_ABAPGIT
ZCL_ABAPGIT_REPO
ZCL_ABAPGIT_REPO_CONTENT_LIST
ZCL_ABAPGIT_REPO_FILTER
ZCL_ABAPGIT_REPO_OFFLINE
ZCL_ABAPGIT_REPO_ONLINE
ZCL_ABAPGIT_REPO_SRV
ZIF_ABAPGIT_DOT_ABAPGIT
ZIF_ABAPGIT_REPO_LISTENER
ZIF_ABAPGIT_REPO_ONLINE
ZIF_ABAPGIT_REPO_SRV

Closes https://github.com/abapGit/abapGit/issues/4253

* Remove delta

* Remove delta

* Remove delta

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-29 11:34:29 +01:00