Commit Graph

16 Commits

Author SHA1 Message Date
Marc Bernard
6623679e67
Dialogs: HTML forms - follow-up (#4329)
* Dialogs: HTML forms - follow-up

Follow-up to #4264:

- Split `zcl_abapgit_html_form` class
Processing form data has been moved to `zcl_abapgit_html_form_utils`

- `iv_is_main` refactored to `iv_cmd_type`

- In case of unsaved data, form exit will now prompt for confirmation (`zcl_abapgit_html_form_utils`)

* dot space

* lint

* Remove const

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-02 15:12:09 +01:00
Marc Bernard
d0983cf386
Dialogs: HTML form enhancements (#4264)
* Dialogs: HTML form tweaks

- Minor increase of contrast for background, input- and readonly fields
- Add read-only option for columns of table control

* Add is_empty

* Add init and hidden

* Render

* Remove init

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-12 08:45:47 +01:00
Marc Bernard
9efdae315d
Dialogs: Enhance HTML form with table control (#4230)
* Dialogs: Enhance HTML form with table control

- Adds option to maintain data using a table control
- Extends UTs with several cases that were include in #4172
- Table control to be used by "repo settings" #4171

* Border

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-24 08:11:53 +01:00
Marc Bernard
82668de47b
UI: New pages for global and personal settings (#4192)
* Dialogs: New pages for global and personal setting

Redesign of abapGit settings using HTML forms. Two functional changes to old settings page:
- "Development Internal Settings" are only visible when using the developer version (not in standalone program)
- "User-specific hotkey settings" are not available anymore. The default hotkeys continue to work as before.

Global/Personal settings can be reached using hotkeys "x" and "y".

* Lint

* Hide button

* Change to top menu

* Remove old page

* Remove old page

* fix links

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-23 08:24:17 +01:00
Marc Bernard
9e385c264e
UI: Add help buttons to "New Online/Offline" (#4189)
* UI: Add help buttons to "New Online/Offline"

- Add help button to both dialogs linking to docs.abapgit.org
- Clicking the button brings up the documentation inside the GUI HTML viewer
- Enhancement to `zcl_abapgit_gui` and `zcl_abapgit_html_viewer_gui` to properly handle 'Back' when navigating through Internet pages

* Open help in external browser

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-18 07:33:00 +01:00
Marc Bernard
16e8f3d02d
Dialogs: HTML form enhancements (#4172)
* Dialogs: HTML form enhancements

In preparation for https://github.com/abapGit/abapGit/issues/4171, HTML forms were enhanced as follows:

- New integer fields (type "number") with min/max, https://github.com/abapGit/abapGit/issues/3559
- Added support for minlength/maxlength for text fields
- Added support for read-only fields
- Added support for password fields
- New option for adding a help button to the form (with URL link)
- Moved HTML snippets to render method
- Changed parameters to csequence to also accept char variables (like abap_true)
- Minor adjustments to styles

* Lint and fix ul/fieldgroup

* Min/max validation, textarea

* Close textarea tag

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-14 11:28:19 +01:00
Marc Bernard
5c1298697d
Trigger main command when pressing enter in form (#4102)
* Triggers main command when pressing enter in form

Adds hidden button that triggers main command when pressing the enter key

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-05 09:46:21 +01:00
Alexander Tsybulsky
19c49fd960
Bugfixes in html_form and Finetune add pages to new event (#4011)
* refactor validation in html_form + UT

* minor UT tweak

* subtle form bugfix (boolc return space string)

* cleanup add forms

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-12 16:40:24 +02:00
Marc Bernard
9672f5b030
Adjust name prefix for types (#3991)
* Part 1

* Part 2

* Part 3

* Lint

* Part 5

* Part 6

* Part 7

* Part 8

* Part 9

* Enforce type naming prefix

All types need to start with TY_...

* Fix local types
2020-10-07 08:54:15 +02:00
Marc Bernard
25774396e6
Dialogs: add offline repo HTML form (#3960)
* Dialogs: add offline repo HTML form

* Dialogs: add offline repo HTML form

* Dialogs: add offline repo HTML form

* Lint

* Lint

* Chaining

* Set required attribute

* Check for empty display name

* Change validation

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-03 10:18:45 +02:00
Alexander Tsybulsky
aae82485e0
html_form chaining (#3908) 2020-09-20 09:29:12 +02:00
Alexander Tsybulsky
6e515e1063
Unified validate and normalize form params in html_form class (#3904)
* html_from - validate and normalize form params

* docs
2020-09-20 07:41:46 +02:00
Lars Hvam
2ff25e27dd
pretty print ZCL_ABAPGIT_HTML_FORM and static (#3880)
pretty print class ZCL_ABAPGIT_HTML_FORM, and change two static methods to instance, this will make future possible changes to the class easier to see in the history
2020-09-12 06:50:31 +02:00
Lars Hvam
d5e5baa7d8
delete method ZCL_ABAPGIT_HTML=>CREATE (#3736) 2020-08-18 06:54:20 +02:00
Alexander Tsybulsky
6fe168640c
Html form improvements and docs (#3582)
* auto id

* fix html validation (form in ul)

* form groups

* move colors to theme

* docs for html form component

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-05 17:57:45 +02:00
Alexander Tsybulsky
f5dfd328f5
Dialogs: add online repo HTML form (#3533)
* first draft

* progress ...

* html->create()

* more progress

* and more

* getting closer

* wiring

* refactor popup_search_help

* refactor create_package to services

* fix services->new_online after rebase

* linter fixes

* more linter fixes

* straing map util

* error handling

* submits for side actions (ugly ... but ...)

* cleanups

* linter fixes

* refactor form values logic

* linter fix

* review fixes

* remove unused var after rebase

* review fixes, better side action layout

* linter fix

* minor css tweaks
2020-07-01 08:16:52 +02:00