Commit Graph

7 Commits

Author SHA1 Message Date
mariusraht2
7ffb4ff91d
Move commit-specific methods from ZCL_ABAPGIT_BRANCH_OVERVIEW to new class ZCL_ABAPGIT_GIT_COMMIT (#4026)
* Implementation

- Create new class ZCL_ABAPGIT_GIT_COMMIT
- Move commit-specific methods from ZCL_ABAPGIT_BRANCH_OVERVIEW to ZCL_ABAPGIT_GIT_COMMIT
- Change methods visibility (from private to public) and type (from instance to class method)

* Remove ##NO_TEXT

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Rename get to get_from_remote

* abapLint: Remove space

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* abapLint

- Remove space
- Remove unused type in ZCL_ABAPGIT_BRANCH_OVERVIEW

* abapLint: Remove space

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Remove obsolete class attribute

* Separate get_by_branch and get_by_commit

* Remove duplicate char

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Remove iv_repo_name; replace its usage by url

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-19 11:24:38 +02:00
mariusraht2
064e006c88 Issue 3042: Error author regex (#3070)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Tags: Error author regex

> Regex couldn't match with string "pull[bot] <39814207+pull[bot]@users.noreply.github.com> 1573216988 +0000" because "[]" weren't allowed

* abapLint

* Added unit test for author_regex

#3042

* Any character in author name and Unit Tests

#3042
#3069

* Unit Tests and utils method for author regex

#3042
#3069

> Unit Tests for author_regex (zif_abapgit_definitions)
> New utils method for regex check as utils method in zcl_abapgit_utils
> Regex for author expects now at least one character for the author name ('^(.+)'...)
> Use zif_abapgit_definitions%3D>ty_commit_tt  instead of local type of the same type in class zcl_abapgit_branch_overview

* Changed utils method/tests and moved unit tests

#3042 - Error author regex
#3069 - Add unit tests

> Renamed is_author to extract_author_data and moved related source code from branch_overview to utils class
> Changed related unit tests to handle exception or not
> Moved unit tests to local class of zcl_abapgit_utils

* abapLint

* abapLint

* abapLint

* abapLint

* exclude 7bit test for testclass
2019-11-21 06:40:25 +01:00
Christian Guenter
cc501d1f9f Branch Overview: Fix author regex 2019-05-21 07:20:18 -07:00
larshp
f9df7c4498 author regex #1957 2018-10-02 07:46:24 +02:00
Johannes Konings
d25bfaf725 fix some naming conventions
https://github.com/larshp/abapGit/issues/1132
2018-08-17 09:24:22 +02:00
Johannes Konings
09791d0685 Unit test ZCL_ABAPGIT_BRANCH_OVERVIEW for author regex (#1767)
* changed assert to exception

* unit test for author regex added

* Umlauts removed
2018-08-06 12:54:43 +02:00
Lars Hvam
95a8a42c25
Parse commit message in branch overview, fix for PGP signature #1387 (#1698)
* pretty print, trigger reordering of methods

* skip PGP signature

* change PARSE_COMMITS to static

change PARSE_COMMITS to static and add unit tests class

* add simple unit test and fix CI findings
2018-07-27 13:16:34 +02:00