Commit Graph

832 Commits

Author SHA1 Message Date
Christian Günter
722a954c43
Improve error message for language mismatch (#5544)
* Improve error message for language mismatch

* refactor

* refactor

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-17 13:31:25 +02:00
Marc Bernard
1b4582bc03
Fix commit message encoding (#5508)
* Fix commit message encoding

- Properly encode % and & symbols
- Add unit test for special characters

Closes https://github.com/abapGit/abapGit/issues/2448

* Exclude testclass

* Comment

* update to 2.0.17

* update to 2.0.18

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-05 15:29:38 +02:00
Fabian Lupa
872339dfe8
Refactor remote settings (#5483)
* Add get_switched_origin to repo_online

* Add onclick action for radiobuttons

* Refactor remote settings to allow for direct input

without using value helps

* Adjust branch overview error message

Inform the user about the possibility of changing HEAD directly without using the value help (that failed to show up).

* Fix hidden form fields taking up vertical space

* Add min/max restriction to commit field

on remote settings page

* Implement basic validation for commit id

on remote settings page

* Load previous branch/tag when PR is selected

in remote settings page to be able to switch back to it more easily

* Use current form data in PR and tag selection

on remote settings page, where possible. Otherwise check the form values are the same as the repo instance values.

* Fix issue when changing URL and switching from PR

at the same time

* Remove repo dependency in PR enumerator

to be able to list PRs for the current url on the repo remote settings page

* Update zcl_abapgit_branch_overview.clas.abap

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-05-02 13:22:23 +02:00
Marc Bernard
8888256eed
Fix ignore count in repo statistics (#5505) 2022-04-30 14:54:37 +02:00
Marc Bernard
79da4eb385
Refactor: Database Utility (#5487)
- Update and harmonize description of DB entries
- Fix description for repo checksums
- Increase width of display and edit areas
- Split long method
2022-04-26 07:54:00 +02:00
Marc Bernard
0fea49b74c
Remove "Tag Overview" popup (#5463)
* Remove "Tag Overview" popup

- The "Tag > Overview" feature has been removed (because of bad performance and low value)
- The tag select popup has been refactored. The code has been moved to `zcl/if_abapgit_popups`. Only change is that the popup is now centered like the others.
- Therefore, class `zcl_abapgit_tag_popups` has been removed

* Update injectors

* Remove interface

* Secondary key
2022-04-25 07:28:07 +02:00
Marc Bernard
3742f2b0d6
UI: Transport popup (#5453) 2022-04-22 07:37:15 +02:00
Alexander Tsybulsky
2cc3f53fc5
Rework checksums (#5328) 2022-04-13 11:29:23 +02:00
Marc Bernard
985dbf1116
Remove "Branch Overview" page (#5428)
* Remove "Branch Overview" page

- The "Branch > Overview" feature has been removed (see #5411 for reasoning). 
- The merge feature has been refactored into a new HTML page under "Branch > Merge" (#5402)

Closes #5411

* Remove old page

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-11 16:34:14 +02:00
Marc Bernard
63a87fa6e7
TABU: Add "jump" to SE16 (#5459)
* TABU: Add "jump" to SE16

When using "Data Cofiguration" you can now jump from the repo view to the data browser (`se16`).

* Simplify

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-08 15:39:03 +02:00
Marc Bernard
de39745541
UI: Fix escaping of textarea input (#5456) 2022-04-07 16:08:19 +02:00
Marc Bernard
ef502d8275
UI: Transport popup (#5452)
Add parameter for new logic
2022-04-06 15:55:48 +02:00
Marc Bernard
7e7104e050
UI: Word-wrap long filenames in repo/stage views (#5424)
Closes #5418

Before

After

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-05 17:17:55 +02:00
Marc Bernard
daa35ab666
UI: Transport popup (#5438)
If default transport is set and its type matches to what is required, then use it as default for the transport popup.

This will make it easier for example if a pull or uninstall failed and needs to be repeated since you want to continue using the same transport.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-05 16:15:08 +02:00
Marc Bernard
f712eb17a5
Folder logic "mixed" (#5413)
* Folder logic "mixed"

Introduces a new folder logic named `mixed` which combines `prefix` and `full`. The root package name will be used as prefix for all sub-packages but the package names are *not* concatenated recursively. This will allow for using significantly logic package names.

Also includes several new unit tests especially for nested packages which had not been tested before.

Closes #5410

Todo: Update docs

* Add constant

* Add options to UI

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-03-31 13:35:34 +02:00
Christian Günter
7992625644
Repo List: fix sort (#5397)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-03-15 18:56:55 +01:00
Lars Hvam
e5eb8d0d0a
icon, fix short dump (#5386)
#5385
2022-03-01 08:02:32 +01:00
Frederik Hudák
adb529152b
minor css adjustments (#5372)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-02-21 17:37:40 +01:00
Marc Bernard
6a85f93312
Update CSS for password fields and buttons (#5364)
Minor addition to CSS

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-21 16:38:45 +01:00
Alexander Tsybulsky
91cd4c3653
Separate zif_abapgit_repo (#5329)
* zif_repo basis

* all but zcl_abapgit_repo_srv

* fix zcl_abapgit_repo_srv

* remove create_new_log from interface

* "hack" -> "TODO"

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-19 09:22:46 +01:00
Lars Hvam
4ac0183df2
unit testing updates (#5354) 2022-02-19 09:02:13 +01:00
g-back
cce8be5f1b
persist "show folder view" option (#5343)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-10 12:01:54 +01:00
Frederik Hudák
baa09083e6
Repo view - show paths below object name (#5323)
* Repo view - show paths below object name

* rework table rows

* fix syntax

* remove old comment
2022-02-09 08:48:12 +01:00
Christian Günter
a4a13e56f7
Repo page: remove orphaned hotkey 'x' aG settings (#5334)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-02-07 12:10:52 -05:00
Fabian Lupa
42a642ccd0
Set window title for log viewer (#5300) 2022-01-30 14:19:13 -05:00
Marc Bernard
6efaa0e0b4
Refactor: Remove ddic flag (#5295)
Closes #5264

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-30 16:37:56 +01:00
Marc Bernard
884a71e00e
Forms: Radio options and minor fixes (#5291)
- Allow for radio options to be arranged in column (instead of side-by-side)
- Render maxlength for text fields only when provided

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-26 19:54:09 +01:00
Marc Bernard
254e6d51e3
UI: Center Popups - Part 2 (#5290)
* UI: Center Popups - Part 2

Adjusting more popups #5275

* Refactor for method length

* Lint indent
2022-01-25 18:40:20 +01:00
Frank Müller
c932426b44
Pre Filter Backend and GUI Logic (#5227)
* Initial

* Adjustments

* Router

* Abaplint

* abaplint

* diff between eclipse and vscode

* Multiple Adjustments

* Split Backend And GUI Logic

* Multiple Adjustments

* No Unit Tests

* abaplint

* Rename ZCL_ABAPGIT_REPO_PRE_FILTER to ...TR

* Multiple Adjustments

* Refactor the OVP action links into a toolbar

* abaplint

* Replace BAPI_MSG by STRING

* Rename Pre Filter to Object Filter

* Rename Pre Filter also in abap_transpile.json

* restore from main

* Check if <ls_item>-li_class is filled in Toolbar

* Adj. toolbars and move TR Req to zif_abapgit_popup

* abaplint

* Move  ty_trrngtrkor_tt to zif_abapgit_definitions

* abaplint

* Move and rename filter menu entries

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: IBM <mbox-060-sap-extern-tbom@daimler.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-01-25 10:00:09 +01:00
Marc Bernard
d7cdb65243
Forms: Minimum text field length (#5287) 2022-01-24 17:10:40 +01:00
Marc Bernard
656e94c612
Change icon for user settings (#5282)
* Change icon for user settings

Reduce confusion because of same icon for different settings.

Closes https://github.com/abapGit/abapGit/issues/5088

* Icon

* Update toolbars

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-24 14:21:02 +01:00
Marc Bernard
cf9ede7d7c
UI: Center Popups (#5274)
* UI: Center Popups

GUI popups were showing up all over the screen. On bigger screens, they often display outside the abapGit HTML frame.

With this change, most popups will show nicely centered or close to it (some fine tuning might still be required).

Notes: 
- Some popups like the one prompting for a transport request do not allow to influence the screen position. 
- Follow-up: Consolidate "Tag Popups" from `ZCL_ABAPGIT_TAG_POPUPS` to `ZCL_ABAPGIT_POPUPS` and adjust accordingly.

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-23 08:50:11 +01:00
Christian Günter
a416de1cf9
Enable clickable icons for link lints (#5271)
* Enable icon for link lints

* Enable clickable icons for link lints
2022-01-17 12:10:00 +01:00
Christian Günter
e74076c0bb
Repo View: 'Order by path' considers object name (#5261)
+ sort files

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-01-10 21:16:32 +01:00
Marc Bernard
074ae5a69b
Refactor: Calling batch input (#5252)
* Refactor: Calling batch input

Standardizes calling batch input API and handling errors.

* Fix indent

* Add new window

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-10 09:27:17 +01:00
Fabian Lupa
a586e5c9ed
Save additional repo view settings (#5257)
* Save additional repo view settings

* Fix formatting
2022-01-10 07:29:11 +01:00
Lars Hvam
c3b9980486
replace XUBNAME with SYUNAME (#5248) 2022-01-06 08:18:45 +01:00
Lars Hvam
1387128719
unit testing updates (#5246)
* unit testing updates

* fix

* split unit test method, ZCL_ABAPGIT_HTML_FORM_UTIL

* run is_empty

* type changes

* update notes

* update

* upd

* update notes

* run check_author_regex

* run parse_commits

* update notes

* add notes

* update

* run extract_author_data1

* run extract_author_data2

* run extract_author_data9

* update notes
2022-01-06 08:14:43 +01:00
Marc Bernard
b2f62e91d5
Repo View: Improve view with folders (#5215)
* Repo View: Improve view with folders 

I made some improvements to the folder view:
- Boxed display of path
- Separate links for folders within path
- Remove leading/trailing `/` in folder display
- Better alignment of `..` parent folder 
- Fix incorrect HTML since `%26lt;tr%26gt;` was before `%26lt;thead%26gt;`

Ref https://github.com/abapGit/abapGit/pull/5159#issuecomment-976124592

* Update CSS

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-12-22 10:31:44 -05:00
Marc Bernard
4f1a4a2b01
Commit page: Add description to links (#5214)
Add some text to clarify links between "Summary" and "Detail" 
https://github.com/abapGit/abapGit/pull/5087#issuecomment-991951078
2021-12-13 15:31:03 -05:00
Marc Bernard
9d5018e39e
Fix code inspection output (#5211)
Fix typo in comparison of object and sub-object
2021-12-13 15:16:07 -05:00
Christian Günter
fe363f7b0a
Downport clipboard_export (#5206)
* Downport clipboard_export

* add transpile filter

* undo
2021-12-13 08:02:19 +01:00
Christian Günter
53a314d946
Command palette: auto close if other palette opens (#5192) 2021-12-09 14:38:10 +01:00
Marc Bernard
b46c8b4599
Refactor: Consolidate front-end classes (#5172)
* Refactor: Consolidate front-end classes

There's no need for two "front-end classes". Moves all of ZCL_ABAPGIT_GUI_FUNCTIONS to ZCL_ABAPGIT_FRONTEND_SERVICES. Now all front-end calls are nicely together.

No functional change, some method reordering. 

Ref #2510, #5145

* Add missing interface

Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-12-09 06:49:43 +01:00
Marc Bernard
1bed7ae318
Repo view: Set minimum width of status column (#5180)
* Repo view: Set minimum width of status column

As seen in https://github.com/abapGit/abapGit/issues/5178, if the repo view table is very wide, the status column might not wide enough and be wrapped. 

Change ensures a minimum width of the column.

* Reduce

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-12-08 11:57:25 -05:00
Marc Bernard
97821c8428
Add user exit for adjusting display of filenames (#5185)
The filenames can become very long, for example, usage of many sub-packages, namespaces, objects like function groups, or BSP/Fiori apps with many sub-objects, or a long paths as starting folder. This can make the repository view very busy or render the output as a very wide table (see #5169, #5178).

This exit allows to adjust the filename according to your own rules. 

Here's an example for shortening the display of files for sub-objects:

```abap
  METHOD zif_abapgit_exit~adjust_display_filename.

    DATA:
      lv_path TYPE string,
      lv_name TYPE string,
      lv_ext1 TYPE string,
      lv_ext2 TYPE string.

    SPLIT iv_filename AT '.' INTO lv_path lv_name lv_ext1 lv_ext2.

    IF lv_ext2 IS INITIAL.
      " Main object
      rv_filename = iv_filename.
    ELSE.
      " Sub object
      rv_filename = |…{ lv_ext1 }.{ lv_ext2 }|.
    ENDIF.

  ENDMETHOD.
```
2021-12-08 08:07:45 +01:00
Christian Günter
451ab7cadf
WebGUI: Disable jump (#5184)
Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
2021-12-06 16:13:24 -05:00
Christian Günter
ad5bad77cb
Webgui: fix path + file encoding issue (#5182)
Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
2021-12-06 15:34:30 -05:00
Marc Bernard
b5af548ed8
Fix "Remove" button for data tables (#5177)
The remove button was not working because it was defined as a second `main` button.
2021-12-03 22:02:46 -05:00
Christian Günter
94e6bdc20b
Patch: Fix link hints (#5176) 2021-12-03 09:10:04 -05:00