Commit Graph

33 Commits

Author SHA1 Message Date
victorizbitskiy
73496a2755
Refactor: Exception handling #4852 (#4869)
https://github.com/abapGit/abapGit/issues/4852
2021-07-13 09:13:25 +02:00
Marc Bernard
25f2bf4d40
DDLS: Fix dump during serialization (#4371)
The specific dump occurred when the source was empty. Now it checks the string length properly.

Closes #4309

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-04 10:06:42 +01:00
Jaime Rodriguez Capote
9ef961cc8a
DDLS newline serialization in 750 and lower (#4143)
* DDLS: Empty line at serialization

Change included in 751+

* Newline serialization remove spaces

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-22 09:47:20 +01:00
Marc Bernard
cc6a207926
DDLS: Uninstall CDS views even if references exist (#4149)
Uninstall will now remove CDS views even if they are referenced in other views.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-12 08:48:48 +01:00
Marc Bernard
bdc44f7476
Remove self-references (#4115)
* Remove self-references

Remove unnecessary self-references (me->)

https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#omit-the-self-reference-me-when-calling-an-instance-method

* 702: Fix syntax error

No chaining with EXPORTING & CHANGING

* remove addiontal me, update abaplint config

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:25:27 +01:00
Marc Bernard
9704ce6708
Fix ZIF_ABAPGIT_OBJECT~EXISTS methods (#3967)
* Fix ZIF_ABAPGIT_OBJECT~EXISTS methods

* Fix EXISTS

* CMPT

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-02 10:23:00 +02:00
Lars Hvam
1c1b04fbe9
update lint config, minor refactors (#3948) 2020-09-27 09:24:31 +02:00
Lars Hvam
03724484f1
use boolc (#3920) 2020-09-23 12:28:13 +02:00
Lars Hvam
9c41a2b7d8
remove text pragmas and pseudo comments (#3827)
* remove text pragmas and pseudo comments

* fix whitespace

* fix carriage return

* test

* test

* Update zcl_abapgit_repo.clas.abap
2020-09-03 09:13:47 +02:00
Marc Bernard
36248e8a83
DDLS: Improve error handling (#3727)
Closes https://github.com/larshp/abapGit/issues/2614

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-13 08:59:03 +02:00
Christian Günter
a785bcdb99
DDLS: Ignore baseinfo file not exists error (#3334)
Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
2020-05-02 16:51:52 +02:00
Jaime Rodriguez Capote
543114963f
abapOpenCheck - Naming Conventions revision #3239 (#3240)
* abapOpenChecks config file

* Ignore SCI config folder

* checks revision

* Revert "checks revision"

This reverts commit 56a12289df.

* Renaming non-constants

Pending:

* Remove SCI configuration

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-09 17:34:26 +01:00
Christian Guenter
bae1e21c5b Refactoring: Delete unused variables 2020-01-13 18:41:52 +01:00
ThomasPloski
dcb4d94275 Support of Baseinfo String for DDLS Object Handler (#2967)
* support of baseinfo string in ddls

* fixes abaplint findings

* fixes abaplint issues
2019-10-11 05:41:01 -07:00
Christian Günter
680dbd6b74 DDLS-Serialization: Write transport request entry (#2927) 2019-09-26 01:41:38 -07:00
Martin Fuchs
9f2db446b1 simplified GET_DESERIALIZE_STEPS
Since all object handler contains exactly the same CASE statement for STEP definition, I would recommend that each object handler simply returns the STEP he belongs to.
This fix should "simply" issue #2499.
2019-05-05 00:57:52 -07:00
Lars Hvam
7bbaf069e2
File format update collection (#2605)
* File format update - changed object handler

I removed the following fields:

CLAS
VSEOCLASS-VERSION

INTF
VSEOINTERF-VERSION

PROG
PROGDIR-STATE

DCLS
AS4LOCAL
ABAP_LANGUAGE_VERSION (if exists)

DDLS
ABAP_LANGUAGE_VERSION (if exists)

DDLX
VERSION
RESPONSIBLE
MASTER_SYSTEM

MSAG
DOKIL-DOKSTATE

ENQU
DD25V-AS4LOCAL
DD25V-AS4VERS

* fix syntax error

* also clear PROG VARCL

* update XML files
2019-03-31 01:17:46 -07:00
GoWa
21527528c6 call redefined method of IF 2019-03-12 21:49:15 -07:00
larshp
25f6284493 implement GET_DESERIALIZE_STEPS
this is a quick fix, field LATE_DESER will be removed in future
2019-03-12 07:37:56 -07:00
Lars Hvam
34e8e0bb69
Uninstall, fix some error messages (#2451)
* SUSO, fix error message

* DDLS error message

instead of "Object could not be deleted"
2019-02-24 22:46:02 -08:00
Lars Hvam
3213d0c2dd
Deserialization performance, refactor COMPARE_TO_REMOTE_VERSION (#2438)
* core part refactored #2436

* indentation

* fix implementations

* delete ZCL_ABAPGIT_COMPARISON_NULL

* pretty print

* Update serializers.md

* downport
2019-02-20 22:20:24 -08:00
Lars Hvam
25d4c9ea07
Remove HAS_CHANGED_SINCE #1021 (#2401)
* core part removed

* remove method implementations
2019-02-15 06:51:57 -08:00
Lars Hvam
89e5010fd0
Naming conventions fixes, #2053 (#2058)
* fix more naming conventions

* more naming conventions fixes
2018-11-07 12:05:27 +01:00
Domi Bigl
cf05295170 mark inactive objects in repo list #1943 (#2017)
* mark inactive objects in repo list

Inactive object are marked in the repo list
The sort order for changed files is not changed
unchanged inactive files come right after the changed files

* move acitve check to object interface

* add is_active for objects up to F

* add is_active for objects up to P

* add is_active for objects up to T

* add is_active for objects up to X

all core object implement (except SSFO) the standard active check via FM RS_INACTIVE_OBJECTS_WARNING now

* add is_active to plugins bridge - always active

* finish object interface implementation + objects

* add is_active for offline with object interface

* rename returning to RV_

* use returning for serialize

* cleanup, PP, UT
2018-10-31 15:54:57 +01:00
Christian Guenter
2a11522598 DDLS, DCLS, DDLX: Improve Error handling 2018-09-29 08:54:35 +02:00
Frederik Hudák
c4639f65ce Removed endmethod and endclass comments - objects folder 2018-07-28 10:10:16 +02:00
christianguenter2
6521d09470 Block pull if any of deserialized object is locked 2018-06-18 14:18:58 +02:00
larshp
334ce44c0d DDLS: fix dump #1488 2018-06-11 12:03:59 +02:00
Lars Hvam
5baeaf070c
Minor changes (#1461)
* remove double space after IF

* remove accesses to table bodies

* remove parameter name where possible

* identical code in conditions
2018-06-06 16:24:15 +02:00
Jakub Filak
b4956a6ce8 DDLS: fix a syntax error on ABAP <7.4
Introduced in 2f9e46421b
Reported as 2f9e46421b (r28962636)
Thank you, @testitorleaveit
2018-05-14 10:31:24 +02:00
Jakub Filak
2f9e46421b DDLS: ignore ACTFLAG and CHGFLAG
Changes to these components disrupt me for nothing.
I do not believe these components needs to be versioned.
2018-05-11 14:47:43 +02:00
Lars Hvam
803148fa0f
fix some naming conventions #1132 (#1211) 2018-02-17 13:55:12 +01:00
Lars Hvam
f14ac831ba
Objects to global (#1187)
* add global classes for objects

* fix metadata

* comment old code

fix serializer class
move missing interfaces

* keep objects and bridge as local

* fix syntax errors

and remove SICF -> tadir dependency, instead tadir -> SICF

* remove dependency TABL -> lcl_popups

* fix indentation

* remove old includes

* fix parser errors

* fix deserializing
2018-02-11 09:16:16 +01:00