Commit Graph

13 Commits

Author SHA1 Message Date
Christian Günter
77d3ff885f Fix hint position for checkboxes (#2834) 2019-08-04 09:47:58 -07:00
Christian Günter
b994382f78 Improve error information - follow up Part 2 (#2814)
- Cleanup JS
- Delete superflous functions and methods
2019-08-03 04:24:03 -07:00
Alexander Tsybulsky
e379dd3cfe Completely dynamic JS hints (#2825)
* draft rewrite hint to be dynamic

* linter fixes

* remove color setting

* remove backspace and esc handling

* close dropdowns

* return some comments in JS

* linter fixes

* Fix hint for dropdown first time + alw close drdwn
2019-08-02 07:45:27 -07:00
Christian Günter
5081ddf7d0 Improve error information - HTML error message (#2775)
* Improve error information

With this commit errors that are raised with zcx_abapgit_exception=>raise
and issued with message are enriched with two additional functions.

1) Go to source
Navigates to the source code position where zcx_abapgit_exception=>raise
is called

2) Callstack
Shows a popup with the full callstack and the possibility to navigate to
the source of each line with double click

This feature requires the full abapGit repository. Without nothing
changes.

* issue messages directly

* zcx_abapgit_exception: adapt callstack handling

- callstack as attribute
- export callstack to ABAP memory only when SAPGui is available

* rename memory id

* Add comment why we don't delete callstack from MEM

* cleanup

* first try html error display

* add some comments

* add longtext

* goto_source and callstack implemented

* part 2

* remove

* fix

* add close button

* fix long classname

* fix linter

* add jump to SE91

* fix lintmr

* fix and cleanup

* fix linter

* fix linter

* fix eslint

* fix linter

* remove message class

* remove superfluous constant

* add missing method implementation

* refactor

* add hotkey for message longtext toggling

* hotkey 2

* refactor + resize callstack popup

* Refactoring: simplify control flow

* fix goto callstack for merged abapGit

* refactor: simplify control flow

* Refactoring: introduce message helper

* fix linter

* remove TODO pragmas

* ren. render meth + move zcl_abapgit_gui_chunk_lib

* refactoring: simplify control flow

* simplify exception handling

* refactor

* refactor

* refactor

* remove duplication

* Rename method

* rename method

* remove superfluous constant

* call ZCL_ABAPGIT_MESSAGE_HELPER dynamically

* cleanup

* Improve UX

* fix linter

* remove hotkey
2019-07-28 03:46:53 -07:00
Christian Guenter
d10d922c06 Patch refactoring: remove duplication + meth order 2019-05-24 03:03:36 -07:00
Christian Günter
9429a3e13b Patch: make cell around checkbox clickable (#2687)
* Patch: make cell around checkbox clickable

* Fixed minor cursor issue
2019-05-21 07:19:27 -07:00
Christian Günter
53dd60c07b Patch: replace links with checkboxes #2673 (#2684)
* Patch: replace links with checkboxes

With this commit we replace the links on the patch page
with checkboxes.
This has several advantages:
- better performance
- simplified and less cluttered UI
- less and easier to understand code

* refactor

* refactoring: introduce new method add_checkbox

* fix linter

* enable link hint navigation

* Refactoring: remove duplication

* refactor: remove duplication

* fix: link hint activate section/lines
2019-05-20 08:44:49 -07:00
Christian Guenter
c61b3f9138 some UI cleanup 2019-05-20 08:43:52 -07:00
Frederik Hudák
02a1a27178 Fix diff filter
@sbcgua  Fixes #2613
2019-05-07 08:02:00 -07:00
Sdfraga
7c8b2228fb Branch Overview Page gitGraph Horizontal Top scrollbar (#2492)
* Adding HTML new elements to BOverview Page

* Adding gitGraph CSS propertires

* Adding gitGraph scroller function

* Set gitGraph Scroller css width dynamically

* Initialize Top Horizontal Scroller on GitGraph

* Adding setGitGraphScroller() to BOverview HTML

* Fixed HTML wrong TAG

* Adding some comments

* Fixing abaplint messages

* Refactoring Indentation for Travis

* Refactoring for Travis

* Removing trailing spaces for Travis
2019-03-14 02:52:40 -07:00
Christian Guenter
963ff52dab Link hints: disable when no tooltips are visible
- Disable link hints mode when no tooltips are visible, e.g. when we pressed a non-existing combination.
- Smaller refactorings
2019-03-01 00:06:53 -08:00
Christian Günter
389512f690 Patch / git add -p: Add and remove sections
After this commit is applied it is possible to add and remove
sections of code on the stage/patch page.
2019-02-25 21:29:24 -08:00
Christian Guenter
0b36ce0c88 move js and css to UI 2019-01-13 07:23:07 +01:00