Commit Graph

845 Commits

Author SHA1 Message Date
Marc Bernard
787bc605b0
Propagate codepage conversion errors (#5638) 2022-06-23 07:12:25 +02:00
Marc Bernard
188996e417
UI: Message box improvements (#5616)
- Align width of message box to width of abapGit div (instead of full window width)
- Don't render "Message (00/001)" for generic messages

Closes #5614
2022-06-08 07:54:29 +02:00
Marc Bernard
da24dba592
Fix dump when switching repo to offline (#5613) 2022-06-05 18:46:31 +02:00
Fabian Lupa
1052ce6e85
Support direct longtexts in exceptions (#5592)
* Support direct longtexts in exceptions

as opposed to already supported indirect T100-based longtexts

* Lint

* Remove direct longtext variable support

* Add unit tests for exception longtext

* Add longtext message to language mismatch error

* Fix missing preserve_newline handling

* Adjust longtext display in error message box

- Convert newlines to html line breaks
- Indicate if a longtext is available on hover

* Fix duplicate preserve newline handling

* Adjust exception longtext rendering

Render linebreaks as html paragraphs

* Align error message box buttons to bottom right

so they do not move on hover when a longtext is available

* Refactor exception unit tests

* Skip failing transpiled tests

* Adjust longtext indicator for error message

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-06-05 18:40:34 +02:00
Fabian Lupa
c04f7b8d7f
Show installation flavour in footer (#5604) 2022-05-31 18:02:02 +02:00
Marc Bernard
bcf01fbfb0
Refactor: Create Tag (#5591)
* Refactor: Create Tag 

Replaces the old style page with a nice HTML form for creating a new tag.

* Update validation

* Allow empty comment and tagger

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-31 09:48:03 +02:00
Fabian Lupa
288e1008dd
Fix object deletions not working (#5594)
Package is now required for CLAS deletion for RS_CORR_INSERT but was not correctly determined for object deletions because of different field names when using MOVE-CORRESPONDING and another missing assignment.

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-05-28 16:52:33 +02:00
Marc Bernard
ddd7e47425
Refactor: Commit list popup (#5569)
* Refactor: Commit list popup

- Move popup for selecting a commit to `zcl_abapgit_popup`
- Allow to skip sorting of commits in `zcl_abapgit_git_commit` which often led to "too many commits" error (on GitHub you get the 300 most recent commits)

Popup will be used in `zcl_abapgit_gui_page_sett_remo` and `zcl_abapgit_gui_page_tags` (separate PR)

* Fix test classes

* Replace popup in remote settings

* Remove type

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-24 16:43:46 +02:00
Marc Bernard
7258fdc315
Repo view: Show icon for different source system (#5514)
In case an objects originates from a different system (`<> sy-sysid`), an icon will be shown after the object. On hover, you can see the id of the original system. 

Closes https://github.com/abapGit/abapGit/issues/3865
2022-05-21 08:13:41 +02:00
Marc Bernard
ba425e0318
Repo stats: don't count lines of ignored files (#5576)
Size and lines of code incorrectly included files that are ignored (outside of `/src/`).
2022-05-19 19:35:13 +02:00
Marc Bernard
297708b054
Repo view: fix "order by transport" dump (#5571)
* Repo view: fix "order by transport"

Partly regression of #5323

Closes #5570

* Add flag

* Improve sort
2022-05-18 21:25:43 +02:00
Marc Bernard
6d2510c84e
Fix tag popup message (#5567)
Tag popup is used for delete and switch therefore the message must be moved to the switch method.
2022-05-18 17:54:15 +02:00
Marc Bernard
ee2c77e6af
Refactor: Email validation (#5568)
Move `is_valid_email` to utitlity class for reuse
2022-05-18 17:42:45 +02:00
Christian Günter
722a954c43
Improve error message for language mismatch (#5544)
* Improve error message for language mismatch

* refactor

* refactor

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-17 13:31:25 +02:00
Marc Bernard
1b4582bc03
Fix commit message encoding (#5508)
* Fix commit message encoding

- Properly encode % and & symbols
- Add unit test for special characters

Closes https://github.com/abapGit/abapGit/issues/2448

* Exclude testclass

* Comment

* update to 2.0.17

* update to 2.0.18

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-05 15:29:38 +02:00
Fabian Lupa
872339dfe8
Refactor remote settings (#5483)
* Add get_switched_origin to repo_online

* Add onclick action for radiobuttons

* Refactor remote settings to allow for direct input

without using value helps

* Adjust branch overview error message

Inform the user about the possibility of changing HEAD directly without using the value help (that failed to show up).

* Fix hidden form fields taking up vertical space

* Add min/max restriction to commit field

on remote settings page

* Implement basic validation for commit id

on remote settings page

* Load previous branch/tag when PR is selected

in remote settings page to be able to switch back to it more easily

* Use current form data in PR and tag selection

on remote settings page, where possible. Otherwise check the form values are the same as the repo instance values.

* Fix issue when changing URL and switching from PR

at the same time

* Remove repo dependency in PR enumerator

to be able to list PRs for the current url on the repo remote settings page

* Update zcl_abapgit_branch_overview.clas.abap

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-05-02 13:22:23 +02:00
Marc Bernard
8888256eed
Fix ignore count in repo statistics (#5505) 2022-04-30 14:54:37 +02:00
Marc Bernard
79da4eb385
Refactor: Database Utility (#5487)
- Update and harmonize description of DB entries
- Fix description for repo checksums
- Increase width of display and edit areas
- Split long method
2022-04-26 07:54:00 +02:00
Marc Bernard
0fea49b74c
Remove "Tag Overview" popup (#5463)
* Remove "Tag Overview" popup

- The "Tag > Overview" feature has been removed (because of bad performance and low value)
- The tag select popup has been refactored. The code has been moved to `zcl/if_abapgit_popups`. Only change is that the popup is now centered like the others.
- Therefore, class `zcl_abapgit_tag_popups` has been removed

* Update injectors

* Remove interface

* Secondary key
2022-04-25 07:28:07 +02:00
Marc Bernard
3742f2b0d6
UI: Transport popup (#5453) 2022-04-22 07:37:15 +02:00
Alexander Tsybulsky
2cc3f53fc5
Rework checksums (#5328) 2022-04-13 11:29:23 +02:00
Marc Bernard
985dbf1116
Remove "Branch Overview" page (#5428)
* Remove "Branch Overview" page

- The "Branch > Overview" feature has been removed (see #5411 for reasoning). 
- The merge feature has been refactored into a new HTML page under "Branch > Merge" (#5402)

Closes #5411

* Remove old page

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-11 16:34:14 +02:00
Marc Bernard
63a87fa6e7
TABU: Add "jump" to SE16 (#5459)
* TABU: Add "jump" to SE16

When using "Data Cofiguration" you can now jump from the repo view to the data browser (`se16`).

* Simplify

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-08 15:39:03 +02:00
Marc Bernard
de39745541
UI: Fix escaping of textarea input (#5456) 2022-04-07 16:08:19 +02:00
Marc Bernard
ef502d8275
UI: Transport popup (#5452)
Add parameter for new logic
2022-04-06 15:55:48 +02:00
Marc Bernard
7e7104e050
UI: Word-wrap long filenames in repo/stage views (#5424)
Closes #5418

Before

After

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-05 17:17:55 +02:00
Marc Bernard
daa35ab666
UI: Transport popup (#5438)
If default transport is set and its type matches to what is required, then use it as default for the transport popup.

This will make it easier for example if a pull or uninstall failed and needs to be repeated since you want to continue using the same transport.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-05 16:15:08 +02:00
Marc Bernard
f712eb17a5
Folder logic "mixed" (#5413)
* Folder logic "mixed"

Introduces a new folder logic named `mixed` which combines `prefix` and `full`. The root package name will be used as prefix for all sub-packages but the package names are *not* concatenated recursively. This will allow for using significantly logic package names.

Also includes several new unit tests especially for nested packages which had not been tested before.

Closes #5410

Todo: Update docs

* Add constant

* Add options to UI

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-03-31 13:35:34 +02:00
Christian Günter
7992625644
Repo List: fix sort (#5397)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-03-15 18:56:55 +01:00
Lars Hvam
e5eb8d0d0a
icon, fix short dump (#5386)
#5385
2022-03-01 08:02:32 +01:00
Frederik Hudák
adb529152b
minor css adjustments (#5372)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-02-21 17:37:40 +01:00
Marc Bernard
6a85f93312
Update CSS for password fields and buttons (#5364)
Minor addition to CSS

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-21 16:38:45 +01:00
Alexander Tsybulsky
91cd4c3653
Separate zif_abapgit_repo (#5329)
* zif_repo basis

* all but zcl_abapgit_repo_srv

* fix zcl_abapgit_repo_srv

* remove create_new_log from interface

* "hack" -> "TODO"

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-19 09:22:46 +01:00
Lars Hvam
4ac0183df2
unit testing updates (#5354) 2022-02-19 09:02:13 +01:00
g-back
cce8be5f1b
persist "show folder view" option (#5343)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-10 12:01:54 +01:00
Frederik Hudák
baa09083e6
Repo view - show paths below object name (#5323)
* Repo view - show paths below object name

* rework table rows

* fix syntax

* remove old comment
2022-02-09 08:48:12 +01:00
Christian Günter
a4a13e56f7
Repo page: remove orphaned hotkey 'x' aG settings (#5334)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-02-07 12:10:52 -05:00
Fabian Lupa
42a642ccd0
Set window title for log viewer (#5300) 2022-01-30 14:19:13 -05:00
Marc Bernard
6efaa0e0b4
Refactor: Remove ddic flag (#5295)
Closes #5264

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-30 16:37:56 +01:00
Marc Bernard
884a71e00e
Forms: Radio options and minor fixes (#5291)
- Allow for radio options to be arranged in column (instead of side-by-side)
- Render maxlength for text fields only when provided

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-26 19:54:09 +01:00
Marc Bernard
254e6d51e3
UI: Center Popups - Part 2 (#5290)
* UI: Center Popups - Part 2

Adjusting more popups #5275

* Refactor for method length

* Lint indent
2022-01-25 18:40:20 +01:00
Frank Müller
c932426b44
Pre Filter Backend and GUI Logic (#5227)
* Initial

* Adjustments

* Router

* Abaplint

* abaplint

* diff between eclipse and vscode

* Multiple Adjustments

* Split Backend And GUI Logic

* Multiple Adjustments

* No Unit Tests

* abaplint

* Rename ZCL_ABAPGIT_REPO_PRE_FILTER to ...TR

* Multiple Adjustments

* Refactor the OVP action links into a toolbar

* abaplint

* Replace BAPI_MSG by STRING

* Rename Pre Filter to Object Filter

* Rename Pre Filter also in abap_transpile.json

* restore from main

* Check if <ls_item>-li_class is filled in Toolbar

* Adj. toolbars and move TR Req to zif_abapgit_popup

* abaplint

* Move  ty_trrngtrkor_tt to zif_abapgit_definitions

* abaplint

* Move and rename filter menu entries

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: IBM <mbox-060-sap-extern-tbom@daimler.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-01-25 10:00:09 +01:00
Marc Bernard
d7cdb65243
Forms: Minimum text field length (#5287) 2022-01-24 17:10:40 +01:00
Marc Bernard
656e94c612
Change icon for user settings (#5282)
* Change icon for user settings

Reduce confusion because of same icon for different settings.

Closes https://github.com/abapGit/abapGit/issues/5088

* Icon

* Update toolbars

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-24 14:21:02 +01:00
Marc Bernard
cf9ede7d7c
UI: Center Popups (#5274)
* UI: Center Popups

GUI popups were showing up all over the screen. On bigger screens, they often display outside the abapGit HTML frame.

With this change, most popups will show nicely centered or close to it (some fine tuning might still be required).

Notes: 
- Some popups like the one prompting for a transport request do not allow to influence the screen position. 
- Follow-up: Consolidate "Tag Popups" from `ZCL_ABAPGIT_TAG_POPUPS` to `ZCL_ABAPGIT_POPUPS` and adjust accordingly.

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-23 08:50:11 +01:00
Christian Günter
a416de1cf9
Enable clickable icons for link lints (#5271)
* Enable icon for link lints

* Enable clickable icons for link lints
2022-01-17 12:10:00 +01:00
Christian Günter
e74076c0bb
Repo View: 'Order by path' considers object name (#5261)
+ sort files

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-01-10 21:16:32 +01:00
Marc Bernard
074ae5a69b
Refactor: Calling batch input (#5252)
* Refactor: Calling batch input

Standardizes calling batch input API and handling errors.

* Fix indent

* Add new window

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-10 09:27:17 +01:00
Fabian Lupa
a586e5c9ed
Save additional repo view settings (#5257)
* Save additional repo view settings

* Fix formatting
2022-01-10 07:29:11 +01:00
Lars Hvam
c3b9980486
replace XUBNAME with SYUNAME (#5248) 2022-01-06 08:18:45 +01:00