Commit Graph

101 Commits

Author SHA1 Message Date
Lars Hvam
7b336a4a71
cleanup unused local variables (#4739) 2021-05-01 09:51:05 +02:00
Lars Hvam
1b9674e620
git transport: error on empty git reply (#4714) 2021-04-25 10:01:10 +02:00
Mike Pokraka
69ac4fd768
Change some masters to main %26 remove unused parameter (#4710)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-19 17:15:47 +02:00
Mike Pokraka
dd6becccbe
Accept remote without HEAD (#4706)
* Accept remote without HEAD

* Update src/git/zcl_abapgit_git_branch_list.clas.testclasses.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-18 11:18:33 +02:00
Lars Hvam
b7d6870077
parsing git branch list, throw errors (#4547)
* parsing git branch list, throw errors

closes #4523

* downport

* fix whitespace

* bugfix
2021-02-21 16:21:34 +01:00
Lars Hvam
5e2d8de52a
/git/, put method get_length under test (#4224)
* /git/, put method get_length under test

add unit tests for method get_length

the method will probably be refactored sometime in the future, I think the bit manipulation can be replaced with some hex, div and bit-mask magic

* fix tabs
2020-11-24 08:02:39 +01:00
Lars Hvam
381d40e35a
ZCL_ABAPGIT_HASH add shorthand methods (#4220)
This adds shorthand methods for the SHA1 calculation of the different git artifacts.
More logic in ZCL_ABAPGIT_HASH, but easier to read and less application logic.
2020-11-23 14:30:31 +01:00
Lars Hvam
266ffb2a7c
/git/: remove unused param, add unit test (#4124)
UPLOAD_PACK_BY_BRANCH
- remove unused parameter EO_BRANCH_LIST

add unit test to ZCL_ABAPGIT_GIT_UTILS
2020-11-03 08:47:12 +01:00
Lars Hvam
df652f0436
delete various unused local variables (#4126) 2020-11-03 08:43:04 +01:00
Marc Bernard
bdc44f7476
Remove self-references (#4115)
* Remove self-references

Remove unnecessary self-references (me->)

https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#omit-the-self-reference-me-when-calling-an-instance-method

* 702: Fix syntax error

No chaining with EXPORTING & CHANGING

* remove addiontal me, update abaplint config

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:25:27 +01:00
mariusraht2
761bbe51af
ZCL_ABAPGIT_GIT_COMMIT: get_by_branch should return parent commit hash too (#4069)
* Implementation

* Turn exporting to returning parameter

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-27 10:01:15 +01:00
mariusraht2
9efa0c916a
Implementation (#4067) 2020-10-27 08:04:51 +01:00
mariusraht2
7ffb4ff91d
Move commit-specific methods from ZCL_ABAPGIT_BRANCH_OVERVIEW to new class ZCL_ABAPGIT_GIT_COMMIT (#4026)
* Implementation

- Create new class ZCL_ABAPGIT_GIT_COMMIT
- Move commit-specific methods from ZCL_ABAPGIT_BRANCH_OVERVIEW to ZCL_ABAPGIT_GIT_COMMIT
- Change methods visibility (from private to public) and type (from instance to class method)

* Remove ##NO_TEXT

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Rename get to get_from_remote

* abapLint: Remove space

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* abapLint

- Remove space
- Remove unused type in ZCL_ABAPGIT_BRANCH_OVERVIEW

* abapLint: Remove space

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Remove obsolete class attribute

* Separate get_by_branch and get_by_commit

* Remove duplicate char

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Remove iv_repo_name; replace its usage by url

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-19 11:24:38 +02:00
mariusraht2
a366e024ea
full_tree: Rename iv_branch to iv_parent (#4041)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-18 09:04:55 +02:00
mariusraht2
53adc30708
Add pull_by_commit (#4023)
* Implementation

* Clean-up

* Remove iv_branch

* abapLint

* Remove optional for iv_commit_hash

* Change method parameters

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-16 12:30:43 +02:00
mariusraht2
90b0f9fae5
upload_pack_by_commit: Be able to get remote objects by any commit hash (#3836)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Update pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Delete pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Rename upload_pack to upload_pack_by_branch

* Renamed missed references

* Introduce new method upload_pack_by_commit

* abapLint: Removed forbidden pragmas/comments

Forbidden pseudo comment
Forbidden pragma

* Replaced numc2 by n length 2

* Removed unneccessary changes of pretty printer

* Removed restriction of deepen_level

* N alone is of length 1 and not numeric

* abapLint

* Remove branch name

* Merge redundant source code into upload_pack

* Make upload_pack private

* abapLint

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/git/zcl_abapgit_git_transport.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Omit receiving

* Omit exporting

Co-authored-by: mariusraht1 <mariusraht+1@gmail.com>
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2020-10-13 15:58:39 +02:00
mariusraht2
a8df9c286f
upload_pack_by_branch: Replace deepen with deepen_level (#3835)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Update pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Delete pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Replaced deepen boolean with deepen_level

* Replaced numc2 by n length 2

* Removed restriction of deepen_level

* N alone is of length 1 and not numeric

Co-authored-by: mariusraht1 <mariusraht+1@gmail.com>
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-09 09:50:00 +02:00
mariusraht2
6f130d0edc
Client must send an empty packfile (#3856) 2020-09-09 08:39:05 +02:00
Marc Bernard
c09cc67c83
Fix startup of repo view (#3831)
* Update error msg

* Fix login popup errors and cancelation

* Remove validate/reset methods

* Lint

* Rename iv_repo_online to io_repo_online

* Change to error in status bar

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-04 09:32:38 +02:00
Lars Hvam
9c41a2b7d8
remove text pragmas and pseudo comments (#3827)
* remove text pragmas and pseudo comments

* fix whitespace

* fix carriage return

* test

* test

* Update zcl_abapgit_repo.clas.abap
2020-09-03 09:13:47 +02:00
mariusraht2
3a75ade563
Rename upload_pack to upload_pack_by_branch (#3818)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Update pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Delete pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Rename upload_pack to upload_pack_by_branch

* Renamed missed references

Co-authored-by: mariusraht1 <mariusraht+1@gmail.com>
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-01 16:23:30 +02:00
Marc Bernard
af5b898a37
Refactor branch constants (#3784)
* Branch constants

* Refactor branch constants

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-24 11:25:46 +02:00
Marc Bernard
e4bafbe715
Validate if branch exists when displaying repo (#3749)
* Validate if branch exists when displaying repo

* Validate if branch exists when displaying repo

* Lint

* Lint and 702

* Lint

* Rename validate_branch to validate

* Fix msg and branch display name

* Move msg to UI layer

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-08-24 11:15:46 +02:00
fdupret
511090d63d
Handle "invalid committer" error (#3774) 2020-08-20 17:56:40 +02:00
Lars Hvam
f878f3b4c3
remove some double spaces (#3740) 2020-08-16 08:24:12 +02:00
Lars Hvam
d36b43defe
line break parameters (#3444)
* line break parameters

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* fix
2020-06-04 15:10:35 +02:00
Lars Hvam
aec7468aad
Type Hunting (#3414)
* Type Hunting

* update

* update

* flag
2020-05-26 05:55:28 +02:00
Marc Bernard
3620e12ee9
Fix CX_SY_RANGE_OUT_OF_BOUNDS dump (#3394)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-23 11:53:02 +02:00
larshp
2d168e170b move stage structures to interface #3377 2020-05-21 07:25:54 +02:00
germanysources
47a2332cc7
encode and decode signed commits (#3373)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-20 12:42:38 +02:00
Lars Hvam
eb7e819b25 refactoring, delete unused variables and methods (#3203)
* zlib

* xml

* processor

* shi5

* remove unused filter parameter

* pinf cleanup

* ssfo delete empty method

* highlighter

* gui page res, remove unused

* remove unused in diff class

* adt link

* gui, remove 2 unused parameters

* branch overview
2020-02-09 09:38:17 +01:00
GB
4b35d98e5d remove macro, replace with method calls 2020-02-03 09:13:31 +01:00
Lars Hvam
7aea72f63a
git pack, remove macros #3170 (#3191) 2020-02-03 06:57:53 +01:00
mariusraht2
a1699302a6 Beautify (#3179)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Beautify

[OPT] Executed Pretty Printer
[OPT] Moved some types to definitions interface to be global

* Beautify

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
2020-01-26 14:32:48 +01:00
Lars Hvam
75812fb17b
less prefixes (#3144) 2020-01-11 09:24:36 +01:00
Lars Hvam
b42f3bc485
Refactoring (#3134)
* fully type constants

* moving to single line

* move to single line

* enable keep_single_parameter_on_one_line
2019-12-28 12:11:32 +01:00
mariusraht2
02204d07b4 Improved time conversion (#3096)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Improved time conversion

Preparation for #3040

> rename time%3D>get to time%3D>get_unix
> added time conversion from unix to real (get_real)
> added unit tests for time conversion

* abapLint

* Raise cx_static_check and removed exc handling
2019-12-02 09:28:41 +01:00
Lars Hvam
3776ac353a
Get all branches, including pull request refs (#3031)
* update example for listing branches

* do not ignore any branches

* add new get_all method

* Update zcl_abapgit_git_branch_list.clas.testclasses.abap
2019-11-06 09:51:34 +01:00
Lars Hvam
678b3bebd5
pretty print class (#3032) 2019-11-06 08:53:28 +01:00
Lars Hvam
714fe7202d
whitespace fixes (#2964)
* whitespace fixes

* fix sql compare operators
2019-10-11 02:50:16 -07:00
Fabian Lupa
cb80f78a6e Cancel branch creation if branch already exists (#2854) 2019-08-07 21:22:11 -07:00
Lars Hvam
998815f6fb
closes #2791 (#2792)
another quick fix for the staus codes, #2791
2019-07-17 01:06:12 -07:00
Lars Hvam
1dbd4d1912
Refactoring types (#2785)
* align use less different types

* refactor

* updates
2019-07-15 09:33:37 -07:00
Lars Hvam
7bbaf069e2
File format update collection (#2605)
* File format update - changed object handler

I removed the following fields:

CLAS
VSEOCLASS-VERSION

INTF
VSEOINTERF-VERSION

PROG
PROGDIR-STATE

DCLS
AS4LOCAL
ABAP_LANGUAGE_VERSION (if exists)

DDLS
ABAP_LANGUAGE_VERSION (if exists)

DDLX
VERSION
RESPONSIBLE
MASTER_SYSTEM

MSAG
DOKIL-DOKSTATE

ENQU
DD25V-AS4LOCAL
DD25V-AS4VERS

* fix syntax error

* also clear PROG VARCL

* update XML files
2019-03-31 01:17:46 -07:00
Lars Hvam
fc167ff3cd
update abaplint config to latest (#2480)
* update abaplint config to latest

* remove some descriptions

* remove more descriptions

* fixes

* fixes
2019-03-04 07:12:42 -08:00
Christian Guenter
8cc6567d40 rename zcl_abapgit_tag to zcl_abapgit_git_tag 2019-02-26 21:29:41 -08:00
Lars Hvam
e42fa60841
git minor changes (#2403)
* git minor changes

code inspector changes

* pretty print
2019-02-15 06:52:11 -08:00
Lars Hvam
e8b6b0020d
Add interface for ZCL_ABAPGIT_PROGRESS #2303 (#2316)
* interface for progress class

* adjust branch overview

* adjust git pack

* adjust diff page

* adjust objects class

* adjust activation class

* adjust repo online class

* adjust serialize class

few methods moved

* adjust tadir class
2019-01-23 06:28:54 +01:00
larshp
3509df80ae add class descriptions 2019-01-14 20:06:33 +01:00
Eduardo Ferrari Copat
d47027ad6c Remove redundant class and interface metadata (#2195)
* Remove CLSFINAL from VSEOCLASS serialization

* Remove EXPOSURE from VSEOCLASS serialization

* Remove clsabstrct from VSEOCLASS serialization

* Remove EXPOSURE from VSEOINTERF serialization

* Revert "Remove EXPOSURE from VSEOINTERF serialization"

This reverts commit 4036b7d015.
2018-12-12 14:31:42 +01:00