Commit Graph

638 Commits

Author SHA1 Message Date
Marc Bernard
7da94f396d
Fix jump to objects with special characters (#4558)
Fixes jump to an object in case the object name contains escaped characters

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-24 05:55:23 +01:00
Lars Hvam
4a30f00a7e
HTML, minor performance? (#4553)
* HTML, minor performance?

@FreHu can you try this, to see if the performance is a few ms better?

* upd
2021-02-22 06:51:24 +01:00
Frederik Hudák
add83f5b94
Repo overview performance improvements (#4541)
* Repo overview performance improvements

* Rework map_repo_list_to_overview

* Reduce usages of get_key

* Fix inline data

* Don't load package descriptions in repo overview

the select is expensive

* suppress titles for non-favorite repositories

* lint

* Update src/ui/zcl_abapgit_gui_page_repo_over.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* optimize render_repo_palette

* Optimize gui_router

* Update zcl_abapgit_gui_page_repo_over.clas.abap

* Update zcl_abapgit_migrations.clas.abap

* remove unused variable

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-21 11:29:01 +01:00
Frederik Hudák
e68feff2e1
Main page - disable hover info for package/user links (#4545)
* Main page - Only show hover info for favorites

in package, user links

suppress titles for non-favorite repositories

* always suppress loading titles in repo overview

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-20 17:22:25 +01:00
Frederik Hudák
c3012513b3
Optimize performance of switching branches (#4548) 2021-02-20 17:16:50 +01:00
Lars Hvam
40cd29297d
overview page, dont display "https://" (#4539)
* overview page, dont display "https://"

dont display "https://" or "http://" in overview page

delete unused method HAS_FAVORITES

* add title
2021-02-20 10:28:02 +01:00
Lars Hvam
da53a04abb
zif_abapgit_html_viewer: refactor CNHT_POST_DATA_TAB & CNHT_QUERY_TABLE (#4499)
* zif_abapgit_html_viewer

* fix syntax
2021-02-12 11:05:46 +01:00
Lars Hvam
fc3fbbaba8
remove install abapgit option from debug page (#4501)
* remove install abapgit from debug page

* fix
2021-02-11 06:51:21 +01:00
Lars Hvam
8e07d46f4b
jump_se11, remove unused parameters (#4498) 2021-02-09 15:50:27 +01:00
Marc Bernard
3766260312
Correct statistics for offline repos (#4489)
* Correct statistics for offline repos

- Adjust labels: "Remote" to "ZIP"
- Fix some file counts

* ZIP

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-09 07:33:17 +01:00
Marc Bernard
3db8c950b8
Adjust "ZIP" spelling (#4495)
* ZIP

* ZIP

* ZIP

* ZIP

* ZIP
2021-02-08 14:46:05 +01:00
Marc Bernard
c26d2158a1
Fix minor CSS issues (#4492)
Fix the following issues to make it CSS3 compliant:
- Font-style bold is not a font-style value
- Family names containing whitespace should be quoted
- Same color for background-color and border-color

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-06 09:39:03 +01:00
Marc Bernard
a15ca2a801
Remove packages from duplicate file check (#4488)
* Remove packages from duplicate file check 

Closes #4485

* Lint
2021-02-05 07:18:38 +01:00
Christian Günter
3674fa55fc
fix sapevents for chromium based browser control (#4478)
* fix sapevents for chromium based browser control

* Fix tooltip hotkey + remove duplication

* fix eslint errors

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-04 15:18:10 +01:00
Marc Bernard
73576ee60e
Improve error messages (#4472)
* Improve error messages

Pass T100 messages to UI/log

* T100 errors

* APACK

* OO

* DEVC

* DRUL

* DTDC

* SRVB

* OBJS

* Program

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-03 16:31:55 +01:00
Marc Bernard
13d3d0aac1
Replace void types (#4484) 2021-02-03 05:53:50 +01:00
Marc Bernard
eb4986389e
Adjustments to Debug Info (#4459)
* Adjustments to Debug Info

- Fix display of abapGit installation package (side-effect of changed package assignment)
- Clarify that list of supported objects is relevant for the local system only (since it's release dependent)
- Add link to complete list of supported objects

* Remove pragmas
2021-01-27 09:23:44 +01:00
Marc Bernard
212f9f8da2
Remove obsolete code related to hotkeys (#4456)
Remove code related to user-specific hotkey settings.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-26 19:36:24 +01:00
Marc Bernard
4b34d5743e
Minor adjustment to front-end dialogs (#4458)
- Change extension of ZIP-files to lower case ".zip"
- Adjust error messages

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-26 19:31:33 +01:00
Marc Bernard
6d356400f6
Terminology: Inclusive Language - Part 4b (#4436)
Change of terminology (#4043). This time with the missing changes in service_repo.

repo_srv and serializer will be next after #4431.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-23 10:13:42 +01:00
Marc Bernard
40efc567f6
Automatic creation of top repository package (#4431)
* Automatic creation of top repository package

When adding a repository, it is not necessary anymore that the top SAP package assigned to the repository exists. Just enter a package name and clone (works for offline, too). 

The initial diff will now show that the top package exists remotely only. Therefore, when pulling, you will not get the "confirm overwrite package" popup anymore. Yippie!

* Typo

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-23 10:11:54 +01:00
Frederik Hudák
45badeb527
Add refresh button to stage page (#4437) 2021-01-23 09:56:15 +01:00
Lars Hvam
431f7095f4
bugfix, Component MAIN_LANG_ONLY not found in targ (#4435)
#4434

rolls back changes from #4432
2021-01-22 10:17:24 +01:00
Marc Bernard
978b7a4a57
Terminology: Inclusive Language - Part 4 (#4432)
* Terminology: Inclusive Language - Part 4

Continue change of terminology (#4043)

* Service

* Language

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-21 17:18:03 +01:00
Marc Bernard
5c7baae1ab
Refactor CTS API and support additional objects (#4424)
* Refactor CTS API and support additional objects

- Change methods from public to private
- Reduce interface to public methods
- Support objects that can not be locked but can be included in a transport (prep for namespaces)

* Remove lenght check

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-20 18:23:10 +01:00
Marc Bernard
31a550db0f
Refactor I18N settings (#4423)
* Refactor I18N settings

- Consolidate I18N parameters into a structure and pass it to xml and serializer classes (#4415)
- Continue change of terminology (#4043)

* Remove changes to serializer class

* Main lang

* DSYS

* OTGR

* Repo view

* Main langu

* Repo view %26 stage

* Serialize

* Settings

* Repo view

* Defs

* Stage

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-19 14:29:09 +01:00
Marc Bernard
fd86eaa0bc
Repo view: Adjust link to settings & render transport (#4422)
* Repo view: Adjust link to settings & render transport 

- Update link text
- Re-init flag to render transport (in case the package has changed)

* Main langu
2021-01-19 08:11:22 +01:00
Alexander Tsybulsky
47dae10ab0
I18n settings (#4416)
* dot abapGit i18n_langs

* rewrite dot abapgit (better design)

* settings

* linter fix

* review fixes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-18 09:32:55 +01:00
Marc Bernard
a824eef662
Prevent staging of duplicate files (#4403)
* Prevent staging of duplicate files

Since objects cannot exist in multiple packages, the staging page is now checking the selected files to prevent the resulting repo from containing an object multiple times.

If an object is moved to another SAP package and the corresponding files are seleted to be added to the repo (for the new package), then the files must also be removed from the repo (from the old package). If not, an error is raised.

* Remove other changes

* Update file status

* Extend unit test

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-17 09:28:54 +01:00
Lars Hvam
db6db7cf79
remove more unused variables (#4413) 2021-01-15 17:22:51 +01:00
Lars Hvam
690da4e51f
delete some unused variables (#4411)
* delete some unused variables

* bdef, remove unused vars

* remove some more
2021-01-15 08:31:01 +01:00
Marc Bernard
748ff1b09b
Dialogs: Remove old repo settings (#4406)
- Remove repo settings page
- Redirect repo overview to new repo settings
- Fix "requirements" table on new repo settings page

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-14 14:13:35 +01:00
Marc Bernard
fcd1159416
UI: Adjust "back" for settings (#4409)
Changes "back" to go to bookmarked page. Closes #4408
2021-01-14 07:44:28 +01:00
Marc Bernard
40331ee80f
Follow-up HTML viewer exceptions (#4404)
* Follow-up HTML viewer exceptions

Properly catch HTML viewer exceptions (follow-up #4396) to avoid dumps

* Add exception

* Add exception

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-12 08:54:03 +01:00
Lars Hvam
f1dbe88729
suppress syntax warnings (#4398) 2021-01-11 10:28:27 +01:00
Lars Hvam
89c77d9e6b
zif_abapgit_html_viewer, change to class based exc (#4396)
* zif_abapgit_html_viewer, change to class based exc

#4381, part A

* catch
2021-01-11 09:59:26 +01:00
Lars Hvam
889d062e1c
data, basic serialization (#4369)
* data

* refactor ZCL_ABAPGIT_SERIALIZE

* upd

* serializing

* cleanup

* fix

* fix

* rename
2021-01-09 10:50:58 +01:00
Marc Bernard
2e476eb7b2
Dialogs: HTML forms for repo settings (#4384)
* Dialogs: HTML forms for repo settings

This moves the repo settings to HTML forms. The settings are split into three pages:
- Repository settings (ie abapgit.xml)
- Local settings
- Infos

* Lint

* Infos > Stats

* Infos > Stats

* Infos > Stats

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-08 13:09:37 +01:00
Marc Bernard
e5540ae054
UI: Refactor form class and fix textarea (#4379)
* UI: Refactor form css class

- Move styles to CSS
- Provide default for form class
- Remove form class from render calls

* Update css

* Condense textarea

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-05 09:25:58 +01:00
Lars Hvam
9f583c1bcc
use non interfaced fields_to_string() (#4378) 2021-01-05 07:57:30 +01:00
Lars Hvam
8b506aa077
omit some default parameter names (#4370)
* apack, omit parameter names

* mass and objects

* omit

* omit
2021-01-04 10:41:20 +01:00
Lars Hvam
1d1d046d39
data: use ajson for serialization (#4363)
* data: use ajson for serialization

* config to_json

* implement from_json

* fix

* move method build_table_itab to new class

* start deserialize

* update

* scaffolding

* add page

* upd

* fix warning

* update

* rename variable

* upd

* update

* reorder
2021-01-03 04:55:24 +01:00
Lars Hvam
d35848b2f8
string map: change set() input value to csequence (#4368) 2021-01-03 04:51:10 +01:00
Marc Bernard
6623679e67
Dialogs: HTML forms - follow-up (#4329)
* Dialogs: HTML forms - follow-up

Follow-up to #4264:

- Split `zcl_abapgit_html_form` class
Processing form data has been moved to `zcl_abapgit_html_form_utils`

- `iv_is_main` refactored to `iv_cmd_type`

- In case of unsaved data, form exit will now prompt for confirmation (`zcl_abapgit_html_form_utils`)

* dot space

* lint

* Remove const

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-02 15:12:09 +01:00
Eduardo Ferrari Copat
16258c59b6
Checkout commit: additional user interface (#4120) (#4349)
* Set branch name with commit

* Can't stage when commit is checked out

* Add missing variable

* Remove passing a parameter, since set relies on IS SUPPLIED

* Undo last commit

* Intelligent create branch when commit is checked o

ut

* lint

* Fix cancel buttons (missing commit)

* Code review

* Remove unused variables

* Add extra line

* Remove unused variable

* Add back new branch pop-up. Considers tag.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-28 12:39:26 +01:00
Lars Hvam
704198f521
unit testing test (#4345)
* update deps

* update deps

* remove CHAR01 usages

* update deps

* update deps

* update deps

* all unit tests in syntax now running!

* update deps

* update deps

* update deps

* enable additional exception unit tests

* zcl_abapgit_string_map running

* upd

* login manager running

* update deps, add progress clas

* upd

* update deps

* fix whitespace

* update deps

* upd

* update deps

* update deps

* update deps

* use cl_abap newline

* upd

* run more

* sort

* update deps

* add intf

* update deps

* upd

* add zcl_abapgit_exit

* some xml interfaces

* zcl_abapgit_version running
2020-12-27 18:00:59 +01:00
Lars Hvam
4b2309f952
zif_abapgit_html, remove uses of char1 (#4351) 2020-12-24 08:36:58 +01:00
Marc Bernard
73cba7ff1b
Fix sorting of objects in repo view (#4346)
Regression of #4087. Closes #4339

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-22 06:47:45 +01:00
Marc Bernard
f1bf013adf
Refactor: GUI router state transfer (#4336)
Moving page-dependent state changes to separate methods for clarity
2020-12-16 08:23:00 +01:00
Christian Günter
0e4f29efa1
New Repo: Check package existence before showing popup (#4323)
* New Repo: Check package existence before showing p

* fix lint errors

* fix linter

* add more unit tests

* refactor unit tests

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-14 14:54:28 +01:00