Commit Graph

19 Commits

Author SHA1 Message Date
Frederik Hudák
1bb195b344 Removed the rest of endmethod/endclass comments 2018-10-18 07:27:27 +02:00
Lars Hvam
fa39fcd43f
Code inspector fixes (#1997)
* pretty print

* definitions to top of routine

* space before .

* omit parameter names where possible

* double space after if

* remove pseudo comments where possible
2018-10-12 07:56:27 +02:00
Jakub Filak
6f6338bc67 repo: skip missing packages in new repo validation
When we try to add a new online repository and we have a repository
whose package does not exist in abapGit we get a short dump caused
by assert in the method zif_abapgit_sap_package~read_parent of
the class zcl_abapgit_sap_pacakge.

This commit makes sure we skip such repositories because we believe it
does not make sense to prevent us from cloning in these cases.

Thank you Petr Benes <petr.benes@sap.com>!
2018-08-10 07:02:46 +02:00
larshp
273947240c interface and factory for persist_repo 2018-08-10 07:02:30 +02:00
larshp
1f75651f90 validate packages: ignore sub packages if set
validate packages: ignore sub packages if set #1779
2018-08-07 09:31:45 +02:00
larshp
48e5a247f2 Online: method INITIALIZE + RESET_STATUS to privat
Change methods INITIALIZE + RESET_STATUS to private in ZCL_ABAPGIT_REPO_ONLINE

One external call of INITIALIZE changed to use REFRESH instead

Part of refactoring for issue #1757
2018-08-05 11:28:50 +02:00
Christian Günter
7ac8dc15b6 Remove local SHA1 from online repository #1485, #1509 (#1666)
* Remove local SHA1 from online repository

In this commit we remove the local SHA1 and all its references from
ZCL_ABAPGIT_REPO_ONLINE. SHA1 is also removed from repo persistency.
SHA1 insn't needed anymore. All where-used places were either migrated to
remote_SHA1 or removed.

* reintroduce logic after push
2018-07-22 10:11:09 +02:00
Christian Günter
4f9f47cd59 Set transport request if needed during uninstall or reset local (#1596)
* delete checks: set transport request if needed

this ensures that the transport request is set when deleting objects.
E.g. uninstalling the repositoy or reset local.

* separate type for delete checks
2018-07-11 16:18:08 +02:00
COPAT
e3676de797 validate sub and super packages from repos
validate sub and super packages from repos
2018-07-05 23:35:29 +02:00
Lars Hvam
b71b96fc9f
Merge pull request #1496 from larshp/repo_srv
interface for ZCL_ABAPGIT_REPO_SRV
2018-06-14 06:27:51 +02:00
larshp
45aa71f2da interface for ZCL_ABAPGIT_REPO_SRV 2018-06-13 17:28:56 +02:00
larshp
4e67e884de first dependency injection #1390
* extract public methods of ZCL_ABAPGIT_TADIR to new interface
* create factory ZCL_ABAPGIT_FACTORY
* refactor existing calls
2018-06-10 12:11:48 +00:00
Lars Hvam
e2b430779d
clone without pull #832 (#1371)
* create online without pull #832

* update tutorial

* fix indentation
2018-05-11 10:14:51 +02:00
Lars Hvam
7a9bec815a
Seperate UI and logic (#1286)
* no activation popup in background

* purge: seperate ui and logic

* order by primary key
2018-03-30 12:28:00 +02:00
Lars Hvam
7152b4281a
Refactoring (#1279)
* URL: rename and add validation method

plus validate url in NEW_ONLINE

* optimize select

* move write protection check

* start refactoring gui away from deserializati/pull

* mvoe ZCL_ABAPGIT_SERVICES_ABAPGIT to UI

* delete ZCL_ABAPGIT_SERVICES_BKG

moved to GUI page

* move ZCL_ABAPGIT_SERVICES_GIT to UI

* move ZCL_ABAPGIT_SERVICES_REPO to UI

* fix indentation

* overwrite popup refactored to UI
2018-03-29 14:29:03 +02:00
Lars Hvam
b9cc65017f
Code inspector (#1272)
* code inspector

+ delete unused methods
+ move methods to private
+ remove commented code

* few more
2018-03-28 08:08:20 +02:00
Lars Hvam
59c1f277ab
more renaming #1132 (#1212)
* more renaming #1132

* fix indentation
2018-02-18 10:04:26 +01:00
Lars Hvam
68d0571516
More classes to global (#1209)
* lcl_background to global

* lcl_branch_overview to global

* lcl_services_git to global

* lcl_services_repo and lcl_services_db to global

* lcl_services_abapgit to global

* lcl_gui_chunk_lib to global

* lcl_gui_view_tutorial to global

* lif_auth to global

* lcl_auth and lcl_gui_view_repo to global

* lcl_view_repo

* lcl_gui_page_syntax to global

* 2 pages to global

* refactor router, less dynamic references

* background pages to global

* branch overview to global

* settings page to global

* repo settings page to global

* explore page to global

* diff page to global

* debug info to global

* main page to global

* refactor router, no dynamic references

* db pages to global

* router to global

* gui to global

* clean up includes

* move type definnition to interface

to avoid syntax error after abapmerge

* move types to interface

* move types to interface

* rename tyep

* move type

* move types

* move type
2018-02-17 12:40:54 +01:00
Lars Hvam
18ea5d637c
lcl_repo (#1205)
* lcl_repo and more to global

* cleanup includes

* fix indentation
2018-02-15 15:10:13 +01:00