SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-02 04:36:49 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
3,083 Commits 3 Branches 39 Tags 53 MiB
7f312f8634
Commit Graph

1927 Commits

Author SHA1 Message Date
Christian Guenter
d82a02cd0e downport 2018-08-06 18:11:09 +02:00
larshp
f0fb0f0470 TADIR performance 
TADIR performance #1756

All usages of TADIR aligned to use the same structure. 
DELFLAG added in the structure.
2 identical structure definitions deleted.

todo: test this PR works after abapmerge has run
 2018-08-06 15:39:15 +02:00
Christian Günter
400846e036 Downport method call chains to 702 + IF_OO_SOURCE_POS_INDEX_HELPER #1775 (#1776) 
* Downport method call chains to 702 + IF_OO_SOURCE_POS_INDEX_HELPER

* catch exception if interfaces doesn't exist

Catch exception if IF_OO_SOURCE_POS_INDEX_HELPER doesn't exist
 2018-08-06 15:11:40 +02:00
Christian Guenter
6ef0357795 ecatt downport 2018-08-06 13:31:43 +02:00
Johannes Konings
6ddd20e2b5 fix some naming convention #1132 (#1771) 
* fix some naming convention

https://github.com/larshp/abapGit/issues/1132

* fix abaplint Reduce line length

https://github.com/larshp/abapGit/pull/1771
 2018-08-06 13:10:03 +02:00
Lars Hvam
18573089e2
Refactor staging + git + online repo (#1769) 
* change merge and staging

always push to the top of the currently selected branch

* remove branch and sha1 from stage object #365

* REPO not longer part of GIT_PORCELAIN

SET_OBJECTS moved to private

* and remove fields from constructor
 2018-08-06 12:55:13 +02:00
Johannes Konings
09791d0685 Unit test ZCL_ABAPGIT_BRANCH_OVERVIEW for author regex (#1767) 
* changed assert to exception

* unit test for author regex added

* Umlauts removed
 2018-08-06 12:54:43 +02:00
larshp
02cccf6995 delete method set_new_remote in online repo 
delete method set_new_remote in online repo

#1757
 2018-08-05 13:12:36 +02:00
larshp
f77b798f4c Interface ZIF_ABAPGIT_GIT_OPERATIONS 
Interface ZIF_ABAPGIT_GIT_OPERATIONS for git operations in repo online class
 2018-08-05 13:05:08 +02:00
larshp
1d035cf1ab create_branch refactored 2018-08-05 12:47:54 +02:00
larshp
703b1022f5 separate repo from PULL 2018-08-05 12:17:34 +02:00
larshp
28adb2f790 separate repo from DELETE_TAG 2018-08-05 12:17:34 +02:00
larshp
748a32f57c separate repo from DELETE_BRANCH 2018-08-05 12:17:34 +02:00
larshp
71b7f9d788 separate repo from CREATE_TAG 2018-08-05 12:17:34 +02:00
larshp
d431f2d9d0 separate repo from CREATE_BRANCH 2018-08-05 12:17:34 +02:00
larshp
742f3e5e2c Sacrifice HEAD_BRANCH feature in repo 
Sacrifice  HEAD_BRANCH feature in repo, suggest instead implementing a branch list cache later

#1757
 2018-08-05 11:52:56 +02:00
larshp
d0838c0f54 delete ZCL_ABAPGIT_STAGE_LOGIC method COUNT 
delete ZCL_ABAPGIT_STAGE_LOGIC method COUNT, not used anywhere
 2018-08-05 11:52:30 +02:00
larshp
48e5a247f2 Online: method INITIALIZE + RESET_STATUS to privat 
Change methods INITIALIZE + RESET_STATUS to private in ZCL_ABAPGIT_REPO_ONLINE

One external call of INITIALIZE changed to use REFRESH instead

Part of refactoring for issue #1757
 2018-08-05 11:28:50 +02:00
Lars Hvam
c72d04ea80
Refactor background to use log object instead of WRITE (#1753) 
* LOG: extra ADD_* methods

Methods ADD_ERROR, ADD_INFO, and ADD_WARNING added to log class

* refactor background to use log object

refactor background to use log object instead of WRITE
 2018-08-05 08:08:41 +02:00
Lars Hvam
bca3fd6002
help, rename wiki to documentation (#1751) 
* remove ENDMETHOD comments

* help, rename wiki to documentation

help, rename wiki to documentation

remove action from router and action definitions
 2018-08-05 08:08:28 +02:00
larshp
de76c32fd3 refactor git length encoding #1741 
refactor git length encoding #1741

can now handle larger numbers than 30mb, uses interation and less code
 2018-08-05 08:08:09 +02:00
Lars Hvam
2c3b80a2a5
1.74.0 (#1750) 
- Stage button in diff screen removed
+ Vimium like link hint navigation, enable in settings
* ecatt downport
* Performance optimizations
* SSFO fix jump to text module
 2018-08-04 10:14:49 +02:00
Christian Guenter
a72edf9725 Remove 'Stage' from diff page 
After this commit is applied it's no longer possible to stage
at the diff page. This simplifies the screen flow.
 2018-08-04 09:49:23 +02:00
Christian Guenter
62506f52bb Default link_hint_key and background color 
With this commit link_hint_key and link_hint_backgroun_dcolor
are populated with default values.
 2018-08-04 09:13:43 +02:00
Christian Günter
ff4d126856 Vimium like link hint navigation #1706 (#1729) 
* Vimium like link hint navigation

After this commit is applied, the link hint navigation can be used.
The feature can be activated and configured in the user settings.
Role model is the link hint navigation in the Google Chrome plugin
Vimium.

* refactoring: introduce KeyNavigation prototype

* refactoring: introduce LinkHints prototype
 2018-08-04 07:36:28 +02:00
Frederik Hudák
adacc174bd Removed endmethod and endclass comments - folder git 2018-08-03 14:49:52 +02:00
Christian Günter
a4e670d254 ecatt: downport and fix naming #1737 (#1740) 
* ecatt: downport and fix naming

* ecatt downport /2
 2018-08-03 14:47:17 +02:00
Frederik Hudák
26c6f4b4dc Removed endmethod and endclass comments - folders syntax, zlib, xml 2018-08-03 13:33:33 +02:00
Frederik Hudák
34a65ba8e4 Removed unnecessary default comments from testclasses 2018-08-03 13:32:57 +02:00
Michael Käsemann
f9746cf199 Optimized ZCL_ABAPGIT_TADIR=>BUILD for better performance (#1725) 
* Optimized ZCL_ABAPGIT_TADIR=>BUILD for better performance

- Using the optimizations in ZCL_ABAPGIT_FOLDER_LOGIC (PR #1723) and ZCL_ABAPGIT_SAP_PACKAGE (PR #1724) to optimize the TADIR build method, by first determining all relevant subpackages and then processing them in one go instead of having to recurse and read information from the DB separately.
- Note that the optimization can also be used without the changes in #1723 and #1724, but the effect will be less or worse and the coding requires adaptations.

* Fixes coding artifact of #1723

Removed a coding artifact that makes use of importing parameter ÌO_FOLDER_LOGIC`, which is no longer needed in the flat BUILD processing.

* Adapted for rework in #1724

After adapting PR #1724 to no longer use buffering, but instead select packages with a level-based selection, the buffering parameter in `ZCL_ABAPGIT_SAP_PACKAGE=>LIST_SUBPACKAGES` no longer exists and should not be used in this PR.

* Compressed IF/ELSE construct

* Removed whitespaces

* Fixed auto-merge issue

Removed a double variable declaration resulting from git auto-merge
 2018-08-02 06:48:13 +02:00
Frederik Hudák
9d79bc3cc5 Removed endmethod and endclass comments - folder utils 2018-08-01 18:55:31 +02:00
Michael Käsemann
3331a73b86 Optimized Git Type Determination 
- Optimized the type determination logic in ZCL_ABAPGIT_GIT_PACK=>GET_TYPE by removing the string conversion and processing the relevant bits directly
 2018-08-01 13:11:22 +02:00
Michael Käsemann
aa90f278b7 Added Buffering to ZCL_ABAPGIT_SAP_PACKAGE (#1724) 
* Added Buffering to ZCL_ABAPGIT_SAP_PACKAGE

- Added a buffering option to ZCL_ABAPGIT_SAP_PACKAGE=>LIST_SUBPACKAGES, which gives a performance increase in repos with a deep tree structure, because all relevant packages are read from the DB only once and then the determination of subpackages is performed on an internal buffer table.

* Used buffered SAP package information determination in file status processing

* Level-based Subpackage Selection

- Replaced buffered package access with level-based subpackage selection

* Minor fix for select statements to avoid warnings
 2018-07-31 17:31:18 +02:00
Christian Guenter
fa61f45886 SSFO: fix jump to text module 
After this commit is applied jump to smartforms
text modules works as expected.
 2018-07-31 13:46:30 +02:00
Michael Käsemann
b3679f0868 Added Buffering to ZCL_ABAPGIT_FOLDER_LOGIC (#1723) 
* Added Buffering to ZCL_ABAPGIT_FOLDER_LOGIC

- Converted ZCL_ABAPGIT_FOLDER_LOGIC=>PACKAGE_TO_PATH and ZCL_ABAPGIT_FOLDER_LOGIC=>PATH_TO_PACKAGE to instance methods, so they can work with buffered data when constructiing path information. This gives a performance advantage in repos with a depp tree structure and multiple leaf packages
- Adapted all calling code to use an instance of ZCL_ABAPGIT_FOLDER_LOGIC instead of the previously available static methods
- Where applicaple PACKAGE_TO_PATH and PATH_TO_PACKAGE were called in an instance of ZCL_ABAPGIT_FOLDER_LOGIC, which was instanced outside of a processing loop and thus profited from the introduced buffering

* Fixed errors

* Removed obsolete coding artifacts

Removed an obsolete parameter, that accidentally got merged into the code when building the pull request

* Forwarded FOLDER_LOGIC instance to recursed calls

Forwarded ZCL_ABAPGIT_FOLDER_LOGIC instance to subsequent BUILD calls to make use of buffering, until the optimizations in #1725 are in place.
 2018-07-31 12:19:29 +02:00
larshp
eac0045305 background: fix dump when reconfiguring 
fix dump due to old background settings
 2018-07-30 16:53:55 +02:00
Lars Hvam
4180373b46
Refactoring, HTML_ACTION_UTILS #1710 (#1720) 
* DBCONTENT_DECODE to ZCL_ABAPGIT_GUI_PAGE_DB_EDIT

* PARSE_COMMIT_REQUEST to ZCL_ABAPGIT_GUI_PAGE_COMMI
 2018-07-30 16:33:52 +02:00
Lars Hvam
e904130b67
v1.73.0 (#1718) 
Background mode must be reconfigured after installing this version
New interface ZIF_ABAPGIT_BACKGROUND for implementing custom handlers
Background mode will now push deletions
 2018-07-29 14:11:22 +02:00
larshp
58fa197ed5 Move settings type to background interface 2018-07-29 14:01:45 +02:00
Lars Hvam
4fa485bf96
Remove superfluous spaces (#1712) 
* remove spaces

* remove spaces

* remove spaces

* remove double space
 2018-07-29 10:08:54 +02:00
Lars Hvam
43da0f819c
Background mode refactoring (#1707) 
* move background logic to new package

* background refactored

* background, gui page refactored

* find implementations

and fix code inspector findings

* pretty print interface
 2018-07-29 10:08:42 +02:00
Frederik Hudák
c4639f65ce Removed endmethod and endclass comments - objects folder 2018-07-28 10:10:16 +02:00
Lars Hvam
67c76df109
Delete unreferenced types (#1705) 
* remove ty_adler32

* remove tt_file_diff
 2018-07-28 07:26:14 +02:00
Lars Hvam
62580af494
Omit parameter name where possible (#1704) 
* zcl_abapgit_2fa_github_auth omit parameter name

* ecatt omit parameter names

* zcl_abapgit_ecatt_script_downl pretty print

* zcl_abapgit_ecatt_script_downl omit parameter name

* zcl_abapgit_ecatt_val_obj_upl omit parameter name

* zcl_abapgit_file_status omit parameter name

* zcl_abapgit_gui omit parameter name

* zcl_abapgit_gui_page_boverview omit parameter name

* zcl_abapgit_syntax_highlighter omit parameter name
 2018-07-28 07:25:28 +02:00
Christian Guenter
7a7587a481 Background: Push deleted objects 
Before this commit is applied deletions weren't pushed in background
mode. With this commit the deletions are pushed.
 2018-07-28 07:24:57 +02:00
Lars Hvam
d013f34893
1.72.2 (#1703) 
* update version

* v1.72.2
 2018-07-27 13:34:44 +02:00
larshp
e5c75da12c background: remove unused variables 2018-07-27 13:17:49 +02:00
larshp
06d06e23fe list_subpackages: order by primary key 
list_subpackages: order by primary key, to fix HANA warning
 2018-07-27 13:17:29 +02:00
larshp
faf2f93197 no need to pass is_checks by value 
plus some methods reordered
 2018-07-27 13:17:14 +02:00
Lars Hvam
95a8a42c25
Parse commit message in branch overview, fix for PGP signature #1387 (#1698) 
* pretty print, trigger reordering of methods

* skip PGP signature

* change PARSE_COMMITS to static

change PARSE_COMMITS to static and add unit tests class

* add simple unit test and fix CI findings
 2018-07-27 13:16:34 +02:00
Christian Guenter
8c38e17df6 CHAR: fix copy and paste error 
Before this commit is applied we get DBSQL_DUPLICATE_KEY_ERROR
dumps while 'reset local'.
 2018-07-27 06:17:32 +02:00
Michael Käsemann
4a51d2845c Small performance improvement in ZCL_ABAPGIT_FILE_STATUS=>CALCULATE_STATUS, where the subpackage information is read only once and then sorted and the sorted information can then be accessed through a binary search read. 2018-07-26 13:38:24 +02:00
Christian Guenter
494cc5a8f8 CHAR: catch exceptions and implement is_locked 
Before this commit is applied we get shortdumps when the object
is locked during deserialization or deletions.
 2018-07-26 13:37:10 +02:00
Christian Guenter
9966bf4c86 Refactor: SET PARAMETER EUK 
After this commit is applied all calls of "SET PARAMETER 'EUK'"
are replaced with the call of objects_super->set_default_package.
The method uses the ABAP memory which is in this case more reliable.
 2018-07-25 16:16:28 +02:00
Christian Günter
8572013c7e CHAR: fix package popup during pull #1661 (#1689) 
* CHAR: fix package popup during pull

* Remove superfluous ABAP memory clearance

memory is already cleared in RS_CORR_INSERT

* Introduce objects_super set_default_package

Refactor set default package logic to super class
zcl_abapgit_objects_super method set_default_package.
 2018-07-25 15:00:52 +02:00
Christian Guenter
335759f741 Store user and time for last deserialize 
With this commit after every deserialize operation the user, date and time
are stored in repo xml. The information is shown in repo overview.
 2018-07-25 06:50:18 +02:00
Christian Guenter
5d439e3699 Code inspector for offline repositories 
Before this commit it wasn't possible to run code inspection
for offline repos. A dump occured.
With this commit it is possible to run code inspections
for offline repos, too.
 2018-07-25 06:47:59 +02:00
mkaesemann
e132c17205 Fixed spelling error 2018-07-25 06:44:07 +02:00
Michael Käsemann
a80ae3c4f5 Fixed naming and missing data element definition 2018-07-25 06:44:07 +02:00
Michael Käsemann
9f50c2d59e ZIF_ABAPGIT_SAP_PACKAGE~LIST_SUBPACKAGES in ZCL_ABAPGIT_SAP_PACKAGE returned duplicate entries for subpackages with more than 1 hierarchy level, because the recursion selected all subpackages of a given package and added them to the list and then parsed the added subpackages again, which would in turn again select the subpackages of the subpackage. 2018-07-25 06:44:07 +02:00
Christian Guenter
bb82f2c8bd Refresh online repo: call BRANCH_LIST just once 
Before this commit is applied BRANCH_LIST is called twice while
refreshing an online repo. This leads to two identical HTTP calls.
After this commit is applied BRANCH_LIST is only called once and
therefore only one HTTP request is sent.
 2018-07-25 06:43:21 +02:00
larshp
d7e90aae60 move version definition to separate interface 
moved version from DEFINITIONS interface to new VERSION interface, to avoid possible future merge conflicts, see #960
 2018-07-25 06:37:38 +02:00
larshp
640839ad0e Do not delete repo at pull error #1675 
Some time ago, the repo was pulled immediately after creation, this has been changed, so we do not need this workaround anymore. Also see #843
 2018-07-22 11:55:13 +02:00
Christian Guenter
01c2cfb610 NEWS: Only update last_change_seen if changed 2018-07-22 11:06:38 +02:00
Christian Günter
7ac8dc15b6 Remove local SHA1 from online repository #1485, #1509 (#1666) 
* Remove local SHA1 from online repository

In this commit we remove the local SHA1 and all its references from
ZCL_ABAPGIT_REPO_ONLINE. SHA1 is also removed from repo persistency.
SHA1 insn't needed anymore. All where-used places were either migrated to
remote_SHA1 or removed.

* reintroduce logic after push
 2018-07-22 10:11:09 +02:00
larshp
45bb5c7405 AVAS: propagate exception to caller 
AVAS, propagate exception to caller, this will fix the syntax warning
 2018-07-22 09:46:13 +02:00
Christian Guenter
1c368ed80c FUGR: Update short text if already exists 
If the short text of the function group has changed in the remote repo,
it's currently not possible to pull that change.
With this commit the short text is pulled properly.
 2018-07-22 07:21:06 +02:00
larshp
52758028a7 delete commented unit test code #1189 2018-07-22 07:20:12 +02:00
larshp
60a4f5ed56 FUGR: show error code from RS_FUNCTION_POOL_INSERT 
FUGR: show error code from RS_FUNCTION_POOL_INSERT
 2018-07-21 11:36:30 +02:00
Lars Hvam
16dcb2ea99
Optimize STATUS performance (#1664) 
* Optimize STATUS performance

move list_subpackages() outside of loop

* logic updated
 2018-07-21 11:36:15 +02:00
Johannes Konings
b98db9bd7c branch overview: no singleton (#1665) 
https://github.com/larshp/abapGit/issues/1647
 2018-07-20 11:21:26 +02:00
Johannes Konings
cdf2f5f448 ABAP Unit for ZCL_ABAPGIT_BRANCH_OVERVIEW #1647 (#1654) 
branch overview:
* preparation ABAP Unit
* change to key

#1647
 2018-07-20 09:29:41 +02:00
Lars Hvam
7079e5ac50
Version 1.72.1 (#1663) 
* 1.72.1

* v1.72.1 changelog
 2018-07-20 08:10:50 +02:00
larshp
7d622fc495 CHAR: fix dump during pull #1660 
Set the activation state to inactive for the values
 2018-07-20 07:26:19 +02:00
Christian Guenter
1c2a1f709e CUS1: deserialization add RS_CORR_INSERT 
before this commit CUS1 wasn't deserialized properly because no TADIR entry was inserted.
 2018-07-20 07:20:33 +02:00
Christian Guenter
25980d80fe SICF: Delete data from ICFAPPLCUST 
The data in table ICFAPPLCUST (Application Customizing Data) isn't
deleted by cl_icf_tree=>if_icf_tree~delete_node( ). Before this commit
is applied it's not possible to delete ICF nodes with data in that table.
With this commit we delete the data in the table. It's the same as
transaction SICF does.
 2018-07-20 06:45:40 +02:00
Christian Guenter
3ba843ad54 VCLS jump: open view cluster in new window 
Before this commit VCLS jump calls VIEWCLUSTER_MAINTENANCE_CALL
which opens inplace. But that's not compatible with abapGit UI
and nothing is visible.

And the semantics changed. The above mentioned FM call the view
cluster for data maintenance and not the development object.
To be aligned with abapGit logic now the transaction SE54 is called.
 2018-07-18 18:24:15 +02:00
Christian Guenter
9822822403 VCLS: Fix - replace meth corr_insert( ) 
Replaces the call of corr_insert( ) with its own call of FM
RS_CORR_INSERT because the parameters used in corr_insert
aren't valid for VCLS
 2018-07-18 16:36:31 +02:00
Jakub Filak
b3186e9202 AVAS: report detailed errors (#1652) 
Unfortunately, we are versioning AVAS objects that can be instantiated
only in SAP systems but we use the repo also in sandbox Customer
systems.

Whenever I open the repository I get an exception of the type
cx_pak_invalid_data.

Without this commit I see the error message:
"AVAS error".

With this commit I see the error message:
"AVAS $GUID: invalid data: The functionality is not supported in
customer systems"
 2018-07-18 15:37:22 +02:00
Christian Günter
495e832882 downport CMPT (#1648) 2018-07-17 13:06:32 +02:00
Christian Günter
394ea52d61 More is_locked: ENHO, FORM, SFPF, SFPI (#1646) 2018-07-17 07:40:01 +02:00
Christian Günter
67b7f74911 Fix: warning package shown twice (#1644) 2018-07-17 07:28:57 +02:00
ThomasPloski
6ea0c465f4 fixes issue #1621 (#1640) 2018-07-14 06:51:20 +02:00
Lars Hvam
4f96d8dbee
show path in diff page #1624 (#1638) 
show path in diff page #1624

plus remove some comments after ENDMETHOD
 2018-07-14 06:51:07 +02:00
Lars Hvam
f4e9676855
CUS0 handle TADIR (#1636) 
* SE80 pretty print

* CUS0 handle TADIR #1565
 2018-07-14 06:50:56 +02:00
Lars Hvam
3a5b2b73fb
VCLS handle TADIR #1565 (#1633) 
VCLS handle TADIR #1565

Source code reorganized by SE80.

Changes: call to corr_insert() added, plus set rs_metadata-delete_tadir %3D abap_true.
 2018-07-14 06:50:44 +02:00
Lars Hvam
1b154ccf7f
list superpackages, fix double entries #1612 (#1632) 
list superpackages, fix double entries #1612
 2018-07-14 06:50:33 +02:00
ThomasPloski
153606eb7a fixes issue #1630 (#1637) 2018-07-13 13:26:46 +02:00
larshp
48e2549003 1.72.0 2018-07-13 08:17:58 +00:00
Lars Hvam
b7ad2b553f
issue #1630, temporary workaround (#1631) 2018-07-13 10:06:25 +02:00
Johannes Konings
e34d80214e zcl_abapgit_object_form naming convention #1132 (#1628) 
* typo corrected "Guide for installing bundle"

* zcl_abapgit_factory naming convention

https://github.com/larshp/abapGit/issues/1132

* zcl_abapgit_object_form naming convention 

https://github.com/larshp/abapGit/issues/1132
 2018-07-13 04:30:30 +02:00
Johannes Konings
e74e03f5a5 zcl_abapgit_factory naming convention #1132 (#1619) 
* typo corrected "Guide for installing bundle"

* zcl_abapgit_factory naming convention

https://github.com/larshp/abapGit/issues/1132
 2018-07-12 16:57:12 +02:00
Lars Hvam
6bdb655435
AVAS support (#1609) 
* AVAS #1360

* AVAS support

* fix linter errors
 2018-07-12 16:55:46 +02:00
Lars Hvam
bf3e5df77e
start moving unit tests to the right classes (#1610) 2018-07-12 16:40:22 +02:00
Christian Günter
4f9f47cd59 Set transport request if needed during uninstall or reset local (#1596) 
* delete checks: set transport request if needed

this ensures that the transport request is set when deleting objects.
E.g. uninstalling the repositoy or reset local.

* separate type for delete checks
 2018-07-11 16:18:08 +02:00
ThomasPloski
6ced7c04bb using "#EC CI_GENBUFF (#1618) 2018-07-11 16:16:48 +02:00
Christian Günter
c161b0d5d4 Overview page: initial focus to filter (#1616) 2018-07-11 15:45:56 +02:00
Lars Hvam
23ded859ea
update source index, #1597 (#1598) 
* update source index #1597

* remove comment

* fix indentation
 2018-07-10 16:41:00 +02:00
Lars Hvam
7d7def95a5
Generic object handler + ASFC support #1578 (#1590) 
* scaffolding #1578

* generic object handler #1578

* fix linter errors
 2018-07-10 16:39:49 +02:00
ThomasPloski
513fe052bb Consideration of ABAP Language Version (#1567) 
* Consideration of ABAP Language Version

* update

* Update zcl_abapgit_object_fugr.clas.abap
 2018-07-09 18:51:53 +02:00
Thoralf Hänsel
5e824d7b62 Naming conventions for zcl_abapgit_ecatt_script_downl #1132 (#1604) 
* Naming conventions zcl_abapgit_ecatt_script_downl

https://github.com/larshp/abapGit/issues/1132

* Fix indentation.

https://github.com/larshp/abapGit/issues/1132

* Naming conventions zcl_abapgit_ecatt_val_obj_upl

https://github.com/larshp/abapGit/issues/1132
 2018-07-09 16:30:46 +02:00
Lars Hvam
9c5c704fad
Merge pull request #1594 from christianguenter2/issue_1558 
Do not automatically deserialize last seen repo
 2018-07-09 16:28:01 +02:00
Lars Hvam
f54009e65a
Merge pull request #1603 from mkaesemann/feature/BITBYTE_TO_INT_optimization 
Performance Improvement in BITBYTE_TO_INT Conversion
 2018-07-09 16:23:41 +02:00
Christian Guenter
3f2e9be939 Do not automatically deserialize last seen repo 
- new default behaviour is that the last seen repo isn't deserialized automatically. Instead the user has to choose a repo to work with
- old behaviour can be reactivated via user setting
 2018-07-09 16:15:36 +02:00
Lars Hvam
58952c15fc
Merge pull request #1599 from christianguenter2/SCP1_jump 
SCP1 jump
 2018-07-09 14:06:28 +02:00
Michael Käsemann
d2fbceb949 Added unit tests for conversion methods 
- Added unit tests for metods BITBYTE_TO_INT and X_TO_BITBYTE of class ZCL_ABAPGIT_CONVERT.
 2018-07-09 12:38:26 +02:00
mkaesemann
3ec6188536
Fixed build issues 
Removed whitespace at end of empty line caused by the Github editor.
 2018-07-09 11:35:57 +02:00
mkaesemann
7dc2dc1af2
Fixed formatting errors 
Fixed indentation and linter issues
 2018-07-09 11:32:32 +02:00
Michael Käsemann
3294474243 Performance Improvement in BITBYTE_TO_INT Conversion 
- Changed: Reduced calculations and processing required to convert a bit string into an integer value to a minimum.
 2018-07-09 11:09:53 +02:00
Christian Guenter
f88a95d0d4 New default setting: jump to ABAP in Eclipse 2018-07-08 21:20:36 +02:00
Christian Guenter
6dc1f30cea SCP1 jump 2018-07-08 21:09:04 +02:00
Christian Günter
e98dbffe92
Merge pull request #1595 from larshp/SCP1 
Basic SCP1 support #1004
 2018-07-08 20:54:53 +02:00
larshp
fdb2483b70 remove breakpoints 2018-07-08 11:12:13 +00:00
larshp
eb86f02a29 basic SCP1 support, #1004 2018-07-08 11:08:46 +00:00
larshp
bb3e092d61 basic SCP1 serialization 2018-07-08 10:02:44 +00:00
Christian Guenter
3ce838269d add timezone to overview page 2018-07-08 09:54:34 +00:00
Christian Guenter
7684e7b2ad merge page: remove duplication 2018-07-08 09:40:00 +00:00
Lars Hvam
290c1109a7
Merge pull request #1588 from JohannesKonings/issue_1585 
syntax error in NW 7.31 caused by PARTIALLY IMPLEMENTED #1585
 2018-07-08 07:21:01 +02:00
Lars Hvam
c6713e608d
Merge pull request #1587 from JohannesKonings/issue_1586 
Embedded Expressions ALPHA cause syntax error on NW 7.31 #1586
 2018-07-08 07:19:20 +02:00
Lars Hvam
528f8d7c3c
Merge pull request #1583 from larshp/issue_1449 
remove link to plugins #1449
 2018-07-08 07:18:51 +02:00
Lars Hvam
997256c0b4
Merge pull request #1577 from larshp/issue_1552 
avoid duplicate objects in reset local #1552
 2018-07-08 07:18:38 +02:00
Johannes Konings
d605b89090 PARTIALLY IMPLEMENTED removed 
https://github.com/larshp/abapGit/issues/1585
 2018-07-07 18:31:42 +02:00
Johannes Konings
1f81fd9eff Expressions ALPHA to CONVERSION_EXIT_ALPHA_OUTPUT 
https://github.com/larshp/abapGit/issues/1586
 2018-07-07 18:03:50 +02:00
larshp
21bd0ec64c remove link to plugins #1449 
remove link to plugins #1449
 2018-07-07 08:33:52 +00:00
larshp
583397ff31 avoid duplicate objects in reset local #1552 
avoid duplicate objects in reset local #1552
 2018-07-07 07:56:07 +00:00
larshp
79b6ed0fa5 commit after updating checksums #1562 
commit after updating checksums #1562

plus remove some comments
 2018-07-07 07:43:19 +00:00
Lars Hvam
0403e29109
Merge pull request #1573 from christianguenter2/issue_1559 
run code inspector after conflict resolution
 2018-07-07 09:01:14 +02:00
Lars Hvam
3a3c06825b
Merge pull request #1571 from christianguenter2/issue_1544 
Add creator and created at to overview page
 2018-07-07 08:59:20 +02:00
Lars Hvam
15c2fae36a
Merge pull request #1572 from larshp/issue_1539 
PARA as DDIC, #1539
 2018-07-07 08:55:55 +02:00
Christian Guenter
c6ebf2be1f run code inspector after conflict resolution 2018-07-06 16:34:16 +02:00
Lars Hvam
20d4605491
Merge pull request #1568 from mkaesemann/feature/X_TO_BITBYTE_optimization 
Performance Improvement in X_TO_BITBYTE Conversion
 2018-07-06 16:28:07 +02:00
larshp
14683c1aef PARA as DDIC, #1539 
this will create the PARA object before the DTEL, tested ok via repo https://github.com/abapGit-tests/DTEL_with_PARA
 2018-07-06 13:51:01 +00:00
Christian Guenter
73f2bdd13b Add creator and created at to overview page 2018-07-06 13:46:49 +00:00
Michael Käsemann
f7f78dfc26 Performance Improvement in X_TO_BITBYTE Conversion 
- Changed: Since X_TO_BITBYTE only converts a single byte to a bitstring, it is faster to use direct addressing instead of a loop/concatenate pair, since concatenate on characters has to process the whole char array in each run.
 2018-07-06 15:39:52 +02:00
Lars Hvam
17d59cc28f
Merge pull request #1563 from mkaesemann/feature/limit_progress_indicator_update 
Limit Progress Indicator Updates
 2018-07-06 15:23:10 +02:00
mkaesemann
b80a10024b
Moved progress percentage calculation into execution block 
Moved the progress percentage calculation into the execution block, because we don't need to calculate the percentage if we are not going to display it.
 2018-07-06 15:16:28 +02:00
mkaesemann
7ec692389e
Fixed Date Calculation for Refresh Interval Detection 
Forgot to recalculate the date, so we don't run into problems if someone works late at night
 2018-07-06 14:54:47 +02:00
larshp
28f1736a41 1.71.0 2018-07-06 12:35:16 +00:00
Lars Hvam
1abce8e84c
Merge pull request #1564 from EduardoCopat/1280 
validate sub and super packages from installed repos
 2018-07-06 14:29:36 +02:00
larshp
6db1b2fbfa pretty print 2018-07-06 12:20:01 +00:00
Lars Hvam
0fa0c3bfe9
Merge pull request #1534 from christianguenter2/issue_1533 
delete empty packages
 2018-07-06 14:13:47 +02:00
COPAT
e3676de797 validate sub and super packages from repos 
validate sub and super packages from repos
 2018-07-05 23:35:29 +02:00
Christian Guenter
ad5ae2a185 delete empty packages 2018-07-05 23:19:32 +02:00
Michael Käsemann
28a1554526 Limit Progress Indicator Updates 
Fixed an issue with the progress indicator updates, where updates of the progress indicator would flush the message queue of SAP GUI and cause a GUI crash or hang.
The problem is described in SAP note #2084109 and seems to occur for large repositories (especially after installing SAP GUI 7.50 PL6)
 2018-07-05 13:55:59 +02:00
Lars Hvam
6f54a1e9ff
Merge pull request #1553 from flaiker/requirements-ui 
Add UI for requirements in repo settings
 2018-07-03 07:45:29 +02:00
Lars Hvam
55c77d55f3
Merge pull request #1551 from christianguenter2/issue_1544 
add created_by and created_at to repo xml
 2018-07-02 19:55:52 +02:00
Lars Hvam
18709bdf74
Merge pull request #1550 from christianguenter2/issue_1543 
New repository overview page
 2018-07-02 19:50:17 +02:00
Lars Hvam
f1786cb405
Merge pull request #1541 from larshp/issue_1539 
Delete PARA after DTEL, #1539
 2018-07-02 17:29:53 +02:00
Lars Hvam
b39bab5363
Merge pull request #1538 from larshp/issue_1537 
TABL: check existence before SELECTing
 2018-07-02 17:29:38 +02:00
Christian Guenter
59128df664 downport code inspector page 2018-07-02 10:38:23 +00:00
Fabian Lupa
127f5a3c9c Remove unused action decode methode 2018-07-02 00:51:38 +02:00
Fabian Lupa
43e91a6296 Add UI for requirements in repo settings 
Fixes #1547
 2018-07-01 18:27:07 +02:00
Christian Guenter
1c59b131b7 add created_by and created_at to repo xml 2018-07-01 15:53:56 +00:00
Christian Guenter
6dfb6316c6 Repository overview page 2018-07-01 16:47:28 +02:00
Christian Guenter
31fb79f915 Fix naming in file_status 2018-06-30 09:27:46 +00:00
larshp
bd7313b472 Delete PARA after DTEL, #1539 2018-06-28 13:49:32 +00:00
Christian Guenter
10b29556f7 fix bug in run_code_inspection 2018-06-28 13:47:07 +00:00
larshp
dcc765d013 TABL: check existence before SELECTing 2018-06-28 13:11:42 +00:00
larshp
f1ffa6eb26 fix FUGR locking problem 
plus show sy-subrc in case of errors from RPY_DYNPRO_INSERT
 2018-06-28 12:29:29 +00:00
larshp
eeb07b0e3f 1.70.0 2018-06-28 12:03:30 +00:00
Lars Hvam
52fb9858ff
Merge pull request #1532 from christianguenter2/1460 
move db util pages to separate package
 2018-06-28 13:41:58 +02:00
Lars Hvam
4e4dac57dc
Merge pull request #1529 from christianguenter2/exp_WAPA_better_diff 
WAPA: better delta handling
 2018-06-28 13:41:15 +02:00
Lars Hvam
cda961dbe1
Merge pull request #1527 from christianguenter2/tag_popups 
tag popups: dependency injection
 2018-06-28 13:33:55 +02:00
christianguenter2
ea798193d0 Block commit/push if code inspection has errors 
- new local setting to set check variant
- new local setting to block pull if code inspector check fails
- check is executed before staging
- new page to display code inspector results
 2018-06-28 13:21:29 +02:00
christianguenter2
557ae3279f move db util pages to separate package 2018-06-28 12:04:25 +02:00
Christian Guenter
a3d26b9901 WAPA: better delta handling 2018-06-26 11:01:42 +02:00
Christian Guenter
fb91909947 tag popups dependency injection 2018-06-25 11:15:46 +02:00
Lars Hvam
307c1395d2
Merge pull request #1523 from christianguenter2/issue_437 
Implement IS_LOCKED for W3*, TTYP, TRAN, SSFO, SSST
 2018-06-21 14:28:35 +02:00
Lars Hvam
016e66244d
Merge pull request #1522 from christianguenter2/issue_1521 
Delete: check if any object is locked
 2018-06-21 14:28:01 +02:00
Lars Hvam
f79e4b7f7b
Merge pull request #1520 from christianguenter2/issue_1512 
add commit to toggle_favorites
 2018-06-21 14:27:44 +02:00
christianguenter2
002f5ba73d Implement IS_LOCKED for W3*, TTYP, TRAN, SSFO, SSST 2018-06-19 18:05:09 +02:00
Christian Guenter
79a0a8fa85 Delete: checks if any object is locked 2018-06-19 13:32:25 +00:00
Christian Guenter
e167464f1d add commit to toggle_favorites 2018-06-19 11:24:00 +00:00
larshp
fa94fa8ea1 unexpected folder structure #1425 
treat objects as non existing when outside the starting folder
 2018-06-19 08:16:55 +02:00
Lars Hvam
145a82e9ef
Merge pull request #1518 from christianguenter2/issue_1514 
Dependency injection for ZCL_ABAPGIT_SAP_PACKAGE
 2018-06-18 15:46:34 +02:00
larshp
cac21f2b37 CHAR: implement is_locked 2018-06-18 15:41:13 +02:00
Christian Guenter
36f257f0bb Dependency injection for ZCL_ABAPGIT_SAP_PACKAGE 2018-06-18 15:37:16 +02:00
Lars Hvam
b6894a5e67
Merge pull request #1517 from christianguenter2/issue_437 
Block pull if any of deserialized object is locked
 2018-06-18 15:32:07 +02:00
Lars Hvam
838769d0bc
Merge pull request #1516 from FreHu/master 
Fixed error message when committing without author name
 2018-06-18 15:23:47 +02:00
Lars Hvam
b071d6e837
Merge pull request #1513 from larshp/char 
CHAR support, #1511
 2018-06-18 15:22:49 +02:00
christianguenter2
6521d09470 Block pull if any of deserialized object is locked 2018-06-18 14:18:58 +02:00
Frederik Hudák
7e4285c1a8 Fixed error message when committing 2018-06-18 09:21:51 +02:00
larshp
1290dcec93 CHAR support, #1511 2018-06-17 12:29:29 +00:00
larshp
9f75d6bd2b refresh repo cache after deletion #1482 2018-06-17 08:23:56 +00:00
larshp
a1e23739b2 1.69.1 2018-06-17 07:58:52 +00:00
Lars Hvam
07955081eb
Merge pull request #1508 from larshp/status 
file_status, more testing
 2018-06-17 09:50:43 +02:00
Lars Hvam
ad0d06e4d0
Merge pull request #1507 from larshp/issue_1502 
TABL: consider DD12L in changed_by #1502
 2018-06-17 09:50:14 +02:00
Lars Hvam
4ae6a8cabb
Merge pull request #1506 from christianguenter2/popup_interface2 
Introduce ZIF_ABAPGIT_POPUPS
 2018-06-17 09:50:01 +02:00
christianguenter2
4662883723 Introduce ZIF_ABAPGIT_POPUPS 
- create popups with factory ZCL_ABAPGIT_UI_FACTORY
- inject test doubles with injector class ZCL_ABAPGIT_UI_INJECTOR
 2018-06-15 11:21:48 +02:00
larshp
a366fed833 file_status, more testing 
old broken test removed
 2018-06-15 09:20:42 +00:00
larshp
d8a5f395ea TABL: consider DD12L in changed_by #1502 2018-06-15 08:12:42 +00:00
larshp
9352ddbf3f SEO_CS_CACHE downport #1414 2018-06-15 07:29:13 +00:00
Lars Hvam
4f59c42fb4
Merge pull request #1501 from christianguenter2/issue_1390 
Introduce injector class
 2018-06-15 09:10:03 +02:00
Christian Guenter
6a9acb8a1b add injector class 2018-06-14 20:33:34 +02:00
Christian Guenter
7b9578a11b implement missing interface methods 2018-06-14 18:25:00 +00:00
Lars Hvam
eec7a7d096
refactor file status unit tests (#1499) 
* refactor file status unit tests

one method per check
tests in ltcl_file_status2 now successful

* more tests

add helper class
 2018-06-14 08:13:37 +02:00
Lars Hvam
602bdf6d96
Merge pull request #1498 from christianguenter2/issue_1494 
SSFO deserialization: catch cx_ssf_fb
 2018-06-14 06:29:05 +02:00
Lars Hvam
b7fc27cfcf
Merge pull request #1497 from christianguenter2/issue_1493 
Pass log object to user exit method change_tadir
 2018-06-14 06:28:46 +02:00
Lars Hvam
b71b96fc9f
Merge pull request #1496 from larshp/repo_srv 
interface for ZCL_ABAPGIT_REPO_SRV
 2018-06-14 06:27:51 +02:00
Lars Hvam
de23d5bf95
Merge pull request #1484 from larshp/issue_1390 
first dependency injection, TADIR #1390
 2018-06-14 06:27:04 +02:00