Commit Graph

71 Commits

Author SHA1 Message Date
Guenter Christian
82205c7811 fixup 2025-04-08 14:50:20 +00:00
Guenter Christian
96dd21079c cleanup 2025-04-08 07:39:17 +00:00
Guenter Christian
fa35dd070d get rid of aliases 2025-04-05 12:27:17 +00:00
Marc Bernard
900952495e
Fix extended check issues - Part 1 (#7086)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2024-12-03 07:18:52 +01:00
Lars Hvam
5d59d6f8d2
html: refactor setting debug mode (#7005)
Some checks are pending
main-build / build-merged (push) Waiting to run
main-build / auto-tag (push) Waiting to run
main-build / auto-tag-artifact (push) Blocked by required conditions
main-build / coverage (push) Waiting to run
2024-07-31 18:22:04 +02:00
francisco-milan
a1eb874ae7
Fix typos and adjust comments within the codebase (Cont'd). (#6785) 2024-01-31 06:20:03 +01:00
Lars Hvam
0a652c25a0
refactor zcl_abapgit_services_abapgit (#6690) 2023-12-11 17:27:51 +01:00
Lars Hvam
6369c57c56
decouple emergency mode from ui core (#6364) 2023-07-22 15:45:12 +02:00
Alexander Tsybulsky
a660f0114e
Modals unification, in-page, own page, better abstraction, on example of settings_remote page (#6277)
Co-authored-by: Marc Bernard <marc@marcbernardtools.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: lars <larshp@hotmail.com>
2023-05-21 14:44:04 +02:00
Christian Günter
0d38cd7c25
Move PASSWORD_POPUP to ZABAPGIT_PASSWORD_DIALOG (#6164) 2023-03-23 21:39:48 +01:00
Marc Bernard
e1f78f733b
Remove unused branch popup (#5742)
`branch_popup_callback` and `POPUP_GET_VALUES_USER_BUTTONS` are not used anymore and leftovers from previous refactoring.
2022-09-07 09:47:44 -04:00
Christian Günter
80b60e9cde
Fix variant maintainance for abapGit report (#5627) 2022-06-20 17:30:54 +02:00
Lars Hvam
ddf1c048a0
add authorization exit on startup (#5630)
#5629
2022-06-17 11:49:53 +02:00
Alexander Tsybulsky
2cc3f53fc5
Rework checksums (#5328) 2022-04-13 11:29:23 +02:00
Marc Bernard
81a70274be
Catch exception in exit form (#4966)
Closes #4965
2021-09-22 09:12:01 -04:00
Christian Günter
6f8e3f45fa
Set focus: fix code inspector warning + improve error handling (#4843)
* Set Focus: fix code inspector warning 

+ improve error handling

* fix method signature
2021-06-14 10:58:01 +02:00
Marc Bernard
f857194037
Focus HTML control on abapGit startup (#4817)
* Focus HTML control on abapGit startup 

`cl_gui_control=>set_focus` must be called during PBO. Maybe there's a nicer way to pass the HTML control to the PBO.

* Move to output form

* Set focus

* Add autofocus
2021-06-09 17:24:59 +02:00
Marc Bernard
21432e8538
Fix dump when using abapGit for more than 50 navigation steps (#4288)
Reverting back to a proper exit of screens using `LEAVE TO SCREEN` and avoid increasing the size of the callstack. 

Closes #4279 

PS: The crash mentioned in #4027 was prevented by removing the commit hash from the check screen. It works also with `LEAVE TO SCREEN`.
2020-12-05 09:48:21 +01:00
Lars Hvam
e35df57646
Change TY_SVAL_TT location (#4155) 2020-11-10 14:21:42 +01:00
Christian Günter
2d0729bc98
Exit logic should only be applied for main sel scr (#4060)
fixes #4058
2020-10-24 08:14:23 +02:00
mariusraht2
54ce6771bd
Issue #4027: Resolve possible crash of AG and add option to be able to suppress showing commit hash on Code Inspector result page (#4028)
* Replace LEAVE with CALL SCREEN

* Add new option iv_show_commit

Add new option iv_show_commit to GUI_CHUNK_LIB to be able to suppress showing commit hash on GUI_PAGE_CODE_INSP page

* abapLint: Replace 'EQ' by '='

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Hide commit hash on other pages too

Hide commit hash on ZCL_ABAPGIT_GUI_PAGE_REPO_SETT and ZCL_ABAPGIT_GUI_PAGE_SYNTAX pages

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-19 11:19:02 +02:00
mariusraht2
9ac7630711
ZABAPGIT_FORMS: Remove obsolete form package_popup and related callback handler (#4029)
* ZABAPGIT_FORMS: Remove obsolete methods

- Remove branch_popup
- Remove package_popup

* Readd branch_popup

* Readd branch_popup

* Remove related callback handler

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-16 09:11:18 +02:00
Marc Bernard
b7b5c2e62e
Change ESCAPE key to work like BACK (#3989)
Pressing ESC used to exit abapGit completely. Changed it to work like F3 (BACK), which makes more sense especially in HTML form. You can still exit from anywhere using SHIFT+F3.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-07 09:14:10 +02:00
Lars Hvam
98a261df1b
remove some unused variables (#3825) 2020-09-01 16:32:44 +02:00
Jaime Rodriguez Capote
543114963f
abapOpenCheck - Naming Conventions revision #3239 (#3240)
* abapOpenChecks config file

* Ignore SCI config folder

* checks revision

* Revert "checks revision"

This reverts commit 56a12289df.

* Renaming non-constants

Pending:

* Remove SCI configuration

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-09 17:34:26 +01:00
Lars Hvam
1dbd4d1912
Refactoring types (#2785)
* align use less different types

* refactor

* updates
2019-07-15 09:33:37 -07:00
Frederik Hudák
777445002a Revert behavior of second back button (#2779)
* Revert behavior of second back button

* Leave clearing of stack on go home
2019-07-10 21:28:20 -07:00
Frederik Hudák
c679d11d7b Change behavior of second back button to go home (#2679)
* Change behavior of second back button to go home

* Change logic as proposed

* Don't go to tutorial page on exit

* Final changes

* Fix abaplint
2019-06-13 22:59:18 -07:00
Srinivasu Reddy
d1c5e332d4 Added client check to add the ability to run abapGit in production/QA environments (#2668)
* Added client check 

Check if repository objects are modifiable in client. If not make write_protected setting active for all repos and make this setting disabled in repo setting page.

* fix abaplint errors

fix for abaplint errors

* code changes as suggested in review

1) Remove zcl_abapgit_client_check class
2) Add is_repo_object_changes_allowed method to zcl_abapgit_environment class

* Delete zcl_abapgit_client_check class

Delete zcl_abapgit_client_check class
2019-05-15 11:32:56 -07:00
Alexander Tsybulsky
80f86bd005 free, go_page, ext error handler 2019-03-22 05:49:33 -07:00
Christian Guenter
87e95e454b disable save button 2019-01-05 07:35:23 +01:00
Alexander Tsybulsky
09e23ce5b4 remove toolbar 2018-12-22 11:36:10 +01:00
sbcgua
4dee27fc1e Gui internals refactoring (#2180)
* GUI internals refactoring

* unify string conversion calls part1
2018-12-04 06:33:35 +01:00
Christian Günter
a708f18840 Start abapGit with package and open the #2160 (#2165)
* Start abapGit with package and open the repo

Set parameter 'PACKAGE' to start abapGit for a package

* Fix whitespace + exit loop
2018-11-30 07:10:45 +01:00
Christian Günter
b96abd8eb4 New repo option 'Open in master language' #2105 (#2117)
* New repo option 'Open in master language'

* Replace sy-langu + conversion exit

* Fix lint error

* Add Success message
2018-11-22 05:06:36 +01:00
larshp
7cdbbc92b6 remove some unreferenced variables 2018-11-08 16:35:08 +01:00
Christian Guenter
97c40c8f8f Fix: Impossible to save a dummy variant for backgr 2018-08-22 06:30:48 +02:00
larshp
578640f844 pretty print code 2018-08-07 16:01:18 +02:00
Christian Günter
400846e036 Downport method call chains to 702 + IF_OO_SOURCE_POS_INDEX_HELPER #1775 (#1776)
* Downport method call chains to 702 + IF_OO_SOURCE_POS_INDEX_HELPER

* catch exception if interfaces doesn't exist

Catch exception if IF_OO_SOURCE_POS_INDEX_HELPER doesn't exist
2018-08-06 15:11:40 +02:00
Christian Günter
ff4d126856 Vimium like link hint navigation #1706 (#1729)
* Vimium like link hint navigation

After this commit is applied, the link hint navigation can be used.
The feature can be activated and configured in the user settings.
Role model is the link hint navigation in the Google Chrome plugin
Vimium.

* refactoring: introduce KeyNavigation prototype

* refactoring: introduce LinkHints prototype
2018-08-04 07:36:28 +02:00
Christian Guenter
3f2e9be939 Do not automatically deserialize last seen repo
- new default behaviour is that the last seen repo isn't deserialized automatically. Instead the user has to choose a repo to work with
- old behaviour can be reactivated via user setting
2018-07-09 16:15:36 +02:00
christianguenter2
4662883723 Introduce ZIF_ABAPGIT_POPUPS
- create popups with factory ZCL_ABAPGIT_UI_FACTORY
- inject test doubles with injector class ZCL_ABAPGIT_UI_INJECTOR
2018-06-15 11:21:48 +02:00
Fabian Lupa
889106b68b Improve error messages (#1213)
* Add T100 support to ZCX_ABAPGIT_EXCEPTION

* Use T100 error messages in DEVC

* Replace zcx_abapgit_exception->text with get_text

* Use SE24 generated constructor in T100 exception
2018-03-10 13:27:09 +01:00
Lars Hvam
68d0571516
More classes to global (#1209)
* lcl_background to global

* lcl_branch_overview to global

* lcl_services_git to global

* lcl_services_repo and lcl_services_db to global

* lcl_services_abapgit to global

* lcl_gui_chunk_lib to global

* lcl_gui_view_tutorial to global

* lif_auth to global

* lcl_auth and lcl_gui_view_repo to global

* lcl_view_repo

* lcl_gui_page_syntax to global

* 2 pages to global

* refactor router, less dynamic references

* background pages to global

* branch overview to global

* settings page to global

* repo settings page to global

* explore page to global

* diff page to global

* debug info to global

* main page to global

* refactor router, no dynamic references

* db pages to global

* router to global

* gui to global

* clean up includes

* move type definnition to interface

to avoid syntax error after abapmerge

* move types to interface

* move types to interface

* rename tyep

* move type

* move types

* move type
2018-02-17 12:40:54 +01:00
Lars Hvam
323881f606
lcl zip (#1206)
* lcl_zip to global

* lcl_transport to global

* lcl_transport_2_branch to global

* lcl_merge to global

* lcl_migrations to global

* lcl_news to global

* lcl_repo_content_list to global

* move test to global class

* clean up empty includes
2018-02-15 15:50:51 +01:00
Lars Hvam
18ea5d637c
lcl_repo (#1205)
* lcl_repo and more to global

* cleanup includes

* fix indentation
2018-02-15 15:10:13 +01:00
Lars Hvam
eae23e8e9c
refactor lcl app (#1203)
* refactor lcl_app repo_srv away

* remove lcl_app gui

* fix indentation
2018-02-15 13:39:20 +01:00
larshp
1d591b545e lcl_password_dialog to global 2018-02-11 12:07:16 +00:00
Christian Günter
eb2db0653c Fix issue #1152 2018-01-17 19:59:05 +01:00
larshp
e2197ab344 lcl_sap_package to global 2018-01-12 11:36:33 +00:00