Commit Graph

4328 Commits

Author SHA1 Message Date
dependabot-preview[bot]
83d83d16e5
Update @abaplint/cli requirement from ^2.61.10 to ^2.62.0 (#4296)
Updates the requirements on [@abaplint/cli](https://github.com/abaplint/abaplint) to permit the latest version.
- [Release notes](https://github.com/abaplint/abaplint/releases)
- [Commits](https://github.com/abaplint/abaplint/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-12-07 10:39:24 +01:00
Marc Bernard
0fc7b43a35
PROG: Fix transport and work area (#4242)
* PROG: Remove objects from work area 

Fixes issue with incomplete deletion of inactive objects

Closes #4151

* Lint

* Add correction

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-07 09:38:56 +01:00
Lars Hvam
297a579757
github actions: save build artifact (#4295)
* save build artifact

* upd
2020-12-07 09:28:35 +01:00
Marc Bernard
07cdc0e0e8
Resolve circular reference in /syntax/ (#4292)
Closes #4258

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-07 09:13:58 +01:00
dependabot-preview[bot]
88372f0430
Update @abaplint/runtime requirement from ^0.8.19 to ^0.8.21 (#4294)
Updates the requirements on [@abaplint/runtime](https://github.com/abaplint/transpiler) to permit the latest version.
- [Release notes](https://github.com/abaplint/transpiler/releases)
- [Commits](https://github.com/abaplint/transpiler/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-12-07 09:09:37 +01:00
dependabot-preview[bot]
d5f2fcfbd7
Update @abaplint/transpiler-cli requirement from ^0.8.19 to ^0.8.21 (#4293)
Updates the requirements on [@abaplint/transpiler-cli](https://github.com/abaplint/transpiler) to permit the latest version.
- [Release notes](https://github.com/abaplint/transpiler/releases)
- [Commits](https://github.com/abaplint/transpiler/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-12-07 09:06:57 +01:00
Lars Hvam
fa97ded1dc
unit testing test (#4256)
* update deps

* add some interfaces

* update deps

* update deps

* add zif_abapgit_auth

* add zif_abapgit_environment

* update deps

* add interfaces

* update deps

* update deps

* update deps

* update deps
2020-12-06 15:26:06 +01:00
Fabian Lupa
ca51d8b0c7
Ensure open in main language opens same abapGit version (#4291)
Fixes #4276

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-06 06:36:45 +01:00
Fabian Lupa
2788e5f0f3
Fix adjust_display_commit_url markdown table (#4290)
* Fix adjust_display_commit_url markdown table

Fixes #4289

* Fix table spacing
2020-12-05 17:21:26 +01:00
Marc Bernard
21432e8538
Fix dump when using abapGit for more than 50 navigation steps (#4288)
Reverting back to a proper exit of screens using `LEAVE TO SCREEN` and avoid increasing the size of the callstack. 

Closes #4279 

PS: The crash mentioned in #4027 was prevented by removing the commit hash from the check screen. It works also with `LEAVE TO SCREEN`.
2020-12-05 09:48:21 +01:00
Marc Bernard
5ed2f5bb22
DOMA: Fix serialize for missing translations (#4283)
Closes #4278

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-04 09:01:24 +01:00
Marc Bernard
1c8f8038c5
Package Structure - Part 3 (#4286)
$ABAPGIT_OBJECTS_OO:

ZCL_ABAPGIT_OO_BASE
ZCL_ABAPGIT_OO_CLASS
ZCL_ABAPGIT_OO_FACTORY
ZCL_ABAPGIT_OO_INTERFACE
ZCL_ABAPGIT_OO_SERIALIZER
ZIF_ABAPGIT_OO_OBJECT_FNC

#4253

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-04 08:51:43 +01:00
Marc Bernard
58024be52e
TRAN: Improve error messages (#4280)
* TRAN: Improve error messages

Pass T100 messages to UI/log

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-04 08:46:08 +01:00
Lars Hvam
bf89ac55f6
uninstall: "including subpackages" (#4287) 2020-12-04 08:44:03 +01:00
Marc Bernard
d11c82148e
Package Structure - Part 2 (#4273)
* Package Structure - Part 2

$ABAPGIT_OBJECTS_TEXTS:

ZCL_ABAPGIT_LONGTEXTS
ZCL_ABAPGIT_SOTR_HANDLER
ZIF_ABAPGIT_LANG_DEFINITIONS
ZIF_ABAPGIT_LONGTEXTS

$ABAPGIT_OBJECTS_ENH:

ZCL_ABAPGIT_OBJECT_ENHO_BADI
ZCL_ABAPGIT_OBJECT_ENHO_CLASS
ZCL_ABAPGIT_OBJECT_ENHO_CLIF
ZCL_ABAPGIT_OBJECT_ENHO_FUGR
ZCL_ABAPGIT_OBJECT_ENHO_HOOK
ZCL_ABAPGIT_OBJECT_ENHO_INTF
ZCL_ABAPGIT_OBJECT_ENHO_WDYC
ZCL_ABAPGIT_OBJECT_ENHO_WDYN
ZCL_ABAPGIT_OBJECT_ENHS_BADI_D
ZCL_ABAPGIT_OBJECT_ENHS_HOOK_D
ZIF_ABAPGIT_OBJECT_ENHO ENHO
ZIF_ABAPGIT_OBJECT_ENHS ENHS

$ABAPGIT_OBJECTS_TEST:

ZCL_ABAPGIT_OBJECTS_CI_TESTS
ZCL_ABAPGIT_PERFORMANCE_TEST
ZCL_ABAPGIT_TEST_SERIALIZE

* Interfaces for ENHx

* Git platform subpackage

* Git_platform, test packages

* Update package.devc.xml

* Update package.devc.xml

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-04 08:41:35 +01:00
Christian Günter
2fcd477e74
New online: Condense repo url to avoid http errors (#4285) 2020-12-04 05:44:05 +01:00
Marc Bernard
3acdcf3534
Optimize status calculation (#4268)
* Optimize status calc 

Avoid status calculation for ignored files. Since files in / are ignored by default, the starting folder for unit tests is set to /.

* Fix if

* Index

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-03 15:15:26 +01:00
Marc Bernard
a3c98afbef
PINF: Missing transport entry (#4275)
* PINF: Missing transport entry

- Added recording into transport for PINF 
- Added description for FTGL "Feature toggle"

* ftgl

* ftgl

* ftlg
2020-12-03 15:12:55 +01:00
Marc Bernard
5ca21a837d
CLIF: Improve error messages (#4271)
Pass T100 messages to UI/log

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-02 13:08:42 +01:00
Marc Bernard
4ba62614eb
Package Structure - Part 1 (#4272)
$ABAPGIT_CTS:

ZCL_ABAPGIT_CTS_API
ZCL_ABAPGIT_DEFAULT_TRANSPORT
ZCL_ABAPGIT_TRANSPORT
ZCL_ABAPGIT_TRANSPORT_2_BRANCH
ZCL_ABAPGIT_TRANSPORT_MASS
ZCL_ABAPGIT_TRANSPORT_OBJECTS
ZIF_ABAPGIT_CTS_API
2020-12-02 12:57:42 +01:00
Lars Hvam
f782190b3a
class ZCL_ABAPGIT_XML_PRETTY add unit tests (#4263)
* class ZCL_ABAPGIT_XML_PRETTY add unit tests

closes #4260

* Update zcl_abapgit_xml_pretty.clas.testclasses.abap

* fix for byte order mark
2020-12-01 05:09:02 +01:00
Lars Hvam
abaac4ab9b
ZCL_ABAPGIT_AUTH add basic unit test (#4261) 2020-12-01 05:05:22 +01:00
Lars Hvam
a0a9eb1771
REPO online: change get_objects to private (#4262)
#2127
2020-12-01 05:00:55 +01:00
Lars Hvam
d92e313c32
string map, remove reference to cl_abap_structdesc (#4257)
the reference is not used, plus it is already validated that input is a structure
2020-12-01 04:54:16 +01:00
Lars Hvam
efa6aa9347
Remove two places wih repo class insantiation (#4250)
* zip, method encode_files as public

* refactor instantiation

* remove filter input parameter
2020-11-30 11:23:36 +01:00
Lars Hvam
0f8a40aa81
unit testing test (#4254)
* update deps

* update deps

* update

* skip exception tests

* update runtime

* update deps

* update deps

* skip invalid

* adler32 running

* update deps

* run for URL class

* update deps
2020-11-29 16:18:11 +01:00
Marc Bernard
7f61ebd645
UI: Clear progress bar (#4249)
* UI: Clear progress bar

Clears status/progress bar at end of process and removes leftover messages. 

Closes #3505

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-27 10:18:52 +01:00
Lars Hvam
846e0a0e1b
ZCL_ABAPGIT_TRANSPORT sort methods (#4251) 2020-11-26 12:33:18 +01:00
Marc Bernard
552024ac3f
UI: Improvements for setting pages (#4229)
* UI: Improvements for setting pages

- Better navigation between settings pages
After jumping between setting pages, the back button will go to last page before navigating to the settings (ie "back with bookmark")
- Add commit work

* Lint + router

* Jump repo view to settings

* Lint

* Conflict

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-26 11:54:49 +01:00
Philipp R
45770773f5
unify rebuild_local_checksums method (#4237)
* unify rebuild_local_checksums method

redefinition of rebuild local checksums is reduced to redefinition of "get_remotes"

* fix formatting

* remove duplicate method implementations

* remove duplicate method implementation

* update zcl_abapgit_repo_online

Co-authored-by: Rembold Rembold <philipp.rebold@sap.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Philipp Rembold <Philipp.Rembold@sap.com>
2020-11-26 11:48:05 +01:00
Marc Bernard
ca0ff368c3
Remove obsolete late_deser from metadata (#4243)
* Remove obsolete late_deser from metadata

Final part to remove late_deser flag. Solution remains compatible with old bridge class which still uses the flag.

* Call

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-25 09:59:33 +01:00
Marc Bernard
e36486901d
Check objects when installing into main package (#4244)
* Check objects when installing into main package

Closes https://github.com/abapGit/abapGit/issues/2273

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-25 09:53:56 +01:00
Marc Bernard
16fb17cfe2
Exception: Set return for split_text_to_symsg (#4245)
Fixes return parameter for `ZCX_ABAPGIT_EXCEPTION=>SPLIT_TEXT_TO_SYMSG`

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-25 09:49:06 +01:00
Marc Bernard
4a2752d467
Fix syntax highlighter (#4238)
- Fix regression XML highlighter
- Adjust UTs for syntax highlighter due to added keywords


Closes #4232

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-25 09:39:17 +01:00
Christian Günter
9d7212e820
Update other-articles-and-presentations.md (#4246) 2020-11-25 09:26:20 +01:00
Marc Bernard
bdcb725fc9
Replace cl_aunit_assert with cl_abap_unit_assert (#4239)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-24 17:28:43 +01:00
Lars Hvam
0a24986682
update linter configuration to latest (#4241)
* update linter configuration to latest

* rerun

* rerun
2020-11-24 17:07:14 +01:00
Lars Hvam
a3ff1a2e4a
move files logic to serialize class (#4231)
* move apack file build to apack package

* move files logic to serialize class
2020-11-24 15:45:44 +01:00
Constantinos Sourelis
5d8f4d2033
User interface: "Advanced" menu tooltips (#4214)
* User interface, "Advanced" menu

Added tooltips to the "Remove" and "Uninstall" options in the advanced menu. As a new user, I would revisit the [documentation](https://docs.abapgit.org/guide-online-uninstall.html) to distinguish between the two.

The tooltips are passed as "iv_title" parameters to ZCL_ABAPGIT_HTML_TOOLBAR->add

* Update src/ui/zcl_abapgit_gui_page_repo_view.clas.abap

Adjustments from review

* Update src/ui/zcl_abapgit_gui_page_repo_view.clas.abap

Adjustments from review

* Update zcl_abapgit_gui_page_repo_view.clas.abap

Comply with abaplint line length of 120

* Update zcl_abapgit_gui_page_repo_view.clas.abap

Comply with abaplint's no whitespaces at EOL

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-24 15:43:40 +01:00
Lars Hvam
01d968c1f8
show log, remove title parameter (#4234)
* show log, remove title parameter

the log objec already have the title as part of the object, another input is not required

this aligns the code to always use the title from the object

closes #4223

* zif_abapgit_log, change title to csequence input
2020-11-24 15:41:26 +01:00
Lars Hvam
6fe7cf8ec0
delete ZIF_ABAPGIT_GIT_OPERATIONS (#4233)
merge the methods into zif_abapgit_repo_online

#2127
2020-11-24 15:37:01 +01:00
Marc Bernard
c554ff2fc7
Refactor: Version comparison (#4216)
* Refactor: Version comparison

Move version comparison from `zcl_abapgit_news` to `zcl_abapgit_version` and make it public for use in other places

* Lint

* Compare sem versions

* Change supplied

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-24 08:16:50 +01:00
Marc Bernard
9efdae315d
Dialogs: Enhance HTML form with table control (#4230)
* Dialogs: Enhance HTML form with table control

- Adds option to maintain data using a table control
- Extends UTs with several cases that were include in #4172
- Table control to be used by "repo settings" #4171

* Border

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-24 08:11:53 +01:00
Marc Bernard
aa2f4bb8e7
Resolve hotkey conflict (#4228)
"f" is default for vimium-links. Changed "New Offline" to "o".

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-24 08:04:27 +01:00
Lars Hvam
5e2d8de52a
/git/, put method get_length under test (#4224)
* /git/, put method get_length under test

add unit tests for method get_length

the method will probably be refactored sometime in the future, I think the bit manipulation can be replaced with some hex, div and bit-mask magic

* fix tabs
2020-11-24 08:02:39 +01:00
Lars Hvam
20c714889f
ZCL_ABAPGIT_GIT_URL, remove repo usage (#4225)
* ZCL_ABAPGIT_GIT_URL, remove repo usage

https://github.com/abapGit/abapGit/issues/2127#issuecomment-732262897, first part of C

* Update zcl_abapgit_git_url.clas.testclasses.abap

* Update src/git_platform/zcl_abapgit_git_url.clas.testclasses.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2020-11-24 08:00:36 +01:00
Lars Hvam
53790c3770
log, purge() now returns the log (#4222)
* log, purge() now returns the log

For each action, the log should be returned, then it is up to the UI how or if to show or persist it in the session.

First step of #2821

* li_log not needed anymore
2020-11-24 07:58:22 +01:00
Lars Hvam
6bd3242ecf
dot abapgit file, move file build (#4226)
move responsibility for building the dotabapgit file to the dotabapgit class instead of the repo

https://github.com/abapGit/abapGit/issues/2127#issuecomment-732262897
2020-11-24 07:55:15 +01:00
Lars Hvam
d3b68b8a48
remove broken dynamic call (#4221)
closes #4195

but lets keep #3453 open
2020-11-24 07:52:58 +01:00
Constantinos Sourelis
f9a6f2d514
Documentation updates to the "contributing" section (#4219)
* Update contributing.md

Rephrase and reorganize to make the various concepts clearer, especially to new abapGit adopters

* Update contributing.md

Clarifications on fork requirement

* Update contributing.md

* Update contributing.md

* Update contributing.md

* Update user-owned branch following merge with abapGit master (#2)

* Documentation: Rephrase the "contributing to abapGit" section (#4213)

* Update contributing.md

Rephrase and reorganize to make the various concepts clearer, especially to new abapGit adopters

* Update contributing.md

Clarifications on fork requirement

* Update contributing.md

* Update contributing.md

* Update contributing.md

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Fix uncaught exception of zcl_abapgit_repo_srv (#4215)

When repeatedly navigating "back" to the main screen via the "Repository List" [o] button:
If somewhere in this navigation sequence you Remove a repository,
then continue on via "Repository List",
but later you use the GUI's actual "BACK" button, until you have returned to the main screen where that repository still existed,
a short dump occurs as the exception raised by zcl_abapgit_repo_srv=>get in zcl_abapgit_gui_page_repo_view->render_content propagates unhandled

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Update contributing.md

Fix the ordered list markup for github pages (where numbering was being restarted)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-23 17:30:36 +01:00