* CHAR: fix package popup during pull
* Remove superfluous ABAP memory clearance
memory is already cleared in RS_CORR_INSERT
* Introduce objects_super set_default_package
Refactor set default package logic to super class
zcl_abapgit_objects_super method set_default_package.
If the short text of the function group has changed in the remote repo,
it's currently not possible to pull that change.
With this commit the short text is pulled properly.
The data in table ICFAPPLCUST (Application Customizing Data) isn't
deleted by cl_icf_tree=>if_icf_tree~delete_node( ). Before this commit
is applied it's not possible to delete ICF nodes with data in that table.
With this commit we delete the data in the table. It's the same as
transaction SICF does.
Before this commit VCLS jump calls VIEWCLUSTER_MAINTENANCE_CALL
which opens inplace. But that's not compatible with abapGit UI
and nothing is visible.
And the semantics changed. The above mentioned FM call the view
cluster for data maintenance and not the development object.
To be aligned with abapGit logic now the transaction SE54 is called.
Unfortunately, we are versioning AVAS objects that can be instantiated
only in SAP systems but we use the repo also in sandbox Customer
systems.
Whenever I open the repository I get an exception of the type
cx_pak_invalid_data.
Without this commit I see the error message:
"AVAS error".
With this commit I see the error message:
"AVAS $GUID: invalid data: The functionality is not supported in
customer systems"
DDLS objects are not cheked in a transport in their deserialize method.
The parallel activation does not call RS_WORKING_OBJECTS_ACTIVATE which
checks in the activated object in a transport.
Therefor, DDLS objecst are never checked in a transport when
the parallel activation is in place (the option experimental features
is enabled - which is enabled by default on all our systems).
I wanted to use TRINT_OBJECTS_CHECK_AND_INSERT because this function
is used by ADT:
CL_WB_ADT_REST_RESOURCE~post
CL_WB_ADT_REST_RESOURCE_DATA
~if_wb_adt_rest_resource_data~get_transport_key
CL_WB_OBJECT~get_transport_key -> PGMID%3DR3TR, OBJTYPE%3DDDLS
CL_WB_ADT_REST_RESOURCE~lock
CL_WB_ADT_REST_RESOURCE~check_obj_in_transport_request
CL_ADT_CTS_MANAGEMENT~check_objects_in_request
CL_ADT_CTS_MANAGEMENT~LCL_DB_PERSISTENCE~check_objects
CALL FUNCTION CTS_WBO_API_CHECK_OBJECTS
CALL FUNCTION TRINT_WBO_IMPL_CHECK_OBJECTS
SAPLCTS_WBO_API_IMPL /
LCTS_WBO_API_IMPLF06 /
FORM CALL_OBJECTS_CHECK_AND_INSERT
CALL FUNCTION
TRINT_OBJECTS_CHECK_AND_INSERT
But it is not enough to call this function, hence, I use RS_CORR_INSERT
which was mentioned by @larshp in our slack conversation. The function
internally use calls TRINT_OBJECTS_CHECK_AND_INSERT.
I tested this patch with modification of a CDS view and also with
adding a new CDS view.
Closes#1466
