Commit Graph

312 Commits

Author SHA1 Message Date
larshp
6c3e6b85ed SFPF: Error by pulling of an existing object
SFPF: Error by pulling of an existing object #2352
2019-02-05 23:07:38 -08:00
Lars Hvam
cb4479b95b
Cleanup (#2361)
* pretty print

* move identical code outside IF

* remove space before .

* remove unreferenced variables

* remove unreferenced variables

* remove unreferenced variables

* fix pseudo comment

* remove unreferenced field symbols
2019-02-04 23:08:29 -08:00
GoWale
4dceb54758 Flag SET-/GET_PARAM bug - move fix to deserialize (#2360)
* add missing functions in plugin VCLS

* fix pretty print

* fix check usage for abaplint

* adjust detection of locks

* german type

* move fix to deserialize

* fix syntax for 7.02
2019-02-03 22:06:33 -08:00
Christian Guenter
8219acf73b SPRX: improve exception handling 2019-02-03 21:43:32 -08:00
Christian Guenter
f0c8375dbd SOTS: fix code inspector errors 2019-02-03 21:32:38 -08:00
Christian Guenter
2c8a3f3b17 SPRX: fix class definition 2019-02-03 21:15:44 +01:00
Christian Günter
6cc064d794 SPRX: Proxy Object
Proxy objects are quite complex. With this commit we add basic SPRX support.

Working scenarios are:
- Service Consumer
- Service Provider
2019-02-02 03:06:11 -08:00
GoWale
96edce7e96 fix for serialize view cluster inactive/not exits (#2339)
* add missing functions in plugin VCLS

* fix pretty print

* fix check usage for abaplint

* adjust detection of locks

* german type
2019-01-31 01:41:33 -08:00
Christian Günter
d63686c442
SOTS: Fix class definition (#2332) 2019-01-24 16:07:33 +01:00
Christian Günter
ed54ff43a1
SOTS: remove create public (#2331) 2019-01-24 15:55:39 +01:00
Christian Günter
262e178407 PINF: Improve error handling #2317 (#2326)
* PINF: Improve error handling

This commit introduces a facade for IF_PACKAGE_INTERFACE which
unifies the exception handling from classic exceptions to
new class based exceptions. Thereby we ensure that all classic
exceptions are catched.

* fix lint errors
2019-01-24 15:01:10 +01:00
Christian Günter
f2e5672678 SOTS: All Concepts (OTR) of a Package - Long Texts #792 (#2323)
* SOTS: All Concepts (OTR) of a Package - Long Texts

* Update supported objects - SOTS
2019-01-24 15:00:37 +01:00
Christian Günter
7b0a687d4a PINF: Implement is_locked 2019-01-24 08:54:50 +01:00
larshp
263a6a5f13 PINF, set package
single statement 'set_default_package( iv_package ).' added

rest is reordering by SE80
2019-01-23 06:31:34 +01:00
Lars Hvam
e8b6b0020d
Add interface for ZCL_ABAPGIT_PROGRESS #2303 (#2316)
* interface for progress class

* adjust branch overview

* adjust git pack

* adjust diff page

* adjust objects class

* adjust activation class

* adjust repo online class

* adjust serialize class

few methods moved

* adjust tadir class
2019-01-23 06:28:54 +01:00
larshp
57d0d5ff96 move c_version to USCA class
as it is not used anywhere else
2019-01-23 06:17:54 +01:00
larshp
4b3d2334cc rollback #2312 2019-01-21 15:09:12 +01:00
Lars Hvam
3f494f091f
Use built-in types (#2306)
* remove uses of DTEL BOOLEAN

* remove uses of DTEL BOOLE_D

* remove uses of DTEL FLAG

* remove uses of DTEL SAP_BOOL

* remove uses of DTEL XFELD

* Update zcl_abapgit_popups.clas.abap
2019-01-20 07:59:24 +01:00
GoWale
3a20f2cf73 fix dynpro set/get parameter (#2312)
* fix dynpro set/get parameter

* Dynpro Generation - Flag SET-/GET_PARAM

* Update zif_abapgit_definitions.intf.abap

* Update zif_abapgit_definitions.intf.xml

* add byte order mark back

* rename local constant to LC_
2019-01-20 07:52:11 +01:00
larshp
c1bf6bac20 show sy-subrc from SEO_CLASS_CREATE_COMPLETE 2019-01-18 07:07:13 +01:00
larshp
ee76ec1f45 update to latest abaplint 2019-01-18 07:06:55 +01:00
Christian Günter
8377759216 Implement SQSC: Database Procedure Proxy 2019-01-17 14:12:35 +01:00
Fabian Lupa
1bef6949f2 Delete missing TVIMF entries on reset local (TOBJ)
Fixes #2267
2019-01-17 13:22:52 +01:00
larshp
3509df80ae add class descriptions 2019-01-14 20:06:33 +01:00
Lars Hvam
610c48d51f
Remove commented code (#2285)
* delete commented code

* delete commented code

* commented code
2019-01-13 10:28:18 +01:00
Andre Becker
da600fa2d3 Improve error handling of ttyp object handler (#2272)
* improve error handling of function modules

* fix abaplint errors

* refactor to hardcoded error strings

* refactor fm error handling to string templates

* removing msag class
2019-01-12 12:44:24 +01:00
Jan Pascal Tschudy
ef0f6e631a fix remove inline method call 2019-01-04 14:35:47 +01:00
larshp
9a935d2a14 TABL: use sy-subrc instead of syst_subrc 2019-01-04 14:19:33 +01:00
Christian Guenter
1de9456567 Fix TABL regression 2019-01-02 11:50:08 +01:00
Domi Bigl
311efc0d20 add IDoc Segment support as part of TABL (#2246)
* add IDoc Segement support as part of TABL

IDoc Segement type/definition is just customizing and has no own transport object but it generates a structure and is coupled to it

The segment type/definitions have their own XML at the TABL object

* fix abaplint errors

* move segment type/defintion to TABL xml
2019-01-02 06:05:49 +01:00
larshp
f1a0307fa9 VCLS clear CHANGEDATE #2227
VCLS clear CHANGEDATE #2227
2018-12-30 08:03:55 +01:00
larshp
c37ce5ff06 Cleanup classes package assignment #2217 2018-12-30 08:03:38 +01:00
larshp
e0841e3bec indentation and se80 reorderings
no logic changes
2018-12-26 06:35:55 +01:00
larshp
f9749776d8 fix naming 2018-12-25 09:10:15 +00:00
larshp
6385caade6 fix whitespace and other minor changes 2018-12-20 09:23:01 +01:00
Lars Hvam
5f9df74463
reduce method length, #2146 (#2212)
* TRAN: refactor method SPLIT_PARAMETERS

new method SHIFT_PARAM added

* settings page: refactoring

rename BUILD_SETTINGS to POST
split contents into smaller methods
2018-12-20 09:22:33 +01:00
Lars Hvam
35f1462d3a
updates to experimental DDIC activation logic (#2206)
* updates to experimental ddic activation logic

* deleted too much

* special handling for INDX

* fixored, this seems to work
2018-12-17 08:17:53 +01:00
Lars Hvam
c9252b1b2a
CLAS cleanup (#2204)
* cleanup old experimental CLAS

* Move ZCL_ABAPGIT_OO_CLASS_NEW to _CLASS
2018-12-17 08:17:07 +01:00
Eduardo Ferrari Copat
d47027ad6c Remove redundant class and interface metadata (#2195)
* Remove CLSFINAL from VSEOCLASS serialization

* Remove EXPOSURE from VSEOCLASS serialization

* Remove clsabstrct from VSEOCLASS serialization

* Remove EXPOSURE from VSEOINTERF serialization

* Revert "Remove EXPOSURE from VSEOINTERF serialization"

This reverts commit 4036b7d015.
2018-12-12 14:31:42 +01:00
CCapa
13f84140f4 Sapscript : sequence of Windows in tdlines files (#2191)
* Sapscript : sequence of Windows in tdlines files

Hello Lars,

You can find a code modification in the method _read_form of class zcl_abapgit_object_form related to the issue #2188
I have added a logic to sort by windows name the contains of the internal table ET_LINES . It allows to have always thre same sequence of  windows code in the file (xxxxxxxxxxgit.form.tdlines). Then file comparison will work with all export.

Regards
Christophe

* Sapscript : sequence of Windows in tdlines files

Hello Lars,

I have moved the code to a new private method _sort_tdlines_by_windows
But I don't add 'ASSERT sy-subrc = 0.'. 
The reason is that during my tests I found some windows in the form without elements inside (windows is not used anymore but it sill exists. The devlopper ddin't remove it). In this case the result of the ASSERT is a dump.
Using the loop from SY-TABIX there is no risk. If no entry exists in the internal table then the loop is not executed.

if needed I can add the following condition before doing the loop :
       IF line_exists( lt_lines[ tdformat = lv_elt_windows
                                tdline = ls_form_windows-tdwindow ] ).
Christophe

* Sapscript : sequence of Windows in tdlines files

I have done the adjustments for the CLEAR and to be  compatible with 702

Christophe

* Sapscript : sequence of Windows in tdlines files

Whitespace at end of line removed
2018-12-08 13:26:09 +01:00
larshp
79c799dffb SUCU support via generic serializer 2018-11-25 07:29:22 +01:00
larshp
158d54aceb pretty print: keywords upper case 2018-11-23 12:17:00 +01:00
larshp
6e9f6b8a45 TABL refactoring, CLEAR_DD03P_FIELDS added #2128 2018-11-23 05:58:04 +01:00
larshp
2fe5b30e4d TRAN refactoring, reduce method length #2128 2018-11-23 05:57:52 +01:00
Christian Guenter
b395132f3b SUSC: Delete tadir 2018-11-20 09:10:38 +01:00
Christian Guenter
8e8c478a7f SUSC: Fix code inspector errors 2018-11-17 10:27:40 +01:00
larshp
aac3c1b709 rename constants 2018-11-17 06:13:41 +01:00
Christian Guenter
e61108511d DDLX: Fix transport request recording + activation 2018-11-15 08:03:48 +01:00
Domi Bigl
ffac70b9c3 TRAN: ignore object not found while delete
If the transaction can't be found in FM RPY_TRANSACTION_DELETE, it's already deleted
2018-11-11 18:41:21 +01:00
Domi Bigl
297112614e SHI3: delete in more direct way - no confirm popup #2035 (#2094)
* SHI3: delete in more direct way - no confirm popup

SHI3 delete is done in a more direct way without confirmation popup

* naming conventions
2018-11-11 17:48:51 +01:00
larshp
aae099b93d naming conventions 2018-11-11 17:45:12 +01:00
Domi Bigl
95287136d6 SUSC: delete in more direct way - no confirm popup #2036 (#2079)
* SUSC: delete in more direct way - no confirm popup

delete needs to be done with a code copy of FM SUSR_DELETE_OBJECT_CLASS
I really hate this but there is no other way

* SUSC: delete in more direct way - no confirm popup

* test

* test

* naming conventions

* PP
2018-11-11 17:44:40 +01:00
Christian Günter
dc173ad906 DCLS: Fix activation error + TADIR handling + late deserialization #2051 (#2085)
* DCLS: Fix activation and move to late deser.

* DCLS: improve tadir handling + activation
2018-11-11 06:32:56 +01:00
Christian Guenter
2a08aca65a SFSW: synchronous deletion 2018-11-11 06:31:42 +01:00
Domi Bigl
b7e5a56080 DEVC: get package from devclass or object name 2018-11-10 08:22:39 +01:00
Christian Günter
36fccd3b52 Fix TADIR handling #2066 (#2078)
* AUTH + FORM: delete tadir

* SFBS + SFBF: delete tadir

* SFSW: synchronous deletion
2018-11-10 08:11:22 +01:00
Christian Günter
74bf1b7e66 SICF: Better errors + is_locked 2018-11-09 11:56:06 +01:00
larshp
9270a58b62 cleanup unreference variables 2018-11-09 11:55:47 +01:00
Christian Guenter
fec33acf5f DDLX: add tadir handling 2018-11-09 05:37:26 +01:00
larshp
7cdbbc92b6 remove some unreferenced variables 2018-11-08 16:35:08 +01:00
larshp
6415f9e249 update abaplint to latest 2018-11-08 06:26:32 +01:00
larshp
28ae85e270 naming conventions 2018-11-08 06:15:07 +01:00
Lars Hvam
06616580eb
Naming conventions (#2059)
* fix naming conventions

* naming conventions
2018-11-07 12:50:20 +01:00
Lars Hvam
89e5010fd0
Naming conventions fixes, #2053 (#2058)
* fix more naming conventions

* more naming conventions fixes
2018-11-07 12:05:27 +01:00
Christian Guenter
e17d3334ff PARA: implement is_locked 2018-11-05 12:47:44 +01:00
Domi Bigl
e326273f20 SCP1: delete in more direct way - no confirm popup
FM SCPR_PRSET_MN_DELETE has some confirmation popups so the delete is done in a more direct way without popups
2018-11-05 12:47:31 +01:00
Christian Guenter
8b1cbd4b89 PARA: better error information 2018-11-03 12:48:51 +01:00
Christian Guenter
45a2ba1cd1 add factory for GUI_IS_AVAILABLE
This commit adds an indirection for function module GUI_IS_AVAILABLE
via interface ZIF_ABAPGIT_GUI_FUNCTIONS and factory ZCL_ABAPGIT_UI_FACTORY.

For tests the implementation can be replaced with
ZCL_ABAPGIT_UI_INJECTOR=>SET_GUI_FUNCTIONS
2018-11-03 08:42:32 +01:00
Christian Günter
db6f21f78c ENHO: save dark 2018-11-03 08:41:25 +01:00
Christian Guenter
6c3538a13a PARA: fix error handling 2018-11-03 08:40:46 +01:00
Domi Bigl
95deb3ed57 Add checks for empty class includes CLAS 2018-11-03 08:40:19 +01:00
Domi Bigl
b8ed4589af SSFO: change workarea range_node_code type 2018-11-01 07:16:43 +01:00
larshp
d82b9daf0e SSFO: do not use STTY_SR_STRING_RANGE 2018-11-01 06:23:24 +01:00
larshp
d426fd4540 SAXX: implement is_active 2018-11-01 06:20:53 +01:00
Christian Guenter
4f39cc2971 SUSC: implement is_active 2018-11-01 04:37:14 +01:00
Christian Guenter
a791d7ddaf CLAS: Add checks for empty class includes 2018-10-31 16:00:41 +01:00
Domi Bigl
cf05295170 mark inactive objects in repo list #1943 (#2017)
* mark inactive objects in repo list

Inactive object are marked in the repo list
The sort order for changed files is not changed
unchanged inactive files come right after the changed files

* move acitve check to object interface

* add is_active for objects up to F

* add is_active for objects up to P

* add is_active for objects up to T

* add is_active for objects up to X

all core object implement (except SSFO) the standard active check via FM RS_INACTIVE_OBJECTS_WARNING now

* add is_active to plugins bridge - always active

* finish object interface implementation + objects

* add is_active for offline with object interface

* rename returning to RV_

* use returning for serialize

* cleanup, PP, UT
2018-10-31 15:54:57 +01:00
Domi Bigl
1c396d9f19 add code line attribute for leading spaces #2011 (#2014)
* add code line attribute for leading spaces

Use attribute abapgit-leadig-spaces to store leading spaces of coding lines at serialization. This is used in deserialization to restoreformatting after XML normalization.

* add attribute also for global types and forms

* fix code formatting
2018-10-26 07:11:38 +02:00
Christian Guenter
cdf3be54c1 SSFO: fix method FX_IDS
Before this commit is applied the FIX_IDS methods was errorneous
and lead to subsequent dump. This commit fixes the algorithm to
replace IDs and IDREFs
2018-10-19 08:00:47 +02:00
Lars Hvam
f405ff9e86 ecatt: remove DEFINITION LOAD of global class 2018-10-19 08:00:20 +02:00
Frederik Hudák
1bb195b344 Removed the rest of endmethod/endclass comments 2018-10-18 07:27:27 +02:00
Christian Guenter
7d92edec4f TRAN: Support oo transactions 2018-10-13 10:00:27 +02:00
Lars Hvam
fa39fcd43f
Code inspector fixes (#1997)
* pretty print

* definitions to top of routine

* space before .

* omit parameter names where possible

* double space after if

* remove pseudo comments where possible
2018-10-12 07:56:27 +02:00
Domi Bigl
2644624985 clear PRESP and PWORK in IEXT serialization + cleanup (#1987)
* clear PRESP and PWORK

clear username fields PRESP and PWORK

* remove unused FM exceptions

if sy-subrc is analysed (only <> 0) no detailed FM exceptions are needed, only OTHERS

* set PRESP and PWORK on deserialization

PRESP and PWORK is not set to SY-UNAME by default so set it explicitly
2018-10-09 12:24:26 +02:00
larshp
e65f55c876 fix whitespace 2018-10-07 09:07:04 +00:00
PCF
b73d90c8c8 Sort dynpros at serialize to get a consistent serialized file 2018-10-07 10:57:47 +02:00
Christian Guenter
9e0161f097 SUSO: Downport delete to 702 2018-10-07 10:56:00 +02:00
Andrew Barnard
4f795f5a88 Object Type UDMO Data Model #1905 (#1966)
* Object Type UDMO Data Model #1905

Support for Object Type UDMO Data Model #1905

* Object Type UDMO Data Model #1905

* Object Type UDMO Data Model #1905

* Object Type UDMO Data Model #1905 Bad formatting correction

* Object Type UDMO Data Model #1905 Bad formatting

* Object Type UDMO Data Model #1905 Reformulation

* Update package.json

* pretty print
2018-10-07 10:55:15 +02:00
larshp
fdf7fd91d4 PROG: clear resize min + max if no resizing #1907
PROG: clear resize min + max if no resizing #1907
2018-10-02 07:46:40 +02:00
Christian Guenter
e9affd102a WEBI: Fix multiple service methods 2018-09-30 12:12:33 +02:00
Christian Günter
44327bf5a1 WEBI: fix package popup 2018-09-29 08:54:50 +02:00
Christian Guenter
2a11522598 DDLS, DCLS, DDLX: Improve Error handling 2018-09-29 08:54:35 +02:00
Christian Guenter
910513bbd3 SUSO: Downport to 702 2018-09-28 08:24:33 +02:00
cherifim
cb10996905 Update zcl_abapgit_object_auth.clas.abap
Syntax DATA(dummy)  is not supported by older SAP Systems (like 7.31), it is available only since 7.40
2018-09-27 17:48:11 +02:00
larshp
7b90fccaea PROG: skip bad dynpro numbers #1967 2018-09-27 15:04:17 +02:00
larshp
ba787d373e SICF: Decouple from core, #1941
Change calls to static SICF methods to dynamic, in order to be able to support systems which do not have SICF objects.
2018-09-27 15:03:15 +02:00
Fabian Lupa
ce05bb65b1 Serialize additional class component metadata (#1889)
* Serialize additional class component metadata

Fixes #1872

* Improve update_attributes performance

* Update WF attribute handling to use API
2018-09-25 16:11:50 +02:00
Christian Guenter
a78aa521b3 DDLX: Serialzie source code in .asddls file
Before this commit is applied DDLX source code was recorded
in the xml file. We changed this so that now a separte .asddls
file is created. The change is downward compatible. Previously
recorded DDLX objects will show a diff the next time and the new
.asddls file has to be committed.
2018-09-25 16:03:51 +02:00
Christian Günter
f7ce109f86 SUSO Delete: remove popup #1948 (#1949)
* SUSO: Delete remove popup

* Refactor delete document method
2018-09-25 16:02:02 +02:00
larshp
d21bbb6caa XSLT: show sy-subrc error 2018-09-25 16:01:25 +02:00