Commit Graph

806 Commits

Author SHA1 Message Date
Marc Bernard
884a71e00e
Forms: Radio options and minor fixes (#5291)
- Allow for radio options to be arranged in column (instead of side-by-side)
- Render maxlength for text fields only when provided

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-26 19:54:09 +01:00
Marc Bernard
254e6d51e3
UI: Center Popups - Part 2 (#5290)
* UI: Center Popups - Part 2

Adjusting more popups #5275

* Refactor for method length

* Lint indent
2022-01-25 18:40:20 +01:00
Frank Müller
c932426b44
Pre Filter Backend and GUI Logic (#5227)
* Initial

* Adjustments

* Router

* Abaplint

* abaplint

* diff between eclipse and vscode

* Multiple Adjustments

* Split Backend And GUI Logic

* Multiple Adjustments

* No Unit Tests

* abaplint

* Rename ZCL_ABAPGIT_REPO_PRE_FILTER to ...TR

* Multiple Adjustments

* Refactor the OVP action links into a toolbar

* abaplint

* Replace BAPI_MSG by STRING

* Rename Pre Filter to Object Filter

* Rename Pre Filter also in abap_transpile.json

* restore from main

* Check if <ls_item>-li_class is filled in Toolbar

* Adj. toolbars and move TR Req to zif_abapgit_popup

* abaplint

* Move  ty_trrngtrkor_tt to zif_abapgit_definitions

* abaplint

* Move and rename filter menu entries

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: IBM <mbox-060-sap-extern-tbom@daimler.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-01-25 10:00:09 +01:00
Marc Bernard
d7cdb65243
Forms: Minimum text field length (#5287) 2022-01-24 17:10:40 +01:00
Marc Bernard
656e94c612
Change icon for user settings (#5282)
* Change icon for user settings

Reduce confusion because of same icon for different settings.

Closes https://github.com/abapGit/abapGit/issues/5088

* Icon

* Update toolbars

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-24 14:21:02 +01:00
Marc Bernard
cf9ede7d7c
UI: Center Popups (#5274)
* UI: Center Popups

GUI popups were showing up all over the screen. On bigger screens, they often display outside the abapGit HTML frame.

With this change, most popups will show nicely centered or close to it (some fine tuning might still be required).

Notes: 
- Some popups like the one prompting for a transport request do not allow to influence the screen position. 
- Follow-up: Consolidate "Tag Popups" from `ZCL_ABAPGIT_TAG_POPUPS` to `ZCL_ABAPGIT_POPUPS` and adjust accordingly.

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-23 08:50:11 +01:00
Christian Günter
a416de1cf9
Enable clickable icons for link lints (#5271)
* Enable icon for link lints

* Enable clickable icons for link lints
2022-01-17 12:10:00 +01:00
Christian Günter
e74076c0bb
Repo View: 'Order by path' considers object name (#5261)
+ sort files

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-01-10 21:16:32 +01:00
Marc Bernard
074ae5a69b
Refactor: Calling batch input (#5252)
* Refactor: Calling batch input

Standardizes calling batch input API and handling errors.

* Fix indent

* Add new window

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-10 09:27:17 +01:00
Fabian Lupa
a586e5c9ed
Save additional repo view settings (#5257)
* Save additional repo view settings

* Fix formatting
2022-01-10 07:29:11 +01:00
Lars Hvam
c3b9980486
replace XUBNAME with SYUNAME (#5248) 2022-01-06 08:18:45 +01:00
Lars Hvam
1387128719
unit testing updates (#5246)
* unit testing updates

* fix

* split unit test method, ZCL_ABAPGIT_HTML_FORM_UTIL

* run is_empty

* type changes

* update notes

* update

* upd

* update notes

* run check_author_regex

* run parse_commits

* update notes

* add notes

* update

* run extract_author_data1

* run extract_author_data2

* run extract_author_data9

* update notes
2022-01-06 08:14:43 +01:00
Marc Bernard
b2f62e91d5
Repo View: Improve view with folders (#5215)
* Repo View: Improve view with folders 

I made some improvements to the folder view:
- Boxed display of path
- Separate links for folders within path
- Remove leading/trailing `/` in folder display
- Better alignment of `..` parent folder 
- Fix incorrect HTML since `%26lt;tr%26gt;` was before `%26lt;thead%26gt;`

Ref https://github.com/abapGit/abapGit/pull/5159#issuecomment-976124592

* Update CSS

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-12-22 10:31:44 -05:00
Marc Bernard
4f1a4a2b01
Commit page: Add description to links (#5214)
Add some text to clarify links between "Summary" and "Detail" 
https://github.com/abapGit/abapGit/pull/5087#issuecomment-991951078
2021-12-13 15:31:03 -05:00
Marc Bernard
9d5018e39e
Fix code inspection output (#5211)
Fix typo in comparison of object and sub-object
2021-12-13 15:16:07 -05:00
Christian Günter
fe363f7b0a
Downport clipboard_export (#5206)
* Downport clipboard_export

* add transpile filter

* undo
2021-12-13 08:02:19 +01:00
Christian Günter
53a314d946
Command palette: auto close if other palette opens (#5192) 2021-12-09 14:38:10 +01:00
Marc Bernard
b46c8b4599
Refactor: Consolidate front-end classes (#5172)
* Refactor: Consolidate front-end classes

There's no need for two "front-end classes". Moves all of ZCL_ABAPGIT_GUI_FUNCTIONS to ZCL_ABAPGIT_FRONTEND_SERVICES. Now all front-end calls are nicely together.

No functional change, some method reordering. 

Ref #2510, #5145

* Add missing interface

Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-12-09 06:49:43 +01:00
Marc Bernard
1bed7ae318
Repo view: Set minimum width of status column (#5180)
* Repo view: Set minimum width of status column

As seen in https://github.com/abapGit/abapGit/issues/5178, if the repo view table is very wide, the status column might not wide enough and be wrapped. 

Change ensures a minimum width of the column.

* Reduce

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-12-08 11:57:25 -05:00
Marc Bernard
97821c8428
Add user exit for adjusting display of filenames (#5185)
The filenames can become very long, for example, usage of many sub-packages, namespaces, objects like function groups, or BSP/Fiori apps with many sub-objects, or a long paths as starting folder. This can make the repository view very busy or render the output as a very wide table (see #5169, #5178).

This exit allows to adjust the filename according to your own rules. 

Here's an example for shortening the display of files for sub-objects:

```abap
  METHOD zif_abapgit_exit~adjust_display_filename.

    DATA:
      lv_path TYPE string,
      lv_name TYPE string,
      lv_ext1 TYPE string,
      lv_ext2 TYPE string.

    SPLIT iv_filename AT '.' INTO lv_path lv_name lv_ext1 lv_ext2.

    IF lv_ext2 IS INITIAL.
      " Main object
      rv_filename = iv_filename.
    ELSE.
      " Sub object
      rv_filename = |…{ lv_ext1 }.{ lv_ext2 }|.
    ENDIF.

  ENDMETHOD.
```
2021-12-08 08:07:45 +01:00
Christian Günter
451ab7cadf
WebGUI: Disable jump (#5184)
Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
2021-12-06 16:13:24 -05:00
Christian Günter
ad5bad77cb
Webgui: fix path + file encoding issue (#5182)
Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
2021-12-06 15:34:30 -05:00
Marc Bernard
b5af548ed8
Fix "Remove" button for data tables (#5177)
The remove button was not working because it was defined as a second `main` button.
2021-12-03 22:02:46 -05:00
Christian Günter
94e6bdc20b
Patch: Fix link hints (#5176) 2021-12-03 09:10:04 -05:00
Marc Bernard
4910506b35
Fix vimium links (#5175)
* Fix vimium links

* Lint
2021-12-02 07:52:58 +01:00
Christian Günter
29f35b0d47
remove superfluous function name (#5174)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-12-01 09:30:18 -05:00
Marc Bernard
29a9201a3b
Commit page: option to hide author fields (#5171)
* Commit page: option to hide author fields

The vast majority of time the committer is the same as the author (I assume). This adds an option to hide the author name and email fields on the commit form.

* Update docs

* Update docs

Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-12-01 09:27:30 -05:00
Marc Bernard
3fa3323b2e
Refactor: Jump to Object Logic (#5158)
* Refactor: Jump to Object Logic

Continue #5114

- Removes jump_adt and jump_se11 from zcl_abapgit_objects_super
- Remove almost all object-specific jump handlers (zif_abapgit_object~jump) since they are covered by GUI Jumper now

* Remove ZCL_ABAPGIT_OBJECT_SICF

* Remove obsolete RS_TOOL_ACCESS

* FUGR

* IATU

* PDXX

* SRVD

* XINX

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-11-29 15:52:13 -05:00
Marc Bernard
9778ec5258
Diff/Patch: Adjust view menu (#5168)
"Ignore Indentation" was not accurate. Renamed it to "Ignore Whitespace".
2021-11-26 10:10:14 -05:00
Christian Günter
13c4d57dd3
Patch: enable new view options similar to Diff (#5162)
* enable new view options on patch page

* add unit test

* new constant for unchanged lines
2021-11-26 07:41:57 +01:00
Marc Bernard
095c35f49b
Diff: Add options to ignore indent, comments, case (#5146)
* Diff: Add options to ignore indent, comments, case

Continuing on #2804

Enjoy!

* Skip new tests

* Trigger actions

* Trigger action

* Trigger action

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-25 07:33:48 +01:00
g-back
510441d486
Decouple last direct usage of CL_GUI_FRONTEND_SERVICES (#5145)
* Add new methods 


directory_create and directory_exis

* clean up whitespace

* normalize whitespace, formatting, comments

* decouple direct usage of cl_gui_frontend_services

* downport + concatenate to string template

* move param to single line

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-23 09:09:38 -05:00
Marc Bernard
928300a5c2
Repo View: Remove file path in folder view (#5159)
No need to show path when in folder view.

Before:

After:
2021-11-22 19:21:29 -05:00
Christian Günter
b6b0aef3b6
add links inside forms to command palette (#5144) 2021-11-18 15:32:19 -05:00
Christian Günter
2dc5626e70
add form actions to command palette (#5141)
* add form actions to command palette

* fix attribute

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-11-18 14:17:52 -05:00
Marc Bernard
543969e870
Fix icon hover in repo bar (#5143)
Closes #5142
2021-11-18 12:12:26 -05:00
Christian Günter
9d0e19feb9
add more toolbars to CommandPalette (#5136) 2021-11-17 07:52:47 +01:00
Marc Bernard
86262f4e54
Diff/Patch: Add "Filter by Object Type" (#5129)
* Diff/Patch: Add "Filter by Object Type"

Enhancement of filter options:

- Renamed "Type" to "Extension"
- Added "Object Type" 

Closes #3249

* Switch to INSERT

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-11-15 16:48:19 +01:00
Christian Günter
500d7eeb9f
hotkeys for form actions (#5133) 2021-11-14 14:55:38 +01:00
Christian Günter
e4b29954a4
Show implicit form hotkeys (#5132)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-14 07:45:44 +01:00
Marc Bernard
060abb8635
Make exceptions compatible with 702 (#5116)
* Make exceptions compatible with 702

702 does not deserialize exception classes correctly that have a constructor in a super class (see #1273). Adding an explicit constructor that calls the super-constructor, the issue is avoided.

* Pretty

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-14 07:28:38 +01:00
g-back
289f22d79d
Add Feature: Create New Branch for Commit (#5123)
* add feature: create new branch for commit

* add clarifying comments

* add check for empty branch name

* remove check box, add condense to new branch name

* add duplicate check for branch name

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-11-10 09:19:47 -05:00
Marc Bernard
51aeea2bc5
Update descriptions of MIME objects (#5124) 2021-11-09 17:22:25 -05:00
Marc Bernard
53951dc2ad
Remove more unused variables (#5112)
* Remove more unused variables

* rm

* rm

* rm

* rm

* needed for refactor later

* rm

* Needed for callback

* rm

* rm

* Pragma

* rm enho

* rm

* rm

* Setting unused_variables

* Revert unused_variables setting

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-09 16:22:29 +01:00
Derby
0ee847e383
bug: When Imoprt ZIP does not display error log. (#5121)
In case of offline + Import ZIP, error log is not showed.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-09 16:14:49 +01:00
Christian Günter
4c919b2aa6
Hotkey overview: Show link hint activation key (#5122) 2021-11-09 08:34:09 -05:00
Christian Günter
02a06cae8f
LinkHints/Hotkey: Unify activation (#5108)
Use hotkey activation logic also for link hints. Previously it was possble to activate link hints on some input fields (e.g. search on stage page). This is now fixed.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-09 05:45:57 +01:00
Marc Bernard
a37cf58e01
Refactor: Jump to Object Logic (#5114)
* Refactor: Jump to Object Logic

The goal is to greatly simplify the code to jump to an object, and to separate UI and object layers some more.

This PR introduces GUI Jumper (`zcl/if_abapgit_gui_jumper`), which covers all generic options to show an object. It tries the following options in order:
- ADT (if enabled)
- Workbench with line number
- Workbench without line number
- Transport System (new)

Only if all fail, abapGit will call the object-specific handler. 

Next steps:

- Remove `jump_adt` and `jump_se11` from `zcl_abapgit_objects_super` and replace by GUI Jumper
- Remove almost all object-specific jump handler since they are covered by GUI Jumper now

* Add class

* Lint

* Misleading name
2021-11-07 08:15:08 +01:00
Marc Bernard
9f689e4e4f
Title case for hotkey descriptions (#5113)
Closes #5089
2021-11-05 17:22:37 +01:00
Lars Hvam
2bee3c8253
remove unused variables (#5107)
* remove unused variables

* rm

* rm

* rm

* rm

* rm
2021-11-05 15:20:56 +01:00