Commit Graph

27 Commits

Author SHA1 Message Date
Marc Bernard
ee9e32d442
Refactor zcx_abapgit_exception (#7123)
Some checks failed
main-build / build-merged (push) Has been cancelled
main-build / auto-tag (push) Has been cancelled
main-build / coverage (push) Has been cancelled
main-build / auto-tag-artifact (push) Has been cancelled
ajson mirror / pr_ajson_changes (push) Has been cancelled
2025-01-10 13:01:11 +01:00
francisco-milan
7bff32b718
Fix typos and adjust comments within source code. (#6778)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2024-01-28 09:21:14 +01:00
Marc Bernard
b4cc162a2c
Clean-up slow_parameter_passing (#6577)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-10-26 16:40:32 +02:00
Lars Hvam
83b554f75e
refactor call to TEXT_SPLIT (#6366) 2023-07-23 11:10:18 +02:00
Lars Hvam
13886f99dc
remove static references to abap_callstack_line (#6032) 2023-02-03 16:23:11 +01:00
Marc Bernard
6485ec50c1
Refactor: MESSAGE ... INTO (#6008) 2023-01-25 09:55:41 +01:00
Marc Bernard
24b1bcffa7
Remove cases of modifying syst fields (#5831)
Remove cases of modifying `syst` structure
2022-10-20 16:43:03 +02:00
Alexander Tsybulsky
380508d72c
FUGR: Better maintenance view auto comments cleanups (#5622) 2022-06-13 12:00:09 +02:00
Fabian Lupa
1052ce6e85
Support direct longtexts in exceptions (#5592)
* Support direct longtexts in exceptions

as opposed to already supported indirect T100-based longtexts

* Lint

* Remove direct longtext variable support

* Add unit tests for exception longtext

* Add longtext message to language mismatch error

* Fix missing preserve_newline handling

* Adjust longtext display in error message box

- Convert newlines to html line breaks
- Indicate if a longtext is available on hover

* Fix duplicate preserve newline handling

* Adjust exception longtext rendering

Render linebreaks as html paragraphs

* Align error message box buttons to bottom right

so they do not move on hover when a longtext is available

* Refactor exception unit tests

* Skip failing transpiled tests

* Adjust longtext indicator for error message

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-06-05 18:40:34 +02:00
Alexander Tsybulsky
c0ad1a96d0
Better multi-lang class tpool handling (#5074)
* better multilang class tpool handling

* dont save lang list on empty clas docu

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-02 06:10:03 +01:00
Marc Bernard
cfb185b87c
Naming of class constants - Part 2 (#4983)
Ref #4945

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-01 08:04:36 +02:00
Marc Bernard
b331de6bc7
Naming of class constants (#4945)
* Naming of class constants

This is in preparation of enforcing a naming convention for constants in classes/interfaces. At the end, the following lint rule shall be set:

```json
    "class_attribute_names": {
      "constants": "^C_.+$",
...
    },
```

After this, the only remaining constants not following this rule are in `zcl_abapgit_version`.

* Update zif_abapgit_dot_abapgit.intf.abap

* Update zcl_abapgit_gui_chunk_lib.clas.abap

* Update zcl_abapgit_gui_router.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-14 16:47:48 +02:00
Alexander Tsybulsky
e5e558a312
Log refactoring, part 1 (#4676)
* log: new features

* log in exception

* log via gui_services

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-27 10:57:57 +01:00
Marc Bernard
16fb17cfe2
Exception: Set return for split_text_to_symsg (#4245)
Fixes return parameter for `ZCX_ABAPGIT_EXCEPTION=>SPLIT_TEXT_TO_SYMSG`

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-25 09:49:06 +01:00
Marc Bernard
19916a5909
Remove reference to helper (#3981) 2020-10-05 17:34:57 +02:00
Marc Bernard
42c909e688
Refactor: Remove dynamic instantiation of ZCL_ABAPGIT_MESSAGE_HELPER (#3966)
* Refactor: Remove dynamic instantiation of ZCL_ABAPGIT_MESSAGE_HELPER

Consolidate `ZCL_ABAPGIT_MESSAGE_HELPER` features into `ZCX_ABAPGIT_EXCEPTION` and removes helper.

* Remove helper

* Pretty

* Update chunk_lib

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-05 16:50:36 +02:00
Marc Bernard
dc9773bee9
Fix handling of T100 exceptions (#3943)
* Fix errors raised during deletion

* Fix error handler

* Harmonize top and bottom message banners

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-27 10:56:08 +02:00
ed-holland
cb851f4ab1
Added Utility method and used it in ENHS (#3658)
* Update zcx_abapgit_exception.clas.abap

* Added Utility class and adjusted exception raises

* Fix Linter

Co-authored-by: Ed Wenmakers <ed.wenmakers@redwood.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-09-03 09:02:01 +02:00
Christian Guenter
bae1e21c5b Refactoring: Delete unused variables 2020-01-13 18:41:52 +01:00
Christian Günter
5081ddf7d0 Improve error information - HTML error message (#2775)
* Improve error information

With this commit errors that are raised with zcx_abapgit_exception=>raise
and issued with message are enriched with two additional functions.

1) Go to source
Navigates to the source code position where zcx_abapgit_exception=>raise
is called

2) Callstack
Shows a popup with the full callstack and the possibility to navigate to
the source of each line with double click

This feature requires the full abapGit repository. Without nothing
changes.

* issue messages directly

* zcx_abapgit_exception: adapt callstack handling

- callstack as attribute
- export callstack to ABAP memory only when SAPGui is available

* rename memory id

* Add comment why we don't delete callstack from MEM

* cleanup

* first try html error display

* add some comments

* add longtext

* goto_source and callstack implemented

* part 2

* remove

* fix

* add close button

* fix long classname

* fix linter

* add jump to SE91

* fix lintmr

* fix and cleanup

* fix linter

* fix linter

* fix eslint

* fix linter

* remove message class

* remove superfluous constant

* add missing method implementation

* refactor

* add hotkey for message longtext toggling

* hotkey 2

* refactor + resize callstack popup

* Refactoring: simplify control flow

* fix goto callstack for merged abapGit

* refactor: simplify control flow

* Refactoring: introduce message helper

* fix linter

* remove TODO pragmas

* ren. render meth + move zcl_abapgit_gui_chunk_lib

* refactoring: simplify control flow

* simplify exception handling

* refactor

* refactor

* refactor

* remove duplication

* Rename method

* rename method

* remove superfluous constant

* call ZCL_ABAPGIT_MESSAGE_HELPER dynamically

* cleanup

* Improve UX

* fix linter

* remove hotkey
2019-07-28 03:46:53 -07:00
Lars Hvam
58235f1e6a
do not skip descriptions check for exception classes (#2714)
* do not skip descriptions check for exception classes

* remove description

* remove description

* remove description

* remove description

* remove description

* remove description

* remove description

* remove description
2019-05-29 23:54:06 -07:00
Fabian Lupa
8186964ef0 Backport ZCX_ABAPGIT_EXCEPTION to 7.02
Co-authored-by: Tapio Reisinger <tr@erp-bt.de>
2018-03-17 13:01:37 +01:00
Fabian Lupa
eac56ae802 Fix exception texts (fixes #1242) 2018-03-17 12:51:29 +01:00
Fabian Lupa
889106b68b Improve error messages (#1213)
* Add T100 support to ZCX_ABAPGIT_EXCEPTION

* Use T100 error messages in DEVC

* Replace zcx_abapgit_exception->text with get_text

* Use SE24 generated constructor in T100 exception
2018-03-10 13:27:09 +01:00
Christian Günter
14b4a217fd Beautify 2 2017-10-25 21:55:46 +00:00
larshp
87418cd125 exception, fix diff 2017-10-01 10:47:12 +00:00
larshp
860ff3b6df lcl_time to global class #773 2017-10-01 09:22:21 +00:00