Commit Graph

85 Commits

Author SHA1 Message Date
Marc Bernard
6f0dfc5a81
Fix extended check issues - Part 2 (#7087)
Some checks failed
main-build / build-merged (push) Has been cancelled
main-build / auto-tag (push) Has been cancelled
main-build / coverage (push) Has been cancelled
main-build / auto-tag-artifact (push) Has been cancelled
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2024-12-03 07:21:05 +01:00
Mike Pokraka
aee4d0aedd
Don't discard includes of nonexistent FUGR (#7053)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2024-09-24 00:25:28 +02:00
Lars Hvam
b751ff519e
basic FUGS serialization (#7045)
Co-authored-by: Marc Bernard <marc@marcbernardtools.com>
2024-09-11 13:52:41 +02:00
francisco-milan
bac2666e51
Fix typos and adjust comments within the codebase (Cont'd) (#6786) 2024-02-01 08:21:41 +01:00
francisco-milan
a1eb874ae7
Fix typos and adjust comments within the codebase (Cont'd). (#6785) 2024-01-31 06:20:03 +01:00
Marc Bernard
78aaf52046
FUGR: Fix check if include belong to function grp (#6711) 2023-12-20 14:27:34 -05:00
Marc Bernard
20c1a3c610
Refactor serializer constructor (#6701) 2023-12-18 17:16:00 -05:00
Christian Günter
7bdd8f9f4c
Extract calls to FM FUNCTION_EXISTS (#6588) 2023-10-27 13:16:53 +02:00
Marc Bernard
aeb6b285d8
Refactor: Fix observations (#6542)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-10-14 10:36:09 +02:00
Marc Bernard
cbd3cb3311
Handle ABAP Language Version for source code objects (#6476)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-10-08 09:07:34 +02:00
Marc Bernard
8420663819
Refactor: Simplify lock check for workbench objects (#6517)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-09-30 08:28:17 +02:00
Marc Bernard
13043b4d34
Prepare FUGR for ABAP Language Version (#6487) 2023-09-14 09:17:08 -04:00
Marc Bernard
152ae1d59c
Consolidate READ/UPDATE_PROGDIR calls (#6464) 2023-09-06 09:28:42 -04:00
Lars Hvam
a8bce57373
move get_jumper() to new objects factory (#6363) 2023-07-23 15:07:06 +02:00
Alexander Tsybulsky
b50be07041
Separate translations from XML, PO files (#6189) 2023-07-17 10:50:52 +03:00
Marc Bernard
c8a4a54a3e
Consolidate READ/INSERT/DELETE REPORT statements (#6299)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-06-24 13:20:24 +02:00
Marc Bernard
5e297630d7
FUGR, CLAS: Enhance "changed by" (#6274) 2023-05-14 09:06:26 +02:00
Marc Bernard
4c9d477882
FUGR,CLAS: Enhance "jump to" (#6250)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-05-03 17:35:00 +02:00
Marc Bernard
39d2e88be3
Enhance Serializer Interface - Follow-up (#6233) 2023-04-20 17:34:03 +02:00
Marc Bernard
5f1dc6d5e0
Enhance Serializer Interface (#6229) 2023-04-20 16:20:01 +02:00
Alexander Tsybulsky
018e56cfcf
USE_LXE settings and serialization of selected languages (in old format) (#6168)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-03-30 15:17:18 +02:00
Marc Bernard
004885fcc0
FUGR: Add documentation (longtexts) (#5795)
After #5786, Ref #5774

Serialize and deserialize documentation of function group, function modules, and parameters. 

Test case: 
https://github.com/abapGit-tests/FUGR_docu

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-10-04 09:44:03 -04:00
Alexander Tsybulsky
380508d72c
FUGR: Better maintenance view auto comments cleanups (#5622) 2022-06-13 12:00:09 +02:00
Marc Bernard
0ab3ee0a06
Remove aliases from object classes (#5588) 2022-06-04 10:33:42 +02:00
Marc Bernard
df2c88223a
FUGR: Fix diff of includes (#5489)
Sort list of includes to avoid diff
2022-04-26 14:40:20 +02:00
Marc Bernard
287539ed4a
CHDO: Avoid double pull and fix uninstall (#5439)
Change documents left a diff when pulled once that would go away after second pull. In debugging warning CD 763 could be seen "No TADIR entry found'. The `tadir` entry is now created properly.

Uninstall would fail with "Function group ... does not exist". Reason was that the function group was already deleted by `chdo` object. The deletion of such generated function groups is now skipped.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-05 16:04:14 +02:00
Marc Bernard
3666dda767
Rename methods returning boolean (#5436)
Just a bit of Clean ABAP:
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-nouns-for-classes-and-verbs-for-methods

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-03 10:40:12 +02:00
yellappam
1246e2718f
Sort includes (#5352)
In some systems, function modules RS_GET_ALL_INCLUDES returns an include *T00. Where *T00 include is not returned, abapGit adds to the internal table. This results in different sorting order in different systems. Sort to keep the same order.
2022-02-15 06:37:58 +01:00
Lars Hvam
c3b9980486
replace XUBNAME with SYUNAME (#5248) 2022-01-06 08:18:45 +01:00
Marc Bernard
2eaaff7ad9
Adjust usage of transport in object classes (#5218)
After #5216

Replaces `zcl_abapgit_default_transport=>get_instance( )->get( )` logic with `iv_transport` for the following object types:
`AMSD, BDEF, DRUL, DTDC, FDT0, FUGR, INTF, PROG, SQSC, SRVB, SRVD, WDCA`

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-03 10:50:53 +01:00
Marc Bernard
3fa3323b2e
Refactor: Jump to Object Logic (#5158)
* Refactor: Jump to Object Logic

Continue #5114

- Removes jump_adt and jump_se11 from zcl_abapgit_objects_super
- Remove almost all object-specific jump handlers (zif_abapgit_object~jump) since they are covered by GUI Jumper now

* Remove ZCL_ABAPGIT_OBJECT_SICF

* Remove obsolete RS_TOOL_ACCESS

* FUGR

* IATU

* PDXX

* SRVD

* XINX

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-11-29 15:52:13 -05:00
Frank Müller
6d02555f96
Check that include belongs to the same fugr (#5134)
* Check that include belongs to the same fugr

* abaplint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-15 16:50:44 +01:00
Marc Bernard
53951dc2ad
Remove more unused variables (#5112)
* Remove more unused variables

* rm

* rm

* rm

* rm

* needed for refactor later

* rm

* Needed for callback

* rm

* rm

* Pragma

* rm enho

* rm

* rm

* Setting unused_variables

* Revert unused_variables setting

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-09 16:22:29 +01:00
Marc Bernard
51ce0b4df9
FUGR: Fix performance issue (#5017)
Optimize selection of function group includes.
2021-10-06 08:01:51 +02:00
Lars Hvam
096aded586
LANGU rollbacks (#4829)
* LANGU rollbacks

#4828

* Update abaplint.json
2021-06-08 16:42:20 +02:00
Marc Bernard
e2a156a326
Replace deprecated LANGU type (#4815)
* Replace deprecated LANGU type

Replace with `sy-langu` and update abaplint rule

* Replace langu

* Add langu to void types

* Replace table of langu
2021-06-02 08:04:05 +02:00
Marc Bernard
73576ee60e
Improve error messages (#4472)
* Improve error messages

Pass T100 messages to UI/log

* T100 errors

* APACK

* OO

* DEVC

* DRUL

* DTDC

* SRVB

* OBJS

* Program

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-03 16:31:55 +01:00
JustACasual
bcbc3d527d
I18N: LXE Translations (#4415)
* Issue 2424

https://github.com/abapGit/abapGit/issues/2424

* Issue 2424

https://github.com/abapGit/abapGit/issues/2424

* Update src/objects/zcl_abapgit_object_fugr.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Fixing LINT issues

* Fixing LINT issues

* TABL, default ROWORCOLST on deserialize (#4430) (#4)

* Fix for #4425

* Remove whitespace at end of line

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Remove whitespace at end of line

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: DerGuteWolf <DerGuteWolf@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Centralize LXE functionality

* Fix FUGR LXE

* delete issue reference comments

* Delete issue reference comments

* Remove Aliases for LXE types

* Review Changes

* Copy from #4452

Integrate changes from #4452 into #4415

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: DerGuteWolf <DerGuteWolf@users.noreply.github.com>
Co-authored-by: Sebastian Koitka <sebastian.koitka@dematic.com>
Co-authored-by: Marc Bernard <marc@marcbernardtools.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-01-31 10:36:28 +01:00
Marc Bernard
31a550db0f
Refactor I18N settings (#4423)
* Refactor I18N settings

- Consolidate I18N parameters into a structure and pass it to xml and serializer classes (#4415)
- Continue change of terminology (#4043)

* Remove changes to serializer class

* Main lang

* DSYS

* OTGR

* Repo view

* Main langu

* Repo view %26 stage

* Serialize

* Settings

* Repo view

* Defs

* Stage

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-19 14:29:09 +01:00
Marc Bernard
b25a67acea
Terminology: Inclusive Language - Part 2 (#4159)
* Terminology: Inclusive Language - Part 2

Change "Master Language" to "Main Language" in UI and comments (documentation and variables next)

* Docs

* Docs

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-11 10:36:38 +01:00
Marc Bernard
c0192df9ec
Close some minor ToDos (#3995)
* Close some todos 

FUGR does not have any class includes

* Remove huh?

* Move WDYN activation to serializer

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-09 13:11:24 +02:00
Marc Bernard
9672f5b030
Adjust name prefix for types (#3991)
* Part 1

* Part 2

* Part 3

* Lint

* Part 5

* Part 6

* Part 7

* Part 8

* Part 9

* Enforce type naming prefix

All types need to start with TY_...

* Fix local types
2020-10-07 08:54:15 +02:00
g-back
c05af1163f
XML Refactoring: zif_abapgit_object et al. (#3895)
* change xml references

* change xml reference, remove type definition


deleted type already exists in zif_abapgit_definitions

* change XML references

* change indentation

* fix indentation

* fix ident pt. 3

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-17 17:24:32 +02:00
Lars Hvam
c9dbee83b4
XML refactoring (#3814)
* XML refactoring

+ DTEL

* ENHO_CLIF + FUGR

* INTF
2020-08-31 09:35:10 +02:00
Lars Hvam
8e7eea457a
FUGR serialization, performance (#3761)
Instead of calling function module FUNCTION_IMPORT_DOKU, replace with a SELECT SINGLE in buffered table

closes #3753
2020-08-19 06:44:39 +02:00
ed-holland
2871914578
Ensure no duplicates of functions are found (#3652)
* Ensure no duplicates of functions are found

* remove modify

Co-authored-by: Ed Wenmakers <ed.wenmakers@redwood.com>
2020-07-19 07:05:17 +02:00
Lars Hvam
8bd932f944
FUGR, FAE fix (#3611)
* FUGR, FAE fix

* FUGR, cache includes in instance

* remove CNAM field
2020-07-12 08:29:24 +02:00
Marc Bernard
70c96e701d
Fix syntax warnings (#3549)
* Update zcl_abapgit_object_ueno.clas.abap

* Fix syntax warning

* Fix syntax warning

* Fix syntax warning

* Fix syntax warning

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-27 16:30:16 +02:00
Lars Hvam
d36b43defe
line break parameters (#3444)
* line break parameters

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* fix
2020-06-04 15:10:35 +02:00
Lars Hvam
4b35ecffb3
FUGR: Give proper error messages for RFC parameter (#3222)
* FUGR: Give proper error messages for RFC parameter

* reduce line length
2020-03-03 10:21:33 +01:00