Commit Graph

37 Commits

Author SHA1 Message Date
Marc Bernard
a23c1d6d58
Fix extended check issues - Part 3 (#7088)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2024-12-05 17:35:53 +01:00
Marc Bernard
8b2ab1e5d9
CLIF: Add missing translations for classes and interfaces (#6963)
Some checks failed
main-build / build-merged (push) Has been cancelled
main-build / auto-tag (push) Has been cancelled
main-build / coverage (push) Has been cancelled
main-build / auto-tag-artifact (push) Has been cancelled
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2024-07-04 13:16:40 +02:00
Christian Günter
30415249ac
CLAS/INTF-SYNTAX_CHECK: Suppress status message (#6812) 2024-02-14 06:45:18 +01:00
Christian Günter
674a04792a
Refactor ZCL_ABAPGIT_OO_FACTORY (#6742) 2024-01-09 01:29:52 +01:00
Christian Günter
bf76fedf19
Do a syntax check before accessing version constant (#6733)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2024-01-07 12:42:02 +01:00
Lars Hvam
fa5fcfe00f
move ty_obj_attribute_tt to OO intf (#6688) 2023-12-07 10:01:00 +01:00
Marc Bernard
b09bc05b63
Clean-up double_spaces (#6573)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-10-26 06:41:17 +02:00
Abo
35711c489a
Update zcl_abapgit_oo_base.clas.abap (#6552)
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2023-10-19 18:32:35 +02:00
Christian Günter
bf117da81b
Fix syntax errors in latest abapGit (#6540) 2023-10-13 09:58:28 -04:00
Albert Mink
73950de6dd
[INTF/CLAS] Make deserialization more robust (#6537)
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2023-10-13 15:32:18 +02:00
Marc Bernard
cbd3cb3311
Handle ABAP Language Version for source code objects (#6476)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-10-08 09:07:34 +02:00
Christian Günter
c2254f9f8f
CLAS/INTF: Fix type (#6469) 2023-09-04 15:26:13 -04:00
Albert Mink
533c595375
CLAS/INTF: Fix seocompotx during deserialization (#6457)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2023-09-04 14:27:07 -04:00
Alexander Tsybulsky
b50be07041
Separate translations from XML, PO files (#6189) 2023-07-17 10:50:52 +03:00
Lars Hvam
cddf583806
OO serializer: skip includes not found (#6324) 2023-06-27 10:55:06 +02:00
Marc Bernard
c8a4a54a3e
Consolidate READ/INSERT/DELETE REPORT statements (#6299)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-06-24 13:20:24 +02:00
Marc Bernard
fce65fe249
Improve deletion of OTR texts (#6228) 2023-04-23 09:44:24 +02:00
Marc Bernard
021c992e25
CLAS: Serialize long texts for exception classes (#6186)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-04-05 14:50:46 +02:00
Marc Bernard
f452b8784a
Fix comment in zcl_abapgit_oo_class (#6158) 2023-03-19 12:04:20 +01:00
Marc Bernard
3a51dd23b5
CLAS: Fix error when changing redefinitions (#6102)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-02-27 09:44:02 +01:00
Marc Bernard
24e79943f5
Update object descriptions - Part 2 (#6019) 2023-02-02 09:03:51 +01:00
Marc Bernard
47dbee1d48
CLAS,INTF: Removing STATE field in XML (#5981)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-01-12 11:36:55 +01:00
Michael Schneider
9d0914675f
Remove static references to cl_oo_source (#5897)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-12-01 16:33:05 -05:00
Michael Schneider
21ed40e4d8
Remove references to cx_oo_clif_scan_error (#5905)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-12-01 12:13:44 -05:00
Marc Bernard
8e7c79261d
CLAS,INTF: Catch runtime error during update (#5841)
Prevent dump when deserializing classes and interfaces in case a sub component was changed in a way that standard SAP code does not handle.

References: 
- message `OO_SOURCE_BASED 019`
- SAP Note [2166231](https://launchpad.support.sap.com/#/notes/2166231)
- https://github.com/abapGit/abapGit/issues/5836

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-10-31 08:49:46 -04:00
Marc Bernard
67093085f6
CLAS,ENHO: Fix inactive enhancements (#5810)
* CLAS,ENHO: Fix inactive enhancements

When pulling a change to an existing class, existing enhancement where inactivated and the enhancement code deleted. 

This was caused by unnecessarily calling `CALL FUNCTION 'SEO_CLASS_CREATE_COMPLETE'` in `zcl_abapgit_oo_class->create`, twice.

The change avoids the second call if the class properties and attributes have *not* been changed. Interfaces are handled the same way. 

Tested with CI tests for classes and interfaces:


Closes #5809

* Clear

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-10-07 15:00:31 -04:00
Marc Bernard
16656d8141
CLAS: Fix pull for deleted interface methods (#5768)
* CLAS: Fix pull for deleted interface methods

In case an interface method was deleted, pulling a class that had implemented such method would not delete the implementation. This resulted in a diff and manual effort to remove the method (or repair the class).

The fix will compare the implemented methods and trigger the repair if necessary.

Closes #5578

* Update zcl_abapgit_oo_class.clas.abap

* return all includes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-09-26 11:20:17 -04:00
Marc Bernard
b18586ba32
CLAS,INTF: Add missing shorttexts (#5755)
* CLAS,INTF: Add missing shorttexts

Serializes shorttexts for sub components (like method and event parameters).

Preparation for https://github.com/abapGit/abapGit/pull/5718

New test cases:

https://github.com/abapGit-tests/INTF_docu
https://github.com/abapGit-tests/CLAS_docu

* Clear/set class/interface name for shorttexts

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-09-15 11:34:32 -04:00
Fabian Lupa
799334dfe2
Add exposure to workflow class attributes (#5603)
* Add exposure to workflow class attributes

* Add constant seoc_state_implemented to abaplint

* Also add seoc_state_implemented to ci/abaplint

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-31 20:33:17 +02:00
Marc Bernard
524f6eebc5
CLAS/INTF: Fix serialize/deserialize of documentation (#5374)
* INTF: Fix serialize/deserialize of documentation

Documentation of interfaces (document class IF) was missing and has been added.

* Fix translations
2022-02-28 14:25:52 +01:00
Fabian Lupa
dc51247e9b
Always use active version for DOCU CL (#5201)
* Always use active version for DOCU CL

* CLAS/INTF delete documentation on pull

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-12-14 06:36:00 +01:00
Marc Bernard
c63d92e6f1
Post-processing option for custom class serializer (#4953)
* Post-processing option for custom class serializer

When using the current exit for serializing classes, you have to code the complete serialization yourself (i.e. reading and formatting the code). 
https://docs.abapgit.org/ref-exits.html#custom_serialize_abap_clif

With this change, you get the option to let abapGit serialize the class first and then post-process the source in the exit. The change is compatible with existing implementations of the exit.

To use the post-processing option, add the following code to the beginning of the exit:

```abap
IF it_source IS INITIAL.
  RETURN.
ENDIF.
```

* Update ref-exits.md

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-09-18 06:23:06 +02:00
Marc Bernard
ce677e449f
INTF: Fix check if interface exists (#4759)
As mentioned in #4673, the existence check for interfaces is not correct and actually checking for classes. The PR will correct the check.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-14 10:28:35 +02:00
Marc Bernard
9f94f339aa
INTF: Refactor to fix "permission error" (#4673)
* INTF: Refactor to fix "permission error"

Implements interface deserializer the same way as the class deserializer.

Closes #4672

* Remove types

* Class exists

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-09 10:40:33 +02:00
Marc Bernard
a1cc7f8668
CLAS: Fix several issues related to class includes (#4510)
* CLAS: Remove test class include

Once unit tests are disabled, the test class include is now completely removed (before it might have still contains obsolete code).

Closes #4460

* Reverse pp

* Update 6 objects

* Typo

* Typo

* Revert

* Revert

* Revert

* Revert

* Revert

* Lint

* Update zcl_abapgit_oo_class.clas.abap

* Move add_to_activation

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-12 07:05:47 +01:00
Marc Bernard
73576ee60e
Improve error messages (#4472)
* Improve error messages

Pass T100 messages to UI/log

* T100 errors

* APACK

* OO

* DEVC

* DRUL

* DTDC

* SRVB

* OBJS

* Program

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-03 16:31:55 +01:00
Marc Bernard
1c8f8038c5
Package Structure - Part 3 (#4286)
$ABAPGIT_OBJECTS_OO:

ZCL_ABAPGIT_OO_BASE
ZCL_ABAPGIT_OO_CLASS
ZCL_ABAPGIT_OO_FACTORY
ZCL_ABAPGIT_OO_INTERFACE
ZCL_ABAPGIT_OO_SERIALIZER
ZIF_ABAPGIT_OO_OBJECT_FNC

#4253

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-04 08:51:43 +01:00