Commit Graph

57 Commits

Author SHA1 Message Date
Marc Bernard
6fcc223c31
Rename "Reset Local to "Selective Pull" (#4954)
Renames "Advanced" > "Reset Local (Forced Pull)" to "Selective Pull" and removes popup to simplify process.
2021-09-16 07:40:29 +02:00
Marc Bernard
c2e9e58319
Enhance "Force Pull" to become "Selective Pull" (#4733)
* Enhance "Force Pull" to become "Selective Pull"

With this PR you can now peform a selective pull. Yay!

- Changes "Force Pull" to show *all* changed objects in the usual "Overwrite Popup". This allows you to select individual objects to be pulled no matter if they were changed locally or remotely.
- Does *not* change the regular "Pull" logic

Closes #413, #4282

* Combine delete and overwrite popups

* Add icons to abaplint.json

* Change if to case

* Add icons to abaplint.json

* Enhance UTs

* show_icon

* Show icon

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-20 06:19:00 +02:00
Marc Bernard
d47c72f429
Remote Settings: Toolbar icon & clean-up (#4724)
* Remote Settings: Clean-up

Continue #4718

- Branch > Switch to PR: removed
- Advanced > Checkout commit: removed
- Advanced > Make Offline / Online: removed menu items and popups
- Advanced > Change Remote: removed menu item and page

* Remove ty_popups

* Remove checkout_commit

* Remove repo_view switch_to_pr

* Remove get_switched

* Add "Edit" icon also for offline

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-27 19:03:06 +02:00
Lars Hvam
393771e6ef
allow switching branches in write protected repos (#4595)
* allow switching branches in write protected repos

* fix
2021-03-06 08:43:18 +01:00
Frederik Hudák
c3012513b3
Optimize performance of switching branches (#4548) 2021-02-20 17:16:50 +01:00
Marc Bernard
46470da59d
Improvements for uninstall (#4198)
* Improvements for uninstall

- Improve error handling on deletion collecting errors in log
Closes #4197

- Remove limit of 3 loops which allows deleting objects with deeper dependencies
(Follow-up https://github.com/abapGit/abapGit/issues/3228#issuecomment-728800249)

* Exception

* Error msg

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-19 09:31:31 +01:00
Fabian Lupa
267f7a0a6e
Fix reset for deletions (#4194)
* Fix reset local not deleting objects

Fixes #4186

* Fix typo

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-17 17:59:01 +01:00
Lars Hvam
df652f0436
delete various unused local variables (#4126) 2020-11-03 08:43:04 +01:00
mariusraht2
ec99d16ec0
Checkout commit: Add menu entry and finish implementation (#4101)
* Implementation

* Add menu entry for checkout commit

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-30 10:24:27 +01:00
mariusraht2
6b336c58f0
ZCL_ABAPGIT_REPO_ONLINE: Change methods fetch_remote and push to be able to retrieve and push objects also by commit hash (#4077)
* Implementation

* Add changes to push method

* Reset commit hash if branch is being switched

* abapLint: Remove whitespace

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2020-10-28 11:56:56 +01:00
mariusraht2
a4172c6acc
ZCL_ABAPGIT_SERVICES_GIT: Add new method checkout_commit to let the user check out commits (#4076)
* Implementation

* abapLint: Omit exporting

* Omit obsolete variables

* Add caller for checkout_commit

* Extend hash column for 1 character

* Add reset_remote to set_sha1

* Merge branch 'master' into add_checkout_commit

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-28 11:08:39 +01:00
mariusraht2
69b6c3c38a
Implementation (#4086) 2020-10-28 10:41:22 +01:00
mariusraht2
3ec07c6493
ZCL_ABAPGIT_SERVICES_GIT: Change signature of method checkout_commit_build_popup (#4072)
* Implementation

* Remove unrelated pretty printer changes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-27 16:14:16 +01:00
mariusraht2
5aebc0c88e
ZCL_ABAPGIT_SERVICES_GIT: Add method checkout_commit_build_list to build the popup selection table for commits (#4070)
* Implementation

* abapLint: Omit exporting and avoid void types

* Clear all exporting parameters first

* Remove unrelated pretty printer changes
2020-10-27 16:05:04 +01:00
Lars Hvam
9c41a2b7d8
remove text pragmas and pseudo comments (#3827)
* remove text pragmas and pseudo comments

* fix whitespace

* fix carriage return

* test

* test

* Update zcl_abapgit_repo.clas.abap
2020-09-03 09:13:47 +02:00
Frederik Hudák
a1ecc65ecc
Improved branching messages (#3685)
* Improvements to branch messages

* Names without refs/heads
2020-07-31 06:15:56 +02:00
mariusraht2
b5d40ca2a3
Build commit popup (#3400)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Added new method checkout_commit_build_popup

* abapLint

* Use hash to identify selected popup row

* Moved definitions

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-28 07:23:05 +02:00
mariusraht2
b91043a270
Refactor Popup (#3310)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Update pull.yml

* Delete pull.yml

* Refactored popup logic

Related to #3040

Refactoring of popup logic/calling to be able to reuse it as commit list.

* Removed reset flag

Removed reset flag cause it doesn't belong to this PR (will be readded later)

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-04 08:36:24 +02:00
g-back
79a1a667c6
Switch branch protected (#3250)
* add write-protect check for switch branch

* disable link for disabled toolbar functions

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-11 12:54:24 +01:00
Jaime Rodriguez Capote
543114963f
abapOpenCheck - Naming Conventions revision #3239 (#3240)
* abapOpenChecks config file

* Ignore SCI config folder

* checks revision

* Revert "checks revision"

This reverts commit 56a12289df.

* Renaming non-constants

Pending:

* Remove SCI configuration

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-09 17:34:26 +01:00
Italo N
be9b57a0f2 Commit form should not be cleared on error (#3015)
* Commit form should not be cleared on error

* move the type definition to ZIF_ABAPGIT_DEFINITION

* Move type definition to new interface
2019-11-04 11:48:53 +01:00
Alexander Tsybulsky
d501afdf83 downport (#3026) 2019-11-01 17:25:44 +01:00
Frederik Hudák
04e196b816 Improve branching messages (#3018)
Mention name of branch which was just deleted/switched to.
2019-10-31 14:35:29 +01:00
Lars Hvam
1dbd4d1912
Refactoring types (#2785)
* align use less different types

* refactor

* updates
2019-07-15 09:33:37 -07:00
Alexander Tsybulsky
ecc1c85ee7 GUI subclass zcx_abapgit_cancel from zcx_abapgit_exception (#2576)
* subclass zcx_abapgit_cancel from zcx_abapgit_excep

* upper case
2019-03-26 23:51:38 -07:00
Lars Hvam
f9318305e9
Minor fixes (#2532)
* minor fixes regarding unused variables

* minor code inspector fixes
2019-03-15 05:54:39 -07:00
Christian Guenter
8cc6567d40 rename zcl_abapgit_tag to zcl_abapgit_git_tag 2019-02-26 21:29:41 -08:00
Lars Hvam
1a60384e84
move method get_unnecessary_local_objs #2127 (#2315)
* move method get_unnecessary_local_objs #2127

move method get_unnecessary_local_objs #2127

* interface for progress class

* oops, rollback previous commit
2019-01-23 06:27:29 +01:00
sbcgua
c465a6b2e8 Offline improvements (#2156)
* local reset in zip-based

* rebuild_local_checksums on new offline
2018-11-28 07:19:27 +01:00
sbcgua
af86d5b969 Refactor repo class, part1 (#2096)
* repo refactoring

* repo refactoring - part 2

* review fixes

* more review fixes
2018-11-17 06:12:20 +01:00
Frederik Hudák
1bb195b344 Removed the rest of endmethod/endclass comments 2018-10-18 07:27:27 +02:00
Lars Hvam
fa39fcd43f
Code inspector fixes (#1997)
* pretty print

* definitions to top of routine

* space before .

* omit parameter names where possible

* double space after if

* remove pseudo comments where possible
2018-10-12 07:56:27 +02:00
Domi Bigl
246b943b87 hide current branch and HEAD in delete popup #1908 (#1961)
* hide current branch and HEAD in delete popup

* refactoring and cleanup

* hide also HEAD symref

* throw  branch delete refused
2018-09-29 08:53:55 +02:00
Johannes Konings
d25bfaf725 fix some naming conventions
https://github.com/larshp/abapGit/issues/1132
2018-08-17 09:24:22 +02:00
Johannes Konings
c3691622ed fix some naming conventions
https://github.com/larshp/abapGit/issues/1132
2018-08-16 06:32:19 +02:00
larshp
6044d3e7b2 move PERSIST_USER behind interface
move PERSIST_USER behind interface

will be moved to instantiate via factory in follow up PR
2018-08-13 18:34:28 +02:00
Christian Günter
400846e036 Downport method call chains to 702 + IF_OO_SOURCE_POS_INDEX_HELPER #1775 (#1776)
* Downport method call chains to 702 + IF_OO_SOURCE_POS_INDEX_HELPER

* catch exception if interfaces doesn't exist

Catch exception if IF_OO_SOURCE_POS_INDEX_HELPER doesn't exist
2018-08-06 15:11:40 +02:00
larshp
1d035cf1ab create_branch refactored 2018-08-05 12:47:54 +02:00
larshp
28adb2f790 separate repo from DELETE_TAG 2018-08-05 12:17:34 +02:00
larshp
748a32f57c separate repo from DELETE_BRANCH 2018-08-05 12:17:34 +02:00
larshp
d431f2d9d0 separate repo from CREATE_BRANCH 2018-08-05 12:17:34 +02:00
Christian Günter
7ac8dc15b6 Remove local SHA1 from online repository #1485, #1509 (#1666)
* Remove local SHA1 from online repository

In this commit we remove the local SHA1 and all its references from
ZCL_ABAPGIT_REPO_ONLINE. SHA1 is also removed from repo persistency.
SHA1 insn't needed anymore. All where-used places were either migrated to
remote_SHA1 or removed.

* reintroduce logic after push
2018-07-22 10:11:09 +02:00
Christian Günter
4f9f47cd59 Set transport request if needed during uninstall or reset local (#1596)
* delete checks: set transport request if needed

this ensures that the transport request is set when deleting objects.
E.g. uninstalling the repositoy or reset local.

* separate type for delete checks
2018-07-11 16:18:08 +02:00
Lars Hvam
cda961dbe1
Merge pull request #1527 from christianguenter2/tag_popups
tag popups: dependency injection
2018-06-28 13:33:55 +02:00
christianguenter2
ea798193d0 Block commit/push if code inspection has errors
- new local setting to set check variant
- new local setting to block pull if code inspector check fails
- check is executed before staging
- new page to display code inspector results
2018-06-28 13:21:29 +02:00
Christian Guenter
fb91909947 tag popups dependency injection 2018-06-25 11:15:46 +02:00
Lars Hvam
838769d0bc
Merge pull request #1516 from FreHu/master
Fixed error message when committing without author name
2018-06-18 15:23:47 +02:00
Frederik Hudák
7e4285c1a8 Fixed error message when committing 2018-06-18 09:21:51 +02:00
larshp
9f75d6bd2b refresh repo cache after deletion #1482 2018-06-17 08:23:56 +00:00
christianguenter2
4662883723 Introduce ZIF_ABAPGIT_POPUPS
- create popups with factory ZCL_ABAPGIT_UI_FACTORY
- inject test doubles with injector class ZCL_ABAPGIT_UI_INJECTOR
2018-06-15 11:21:48 +02:00