* UI: Clear progress bar
Clears status/progress bar at end of process and removes leftover messages.
Closes#3505
* Lint
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* UI: Improvements for setting pages
- Better navigation between settings pages
After jumping between setting pages, the back button will go to last page before navigating to the settings (ie "back with bookmark")
- Add commit work
* Lint + router
* Jump repo view to settings
* Lint
* Conflict
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* User interface, "Advanced" menu
Added tooltips to the "Remove" and "Uninstall" options in the advanced menu. As a new user, I would revisit the [documentation](https://docs.abapgit.org/guide-online-uninstall.html) to distinguish between the two.
The tooltips are passed as "iv_title" parameters to ZCL_ABAPGIT_HTML_TOOLBAR->add
* Update src/ui/zcl_abapgit_gui_page_repo_view.clas.abap
Adjustments from review
* Update src/ui/zcl_abapgit_gui_page_repo_view.clas.abap
Adjustments from review
* Update zcl_abapgit_gui_page_repo_view.clas.abap
Comply with abaplint line length of 120
* Update zcl_abapgit_gui_page_repo_view.clas.abap
Comply with abaplint's no whitespaces at EOL
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* show log, remove title parameter
the log objec already have the title as part of the object, another input is not required
this aligns the code to always use the title from the object
closes#4223
* zif_abapgit_log, change title to csequence input
* Dialogs: Enhance HTML form with table control
- Adds option to maintain data using a table control
- Extends UTs with several cases that were include in #4172
- Table control to be used by "repo settings" #4171
* Border
* Lint
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* log, purge() now returns the log
For each action, the log should be returned, then it is up to the UI how or if to show or persist it in the session.
First step of #2821
* li_log not needed anymore
This adds shorthand methods for the SHA1 calculation of the different git artifacts.
More logic in ZCL_ABAPGIT_HASH, but easier to read and less application logic.
When repeatedly navigating "back" to the main screen via the "Repository List" [o] button:
If somewhere in this navigation sequence you Remove a repository,
then continue on via "Repository List",
but later you use the GUI's actual "BACK" button, until you have returned to the main screen where that repository still existed,
a short dump occurs as the exception raised by zcl_abapgit_repo_srv=>get in zcl_abapgit_gui_page_repo_view->render_content propagates unhandled
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Dialogs: New pages for global and personal setting
Redesign of abapGit settings using HTML forms. Two functional changes to old settings page:
- "Development Internal Settings" are only visible when using the developer version (not in standalone program)
- "User-specific hotkey settings" are not available anymore. The default hotkeys continue to work as before.
Global/Personal settings can be reached using hotkeys "x" and "y".
* Lint
* Hide button
* Change to top menu
* Remove old page
* Remove old page
* fix links
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* UI: Add help buttons to "New Online/Offline"
- Add help button to both dialogs linking to docs.abapgit.org
- Clicking the button brings up the documentation inside the GUI HTML viewer
- Enhancement to `zcl_abapgit_gui` and `zcl_abapgit_html_viewer_gui` to properly handle 'Back' when navigating through Internet pages
* Open help in external browser
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Refactor XSTRING_TO_INT
this will use the built-in type conversion, its less code and most likely also runs faster
* delete METHOD alpha_output
it is only used in one place, and its a simple NUMC that is converted
* Dialogs: HTML form enhancements
In preparation for https://github.com/abapGit/abapGit/issues/4171, HTML forms were enhanced as follows:
- New integer fields (type "number") with min/max, https://github.com/abapGit/abapGit/issues/3559
- Added support for minlength/maxlength for text fields
- Added support for read-only fields
- Added support for password fields
- New option for adding a help button to the form (with URL link)
- Moved HTML snippets to render method
- Changed parameters to csequence to also accept char variables (like abap_true)
- Minor adjustments to styles
* Lint and fix ul/fieldgroup
* Min/max validation, textarea
* Close textarea tag
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* ZCL_ABAPGIT_CONVERT refactor
this removes calls to function modules, replacing with class based equivalents, or all custom ABAP implementations
* rename local variables
* move merge types to merge class
this will make the God interface defintions smaller
also reducing INTF -> CLAS references
and making it easier to add an interface for the merge class in the future
* add interface ZIF_ABAPGIT_MERGE
* Terminology: Inclusive Language - Part 2
Change "Master Language" to "Main Language" in UI and comments (documentation and variables next)
* Docs
* Docs
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Move git url repo methods
This moves methods GET_COMMIT_DISPLAY_URL and GET_DEFAULT_COMMIT_DISPLAY_URL from the repo class to new class in new package GIT_PLATFORM.
we want to keep the repo class small, as its quite complex and central
#4085
* fix line length
* Triggers main command when pressing enter in form
Adds hidden button that triggers main command when pressing the enter key
* Lint
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Backup and restore for abapGit persistency
Backup complete content of abapGit persistency to a ZIP file and restore when necessary.
* Messages
* 702
Co-authored-by: Lars Hvam <larshp@hotmail.com>
- Added icon for user
- Changed icon for transport to truck
- Adapted "staging" page
- Renamed CSS-classes because of conflict with classes used on staging page
Screenshots #4097Closes#4098
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* 702: Downport
No chaining with CHANGING
* 702: Downport
* Syntax check variant
* Too many fields warning
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* UI: Unify rendering of branch, package, user names
Branch name was already rendered "boxed with a leading icon". The same is now done for package and user names.
See `zcl_abapgit_gui_chunk_lib->render_branch_name, render_package_name, render_user_name`.
Closes#4059
* Lint %26 transport
* Unknown user
* Transport css
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Some files that existed locally didn't have a link. After #4084, the state can be evaluated properly to determine if local object exists.
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Replace LEAVE with CALL SCREEN
* Add new option iv_show_commit
Add new option iv_show_commit to GUI_CHUNK_LIB to be able to suppress showing commit hash on GUI_PAGE_CODE_INSP page
* abapLint: Replace 'EQ' by '='
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
* Hide commit hash on other pages too
Hide commit hash on ZCL_ABAPGIT_GUI_PAGE_REPO_SETT and ZCL_ABAPGIT_GUI_PAGE_SYNTAX pages
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* refactor validation in html_form + UT
* minor UT tweak
* subtle form bugfix (boolc return space string)
* cleanup add forms
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Part 1
* Part 2
* Part 3
* Lint
* Part 5
* Part 6
* Part 7
* Part 8
* Part 9
* Enforce type naming prefix
All types need to start with TY_...
* Fix local types
* event->post_data logic
* part of pages, commit test
this is also long text
to test
* string_map: port strict() feature
* pages refactoring part 2
* linter
* docs
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Dialogs: add offline repo HTML form
* Dialogs: add offline repo HTML form
* Dialogs: add offline repo HTML form
* Lint
* Lint
* Chaining
* Set required attribute
* Check for empty display name
* Change validation
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Add button to launch IEChooser.exe on Windows
* Fix CASE statement
* Determine iechooser.exe path using system directory
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Split settings and dev utils menu
* Fix missing settings hotkey on repo view
* Revert "Fix missing settings hotkey on repo view"
This reverts commit 1444744a5f.
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* remove uses of CHAR30
* Update abaplint.json
* add basic unit test for ZCL_ABAPGIT_MESSAGE_HELPER
* replace uses of char50
* fix name
* Update abaplint.json
* use sy-uname instead of uname
in ZCL_ABAPGIT_USER_MASTER_RECORD
pretty print class ZCL_ABAPGIT_HTML_FORM, and change two static methods to instance, this will make future possible changes to the class easier to see in the history
Follow-up to #3717:
- Proper display of public, protected, and private sections
- Add CLAS prefix to be inline with other object types
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* popup_to_select_from_list can handle element tabs
popup_to_select_from_list can now handle element-based non-structured tables like a table of url strings
Therefore related to #3639
* Update zcl_abapgit_popups.clas.abap
* Fixed wrong value assigning and added assert
* Add performance test
* Fix some linter errors
* Refactor free selections to reduce method length
* Performance test add title to result ALV
* Attempt downport
* Downport
* Pretty Printer VS abaplint
* Undo more changes done by pretty printer
* Adjust performance popup title and ALV layout
* Move free sel dialog to global for abapmerge
* Move some type definitions for abapmerge
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* navigate to repo after ZIP import
* add zip import/export action for offline repos
* rename action labels
* change new state to be dependent on current page
change replacing -> new page if action called from repo list
rerender if in repo view
* add some TODOs, see PR discussion
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Update error msg
* Fix login popup errors and cancelation
* Remove validate/reset methods
* Lint
* Rename iv_repo_online to io_repo_online
* Change to error in status bar
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* refactoring, use interface for html
replace uses of zcl_abapgit_html with zif_abapgit_html
#3460
* replace additional uses of the A alias
* This removes the A alias from the HTML class
This removes the following alias,
"a FOR zif_abapgit_html~a ."
* fix syntax error
* background pull: always overwrite all objects
always choose to overwrite all objects when using the pull in background feature. If the decision is not set the job will fail with a "undecided" error
#3800
* fix page title typo
* Improve display when there are no changes in repo view
* Update view and remove empty_package method
* Empty package msg
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Validate if branch exists when displaying repo
* Validate if branch exists when displaying repo
* Lint
* Lint and 702
* Lint
* Rename validate_branch to validate
* Fix msg and branch display name
* Move msg to UI layer
* Lint
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
* abapGit Emergency Mode
On rare occasions, it is necessary to edit the abapGit settings to overcome an issue (example: https://github.com/larshp/abapGit/issues/3701).
This enhancement allows you to start abapGit in "emergency mode", which directly shows the "Database Utility" for you to view or edit any setting.
How to start abapGit in "Emergency Mode":
1. Go to transaction SU3 to maintain your user profile
2. Maintain parameter DBT with value "ZABAPGIT" (all-caps).
3. Start abapGit
4. After exiting abapGit, go back to SU3 and remove parameter DBT
* Update ref-database-util.md
* Add files via upload
* Update ref-database-util.md
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Use title case for page titles
Other minor changes:
- patch page is no longer called diff
- "code inspector" in main page action menu renamed to "check"
* Two more
* Update zcl_abapgit_gui_page_db_dis.clas.abap
* Update zcl_abapgit_gui_page_repo_sett.clas.abap
* Repo advanced menu
* Commit form labels
* Repo setting lables
* Settings, repo
* Final ones?
* Database util
* Column name in stage page
* abaplint
* Update zcl_abapgit_gui_page_stage.clas.abap
* Hover texts for stage column, commit settings
* lint
Turning on "Details" in Repo Overview will now hide the "Action" column to improve display on smaller screens.
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* show last commit hash w/ link if possible
link to commit is supported for github.com and bitbucket.org
* remove inline data declaration
* add gitlab link support with UT
* add commit icon for non supported provider
* remove inline declaration
* remove new for CRETE OBJECT
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Enhance result view of Code Inspector/Syntax Check
* Enhance result view of Code Inspector/Syntax Check
* Enhance result view of Code Inspector/Syntax Check
* Lint
* Move sort
* Downport: Fix syntax error in 702
Method "ASSERT_TRUE" does not exist in 702
* Downport: Fix syntax error in 702
Co-authored-by: Lars Hvam <larshp@hotmail.com>
After this fix is applied the menu "advanced > open in master language" opens the repo directly and doesn't open the repo list.
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Remember repo list filter
resolves#3552
Changes:
- store filter in local storage instead of session storage, so it is remembered on abapgit restart
- filter is saved whenever it is changed instead of page unload
- removed debug output, it doesn't need to clutter the main page
* Don't resave on page load
* Add semicolons
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Improved staging robustness
- Skipped any objects in the changelist that are not marked for staging prior to processing them , to avoid that they keep other objects without errors from being staged if the user wants to stage parts of the changes
* Reduced line length
* Removed missed whitespace
* Update abaplint.json
* Update abaplint.json
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Fixed faulty translation of post data to parsable string
- Added method TRANSLATE_POSTDATA to ZCL_ABAPGIT_UTILS as a centralized place to translate post data to a string
- Replaced all post data string concatenations with the translation helper method to correctly parse spaces that fall to the end of a table line (this should solve #3073 as well as any other random crash caused by accidental misalignment of the post data)
* Backport ABAP statement to 7.02
* Code cleanup for linter checks
* Code cleanup for linter checks
* Fixed a possible error in parsing
If it_postdata contains an empty last line, the staging fails, because the string may contain a lot of soaces at the end of the previous to last line.
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* HTML: move add_icon to interface
* ZCL_ABAPGIT_HTML_TOOLBAR use interface
* ZCL_ABAPGIT_GUI_REPO_OVER use interface
* ZCL_ABAPGIT_GUI_PAGE_VIEW_REPO use intf
* CI Update
* Raise exception when no .abapgit.xml is found (#3512)
Update
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Updated documentation for repo settings & icons (#3499)
* Completed to-dos
- Updated abapgit.xml example
- Completed missing docu for local settings
* screenshots
* screenshots
* Delete repo_settings_local.png
* screenshots
* Delete repo_settings_local.png
* screenshots
* screenshots
* Combine write-protect setting
* Merged to repo settings
* screenshots
* screenshots
* merged to repo settings
* merged to repo settings
* Adding details
* Added links
* links
* icons
* icons
* icons
* icons
* icons
* icons
* icons
* Update ref-icons.md
* icons
* icons
* Update docs/ref-dot-abapgit.md
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Fix icon display in docs (#3517)
Icons showed on github.com but not on docs.abapgit.org
* +On/offline: If package already in other repo, nav to repo (#3525)
* New method to get repo from package
If package already exists in a repo and it returns the repo and reason why the package can't be used in a new repo
* UI: If package exists in repo, nav to repo
+Online, +Offline - if repo is already versioned, navigate to repo and show message why package could not be used in new repo
Closes https://github.com/larshp/abapGit/issues/3452
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
* Update eslint requirement from ^7.2.0 to ^7.3.0 (#3534)
* Update @abaplint/cli requirement from ^2.36.6 to ^2.36.9 (#3535)
* Fix syntax errors in 702 (#3548)
Caused by https://github.com/larshp/abapGit/pull/3525
* SCP1 Import Order (#3543)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Update .gitlab-ci.yml
* Update eslint requirement from ^7.3.0 to ^7.3.1 (#3556)
* Update @abaplint/cli requirement from ^2.36.9 to ^2.37.2 (#3557)
* Repo overview as main page (#3498)
* Add main menu, toggle favorites
* Make abapgit logo go to overview
* Remove favorite repo links
* Fix remember filter
* Separator between filters
* Remove unused code
* Repo overview to main page
* Fix errors
* Fix naming
* Downport js
* Add separator
* remove unrelated changes
* Fix spacing
* Add package link
* Fix orderby dumping
* Only show tutorial with no favorites
Still have to do something about empty table
* Move abapgit installation info to debug info
* Improve tutorial, resolves#3497
* Add branch switch link
* Reduce line length
* Revert temporary hack
* Working version of removing logo
* No longer show tutorial in repositories
* Code cleanup
* More cleanup, rename tutorial to page
* Fix
* Force order by favorite
* Add checkmark icons
* View repo to page, rework menu
* Fix build
* Return logo
* Fix hotkeys on repo page, rename to page
* Fix show last repo, cleanup
* Abaplint
* Rollback js reformat
* Fix tutorial title, hotkeys
* Try resolve strange situation with PR
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Remove unused method (#3554)
* Remove unused method
* whitespace
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* 1.97.0 (#3561)
* 1.97.0
whitespace
* 1.97.0
* v1.97.0
* fix for apply_order_by (#3566)
* Update zcl_abapgit_repo.clas.abap (#3570)
* Dialogs: add online repo HTML form (#3533)
* first draft
* progress ...
* html->create()
* more progress
* and more
* getting closer
* wiring
* refactor popup_search_help
* refactor create_package to services
* fix services->new_online after rebase
* linter fixes
* more linter fixes
* straing map util
* error handling
* submits for side actions (ugly ... but ...)
* cleanups
* linter fixes
* refactor form values logic
* linter fix
* review fixes
* remove unused var after rebase
* review fixes, better side action layout
* linter fix
* minor css tweaks
* Fix user settings containing invalid repo key (#3569)
* Update zcl_abapgit_persistence_user.clas.abap
* Fix dump when last repo is invalid
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* UI: Fixes for dark theme (#3540)
* Add logo for dark theme
* Dark theme fixes
* Dark theme fixes
* Solve conflict
* Remove logo changes
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
* Missing objects in overwrite confirmation popup (#3558)
* Missing objects in overwrite confirmation popup
Closes https://github.com/larshp/abapGit/issues/3550
* Unit tests
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Fix open url in repo view (#3581)
* Fix open url in repo view
* Move call_browser to gui_router
* CSS and logo fixes (#3578)
* css cleanups
* orange logo
* Revert "orange logo"
This reverts commit b9aa45bbd0.
* update font
* css improvements
* remove logo png
* re-layout page title and footer
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Html form improvements and docs (#3582)
* auto id
* fix html validation (form in ul)
* form groups
* move colors to theme
* docs for html form component
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Generate news instance (#3585)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Update @abaplint/cli requirement from ^2.37.2 to ^2.37.5 (#3588)
* Update eslint requirement from ^7.3.1 to ^7.4.0 (#3589)
* Update .gitlab-ci.yml
* fix repo palette (#3580)
* fix repo palette
* fix page_view_repo after rebase
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Adjust new logo color for dark theme (#3592)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Add deleted objects to overwrite confirm popup (#3591)
* Add deleted objects to overwrite confirm popup
Closes https://github.com/larshp/abapGit/issues/2845
* Pretty print
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Top menu improvements (#3590)
* Use icons, add back menu to repo show page
* Event handling
* Abaplint
* Add menu to tutorial page
* Lint
* More icons
* Update tutorial, reorganize button code
* Move icon css
* Fix error
* Fix menu
* Update .gitlab-ci.yml
* Fix rebase issue
* Fix rebase mess up
* Raise exception when no .abapgit.xml is found (#3512)
Update
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Updated documentation for repo settings & icons (#3499)
* Completed to-dos
- Updated abapgit.xml example
- Completed missing docu for local settings
* screenshots
* screenshots
* Delete repo_settings_local.png
* screenshots
* Delete repo_settings_local.png
* screenshots
* screenshots
* Combine write-protect setting
* Merged to repo settings
* screenshots
* screenshots
* merged to repo settings
* merged to repo settings
* Adding details
* Added links
* links
* icons
* icons
* icons
* icons
* icons
* icons
* icons
* Update ref-icons.md
* icons
* icons
* Update docs/ref-dot-abapgit.md
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Fix icon display in docs (#3517)
Icons showed on github.com but not on docs.abapgit.org
* +On/offline: If package already in other repo, nav to repo (#3525)
* New method to get repo from package
If package already exists in a repo and it returns the repo and reason why the package can't be used in a new repo
* UI: If package exists in repo, nav to repo
+Online, +Offline - if repo is already versioned, navigate to repo and show message why package could not be used in new repo
Closes https://github.com/larshp/abapGit/issues/3452
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
* Update eslint requirement from ^7.2.0 to ^7.3.0 (#3534)
* Update @abaplint/cli requirement from ^2.36.6 to ^2.36.9 (#3535)
* Fix syntax errors in 702 (#3548)
Caused by https://github.com/larshp/abapGit/pull/3525
* SCP1 Import Order (#3543)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Update .gitlab-ci.yml
* Update eslint requirement from ^7.3.0 to ^7.3.1 (#3556)
* Update @abaplint/cli requirement from ^2.36.9 to ^2.37.2 (#3557)
* Repo overview as main page (#3498)
* Add main menu, toggle favorites
* Make abapgit logo go to overview
* Remove favorite repo links
* Fix remember filter
* Separator between filters
* Remove unused code
* Repo overview to main page
* Fix errors
* Fix naming
* Downport js
* Add separator
* remove unrelated changes
* Fix spacing
* Add package link
* Fix orderby dumping
* Only show tutorial with no favorites
Still have to do something about empty table
* Move abapgit installation info to debug info
* Improve tutorial, resolves#3497
* Add branch switch link
* Reduce line length
* Revert temporary hack
* Working version of removing logo
* No longer show tutorial in repositories
* Code cleanup
* More cleanup, rename tutorial to page
* Fix
* Force order by favorite
* Add checkmark icons
* View repo to page, rework menu
* Fix build
* Return logo
* Fix hotkeys on repo page, rename to page
* Fix show last repo, cleanup
* Abaplint
* Rollback js reformat
* Fix tutorial title, hotkeys
* Try resolve strange situation with PR
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Remove unused method (#3554)
* Remove unused method
* whitespace
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* 1.97.0 (#3561)
* 1.97.0
whitespace
* 1.97.0
* v1.97.0
* fix for apply_order_by (#3566)
* Update zcl_abapgit_repo.clas.abap (#3570)
* Dialogs: add online repo HTML form (#3533)
* first draft
* progress ...
* html->create()
* more progress
* and more
* getting closer
* wiring
* refactor popup_search_help
* refactor create_package to services
* fix services->new_online after rebase
* linter fixes
* more linter fixes
* straing map util
* error handling
* submits for side actions (ugly ... but ...)
* cleanups
* linter fixes
* refactor form values logic
* linter fix
* review fixes
* remove unused var after rebase
* review fixes, better side action layout
* linter fix
* minor css tweaks
* Fix user settings containing invalid repo key (#3569)
* Update zcl_abapgit_persistence_user.clas.abap
* Fix dump when last repo is invalid
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* UI: Fixes for dark theme (#3540)
* Add logo for dark theme
* Dark theme fixes
* Dark theme fixes
* Solve conflict
* Remove logo changes
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
* Missing objects in overwrite confirmation popup (#3558)
* Missing objects in overwrite confirmation popup
Closes https://github.com/larshp/abapGit/issues/3550
* Unit tests
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Fix open url in repo view (#3581)
* Fix open url in repo view
* Move call_browser to gui_router
* CSS and logo fixes (#3578)
* css cleanups
* orange logo
* Revert "orange logo"
This reverts commit b9aa45bbd0.
* update font
* css improvements
* remove logo png
* re-layout page title and footer
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Html form improvements and docs (#3582)
* auto id
* fix html validation (form in ul)
* form groups
* move colors to theme
* docs for html form component
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Generate news instance (#3585)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Update @abaplint/cli requirement from ^2.37.2 to ^2.37.5 (#3588)
* Update eslint requirement from ^7.3.1 to ^7.4.0 (#3589)
* Improve message when no branches selectable
* Update .gitlab-ci.yml
* Fix linter issues
* Fix rebase mess up
* Enhanced Error message
* Delete .gitlab-ci.yml
Co-authored-by: Ed Wenmakers <ed.wenmakers@redwood.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Rakshith Gore <58498218+goreraks@users.noreply.github.com>
Co-authored-by: Lukáš Novák <lthenovi@gmail.com>
Co-authored-by: Alexander Tsybulsky <sbcgua@users.noreply.github.com>
Co-authored-by: Jaime Rodriguez Capote <jrodriguez@resultoconsultoria.com>
* Fix issue 3597 (#2 try)
When abapGit is being executed on SAP GUI for HTML, all the links don't work (don't do anything because SAPEVENT isn't being passed back to the application server).
* Fix build errors of previous commit
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Use icons, add back menu to repo show page
* Event handling
* Abaplint
* Add menu to tutorial page
* Lint
* More icons
* Update tutorial, reorganize button code
* Move icon css
* Fix error
* Fix menu
* auto id
* fix html validation (form in ul)
* form groups
* move colors to theme
* docs for html form component
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* css cleanups
* orange logo
* Revert "orange logo"
This reverts commit b9aa45bbd0.
* update font
* css improvements
* remove logo png
* re-layout page title and footer
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Add logo for dark theme
* Dark theme fixes
* Dark theme fixes
* Solve conflict
* Remove logo changes
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
Main and repo are no longer one page, so the `re_render` action does not make sense anymore. `new_page_replacing` is used instead of `new_page` so you cannot navigate back to the removed repo.
* Add main menu, toggle favorites
* Make abapgit logo go to overview
* Remove favorite repo links
* Fix remember filter
* Separator between filters
* Remove unused code
* Repo overview to main page
* Fix errors
* Fix naming
* Downport js
* Add separator
* remove unrelated changes
* Fix spacing
* Add package link
* Fix orderby dumping
* Only show tutorial with no favorites
Still have to do something about empty table
* Move abapgit installation info to debug info
* Improve tutorial, resolves#3497
* Add branch switch link
* Reduce line length
* Revert temporary hack
* Working version of removing logo
* No longer show tutorial in repositories
* Code cleanup
* More cleanup, rename tutorial to page
* Fix
* Force order by favorite
* Add checkmark icons
* View repo to page, rework menu
* Fix build
* Return logo
* Fix hotkeys on repo page, rename to page
* Fix show last repo, cleanup
* Abaplint
* Rollback js reformat
* Fix tutorial title, hotkeys
* Try resolve strange situation with PR
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* New method to get repo from package
If package already exists in a repo and it returns the repo and reason why the package can't be used in a new repo
* UI: If package exists in repo, nav to repo
+Online, +Offline - if repo is already versioned, navigate to repo and show message why package could not be used in new repo
Closes https://github.com/larshp/abapGit/issues/3452
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
* Minor improvement for icons in repo view
* Add Icon Legend in "Debug Info"
A place to see available icons (will copy it to documentation).
* Pretty print
* Reverse icons in debug info
Icons are now in docs. No need for this here
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Fix incorrect status of ignored filed in repo view
After update of repo settings, some ignored files showed as "-/A".
https://github.com/larshp/abapGit/pull/3415
* Whitespace
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Old logic was failing if transaction ZABAPGIT already existed - typically because it was created manually for the merged version. Testing for program ZABAPGIT would not be any better since that might have been used for the merged version as well. It's more reliable to check a class.
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Add syntax-highlighters for CSS, JS, JSON
* Update W3MI ZABAPGIT_CSS_THEME_DEFAULT
* Fix line size and case statement
* Fix line size
* Update styles, removed operators
* Added highlight for comments in HTML/XML
* Fix menu hover background
This makes the selected menu more visible.
Also includes color fix for repo name and url in dark theme.
* Fix for W3xx objects with "." in name
* Reverse fix for W3xx
* Remove hover style changes
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* refactor mi_gui_services to getter
* zif_html->set_title (for debug of postponed parts)
* add set_title to all postponed parts
* gui optional rollback on error
* forgotten gui_services call
* docs
* remove gui_page redirect #3404
* forgotten html~set_title in hotkey class
also renamed render_js_part into render_scripts for unification and reuse register_deferred_script - this is why I lost it int the first place
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Update zcl_abapgit_gui_page_stage.clas.abap
* Change to exception
* add reference to issue as comment in code
* Update zcl_abapgit_gui_page_stage.clas.abap
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Set filter for file open and save dialogs
Set the file filter dropdown and default to *.ZIP in file open and save dialogs
* Add new setting for default commit comment
New abapGit setting to define a default for the comment used for commits. Object and/or filename can added to the comment automatically, which works similar to GitHub if a single file is changed. If multiple objects are changed, then object/file count is included in the default for the comment.
* Update CLAS ZCL_ABAPGIT_GUI_PAGE_COMMIT
* Fix text for $object
Fixed case when one object with multiple files was changed
* Pretty print
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* zcl_abapgit_html_parts primitive
* integrate parts in GUI
* bughunting and renames
* scripts collection, move hotkeys js to parts
* linter fixes
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Create pull.yml
* Update zcl_abapgit_git_transport.clas.abap
* Update zcl_abapgit_git_transport.clas.abap
* Update pull.yml
* Update pull.yml
* Delete pull.yml
* Refactored popup logic
Related to #3040
Refactoring of popup logic/calling to be able to reuse it as commit list.
* Removed reset flag
Removed reset flag cause it doesn't belong to this PR (will be readded later)
Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Introduce zcl_abapgit_gui_page_patch as subclass of zcl_abapgit_gui_page_diff
introduce pop-method on GUI stack
fix linter + raising exception when gui stack emp
introduce zcl_abapgit_gui_page_patch
more
add
fix linter
remove go back to patch after commit
fix linter
remove bookmark for stage page
remove pop
src/ui/core/zcl_abapgit_gui.clas.abap
src/zcl_abapgit_repo_online.clas.abap
* refactor: move more logic to render_line_split_ro
* refactor move logic to render_diff_head_after_stat
* add logic to render_table_head_non_unified
* extract render_table_head_unified
* extract of is_patch_possible calculation
* fix linter
* move hotkey to patch
* refactor and rename to get_normalized_fname_with_p
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Patch: Refresh object first working version
* Patch: add refresh local and refresh repo + refact
* add missing stuff
* fix lint
* refactoring and cleanup
* add missing stuff
* refactor
* refactor
* refactor
* add title for menu bar
* Save and restore scroll position
* refactoring and cleanup
* refactor
* cleanup
* cleanup
* cleanup
* remove new hotkey
* disable object refresh for non-object files
* remove restore scrollposition
* cleanup
* refactor
* cleanup
* save scroll position
* Fix: refresh of deleted objects
* Fix dump: refresh new objects
* add hotkey support for refresh all local objects
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* Resize stage list to full width
* Move patch button to the top menu
* Center stage list, increase line width in repo, stage
* Repo page - Increase line height for path column
* Stage list to full size
Co-authored-by: Lars Hvam <larshp@hotmail.com>
* add proxy bypass option in settings
* add proxy bypass popup and persist settings
* add proxy bypass to proxy config class
* Fix Proxy Bypass Button HTML
* Fix indentation
* Implement Method popup_proxy_bypass
* Fix behaviour in case of empty range tab
* Fix behaviour in case of empty range tab 2
