Commit Graph

2768 Commits

Author SHA1 Message Date
Marc Bernard
67928912c6
SHMA: Return last changed by (#3693) 2020-08-01 12:06:29 +02:00
Lars Hvam
9180d0986d
FUGR table maintenance, solve diffs (#3659)
* update SQLX

* helpful error message for EU522

* add comment

* and UCCHECK
2020-07-31 06:38:31 +02:00
germanysources
1efb62feda
Testing class zcl_abapgit_objects_files (#3678)
* Support all kinds of line-breaks

* Unit-Tests for class zcl_abapgit_objects_files

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-31 06:29:22 +02:00
Frederik Hudák
b93b76a0f7
Fix master language serialization - DSYS (#3687)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-31 06:27:28 +02:00
Frederik Hudák
68ec17a5dd
Fix dump when pulling dsys (#3686)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-31 06:24:52 +02:00
Lars Hvam
837d45bc83
fix whitespace (#3690) 2020-07-31 06:22:01 +02:00
Frederik Hudák
a1ecc65ecc
Improved branching messages (#3685)
* Improvements to branch messages

* Names without refs/heads
2020-07-31 06:15:56 +02:00
Lars Hvam
6d9320505c
Codespaces setup (#3666)
* default ignore devcontainer.json

* abapgit, ignore devcontainer.json

* add devcontainer.json

* rename

* fix byte order mark
2020-07-28 09:20:02 +02:00
Domi Bigl
395116e481
add TABL authorization group handling (#3621)
* add TABL authorization group handling 

fixes #1328
test repo https://github.com/abapGit-tests/TABL-AuthorizationGroup.git
Authorization Group (TDDAT) is handled with TABL and TOBJ now

* fix linter errors

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-25 17:36:14 +02:00
Alexander Tsybulsky
525634e42b
page hoc concept (#3626)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-23 15:10:40 +02:00
Michael Käsemann
04e71feabe
Improved staging robustness (#3625)
* Improved staging robustness

- Skipped any objects in the changelist that are not marked for staging prior to processing them , to avoid that they keep other objects without errors from being staged if the user wants to stage parts of the changes

* Reduced line length

* Removed missed whitespace

* Update abaplint.json

* Update abaplint.json

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-23 14:59:22 +02:00
Lars Hvam
b78dab85db
1.98.0 (#3657)
* 1.98.0

* v1.98.0

* Update changelog.txt
2020-07-21 08:11:39 +02:00
Frederik Hudák
144e53608d
Add action column to repo overview (#3645)
* Add stage, patch buttons to repo overview

* Fix abaplint

* Add syntax check, code inspector

* Add pull

* constant naming

* Last changes

* lint

* lint

* Update abaplint.json

* Update abaplint.json

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-21 07:24:38 +02:00
ed-holland
ae30875b21
ENHS: Enhance exceptions (#3651)
* Enhanced Exception Message

* Fix Linter

* Implemented example

Co-authored-by: Ed Wenmakers <ed.wenmakers@redwood.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-21 06:40:01 +02:00
Lars Hvam
1006105a09
bridge, no need to lookup in view (#3653)
lookup in the transparent table, note it has an index
2020-07-19 20:59:12 +02:00
ed-holland
2871914578
Ensure no duplicates of functions are found (#3652)
* Ensure no duplicates of functions are found

* remove modify

Co-authored-by: Ed Wenmakers <ed.wenmakers@redwood.com>
2020-07-19 07:05:17 +02:00
Marc Bernard
67cd9d12ab
TOBJ: Clear package (#3632)
Closes https://github.com/larshp/abapGit/issues/3627

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-18 07:48:58 +02:00
Marc Bernard
c3e09f78d9
PARA: Dequeue parameter after deletion (#3644)
Closes https://github.com/larshp/abapGit/issues/3643

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-17 10:21:02 +02:00
Marc Bernard
178e23e639
Uninstall: Resolve DDIC dependencies of VIEW (#3630)
Fix uninstall if table/structure references a view (ex https://github.com/abapGit-tests/TABL_include_VIEW)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-17 07:10:12 +02:00
Marc Bernard
888d49f702
IOBJ: Remove number range objects and return error during delete (#3631)
* IOBJ: Remove number range objects

Number ranges for BW objects are local to a system and will cause errors when duplicates occur.

* Fix spelling

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-17 07:07:25 +02:00
Michael Käsemann
72ccc986c7
Faulty handling of post data (#3624)
* Fixed faulty translation of post data to parsable string

- Added method TRANSLATE_POSTDATA to ZCL_ABAPGIT_UTILS as a centralized place to translate post data to a string
- Replaced all post data string concatenations with the translation helper method to correctly parse spaces that fall to the end of a table line (this should solve #3073 as well as any other random crash caused by accidental misalignment of the post data)

* Backport ABAP statement to 7.02

* Code cleanup for linter checks

* Code cleanup for linter checks

* Fixed a possible error in parsing

If it_postdata contains an empty last line, the staging fails, because the string may contain a lot of soaces at the end of the previous to last line.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-16 15:51:36 +02:00
Marc Bernard
3183f95bb6
SUSO: Improve error message when deleting auth.object (#3642)
Reference to transaction SU21, which can be used to find out where auth.object is still used.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-16 10:33:21 +02:00
Marc Bernard
6cd192e86f
Improved HTTP error messages (#3638)
Just a bit more user-friendly texts

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-16 10:29:53 +02:00
Marc Bernard
3a48d01201
Remove repo from favorites at delete/purge (#3641)
Closes https://github.com/larshp/abapGit/issues/3640
2020-07-16 08:38:32 +02:00
Alexander Tsybulsky
07e1f787c6
gui_page cleanups (#3615)
* move test_changed_by from gui_page to services

* kind of linter fix

* move more action to router

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-13 17:42:40 +02:00
Alexander Tsybulsky
144cb8822c
improve missing branch styling (#3619)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-13 11:34:39 +02:00
Lars Hvam
0feae7c1b2
ZCL_ABAPGIT_FRONTEND_SERVICES private (#3617)
private instantiation
2020-07-13 11:17:21 +02:00
Lars Hvam
f579dfb7a0
allow dependency injection from anywhere (#3614) 2020-07-12 13:06:38 +02:00
Alexander Tsybulsky
d18d4c798e
Fix #3609 (clone uppercase pkg name) (#3613) 2020-07-12 08:56:44 +02:00
Lars Hvam
5139ef8507
move longtexts under interface (#3607)
* move longtexts under interface

adds interface for the longtext class

* fix

* longtexts, remove the constructor

* add injector method for longtexts
2020-07-12 08:39:53 +02:00
Lars Hvam
cd9ea97a63
HTML: move add_icon to interface (#3608)
* HTML: move add_icon to interface

* ZCL_ABAPGIT_HTML_TOOLBAR use interface

* ZCL_ABAPGIT_GUI_REPO_OVER use interface

* ZCL_ABAPGIT_GUI_PAGE_VIEW_REPO  use intf
2020-07-12 08:37:15 +02:00
Lars Hvam
8bd932f944
FUGR, FAE fix (#3611)
* FUGR, FAE fix

* FUGR, cache includes in instance

* remove CNAM field
2020-07-12 08:29:24 +02:00
Marc Bernard
773fbe6ba5
Special characters in object/file names (#3564)
* Fix for objects with space or dot in name

* Update zcl_abapgit_file_status.clas.abap

* Fix for objects with space or dot in name

* Escaping of filenames

* Escape %

* Remove escape of space

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-11 16:06:11 +02:00
ed-holland
df48acc015
Clearer error message for no branch (#3605)
* CI Update

* Raise exception when no .abapgit.xml is found (#3512)

Update

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Updated documentation for repo settings & icons (#3499)

* Completed to-dos

- Updated abapgit.xml example
- Completed missing docu for local settings

* screenshots

* screenshots

* Delete repo_settings_local.png

* screenshots

* Delete repo_settings_local.png

* screenshots

* screenshots

* Combine write-protect setting

* Merged to repo settings

* screenshots

* screenshots

* merged to repo settings

* merged to repo settings

* Adding details

* Added links

* links

* icons

* icons

* icons

* icons

* icons

* icons

* icons

* Update ref-icons.md

* icons

* icons

* Update docs/ref-dot-abapgit.md

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Fix icon display in docs (#3517)

Icons showed on github.com but not on docs.abapgit.org

* +On/offline: If package already in other repo, nav to repo (#3525)

* New method to get repo from package

If package already exists in a repo and it returns the repo and reason why the package can't be used in a new repo

* UI: If package exists in repo, nav to repo

+Online, +Offline - if repo is already versioned, navigate to repo and show message why package could not be used in new repo

Closes https://github.com/larshp/abapGit/issues/3452

Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>

* Update eslint requirement from ^7.2.0 to ^7.3.0 (#3534)

* Update @abaplint/cli requirement from ^2.36.6 to ^2.36.9 (#3535)

* Fix syntax errors in 702 (#3548)

Caused by https://github.com/larshp/abapGit/pull/3525

* SCP1 Import Order (#3543)

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Update .gitlab-ci.yml

* Update eslint requirement from ^7.3.0 to ^7.3.1 (#3556)

* Update @abaplint/cli requirement from ^2.36.9 to ^2.37.2 (#3557)

* Repo overview as main page (#3498)

* Add main menu, toggle favorites

* Make abapgit logo go to overview

* Remove favorite repo links

* Fix remember filter

* Separator between filters

* Remove unused code

* Repo overview to main page

* Fix errors

* Fix naming

* Downport js

* Add separator

* remove unrelated changes

* Fix spacing

* Add package link

* Fix orderby dumping

* Only show tutorial with no favorites

Still have to do something about empty table

* Move abapgit installation info to debug info

* Improve tutorial, resolves #3497

* Add branch switch link

* Reduce line length

* Revert temporary hack

* Working version of removing logo

* No longer show tutorial in repositories

* Code cleanup

* More cleanup, rename tutorial to page

* Fix

* Force order by favorite

* Add checkmark icons

* View repo to page, rework menu

* Fix build

* Return logo

* Fix hotkeys on repo page, rename to page

* Fix show last repo, cleanup

* Abaplint

* Rollback js reformat

* Fix tutorial title, hotkeys

* Try resolve strange situation with PR

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Remove unused method (#3554)

* Remove unused method

* whitespace

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* 1.97.0 (#3561)

* 1.97.0

whitespace

* 1.97.0

* v1.97.0

* fix for apply_order_by (#3566)

* Update zcl_abapgit_repo.clas.abap (#3570)

* Dialogs: add online repo HTML form (#3533)

* first draft

* progress ...

* html->create()

* more progress

* and more

* getting closer

* wiring

* refactor popup_search_help

* refactor create_package to services

* fix services->new_online after rebase

* linter fixes

* more linter fixes

* straing map util

* error handling

* submits for side actions (ugly ... but ...)

* cleanups

* linter fixes

* refactor form values logic

* linter fix

* review fixes

* remove unused var after rebase

* review fixes, better side action layout

* linter fix

* minor css tweaks

* Fix user settings containing invalid repo key (#3569)

* Update zcl_abapgit_persistence_user.clas.abap

* Fix dump when last repo is invalid

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* UI: Fixes for dark theme (#3540)

* Add logo for dark theme

* Dark theme fixes

* Dark theme fixes

* Solve conflict

* Remove logo changes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>

* Missing objects in overwrite confirmation popup (#3558)

* Missing objects in overwrite confirmation popup

Closes https://github.com/larshp/abapGit/issues/3550

* Unit tests

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Fix open url in repo view (#3581)

* Fix open url in repo view

* Move call_browser to gui_router

* CSS and logo fixes (#3578)

* css cleanups

* orange logo

* Revert "orange logo"

This reverts commit b9aa45bbd0.

* update font

* css improvements

* remove logo png

* re-layout page title and footer

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Html form improvements and docs (#3582)

* auto id

* fix html validation (form in ul)

* form groups

* move colors to theme

* docs for html form component

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Generate news instance (#3585)

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Update @abaplint/cli requirement from ^2.37.2 to ^2.37.5 (#3588)

* Update eslint requirement from ^7.3.1 to ^7.4.0 (#3589)

* Update .gitlab-ci.yml

* fix repo palette (#3580)

* fix repo palette

* fix page_view_repo after rebase

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Adjust new logo color for dark theme (#3592)

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Add deleted objects to overwrite confirm popup (#3591)

* Add deleted objects to overwrite confirm popup

Closes https://github.com/larshp/abapGit/issues/2845

* Pretty print

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Top menu improvements (#3590)

* Use icons, add back menu to repo show page

* Event handling

* Abaplint

* Add menu to tutorial page

* Lint

* More icons

* Update tutorial, reorganize button code

* Move icon css

* Fix error

* Fix menu

* Update .gitlab-ci.yml

* Fix rebase issue

* Fix rebase mess up

* Raise exception when no .abapgit.xml is found (#3512)

Update

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Updated documentation for repo settings & icons (#3499)

* Completed to-dos

- Updated abapgit.xml example
- Completed missing docu for local settings

* screenshots

* screenshots

* Delete repo_settings_local.png

* screenshots

* Delete repo_settings_local.png

* screenshots

* screenshots

* Combine write-protect setting

* Merged to repo settings

* screenshots

* screenshots

* merged to repo settings

* merged to repo settings

* Adding details

* Added links

* links

* icons

* icons

* icons

* icons

* icons

* icons

* icons

* Update ref-icons.md

* icons

* icons

* Update docs/ref-dot-abapgit.md

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Fix icon display in docs (#3517)

Icons showed on github.com but not on docs.abapgit.org

* +On/offline: If package already in other repo, nav to repo (#3525)

* New method to get repo from package

If package already exists in a repo and it returns the repo and reason why the package can't be used in a new repo

* UI: If package exists in repo, nav to repo

+Online, +Offline - if repo is already versioned, navigate to repo and show message why package could not be used in new repo

Closes https://github.com/larshp/abapGit/issues/3452

Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>

* Update eslint requirement from ^7.2.0 to ^7.3.0 (#3534)

* Update @abaplint/cli requirement from ^2.36.6 to ^2.36.9 (#3535)

* Fix syntax errors in 702 (#3548)

Caused by https://github.com/larshp/abapGit/pull/3525

* SCP1 Import Order (#3543)

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Update .gitlab-ci.yml

* Update eslint requirement from ^7.3.0 to ^7.3.1 (#3556)

* Update @abaplint/cli requirement from ^2.36.9 to ^2.37.2 (#3557)

* Repo overview as main page (#3498)

* Add main menu, toggle favorites

* Make abapgit logo go to overview

* Remove favorite repo links

* Fix remember filter

* Separator between filters

* Remove unused code

* Repo overview to main page

* Fix errors

* Fix naming

* Downport js

* Add separator

* remove unrelated changes

* Fix spacing

* Add package link

* Fix orderby dumping

* Only show tutorial with no favorites

Still have to do something about empty table

* Move abapgit installation info to debug info

* Improve tutorial, resolves #3497

* Add branch switch link

* Reduce line length

* Revert temporary hack

* Working version of removing logo

* No longer show tutorial in repositories

* Code cleanup

* More cleanup, rename tutorial to page

* Fix

* Force order by favorite

* Add checkmark icons

* View repo to page, rework menu

* Fix build

* Return logo

* Fix hotkeys on repo page, rename to page

* Fix show last repo, cleanup

* Abaplint

* Rollback js reformat

* Fix tutorial title, hotkeys

* Try resolve strange situation with PR

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Remove unused method (#3554)

* Remove unused method

* whitespace

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* 1.97.0 (#3561)

* 1.97.0

whitespace

* 1.97.0

* v1.97.0

* fix for apply_order_by (#3566)

* Update zcl_abapgit_repo.clas.abap (#3570)

* Dialogs: add online repo HTML form (#3533)

* first draft

* progress ...

* html->create()

* more progress

* and more

* getting closer

* wiring

* refactor popup_search_help

* refactor create_package to services

* fix services->new_online after rebase

* linter fixes

* more linter fixes

* straing map util

* error handling

* submits for side actions (ugly ... but ...)

* cleanups

* linter fixes

* refactor form values logic

* linter fix

* review fixes

* remove unused var after rebase

* review fixes, better side action layout

* linter fix

* minor css tweaks

* Fix user settings containing invalid repo key (#3569)

* Update zcl_abapgit_persistence_user.clas.abap

* Fix dump when last repo is invalid

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* UI: Fixes for dark theme (#3540)

* Add logo for dark theme

* Dark theme fixes

* Dark theme fixes

* Solve conflict

* Remove logo changes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>

* Missing objects in overwrite confirmation popup (#3558)

* Missing objects in overwrite confirmation popup

Closes https://github.com/larshp/abapGit/issues/3550

* Unit tests

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Fix open url in repo view (#3581)

* Fix open url in repo view

* Move call_browser to gui_router

* CSS and logo fixes (#3578)

* css cleanups

* orange logo

* Revert "orange logo"

This reverts commit b9aa45bbd0.

* update font

* css improvements

* remove logo png

* re-layout page title and footer

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Html form improvements and docs (#3582)

* auto id

* fix html validation (form in ul)

* form groups

* move colors to theme

* docs for html form component

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Generate news instance (#3585)

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Update @abaplint/cli requirement from ^2.37.2 to ^2.37.5 (#3588)

* Update eslint requirement from ^7.3.1 to ^7.4.0 (#3589)

* Improve message when no branches selectable

* Update .gitlab-ci.yml

* Fix linter issues

* Fix rebase mess up

* Enhanced Error message

* Delete .gitlab-ci.yml

Co-authored-by: Ed Wenmakers <ed.wenmakers@redwood.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Rakshith Gore <58498218+goreraks@users.noreply.github.com>
Co-authored-by: Lukáš Novák <lthenovi@gmail.com>
Co-authored-by: Alexander Tsybulsky <sbcgua@users.noreply.github.com>
Co-authored-by: Jaime Rodriguez Capote <jrodriguez@resultoconsultoria.com>
2020-07-11 12:38:55 +02:00
Shai
15f55276e1
Fix issue 3597 (#2 try) (#3601)
* Fix issue 3597 (#2 try)

When abapGit is being executed on SAP GUI for HTML, all the links don't work (don't do anything because SAPEVENT isn't being passed back to the application server).

* Fix build errors of previous commit

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-11 08:28:41 +02:00
Frederik Hudák
d49d0656b0
Top menu improvements (#3590)
* Use icons, add back menu to repo show page

* Event handling

* Abaplint

* Add menu to tutorial page

* Lint

* More icons

* Update tutorial, reorganize button code

* Move icon css

* Fix error

* Fix menu
2020-07-09 09:12:58 +02:00
Marc Bernard
4f0a5480a1
Improved error message when uninstalling DDIC objects (#3562)
* Update zcl_abapgit_object_doma.clas.abap

* Uninstall DDIC

* DDIC uninstall

* Pretty print

* DOMA delete append

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-07 15:36:13 +02:00
Marc Bernard
e0c93b0d7c
Add deleted objects to overwrite confirm popup (#3591)
* Add deleted objects to overwrite confirm popup

Closes https://github.com/larshp/abapGit/issues/2845

* Pretty print

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-07 15:31:21 +02:00
Marc Bernard
a980d9812d
Adjust new logo color for dark theme (#3592)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-07 15:21:34 +02:00
Alexander Tsybulsky
2699e2d513
fix repo palette (#3580)
* fix repo palette

* fix page_view_repo after rebase

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-07 14:59:31 +02:00
Alexander Tsybulsky
f80b537c7c
defaul theme fix (grey headings) (#3587)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-06 08:12:47 +02:00
Jaime Rodriguez Capote
fd32cbd951
Generate news instance (#3585)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-05 18:08:51 +02:00
Alexander Tsybulsky
6fe168640c
Html form improvements and docs (#3582)
* auto id

* fix html validation (form in ul)

* form groups

* move colors to theme

* docs for html form component

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-05 17:57:45 +02:00
Domi Bigl
91980ed8ae
add variant transaction support and fix FG global variables (#3575)
* add variant transaction support and fix FG globals

add handling of variant transaction
clear globals in FG for FM RPY_TRANSACTION_INSERT

fixes #2744

* CC cleanup

* fix linter errors

* fix linter errors

* fix linter error - type pool constants

* fix linter error void type

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-05 17:47:20 +02:00
Alexander Tsybulsky
cae3aae5e2
CSS and logo fixes (#3578)
* css cleanups

* orange logo

* Revert "orange logo"

This reverts commit b9aa45bbd0.

* update font

* css improvements

* remove logo png

* re-layout page title and footer

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-04 12:47:14 +02:00
Jaime Rodriguez Capote
f8d74cc928
Fix open url in repo view (#3581)
* Fix open url in repo view

* Move call_browser to gui_router
2020-07-04 12:35:38 +02:00
Marc Bernard
9d29fe57ce
Missing objects in overwrite confirmation popup (#3558)
* Missing objects in overwrite confirmation popup

Closes https://github.com/larshp/abapGit/issues/3550

* Unit tests

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-04 09:31:21 +02:00
Marc Bernard
493bb969b2
UI: Fixes for dark theme (#3540)
* Add logo for dark theme

* Dark theme fixes

* Dark theme fixes

* Solve conflict

* Remove logo changes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-07-02 09:15:31 +02:00
Marc Bernard
7ce457dc8d
Fix user settings containing invalid repo key (#3569)
* Update zcl_abapgit_persistence_user.clas.abap

* Fix dump when last repo is invalid

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-01 15:24:33 +02:00
Frederik Hudák
961afa37f8
Fix error after removing/uninstalling repo (#3572)
Main and repo are no longer one page, so the `re_render` action does not make sense anymore. `new_page_replacing` is used instead of `new_page` so you cannot navigate back to the removed repo.
2020-07-01 15:10:39 +02:00
Alexander Tsybulsky
f5dfd328f5
Dialogs: add online repo HTML form (#3533)
* first draft

* progress ...

* html->create()

* more progress

* and more

* getting closer

* wiring

* refactor popup_search_help

* refactor create_package to services

* fix services->new_online after rebase

* linter fixes

* more linter fixes

* straing map util

* error handling

* submits for side actions (ugly ... but ...)

* cleanups

* linter fixes

* refactor form values logic

* linter fix

* review fixes

* remove unused var after rebase

* review fixes, better side action layout

* linter fix

* minor css tweaks
2020-07-01 08:16:52 +02:00
Marc Bernard
8e031e0498
Update zcl_abapgit_repo.clas.abap (#3570) 2020-06-30 17:28:01 +02:00
Lukáš Novák
d621551146
fix for apply_order_by (#3566) 2020-06-30 10:11:27 +02:00
Lars Hvam
051c9c6569
1.97.0 (#3561)
* 1.97.0

whitespace

* 1.97.0

* v1.97.0
2020-06-29 16:52:15 +02:00
Frederik Hudák
e4fd14ee73
Remove unused method (#3554)
* Remove unused method

* whitespace

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-29 16:40:01 +02:00
Frederik Hudák
32cf59ca1e
Repo overview as main page (#3498)
* Add main menu, toggle favorites

* Make abapgit logo go to overview

* Remove favorite repo links

* Fix remember filter

* Separator between filters

* Remove unused code

* Repo overview to main page

* Fix errors

* Fix naming

* Downport js

* Add separator

* remove unrelated changes

* Fix spacing

* Add package link

* Fix orderby dumping

* Only show tutorial with no favorites

Still have to do something about empty table

* Move abapgit installation info to debug info

* Improve tutorial, resolves #3497

* Add branch switch link

* Reduce line length

* Revert temporary hack

* Working version of removing logo

* No longer show tutorial in repositories

* Code cleanup

* More cleanup, rename tutorial to page

* Fix

* Force order by favorite

* Add checkmark icons

* View repo to page, rework menu

* Fix build

* Return logo

* Fix hotkeys on repo page, rename to page

* Fix show last repo, cleanup

* Abaplint

* Rollback js reformat

* Fix tutorial title, hotkeys

* Try resolve strange situation with PR

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-29 16:34:59 +02:00
Rakshith Gore
f132e99722
SCP1 Import Order (#3543)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-28 10:53:49 +02:00
Marc Bernard
5f7c7dc2bc
DDIC with reference to class/interface, Search Help with Exit Function (#3545)
* Update zcl_abapgit_objects.clas.abap

* DDIC with reference to class/interface

* DDIC with reference to class/interface

* Search help with exit function

* Table with reference to search help

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-28 10:47:39 +02:00
Marc Bernard
70c96e701d
Fix syntax warnings (#3549)
* Update zcl_abapgit_object_ueno.clas.abap

* Fix syntax warning

* Fix syntax warning

* Fix syntax warning

* Fix syntax warning

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-27 16:30:16 +02:00
Marc Bernard
dc95fb3efd
Fix syntax errors in 702 (#3548)
Caused by https://github.com/larshp/abapGit/pull/3525
2020-06-27 16:25:23 +02:00
Lars Hvam
3ab83632d8
clear ICFSERVICE-ICFBITMAP (#3542) 2020-06-25 06:39:31 +02:00
Marc Bernard
178fc9cc91
Unit test for "Changed package assignment" (#3539)
https://github.com/larshp/abapGit/pull/3529
2020-06-23 13:38:05 +02:00
Marc Bernard
01dce88475
Interface and implementing class in same package (#3528)
* Interface and implementing class in same package

* Interface and implementing class in same package

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-21 10:23:43 +02:00
Marc Bernard
a55011894e
Condense messages in case of package move (#3529)
* Update zif_abapgit_definitions.intf.abap

* Condense messages in case of package move

* Improve msg alignment

Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-21 10:09:58 +02:00
Andre Becker
507cb9c9db
Add interface for better testing to zcl_abapgit_xml_input/output (#3514)
* introduce interfaces for classes zcl_abapgit_xml_input/output

* refactor classes to use interfaces

* fix indentation of xml files

* fix exception class

* Removed default for commit comment (#3513)

* Removed default for commit comment

Closes https://github.com/larshp/abapGit/issues/3511

* Removed default for commit comment

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Fix incorrect status of ignored files in repo view (#3506)

* Fix incorrect status of ignored filed in repo view

After update of repo settings, some ignored files showed as "-/A". 
https://github.com/larshp/abapGit/pull/3415

* Whitespace

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Minor improvements of icons in repo view (#3493)

* Minor improvement for icons in repo view

* Add Icon Legend in "Debug Info"

A place to see available icons (will copy it to documentation).

* Pretty print

* Reverse icons in debug info

Icons are now in docs. No need for this here

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* z'ify

* zif'y

* remove to much zif'iation

* whitespace

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-21 09:57:42 +02:00
Marc Bernard
09120cb80d
+On/offline: If package already in other repo, nav to repo (#3525)
* New method to get repo from package

If package already exists in a repo and it returns the repo and reason why the package can't be used in a new repo

* UI: If package exists in repo, nav to repo

+Online, +Offline - if repo is already versioned, navigate to repo and show message why package could not be used in new repo

Closes https://github.com/larshp/abapGit/issues/3452

Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-06-20 14:32:00 +02:00
Lars Hvam
3a013c497a
record W3MI to transport (#3522) 2020-06-20 07:52:28 +02:00
Jaime Rodriguez Capote
a0087d3490
Changelog news (#3479)
* APACK definition

* Rework News

Use APACK version for news and remove restriction for repository to set available for all with APACK

* Remove APACK for abapGit

* TODO mark for version constant use

* Move is_abapgit_repo to zcl_abapgit_url

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-19 08:47:21 +02:00
Marc Bernard
d74284bd8b
Minor improvements of icons in repo view (#3493)
* Minor improvement for icons in repo view

* Add Icon Legend in "Debug Info"

A place to see available icons (will copy it to documentation).

* Pretty print

* Reverse icons in debug info

Icons are now in docs. No need for this here

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-16 16:54:01 +02:00
Marc Bernard
ed09b51855
Fix incorrect status of ignored files in repo view (#3506)
* Fix incorrect status of ignored filed in repo view

After update of repo settings, some ignored files showed as "-/A". 
https://github.com/larshp/abapGit/pull/3415

* Whitespace

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-16 16:00:30 +02:00
Marc Bernard
d006cd0658
Removed default for commit comment (#3513)
* Removed default for commit comment

Closes https://github.com/larshp/abapGit/issues/3511

* Removed default for commit comment

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-16 15:57:04 +02:00
Christian Günter
50cff91259
Raise exception when no .abapgit.xml is found (#3512)
Update

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-16 13:10:03 +02:00
Lars Hvam
024167ce97
replace SYREPID (#3501)
* Update abaplint.json

* replace SYREPID
2020-06-16 07:34:12 +02:00
Christian Günter
58fb961a19
Fix: remove URL validation for offline repos (#3508) 2020-06-15 12:53:40 +02:00
Marc Bernard
38099501b8
Improved validation of URLs (#3486)
* Limit URLs to http and https

* Validate URLs

* Raise error only for validation (not for get_name)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-14 20:14:39 +02:00
Marc Bernard
941407b194
Avoid parsing empty lines in syntax highlighter (#3483)
* Performance 

Avoid parsing empty lines

* Avoid parsing empty lines in syntax highlighter

* Empty or whitespace

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-13 09:47:25 +02:00
Lars Hvam
420e6f5964
replace HTML with interface (#3490)
* replace HTML with interface

part of #3460

* pretty print
2020-06-13 09:39:46 +02:00
Lars Hvam
eb1ce57d03
sort WDYN UI elements (#3489)
closes #3450
2020-06-13 09:36:20 +02:00
Lars Hvam
9720b4cd6d
replace ddic MANDT with SY-MANDT (#3492) 2020-06-13 09:29:42 +02:00
Lars Hvam
01823a97a9
dsys downport (#3495) 2020-06-12 20:57:31 +02:00
Jens Maier
ac701157f0
DSYS serializer overhaul (#3445)
* DSYS serializer rewritten

* Fixes issue #3374 when object names include a namespace.
* Uses longtexts facility to serialize texts:
   * Supports i18n texts.
   * Supports text versions other than 0001.

* Fix linter compliance

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-12 18:05:52 +02:00
Marc Bernard
91f25304ce
Fix message helper (#3482)
* Fix message helper

Split text didn't work if message has space at offset 51

* Add unit tests
2020-06-12 07:11:57 +02:00
Marc Bernard
f5754056f2
Enhanced object list for "Debug Info" (#3480)
Move browser info up
2020-06-10 15:11:47 +02:00
Lars Hvam
83098a35a9
1.96.0 (#3477)
* 1.96.0

* 1.96.0
2020-06-10 06:25:13 +02:00
Jens Maier
f5bd8081ea
Remove fallback TADIR lookup (#3449)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-10 06:14:03 +02:00
Marc Bernard
19503b8116
Enhanced object list for "Debug Info" (#3475)
* Enhanced object list for "Debug Info"

* Shorter line

* Whitespace
2020-06-09 06:11:53 +02:00
FunMustBe
b45a51eedf
Update CLAS ZCL_ABAPGIT_OBJECT_PINF (#3455)
Fixes the dump and import error for package interfaces. Even if the package interface is in a different package than the referencedpackage itself.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-08 06:10:54 +02:00
Rakshith Gore
14b9c7d864
Deserialize postprocess (#3461)
* Update 3 objects

* Update zcl_abapgit_exit.clas.abap

Pretty printer didnt work in JAVA GUI, so had to manually change the file

* IS_STEP as input parameter

* Issue in JAVA based GUI

Pretty printer not working for class name in implementation

* Move TY_STEP_DATA to ZIF_ABAPGIT_DEFINITIONS

* try moving ty_deserialization_step

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-08 06:05:49 +02:00
Lars Hvam
9af61c99c6
fully type sydatum and syuzeit (#3457) 2020-06-07 09:01:08 +02:00
g-back
da9fcd673f
downport loop statement (#3456)
* downport loop statement

* whitespace fix
2020-06-05 15:45:41 +02:00
Lars Hvam
d36b43defe
line break parameters (#3444)
* line break parameters

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* fix
2020-06-04 15:10:35 +02:00
KDS42
f8f6241890
Issue 3324: WDA Texts are not taken into account (#3352)
* Issue 3324: WDA Texta are not taken into accout

* Remove the not allowed Web Dynpro component

* Correct ABAB CHECKS 702 for SOTR_HANDLER

* ABAP Check 702 SOTR_HANDLER II

* ABAP Check 702 SOTR_HANDLER III: AUnit Exception

* ABAP Check 702 compliant IV

* ABAB Check 702 compliance V

* ABAP Check Compliance 702 VI

* ABAP Check 702 compliance VII

* ABAP Check 702 compliance VIII: delete comment

* ABAP Check compliance 702 IX : conv #

* Commit X: Improvements of ABAP Unit tests

-Test uses a 100% existing wd component and TEST(!) checks it
-Test enhanced with a non existing component -> no exception is raised nor existence is checked inside the PRODUCTIVE ROUTINE(!) via WDR_REPOSITORY_INFO as this check should have been done earlier not in this last phase to append the texts, labels, etc... to the component archive

* C XI: ABAP Unit Tests(2)

* C XII : ABAP Checks 702 for ABAP Unit Tests

* C XIII : ABAP CHECKS 702

* C XIV : ABAP CHECKS 702

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-04 14:57:06 +02:00
Marc Bernard
40b45f6221
Add master language and ignore files to repo settings (#3415)
Closes https://github.com/larshp/abapGit/issues/3413

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-03 09:17:57 +02:00
Marc Bernard
87241e9f07
Fix for proxy bypass setting (#3439)
Closes https://github.com/larshp/abapGit/issues/3435
2020-05-31 10:30:53 +02:00
Lars Hvam
ea03cc5e4a
Fewer DDIC type references (#3434)
* Fewer DDIC type references

* Update abaplint.json
2020-05-29 06:30:24 +02:00
mariusraht2
b5d40ca2a3
Build commit popup (#3400)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Added new method checkout_commit_build_popup

* abapLint

* Use hash to identify selected popup row

* Moved definitions

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-28 07:23:05 +02:00
Lars Hvam
9e56c03117
propagate exception (#3431)
closes https://github.com/larshp/abapGit/issues/3430
2020-05-27 18:35:48 +02:00
Marc Bernard
6d0861a7bd
Fix "repo not found" error (#3416)
Fix for https://github.com/larshp/abapGit/issues/2938

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-27 15:06:52 +02:00
Marc Bernard
63ab2d276c
INTF: 702: Fix for missing suppress_dialog parameter (#3427)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-26 18:18:06 +02:00
Marc Bernard
853e4ed98d
CLAS: 702: Fix for missing suppress_dialog parameter (#3426)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-26 10:13:46 +02:00
Frederik Hudák
657405433d
Add master language setting to new repo popups (#3409)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-26 06:29:31 +02:00
Christian Günter
caf7c92eaf
SAP Package: Replace ASSERT with RAISE (#3421)
* Package read_parent: RAISE instead of ASSERT

* remove pseudo comment

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-26 06:09:17 +02:00
Marc Bernard
f1c249b073
Fix detection of abapGit installation (#3425)
Old logic was failing if transaction ZABAPGIT already existed - typically because it was created manually for the merged version. Testing for program ZABAPGIT would not be any better since that might have been used for the merged version as well. It's more reliable to check a class.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-26 06:05:10 +02:00
Christian Günter
0cc10cd44f
SRVD: Downport (#3424)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-26 06:01:09 +02:00
Marc Bernard
2185da3034
CLAS: 702: Type CX_OO_CLIF_SCAN_ERROR_DETAIL is unknown (#3423)
Downport of https://github.com/larshp/abapGit/pull/3314

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-26 05:58:10 +02:00
Lars Hvam
aec7468aad
Type Hunting (#3414)
* Type Hunting

* update

* update

* flag
2020-05-26 05:55:28 +02:00
Marc Bernard
2e2b8584fb
New syntax-highlighters for CSS, JS, JSON (#3381)
* Add syntax-highlighters for CSS, JS, JSON

* Update W3MI ZABAPGIT_CSS_THEME_DEFAULT

* Fix line size and case statement

* Fix line size

* Update styles, removed operators

* Added highlight for comments in HTML/XML

* Fix menu hover background

This makes the selected menu more visible. 

Also includes color fix for repo name and url in dark theme.

* Fix for W3xx objects with "." in name

* Reverse fix for W3xx

* Remove hover style changes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-25 06:29:03 +02:00
Lars Hvam
5a21bbba7d
remove self interface references (#3412) 2020-05-24 15:28:25 +02:00
mariusraht2
4421cdc209
Issue 3399: Use c or char instead of sychar (#3410)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Update pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Delete pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Use char or c instead of sychar

* Replaced char with type of c

Co-authored-by: mariusraht1 <mariusraht+1@gmail.com>
2020-05-24 11:23:50 +02:00
Alexander Tsybulsky
5c4c0b882e
Gui refactoring - part 5 (#3403)
* refactor mi_gui_services to getter

* zif_html->set_title (for debug of postponed parts)

* add set_title to all postponed parts

* gui optional rollback on error

* forgotten gui_services call

* docs

* remove gui_page redirect #3404

* forgotten html~set_title in hotkey class

also renamed render_js_part into render_scripts for unification and reuse register_deferred_script - this is why I lost it int the first place

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-24 10:42:06 +02:00
Lars Hvam
411c703e0e
replace use of stringtab with builtin (#3407) 2020-05-24 10:30:51 +02:00
Lars Hvam
bbba9a612d
remove self prefixes (#3406) 2020-05-24 10:27:42 +02:00
Frederik Hudák
b12c811159
Master lang only - clear descriptions for clas, intf (#3388)
* Master lang only - descriptions for clas, intf

* Use master language instead of logon language

* sy-langu to master language - fix cus0, cus1, cus2

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-23 12:59:54 +02:00
Marc Bernard
1ef0aa9e74
Fix related to textpools of includes (#3389)
Reference: 0b4809de6d

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-23 11:55:46 +02:00
Marc Bernard
3620e12ee9
Fix CX_SY_RANGE_OUT_OF_BOUNDS dump (#3394)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-23 11:53:02 +02:00
Frederik Hudák
0a67f95c11
Replace assert in gui_page_stage with check (#3392)
* Update zcl_abapgit_gui_page_stage.clas.abap

* Change to exception

* add reference to issue as comment in code

* Update zcl_abapgit_gui_page_stage.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-23 11:42:41 +02:00
Marc Bernard
6d2deece76
Add missing TH closing tag (#3393) 2020-05-23 06:32:34 +02:00
Maxim Engel
f20e13d3ab
Fix for missing-field-popup (#3391)
Fix for missing-field-popup during cloning online repos, due to missing description.

Closes #3390
2020-05-22 17:43:23 +02:00
Frederik Hudák
5d34284805
Highlight hovered line (#3347)
* Highlight hovered line

* Better hover color

* Remove hover border in diffs

* Change bacgkround color

* Fix unrelated syntax errors in css
2020-05-22 10:10:41 +02:00
Marc Bernard
aa204c1e8f
Map blank "last changed by" to "unknown" (#3387)
* Map blank "last changed by" to "unknown" 

Fix blank entry in filter dropdown

* Whitespace
2020-05-22 10:02:33 +02:00
Lars Hvam
353b813683
1.95.0 (#3384)
* 1.95.0

* Update changelog.txt
2020-05-21 07:39:32 +02:00
larshp
2d168e170b move stage structures to interface #3377 2020-05-21 07:25:54 +02:00
Frederik Hudák
2886c00592 Fix syntax error in gui_router
Somehow lost this change from #3378. The class no longer exists.
2020-05-21 06:58:26 +02:00
Frederik Hudák
be260435f5
Move explore link (#3378)
* Move explore link

* Update zcl_abapgit_services_abapgit.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-20 19:47:42 +02:00
Frederik Hudák
3335317278
Remove page playground (#3375)
* Remove page playground

* Remove constant
2020-05-20 18:28:03 +02:00
Alexander Tsybulsky
8eae18c0f5
Gui refactoring part 4 (#3362)
* refactoring and remove get_events from gui_page

* cleanups

* more cleanups

* register_deferred_script

* refactor page_stage

* refactor page_diff

* refactor page_commit

* refactor page_debuginfo

* linter fixes

* refactor page_tag

* refactor rage_repo_over

* refactor page_patch

* make gui_page->scripts private
2020-05-20 17:50:00 +02:00
germanysources
47a2332cc7
encode and decode signed commits (#3373)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-20 12:42:38 +02:00
Marc Bernard
aa71ed52ae
Set filter for file open and save dialogs / Add new setting for default commit comment (#3371)
* Set filter for file open and save dialogs

Set the file filter dropdown and default to *.ZIP in file open and save dialogs

* Add new setting for default commit comment

New abapGit setting to define a default for the comment used for commits. Object and/or filename can added to the comment automatically, which works similar to GitHub if a single file is changed. If multiple objects are changed, then object/file count is included in the default for the comment.

* Update CLAS ZCL_ABAPGIT_GUI_PAGE_COMMIT

* Fix text for $object

Fixed case when one object with multiple files was changed

* Pretty print

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-20 12:37:58 +02:00
Marc Bernard
840d818b2d
Minor improvement for debug info (#3372)
- Full SAP GUI patch
- APACK version
2020-05-19 17:46:07 +02:00
Frederik Hudák
202e2d0239
Unify different wordings of 'Diff' (#3367)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-19 07:30:51 +02:00
Alexander Tsybulsky
310d8673dd
Gui refactoring, chapter 3 (#3355)
* zcl_abapgit_html_parts primitive

* integrate parts in GUI

* bughunting and renames

* scripts collection, move hotkeys js to parts

* linter fixes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-13 12:58:43 +02:00
Marc Bernard
40a1ef3a13
Allow setting of display name for offline repos (#3359)
Minor improvement to enable "Display Name" setting for offline projects which is shown in favorites for example
2020-05-13 12:42:23 +02:00
Lars Hvam
0944649ffd
CHAR downport (#3354)
closes #3353
2020-05-08 12:05:51 +02:00
Alexander Tsybulsky
c056076170
Gui refactoring 2 (#3338)
* hotkeys refactoring: draft logic

- new interfaces
- gui services binding
- move render to zcl_hotkeys
- move global hotkeys to hotkeys class
- remove unnecessary stuff from gui_page

* implement zif_abapgit_gui_hotkeys in rel.pages

* settings page draft

* remove zif_abapgit_gui_page_hotkey

* linter fixes

* finalize rendering logic

* finalize settings

* linter fix

* sorting tweak

* fix abapgit_full work

Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-05-08 10:26:54 +02:00
Frederik Hudák
a64b6d96f8
Don't run code inspector in parallel when disabled (#3348)
* Don't run code inspector in parallel when disabled

* Restructure if

* Fix spacing

* Fix comment position
2020-05-07 11:30:35 +02:00
Frederik Hudák
14a2820d30
Filter msag longtexts by master language in database (#3344)
* Serialize master lang only - DTEL, DOCT

* Filter msag longtext in database
2020-05-05 08:40:01 +02:00
Jakub Filak
ccba5c0286
CHAR fixes (#3346)
* char: deserialize missing attribute hide_icons

* char: unlock upon all errors

It's very annoying when I have to go to SM12 to unlock CHAR
objects which could not be activated due to a missing OTGR.
2020-05-05 06:43:56 +02:00
Frederik Hudák
055d1b8591
Serialize master lang only - DTEL, DOCT (#3343) 2020-05-04 18:09:54 +02:00
Frederik Hudák
240fc1ed06
CUS0, CUS1, CUS2 - Serialize master lang only (#3342)
The "serialize master language only" setting is not respected everywhere. This PR fixes CUS0, CUS1, CUS2 object types.
2020-05-04 16:02:49 +02:00
Christian Günter
1cf1a30e81
Downport (#3341)
* downport DTDC

* downport DRUL

* Downport AMSD

* downport BDEF

* more downport

Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
2020-05-04 11:34:32 +02:00
mariusraht2
b91043a270
Refactor Popup (#3310)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Update pull.yml

* Delete pull.yml

* Refactored popup logic

Related to #3040

Refactoring of popup logic/calling to be able to reuse it as commit list.

* Removed reset flag

Removed reset flag cause it doesn't belong to this PR (will be readded later)

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-04 08:36:24 +02:00
Christian Günter
5234a25c35
DTDC: Dynamic Cache (#3335)
* DTDC: Dynamic Cache

* Update ref-supported.md

Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
2020-05-02 17:04:08 +02:00
Christian Günter
2d991b2315
DRUL: Dependency Rule (#3336)
* DRUL: Dependency Rule

* Update ref-supported.md

Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
2020-05-02 17:01:00 +02:00
Christian Günter
a785bcdb99
DDLS: Ignore baseinfo file not exists error (#3334)
Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
2020-05-02 16:51:52 +02:00
Jaime Rodriguez Capote
6b74fb5d33
Check table SEOMETAREL (#3322)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-02 16:45:47 +02:00
Christian Günter
1f536b3225
SRVD: Service Definition (#3329)
* SRVD: Service Definition

* Update ref-supported.md

* cleanup

* change file extension to assrvd

Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-02 16:39:31 +02:00
Jakub Filak
4be0dd14ba
Move misplaced object handler to their correct package (#3327)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-02 16:32:48 +02:00
Christian Günter
02b208487c
AMSD: Logical Database Schema (#3337)
* AMSD: Logical Database Schema

* Update ref-supported.md

Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
2020-05-02 16:26:14 +02:00
Christian Günter
eacfe8a2b7
BDEF: Behaviour Definition (#3331)
* BDEF: Behaviour Definition

add transport handling

* Update ref-supported.md

* refactor

* remove DDLS activation

Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-02 16:15:55 +02:00
Christian Günter
e2b64d83c6
SRVB: Service Binding (#3330)
* SRVB: Service Binding

* cleanup

* Update ref-supported.md

* Update ref-supported.md

Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-02 16:07:12 +02:00
abapChaoLiu
90bf633b8f
Add support to object OA2P - OAuth2 Profile (#3302)
* add support to object OA2P - OAuth2 Profile

* remove some comments

* fix abaplint errors

* docs: OAP2 supported

* Update ref-supported.md

* Update .abapgit.xml

* remove system specific information in SERIALIZE()

* Add support to method JUMP()

* Avoid manipulating DB tables directly

* fix abapLint errors

* fix abapLint errors

* fix abapLint error

* code object and APIs dynamically

Co-authored-by: Chao Liu <abapChaoLiu@gmail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2020-04-26 09:00:56 +02:00
Jaime Rodriguez Capote
1b36d98ef8
(de)serialization (z)if_apack_manifest (#3311)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-04-26 08:54:50 +02:00
Rakshith Gore
b0d54f97e3
STVI, Transaction variants (#3307)
* Screen Variants Support

* Update package.devc.xml

* Checks Corrected

* Package Description Change

* Transaction Variant Supported

* Delete zcl_abapgit_object_stvi.clas.xml

* Delete zcl_abapgit_object_stvi.clas.abap

* Transaction Variants Supported

* Checks Corrected

* Clean Code

* Handle User Details

* Delete zcl_abapgit_object_scvi.clas.abap

Delete Conflicting files

* Delete zcl_abapgit_object_scvi.clas.xml

Deleting conflicting files

* docs, STVI, Transaction variant

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-04-23 07:09:51 +02:00
Rakshith Gore
f0641a7292
SCVI: Screen Variants Support (#3306)
* Screen Variants Support

* Update package.devc.xml

* Checks Corrected

* Package Description Change

* Transaction Variant Supported

* Delete zcl_abapgit_object_stvi.clas.xml

* Delete zcl_abapgit_object_stvi.clas.abap

* Clean Code

* Handle User Details

* docs, SCVI supported

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-04-22 07:29:26 +02:00
abapChaoLiu
4ab4abcc6b
fix - handle exception cx_oo_clif_scan_error_detai (#3314)
fix issue 3313

Co-authored-by: Chao Liu <abapChaoLiu@gmail.com>
2020-04-22 07:24:07 +02:00
mariusraht2
c2fc8f00fe
Issue 3294: ZCL_ABAPGIT_TIME: Unit Test fails on AS ABAP 752, SP04 (#3295)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Update pull.yml

* Updated testclass for util_time

* abaplint, get_utc

* Delete pull.yml

* Made time tests method more simple

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-04-15 14:15:03 +02:00
Christian Günter
48454c5922
fix page diff dump: use repo instead of repo_online (#3304)
* fix page diff dump: use repo instead of repo_onlin

* make repo online an attribute
2020-04-14 18:57:21 +02:00
Christian Günter
c9241e7cff
Fix zcl_abapgit_gui_component definition (#3299)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-04-09 09:39:35 +02:00
Christian Günter
decc2d4863
Page Patch: fix unit test (#3293) 2020-04-08 15:58:22 +02:00
Jaime Rodriguez Capote
0bc7e6bde7
Clean code (#3292)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-04-07 18:49:09 +02:00
Alexander Tsybulsky
0eb22a0c87
Gui refactor, part 1 (#3289)
* gui component and event registering

* remove iv_prev_page from event_handler if

* constructors raising zcx_abapgit_exception

* get_gui_services - UT friendly

* linter fixes

* more linter fixes

* zif_gui_services stub all methods

* linter fix

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-04-07 10:30:43 +02:00
Jaime Rodriguez Capote
fce71de4d1
Use constants for Y/N/P (#3291)
* Use constants

* Pretty Printer
2020-04-05 10:55:24 +02:00
Jaime Rodriguez Capote
27ac61e95d
Apack dependencies (#3285)
* Support APACK dependencies

Check installed apack package dependencies for current repository
Display a popup with dependencies

* abaplint checks

* abaplint checks

* abaplint checks

* Popup only when dependency not met

* abaplint checks

* abaplint checks

* Optimization

* abaplint checks

* abaplint checks

* Fix typo "dependeNcies"

* Remove address from dependency check

* Dependencies popup title

* Dependencies popup enhanced

* EXCEPTION column replacing MET
* Enable Git URL hiperlink

* APACK doc - Version dependency support

* Dependencies version check support

* abaplint checks

* abaplint checks

* Version utils

* fix syntax warning

* move set_dot_apack to protected

Co-authored-by: larshp <larshp@hotmail.com>
2020-04-05 08:57:59 +02:00
Christian Günter
803ca23176
Refactor page diff: Introduce subclass for patch (#3283)
* Introduce zcl_abapgit_gui_page_patch as subclass of zcl_abapgit_gui_page_diff

introduce pop-method on GUI stack

fix linter + raising exception when gui stack emp

introduce zcl_abapgit_gui_page_patch

more

add

fix linter

remove go back to patch after commit

fix linter

remove bookmark for stage page

remove pop

src/ui/core/zcl_abapgit_gui.clas.abap

 src/zcl_abapgit_repo_online.clas.abap

* refactor: move more logic to  render_line_split_ro

* refactor move logic to render_diff_head_after_stat

* add logic to render_table_head_non_unified

* extract render_table_head_unified

* extract of is_patch_possible calculation

* fix linter

* move hotkey to patch

* refactor and rename to get_normalized_fname_with_p

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-31 17:14:13 +02:00
Lars Hvam
6957f6e9fb
1.94.0 (#3279)
* 1.94.0

* v1.94.0
2020-03-29 14:16:36 +02:00
Jaime Rodriguez Capote
90e3208163
Skip dom. appends serialization (#3275) 2020-03-29 09:16:54 +02:00
Christian Günter
1e4560b32a
Patch: new refresh functions (#3271)
* Patch: Refresh object first working version

* Patch: add refresh local and refresh repo + refact

* add missing stuff

* fix lint

* refactoring and cleanup

* add missing stuff

* refactor

* refactor

* refactor

* add title for menu bar

* Save and restore scroll position

* refactoring and cleanup

* refactor

* cleanup

* cleanup

* cleanup

* remove new hotkey

* disable object refresh for non-object files

* remove restore scrollposition

* cleanup

* refactor

* cleanup

* save scroll position

* Fix: refresh of deleted objects

* Fix dump: refresh new objects

* add hotkey support for refresh all local objects

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-26 12:30:22 +01:00
Frederik Hudák
63640bb3fc
Minor ux improvements (#3253)
* Resize stage list to full width

* Move patch button to the top menu

* Center stage list, increase line width in repo, stage

* Repo page - Increase line height for path column

* Stage list to full size

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-21 09:56:53 +01:00
Jaime Rodriguez Capote
7bf443d7a8
SHA1 for file zcl_abapgit_object_chdo.clas.abap (#3264) 2020-03-15 07:34:22 +01:00
Marcello Urbani
68117adb97
CHDO: clear UZEIT and UTIME dynamically (#3256) bis (#3260)
* CHDO: clear UZEIT and UTIME dynamically (#3256) bis

* fix variable name
2020-03-14 11:14:30 +01:00
Christian Günter
5c65f3411d
CHDO: clear UZEIT and UTIME dynamically (#3256)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-13 10:46:49 +01:00
Eduardo Ferrari Copat
e74d40516c
Diff - Add option to collapse files (#3248)
* Update zcl_abapgit_gui_page_diff.clas.abap

* Update zcl_abapgit_gui_page_diff.clas.abap

* Update zabapgit_css_common.w3mi.data.css

* Update zabapgit_css_common.w3mi.data.css

* test

* Update zabapgit_css_theme_default.w3mi.data.css

* Add collapse to css

* Add user select

* onDiffCollapse

* show source

* src

* Tries text

* hide/show

* uses nodisplay instead of hidden

* good hide

* ===

* Add button

* lint

* lint

* set function as global

* lint

* Exclude gui page diff

* remove extra space

* chevron

* pointer

* class

* Icons

* lint

* lint

* hide

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-12 17:09:00 +01:00
Frederik Hudák
31a912b124
Use xml syntax highlighter for html as well (#3251)
I came upon a `w3ht.data.html` object without syntax highlighting. We can reuse the xml highlighter for html.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-11 16:46:21 +01:00
g-back
79a1a667c6
Switch branch protected (#3250)
* add write-protect check for switch branch

* disable link for disabled toolbar functions

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-11 12:54:24 +01:00
Paweł Wiejkut
b0741dd419
AREA Object support (#3235)
* IOBJ fix #3105

* Variable fix

* BW function modules check

* AREA support

AREA support

* update, comment fix

* update

* iobj update

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-11 12:47:31 +01:00
g-back
07c87edd03
PINF: Exporting to Returning Parameter (#3252)
* change exporting to returning parameter

* enable prefer_returning_to_exporting
2020-03-11 11:42:15 +01:00
larshp
e638e6065a ZCL_ABAPGIT_GUI_PAGE_DIFF propagate exception 2020-03-10 08:17:12 +01:00
Jaime Rodriguez Capote
543114963f
abapOpenCheck - Naming Conventions revision #3239 (#3240)
* abapOpenChecks config file

* Ignore SCI config folder

* checks revision

* Revert "checks revision"

This reverts commit 56a12289df.

* Renaming non-constants

Pending:

* Remove SCI configuration

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-09 17:34:26 +01:00
larshp
8fcf072917 remove call to super->constructor
there is no super class
2020-03-09 17:19:34 +01:00
Lars Hvam
c227d473df
Authorization objects in transactions #3233 (#3237)
* Support authorization in TRAN

* abaplint checks

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-05 18:43:58 +01:00
Jaime Rodriguez Capote
c9ae5ac122
Transaction, unknown cinfo #3223 (#3232)
* Determination transaction type

* Determine TX type

* abaplint checks
2020-03-04 06:41:04 +01:00
Lars Hvam
a85db8c8b8
SRFC: clear some admin fields (#3225)
* SRFC: clear some admin fields

* fix lock problem and delete problem
2020-03-04 06:34:58 +01:00
Jaime Rodriguez Capote
2ca3a3da91
CHDO change document object #802 (#3207)
* Support for CHDO

* Remove dependency from GENERIC

* Skip gen. objects by CHDO

* abaplint checks

* Moved filter to zcl_abapgit_repo

* Adjusted filter logic

* Delete unused methods

* Extract apply filter methods

New class zcl_abapgit_repo_filter generated with apply filter methods

* docs: update supported with CHDO

* Clear serialization fields

* Set package at deserialize

* Check errors at deserialize
2020-03-04 06:29:31 +01:00
Lars Hvam
4b35ecffb3
FUGR: Give proper error messages for RFC parameter (#3222)
* FUGR: Give proper error messages for RFC parameter

* reduce line length
2020-03-03 10:21:33 +01:00
larshp
b4b3414009 non existing package: fix dump #3224 2020-03-03 10:10:35 +01:00
Daniel Wegner
eb10fae8ef
Proxy bypass (#3221)
* add proxy bypass option in settings

* add proxy bypass popup and persist settings

* add proxy bypass to proxy config class

* Fix Proxy Bypass Button HTML

* Fix indentation

* Implement Method popup_proxy_bypass

* Fix behaviour in case of empty range tab

* Fix behaviour in case of empty range tab 2
2020-03-02 15:30:23 +01:00
Christian Günter
cec926e954
Diff: Only add beacon at beginning while patching (#3218) 2020-02-20 16:43:02 +01:00
Christian Günter
a8d474fab4
Patch: add path to jump target (#3216)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-20 09:39:56 +01:00
Alexander Tsybulsky
0961429903
#3209 DOCU master lang only (#3217) 2020-02-20 08:28:12 +01:00
Christian Günter
1668e670cf
Fix patch: multiple files with same name (#3213)
- unify id generation
- generate unique filenames

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-19 14:24:04 +01:00
Christian Günter
109c8c3be4
Patch: Remember patched lines when cancel Commit (#3212)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-19 13:55:19 +01:00
Christian Günter
5067e403b7
Patch: add beacon at beginning of objects (#3210)
* Patch: add beacon at beginning of objects

* extract constant + fix unit test
2020-02-19 12:48:26 +01:00
Johan Wigert
e57037e12c
Stage of IWMO, IWSG, IWSV (#3205)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-11 10:23:28 +01:00
Mauricio Lauffer
a9a505faf4
Prefer RETURNING to EXPORTING (#3204)
* refactor: Prefer RETURNING to EXPORTING

* refactor: Prefer RETURNING to EXPORTING
2020-02-11 10:20:45 +01:00
Lars Hvam
eb7e819b25 refactoring, delete unused variables and methods (#3203)
* zlib

* xml

* processor

* shi5

* remove unused filter parameter

* pinf cleanup

* ssfo delete empty method

* highlighter

* gui page res, remove unused

* remove unused in diff class

* adt link

* gui, remove 2 unused parameters

* branch overview
2020-02-09 09:38:17 +01:00
Jaime Rodriguez Capote
d5bc9b89c6
Img structure enhancement (#3200)
* Structure sequence extension

* Selection ORDER BY PRIMARY KEY
2020-02-08 09:02:51 +01:00
Jaime Rodriguez Capote
701f83ec2d
Travis-CI Error (#3201)
./src/ui/zcl_abapgit_gui_page_merge.clas.abap[187, 18] - Keep single parameter on one line (keep_single_parameter_on_one_line)

https://travis-ci.org/jrodriguez-rc/abapGit/builds/647280505?utm_medium=notification%26utm_source=github_status
2020-02-07 12:34:59 +01:00
g-back
48032207a8
remove macro, replace with method calls (#3198)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-03 09:16:36 +01:00
GB
4b35d98e5d remove macro, replace with method calls 2020-02-03 09:13:31 +01:00
Lars Hvam
7aea72f63a
git pack, remove macros #3170 (#3191) 2020-02-03 06:57:53 +01:00