Commit Graph

3507 Commits

Author SHA1 Message Date
Marc Bernard
985dbf1116
Remove "Branch Overview" page (#5428)
* Remove "Branch Overview" page

- The "Branch > Overview" feature has been removed (see #5411 for reasoning). 
- The merge feature has been refactored into a new HTML page under "Branch > Merge" (#5402)

Closes #5411

* Remove old page

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-11 16:34:14 +02:00
buca92
4d503876a2
Several methods moved from zcl_abapgit_repo to zif_abapgit_repo (#5466) 2022-04-11 13:36:38 +02:00
Marc Bernard
9d9b4327ad
Avoid logon when comparing with remote (#5458)
"Data Config" is persisted on remote side only. Comparison feature reads the local part only and therefore does not support comparing of "data config". Therefore `get_files_remote` is not necessary.

Closes #5189, #5443

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-08 17:00:54 +02:00
Marc Bernard
583d215114
Add paramter iv_show_log to serialize package (#5457)
Pass along paramter `iv_show_log`(should have been an "unused variable/parameter" check).
2022-04-08 15:43:48 +02:00
Marc Bernard
63a87fa6e7
TABU: Add "jump" to SE16 (#5459)
* TABU: Add "jump" to SE16

When using "Data Cofiguration" you can now jump from the repo view to the data browser (`se16`).

* Simplify

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-08 15:39:03 +02:00
Marc Bernard
e6378ac17f
DEVC: Fix DYNPRO_SEND_IN_BACKGROUND (#5461)
When deserializing SAP packages that do not exist in background, AG will dump with `DYNPRO_SEND_IN_BACKGROUND`. This is caused by a popup asking for the transport.

Fixed by passing the transport to the save method.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-08 11:33:18 +02:00
Marc Bernard
ad1808cc72
Improve JSON syntax highlighter (#5450) 2022-04-08 11:12:36 +02:00
Marc Bernard
de39745541
UI: Fix escaping of textarea input (#5456) 2022-04-07 16:08:19 +02:00
Marc Bernard
ef502d8275
UI: Transport popup (#5452)
Add parameter for new logic
2022-04-06 15:55:48 +02:00
Marc Bernard
62443633fd
Improve LXE error handling (#5440)
* Improve LXE error handling

Raise exception in case of error messages

* Remove space

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-06 10:48:58 +02:00
Marc Bernard
00e1505613
DEVC: Raise error for main/structure packages (#5444)
* DEVC: Raise error for main/structure packages

Main or structure package and cannot be used in local packages (`$...`). 

abapGit will now raise an error, if one tries to pull main or structure packages into a local package.

* Split into two messages

* Locally

* Local

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-06 09:17:09 +02:00
Marc Bernard
8d8d537fcf
DOMA: Deletion of domains with append (#5445)
* DOMA: Deletion of domains with append

On newer releases, suppressing the confirmation popup does not work since the parameter has changed.

Added a call using the new parameter.

* No if

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-05 18:00:27 +02:00
Marc Bernard
7e7104e050
UI: Word-wrap long filenames in repo/stage views (#5424)
Closes #5418

Before

After

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-05 17:17:55 +02:00
Marc Bernard
250feae861
Add transport for deletions in generic serializer (#5434)
Closes #5421

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-05 16:41:03 +02:00
Marc Bernard
3574521d2d
Record objects in transports (#5435)
* Record objects in transports

Follow-up to #5419

* Record objects in transports

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-05 16:26:07 +02:00
Marc Bernard
daa35ab666
UI: Transport popup (#5438)
If default transport is set and its type matches to what is required, then use it as default for the transport popup.

This will make it easier for example if a pull or uninstall failed and needs to be repeated since you want to continue using the same transport.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-05 16:15:08 +02:00
Marc Bernard
287539ed4a
CHDO: Avoid double pull and fix uninstall (#5439)
Change documents left a diff when pulled once that would go away after second pull. In debugging warning CD 763 could be seen "No TADIR entry found'. The `tadir` entry is now created properly.

Uninstall would fail with "Function group ... does not exist". Reason was that the function group was already deleted by `chdo` object. The deletion of such generated function groups is now skipped.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-05 16:04:14 +02:00
Christian Günter
e0742e5181
CUS1: fix jump (#5447) 2022-04-05 10:31:04 +02:00
Marc Bernard
3666dda767
Rename methods returning boolean (#5436)
Just a bit of Clean ABAP:
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-nouns-for-classes-and-verbs-for-methods

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-03 10:40:12 +02:00
Marc Bernard
3d158a3fbc
DDLS: Avoid dump and show error (#5437)
* DDLS: Avoid dump and show error

Ref https://github.com/abapGit/abapGit/issues/4624

* Typo
2022-04-03 10:10:58 +02:00
Marc Bernard
453c430723
Deserialize textpool for some objects (#5417)
* Deserialize textpool for some objects

Fixes inserting the textpool for objects that are not handled by `RPY_PROGRAM_INSERT`. This applies for example to function groups and exit includes (`zx...`).

* Fix deserialize_textpool

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-01 17:51:32 +02:00
Marc Bernard
014d40db1c
Fix "dynpro_send_in_background" (#5430)
* Fix "dynpro_send_in_background"

Suppresses dialog processes for ENHC, ENHS, ENSC, SPRX, and TRAN.

Closes #5420

* Update zcl_abapgit_object_enho.clas.abap

* Update zcl_abapgit_object_enhs.clas.abap

* Update zcl_abapgit_object_ensc.clas.abap

* Update zcl_abapgit_object_sprx.clas.abap

* Update zcl_abapgit_object_tran.clas.abap

* exit
2022-04-01 17:40:28 +02:00
Marc Bernard
485bb12cc1
Record objects in transports (#5419)
CI tests have shown that several object types are not properly recorded in transports. For some objects there was no transport entry when creating the objects, for others when deleting it. 

This PR add the necessary calls to `corr_insert()`. 

(some SE80 reorders)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-03-31 15:20:25 +02:00
Marc Bernard
30371b9a8f
Check if package name is allowed (#5416)
* Check if package name is allowed

When validating SAP packages, it now checks the naming conventions.

* Move method

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-03-31 14:57:48 +02:00
Marc Bernard
f712eb17a5
Folder logic "mixed" (#5413)
* Folder logic "mixed"

Introduces a new folder logic named `mixed` which combines `prefix` and `full`. The root package name will be used as prefix for all sub-packages but the package names are *not* concatenated recursively. This will allow for using significantly logic package names.

Also includes several new unit tests especially for nested packages which had not been tested before.

Closes #5410

Todo: Update docs

* Add constant

* Add options to UI

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-03-31 13:35:34 +02:00
Marc Bernard
6e927e63c5
UENO: Fix diff related to release (#5422) 2022-03-31 06:48:57 +02:00
Marc Bernard
ba09c6e92d
DDLX: Delete before DDLS (#5414)
Fix order of deletion
2022-03-29 23:28:41 +02:00
github-actions[bot]
45fbfd0feb
ajson, Automatic Update (#5412)
* [create-pull-request] automated change

* Update zcl_abapgit_ajson.clas.locals_imp.abap

* Update zcl_abapgit_ajson.clas.locals_imp.abap

* update deps

* skip

Co-authored-by: larshp <larshp@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-03-28 09:14:13 +02:00
Marc Bernard
995e77e949
Visualize difference for EOF (#5404) 2022-03-25 06:58:33 +01:00
Marc Bernard
103790eb35
Remove popup for XML version mismatch (#5403)
Very unlikely that this error happens. Therefore, the popup was replaced with an exception which makes the case testable.
2022-03-24 07:12:24 +01:00
Marc Bernard
ab19fec80b
Fix deserialize order (#5399)
* Fix deserialize order

Fix order for 
- CLAS, INTF, XSLT
- IASP, IARP, IATU

* iaxu
2022-03-16 11:38:46 +01:00
Christian Günter
7992625644
Repo List: fix sort (#5397)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-03-15 18:56:55 +01:00
Marc Bernard
c88dc9f216
SRVB: Fix uncaught exception (#5398)
Fixes dumps due to uncaught exceptions and gives proper error message
2022-03-15 18:43:04 +01:00
ThomasPloski
38db43ce13
Update zcl_abapgit_object_srvd.clas.abap (#5395)
* Update zcl_abapgit_object_srvd.clas.abap

* Update src/objects/zcl_abapgit_object_srvd.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2022-03-10 08:44:30 +01:00
yellappam
bcdeebb3ad
Sort internal tables (#5390)
Function module WEBI_GET_OBJECT returns several internal tables. Sometimes, the sorting order of these internal tables is different in each system ex: S/4HANA and non-S/4HANA. This fixes #5389.
2022-03-02 14:37:23 +01:00
Lars Hvam
e5eb8d0d0a
icon, fix short dump (#5386)
#5385
2022-03-01 08:02:32 +01:00
Marc Bernard
524f6eebc5
CLAS/INTF: Fix serialize/deserialize of documentation (#5374)
* INTF: Fix serialize/deserialize of documentation

Documentation of interfaces (document class IF) was missing and has been added.

* Fix translations
2022-02-28 14:25:52 +01:00
sandraros
0f6267688e
Fix pull/activate table type ref to data type (#5384)
Fix #5383

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-02-27 17:45:29 +01:00
sandraros
5e53bb9626
Fix DDIC errors related to ref to class/interface (#5369) 2022-02-27 17:23:13 +01:00
Marc Bernard
a491dcf875
SOTS: Fix dump in case of lower case language code (#5381)
Closes #5380
2022-02-25 10:02:33 +01:00
Frederik Hudák
adb529152b
minor css adjustments (#5372)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-02-21 17:37:40 +01:00
sandraros
68e2cfa5c2
Fix data elem type ref to class in same repository (#5370)
* Fix data elem type ref to class in same repository

* simpler solution by testing refkind and reftype

Co-authored-by: sandraros <sandra.rossi@gmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-02-21 17:20:39 +01:00
Marc Bernard
6a85f93312
Update CSS for password fields and buttons (#5364)
Minor addition to CSS

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-21 16:38:45 +01:00
Alexandr Razinkin
353f748bd6
Don't fail if a dictionary object is activated with warnings (#5362)
* Fix proposal for issue #5347: added support for 'TYPE REF TO DATA' DDIC data elements as components in DDIC structures

* Fix proposal for issue #5347. Added support for 'REF TO DATA' DTEL DDIC element residing in DDIC structure

* Fix proposal for issue #5347, added support for 'TYPE REF TO DATA' DDIC data element residing in DDIC data structurees

* REF TO DATA for DDIC element support (#5347)

* No error if ddic type has warning (abapGit#5361) during import

* Update zcl_abapgit_objects_activation.clas.abap

* Fix for (abapGit#5361). Warnings during DDIC objects activation shouldn't be considered as error but will be shown as 'yellow' messages after activation

* Fix for (#5361).
Warnings during DDIC objects activation shouldn't be considered as error but will be shown as 'yellow' messages after activation

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-20 11:39:09 +01:00
Alexander Tsybulsky
91cd4c3653
Separate zif_abapgit_repo (#5329)
* zif_repo basis

* all but zcl_abapgit_repo_srv

* fix zcl_abapgit_repo_srv

* remove create_new_log from interface

* "hack" -> "TODO"

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-19 09:22:46 +01:00
Lars Hvam
4ac0183df2
unit testing updates (#5354) 2022-02-19 09:02:13 +01:00
Christian Günter
2ba6151355
JUMP: Switch execution order - first specific then generic (#5357)
* Switch jump order

* fix DDLS

* fix SHI3
2022-02-18 05:48:36 +01:00
Alexandr Razinkin
256007685e
DTEL: REF TO DATA for DDIC element support (#5350) 2022-02-15 07:39:27 +01:00
yellappam
1246e2718f
Sort includes (#5352)
In some systems, function modules RS_GET_ALL_INCLUDES returns an include *T00. Where *T00 include is not returned, abapGit adds to the internal table. This results in different sorting order in different systems. Sort to keep the same order.
2022-02-15 06:37:58 +01:00
Marc Bernard
92b583bb18
Improve progress bar and log for pull (#5311)
- Eliminate flashing of progress bar during deserialize
- Updated description for deserialize steps
- Add steps to log (see below)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-14 08:25:27 +01:00