Commit Graph

8 Commits

Author SHA1 Message Date
Lars Hvam
9675ad6007
Replace use of type W3URL with string (#4874)
* replace W3URL with string

* fixes

* ASSERT strlen( iv_url ) <= 250.
2021-07-21 11:41:56 +02:00
Marc Bernard
f857194037
Focus HTML control on abapGit startup (#4817)
* Focus HTML control on abapGit startup 

`cl_gui_control=>set_focus` must be called during PBO. Maybe there's a nicer way to pass the HTML control to the PBO.

* Move to output form

* Set focus

* Add autofocus
2021-06-09 17:24:59 +02:00
Marc Bernard
cea83ffb86
Improve reuse of HTML viewer (#4688)
* Improve reuse of HTML viewer

Adding optional parameters to allow reuse of HTML viewer in subscreens and allow testing of query parameter table (potential replacement of `zcl_abapgit_html_action_util=>parse...`).

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-07 17:50:31 +02:00
Marc Bernard
40331ee80f
Follow-up HTML viewer exceptions (#4404)
* Follow-up HTML viewer exceptions

Properly catch HTML viewer exceptions (follow-up #4396) to avoid dumps

* Add exception

* Add exception

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-12 08:54:03 +01:00
Fabian Lupa
123de8fd68
Allow html viewer to be hidden (#4203)
* Allow html viewer to be hidden

for CALL SCREEN in the same session to work

* Move html viewer hiding to router
2020-11-20 08:38:37 +01:00
Marc Bernard
9e385c264e
UI: Add help buttons to "New Online/Offline" (#4189)
* UI: Add help buttons to "New Online/Offline"

- Add help button to both dialogs linking to docs.abapgit.org
- Clicking the button brings up the documentation inside the GUI HTML viewer
- Enhancement to `zcl_abapgit_gui` and `zcl_abapgit_html_viewer_gui` to properly handle 'Back' when navigating through Internet pages

* Open help in external browser

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-18 07:33:00 +01:00
Marc Bernard
bdc44f7476
Remove self-references (#4115)
* Remove self-references

Remove unnecessary self-references (me->)

https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#omit-the-self-reference-me-when-calling-an-instance-method

* 702: Fix syntax error

No chaining with EXPORTING & CHANGING

* remove addiontal me, update abaplint config

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:25:27 +01:00
Lars Hvam
9f396366cd
gui refactoring, for web edition (#3890)
* put cl_gui_html_viewer behind an interface

* cleanup

* injectable html viewer

* method_parameter_names, exclude zif_abapgit_html_viewer

* fix whitespace

* public get_asset_manager

* Update abaplint.json

* add prefixes
2020-09-16 12:39:23 +02:00